GNU bug report logs - #51990
[PATCH] gnu: Add emacs-bazel.

Previous Next

Full log

Message #8 received at 51990 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Brian Kubisiak <brian <at> kubisiak.com>
Cc: 51990 <at> debbugs.gnu.org
Subject: Re: [bug#51990] [PATCH] gnu: Add emacs-bazel.
Date: Sun, 21 Nov 2021 21:30:52 +0100

Hello,

Brian Kubisiak <brian <at> kubisiak.com> writes:

> * gnu/packages/emacs-xyz (emacs-bazel): New variable.

Thank you. Some comments follow.
>
> Signed-off-by: Brian Kubisiak <brian <at> kubisiak.com>

We don't sign our own commits. So the line above is not necessary.

> +(define-public emacs-bazel
> +  (package
> +    (name "emacs-bazel")
> +    (version "20211031.1941")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://melpa.org/packages/bazel-"
> +                           version ".el"))

We don't trust MELPA as a reliable source. Could you use git-fetch
instead, and get source files from upstream instead?

Also, the version is "O", according to "Version" keyword in "bazel.el"
file.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.