From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 19 16:06:15 2021 Received: (at submit) by debbugs.gnu.org; 19 Nov 2021 21:06:15 +0000 Received: from localhost ([127.0.0.1]:40665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moB5L-0001HF-En for submit@debbugs.gnu.org; Fri, 19 Nov 2021 16:06:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:55112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moB5K-0001H8-DJ for submit@debbugs.gnu.org; Fri, 19 Nov 2021 16:06:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moB5J-0004Qu-SD for guix-patches@gnu.org; Fri, 19 Nov 2021 16:06:14 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:35680) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moB5E-0002p1-Ti for guix-patches@gnu.org; Fri, 19 Nov 2021 16:06:13 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100b]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id D2D6F1AA41 for ; Fri, 19 Nov 2021 13:06:01 -0800 (PST) From: Vagrant Cascadian To: guix-patches@gnu.org Subject: lint: Adjust patch file length check. Date: Fri, 19 Nov 2021 13:05:58 -0800 Message-ID: <875ysnsvnt.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=173.255.214.101; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain The current guix lint check is a bit overly conservative, and reports several results which do not in practice actually cause issues. This patch proposes to reduce the size by two characters (leaving only two patches on guix master that need to be adjusted), uses a version string more like what actually might be included in a tarball built using "make dist", and adds a comment describing what the arbitrary string actually is supposed to represent. This should still even leave a little wiggle-room when guix hits version 100+ and/or 1000000+ commits, by which time hopefully guix has switched to a tarball format that doesn't have such a short arbitrary file length limit! live well, vagrant --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lint-Adjust-patch-file-length-check.patch Content-Transfer-Encoding: quoted-printable From=206ad2050a8bbc308a328d30d4f66cb229d868b79d Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Fri, 19 Nov 2021 12:14:19 -0800 Subject: [PATCH] lint: Adjust patch file length check. * guix/lint.scm (check-patch-file-names): Adjust margin used to check for patch file lengths. =2D-- guix/lint.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/guix/lint.scm b/guix/lint.scm index ac2e7b3841..39b4a2ae85 100644 =2D-- a/guix/lint.scm +++ b/guix/lint.scm @@ -957,7 +957,10 @@ patch could not be found." =20 ;; Check whether we're reaching tar's maximum file name length. (let ((prefix (string-length (%distro-directory))) =2D (margin (string-length "guix-2.0.0rc3-10000-1234567890/")) + ;; Margin approximating the largest path that "make dist" might + ;; create, with a release candidate version, 123456 commits, and + ;; git commit hash abcde0. + (margin (string-length "guix-12.0.0rc3-123456-abcde0/")) (max 99)) (filter-map (match-lambda ((? string? patch) =2D-=20 2.30.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYZgRtgAKCRDcUY/If5cW qup5AQD81KiqA/DfiPpt9xQTyb4qvkp++22qCv9Wgl0Di+JB3wD/TyO2cTC2XkoX dGk/JnNlOcLquHtSuQ4FmA0thjC/fgw= =qx7F -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 22 06:22:17 2021 Received: (at 51985) by debbugs.gnu.org; 22 Nov 2021 11:22:17 +0000 Received: from localhost ([127.0.0.1]:47116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mp7Or-0004dg-75 for submit@debbugs.gnu.org; Mon, 22 Nov 2021 06:22:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mp7Op-0004dT-3r for 51985@debbugs.gnu.org; Mon, 22 Nov 2021 06:22:16 -0500 Received: from [2001:470:142:3::e] (port=57446 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mp7Oj-00053Z-OL; Mon, 22 Nov 2021 06:22:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=CyV3w2sGcMHQ6Vlnvnc0GmtY+xsGjKTSp7rjtADP0D0=; b=UXqHnaHFNDlNr9qp5q7s wuIAriYGzUCBQC3yXfuZAxnpiBwUkiccCOoLs/kk2ivrgNtc3ry/pDWUHrW+sQA6iRqWiwIgLqbuA uFiZkdSqlsDtVTJRum66OZDWwrXU43NkxNnW2lPDdkmFGzR628QGlTOvAqGG27fchlWcDRLVWCbei 9IMPaFbauNcYzXgx1EkSvXjVBsfLyNZ3SDfxD/H5C87CWIz0+S4ZOJnRJo6SWldqyR0z2GwroW+pI cwan9vkfFmJjdSiR+xfCFC/LVBWpwclgtEBWNZnTzm5V9Ag3oM0NcMe3OrmSo0eCY1PXFMGOhOYl3 yJp5d5tAKqo6Lw==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=49462 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mp7Oj-00056F-HN; Mon, 22 Nov 2021 06:22:09 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Vagrant Cascadian Subject: Re: bug#51985: lint: Adjust patch file length check. References: <875ysnsvnt.fsf@yucca> Date: Mon, 22 Nov 2021 12:22:03 +0100 In-Reply-To: <875ysnsvnt.fsf@yucca> (Vagrant Cascadian's message of "Fri, 19 Nov 2021 13:05:58 -0800") Message-ID: <877dd0ph9g.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51985 Cc: 51985@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Vagrant Cascadian skribis: > From 6ad2050a8bbc308a328d30d4f66cb229d868b79d Mon Sep 17 00:00:00 2001 > From: Vagrant Cascadian > Date: Fri, 19 Nov 2021 12:14:19 -0800 > Subject: [PATCH] lint: Adjust patch file length check. > > * guix/lint.scm (check-patch-file-names): Adjust margin used to check for > patch file lengths. Make sure =E2=80=9Cmake check TESTS=3Dtests/lint.scm=E2=80=9D is still happ= y, but otherwise LGTM. Thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 16:25:27 2021 Received: (at 51985) by debbugs.gnu.org; 24 Nov 2021 21:25:28 +0000 Received: from localhost ([127.0.0.1]:55113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpzlf-0003m3-Mf for submit@debbugs.gnu.org; Wed, 24 Nov 2021 16:25:27 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:57650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpzlb-0003ln-J0 for 51985@debbugs.gnu.org; Wed, 24 Nov 2021 16:25:26 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100e]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 540F01A982; Wed, 24 Nov 2021 13:25:17 -0800 (PST) From: Vagrant Cascadian To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#51985: lint: Adjust patch file length check. In-Reply-To: <877dd0ph9g.fsf@gnu.org> References: <875ysnsvnt.fsf@yucca> <877dd0ph9g.fsf@gnu.org> Date: Wed, 24 Nov 2021 13:25:05 -0800 Message-ID: <8735nl5jri.fsf@ponder> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51985 Cc: 51985@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-11-22, Ludovic Court=C3=A8s wrote: > Vagrant Cascadian skribis: >> From 6ad2050a8bbc308a328d30d4f66cb229d868b79d Mon Sep 17 00:00:00 2001 >> From: Vagrant Cascadian >> Date: Fri, 19 Nov 2021 12:14:19 -0800 >> Subject: [PATCH] lint: Adjust patch file length check. >> >> * guix/lint.scm (check-patch-file-names): Adjust margin used to check for >> patch file lengths. > > Make sure =E2=80=9Cmake check TESTS=3Dtests/lint.scm=E2=80=9D is still ha= ppy, but > otherwise LGTM. With: commit bdf5c16ac052af2ca9d5c3acc4acbc08fd9fdbea Author: Ludovic Court=C3=A8s Date: Tue Nov 23 09:06:49 2021 +0100 maint: "make dist" builds tarballs in 'ustar' format. It seems like this actually needs even further updates, as that should allow for a much longer file length in general (although a little difficult to figure out the exact file length allowed). And then the corresponding test suite will need changes as well... live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYZ6ttwAKCRDcUY/If5cW qpMmAQDYNL6jp9K4UgGRdzrz8iurXUAL0cHACYmM4fV/CA5fLQEA0lyijddpNmXt RpBO3nHkd7z/pJ//EiM2+3EkwaAedwM= =19+k -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 24 16:27:19 2021 Received: (at 51985) by debbugs.gnu.org; 24 Nov 2021 21:27:19 +0000 Received: from localhost ([127.0.0.1]:55118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpznT-0003on-2T for submit@debbugs.gnu.org; Wed, 24 Nov 2021 16:27:19 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:57662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpznR-0003ob-Mq for 51985@debbugs.gnu.org; Wed, 24 Nov 2021 16:27:18 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100e]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 49D301A982; Wed, 24 Nov 2021 13:27:12 -0800 (PST) From: Vagrant Cascadian To: Philip McGrath , Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= Subject: Re: default tar format for "make dist" and patch file length In-Reply-To: <87tug7jtba.fsf@ponder> References: <87sfvxhrav.fsf@ponder> <874k8bxbit.fsf@gnu.org> <87fsru8l05.fsf@ponder> <87czmy8hr6.fsf@ponder> <87y25kjiwa.fsf@gnu.org> <071f69a4-4e8a-3337-6a84-6ceca5119e6f@philipmcgrath.com> <87tug7jtba.fsf@ponder> Date: Wed, 24 Nov 2021 13:27:03 -0800 Message-ID: <87zgpt453s.fsf@ponder> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51985 Cc: guix-devel@gnu.org, 51985@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-11-19, Vagrant Cascadian wrote: > On 2021-11-19, Philip McGrath wrote: >> On 11/19/21 09:54, Ludovic Court=C3=A8s wrote: >>> Vagrant Cascadian skribis: >>>> So, I guess I'm leaning towards making the guix lint check a little mo= re >>>> lenient. >>>> >>>> Thoughts? >>>=20 >>> That sounds even better, I=E2=80=99m all for it (changing (guix lint) += fixing >>> the two remaining issues)! > > Submitted the guix lint change as https://issues.guix.gnu.org/51775 Er, I meant: https://issues.guix.gnu.org/51985 >> It might also help to change the warning given by the check. >> >> When a program called "lint" tells me that something is too long, I=20 >> understand that to mean that what I've done is generally considered bad= =20 >> style, but there might be a very good reason to do it in some specific=20 >> case. For example, I might exceed a line length guideline to avoid=20 >> inserting linebreaks into a URL. > > That's a good point! > > >> If instead `guix lint` is telling us about a hard limit that will break= =20 >> things, I think it should say so clearly. > > Not sure how to convey succinctly, but here's an attempt at a patch > (which ironically also probably makes the line a bit too long in the > code): > > diff --git a/guix/lint.scm b/guix/lint.scm > index ac2e7b3841..6464fb751a 100644 > --- a/guix/lint.scm > +++ b/guix/lint.scm > @@ -968,7 +968,7 @@ (define (starts-with-package-name? file-name) > max) > (make-warning > package > - (G_ "~a: file name is too long") > + (G_ "~a: file name is too long and may break = release tarball generation") > (list (basename patch)) > #:field 'patch-file-names) > #f)) > diff --git a/tests/lint.scm b/tests/lint.scm > index 9a91dd5426..d4c3d62aaf 100644 > --- a/tests/lint.scm > +++ b/tests/lint.scm > @@ -509,7 +509,7 @@ (define hsab (string-append (assoc-ref inputs > "hsab") > (test-equal "patches: file name too long" > (string-append "x-" > (make-string 100 #\a) > - ".patch: file name is too long") > + ".patch: file name is too long and may break release ta= rball generation") > (single-lint-warning-message > (let ((pkg (dummy-package > "x" live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYZ6uKwAKCRDcUY/If5cW qlNPAQCKSp3tT9jJrGVN6CQqrVTvtXBEYopDyUtXS6Px0WRSegEAqfVuvxPRoVRv VA5clCc8ynDcuDWATqqpgZGvkGgoCg8= =kuOO -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 25 08:08:53 2021 Received: (at 51985) by debbugs.gnu.org; 25 Nov 2021 13:08:53 +0000 Received: from localhost ([127.0.0.1]:56139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqEUe-0001hP-Pb for submit@debbugs.gnu.org; Thu, 25 Nov 2021 08:08:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqEUb-0001h8-OK for 51985@debbugs.gnu.org; Thu, 25 Nov 2021 08:08:50 -0500 Received: from [2001:470:142:3::e] (port=40082 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqEUW-0002n2-3J; Thu, 25 Nov 2021 08:08:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Jmxf8OqGU42x0PnC82Tk6eKHk+ObRyPFsECWnIKRXiQ=; b=NRUSFibBmcjEYGL92Fd/ 2wNAd+zyD869v+mDmgkbn6cHQqWpqM5qqIB6AhTaUk+u8C0ig+rsxIaekdUtAwfhe1W8K6KYwbfCV 9Iak8Bz8ool37FIf0dT0hK17Cbt2UquLF8Te2i+L+mlgAlfu8NZ2YrgEQnyPWd4myZuoEVmdwupWp gJflZadW8Q09MoQj907GtuXZUNdpGzzLvTTZNY4FrkDrR5+baNg4ORjp2fMK/5oMBB8WmuoNmAvF2 B4DgW3vxJqpMJW+iBU4Di1gvrzkI8lMf5u8NmGwwnkKJnoC34uAnIidGgcDzUGlATNuUeKpvsl1g8 AwSZK0Yij+ncNA==; Received: from nat-eduroam-36-gw-01-bso.bordeaux.inria.fr ([194.199.1.36]:56196 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqEUV-00017v-RD; Thu, 25 Nov 2021 08:08:44 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Vagrant Cascadian Subject: Re: bug#51985: lint: Adjust patch file length check. References: <875ysnsvnt.fsf@yucca> <877dd0ph9g.fsf@gnu.org> <8735nl5jri.fsf@ponder> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 Frimaire an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 25 Nov 2021 14:08:42 +0100 In-Reply-To: <8735nl5jri.fsf@ponder> (Vagrant Cascadian's message of "Wed, 24 Nov 2021 13:25:05 -0800") Message-ID: <8735nke61x.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51985 Cc: 51985@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Vagrant Cascadian skribis: > With: > > commit bdf5c16ac052af2ca9d5c3acc4acbc08fd9fdbea > Author: Ludovic Court=C3=A8s > Date: Tue Nov 23 09:06:49 2021 +0100 > > maint: "make dist" builds tarballs in 'ustar' format. > > It seems like this actually needs even further updates, as that should > allow for a much longer file length in general (although a little > difficult to figure out the exact file length allowed). > > And then the corresponding test suite will need changes as well... I think independently of the switch to ustar, it=E2=80=99s a good idea for = =E2=80=98guix lint=E2=80=99 to warn about long patch file names, but to warn a bit less frequently than today. In that spirit, your patch is still relevant and worth applying IMO. Thoughts? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 26 16:09:09 2021 Received: (at 51985) by debbugs.gnu.org; 26 Nov 2021 21:09:10 +0000 Received: from localhost ([127.0.0.1]:60614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqiSz-0003gj-IZ for submit@debbugs.gnu.org; Fri, 26 Nov 2021 16:09:09 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:32854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqiSx-0003gW-N1 for 51985@debbugs.gnu.org; Fri, 26 Nov 2021 16:09:08 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100e]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 88DE61A982; Fri, 26 Nov 2021 13:09:01 -0800 (PST) From: Vagrant Cascadian To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#51985: lint: Adjust patch file length check. In-Reply-To: <8735nke61x.fsf@gnu.org> References: <875ysnsvnt.fsf@yucca> <877dd0ph9g.fsf@gnu.org> <8735nl5jri.fsf@ponder> <8735nke61x.fsf@gnu.org> Date: Fri, 26 Nov 2021 13:08:51 -0800 Message-ID: <87ee72fwv0.fsf@ponder> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51985 Cc: 51985@debbugs.gnu.org, philip@philipmcgrath.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-11-25, Ludovic Court=C3=A8s wrote: > Vagrant Cascadian skribis: > >> With: >> >> commit bdf5c16ac052af2ca9d5c3acc4acbc08fd9fdbea >> Author: Ludovic Court=C3=A8s >> Date: Tue Nov 23 09:06:49 2021 +0100 >> >> maint: "make dist" builds tarballs in 'ustar' format. >> >> It seems like this actually needs even further updates, as that should >> allow for a much longer file length in general (although a little >> difficult to figure out the exact file length allowed). >> >> And then the corresponding test suite will need changes as well... > > I think independently of the switch to ustar, it=E2=80=99s a good idea fo= r =E2=80=98guix > lint=E2=80=99 to warn about long patch file names, but to warn a bit less > frequently than today. > > In that spirit, your patch is still relevant and worth applying IMO. Sure, although while I'm mucking around... I went ahead and did some real-world testing of file lengths usable by ustar. Using ustar adds a significant buffer, though less than one might think in the case of guix-VERSION/gnu/packages/patches/*.patch (~151 characters vs. ~99). I'm guessing this is plenty buffer though, most existing patches were only a theoretical problem... almost to the point that maybe even removing the check entirely might be fine. Updated patch integrating this and the stronger warning suggested by Philip McGrath. I haven't yet actually *tested* this updated patch yet, but the previous iteration tested just fine. :) live well, vagrant --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lint-Adjust-patch-file-length-check.patch Content-Transfer-Encoding: quoted-printable From=20c0738574a3571977855d655c157ab0ea0f9be6ef Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Fri, 26 Nov 2021 12:13:45 -0800 Subject: [PATCH] lint: Adjust patch file length check. With the switch to "ustar" format in commit bdf5c16ac052af2ca9d5c3acc4acbc08fd9fdbea, the maximum file length has increased. * guix/lint.scm (check-patch-file-names): Adjust margin used to check for patch file lengths. Increase allowable patch file length appropriate to n= ew tar format. Extend warning to explain that long files may break 'make dis= t'. * tests/lint.scm: Update tests accordingly. =2D-- guix/lint.scm | 9 ++++++--- tests/lint.scm | 8 ++++---- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/guix/lint.scm b/guix/lint.scm index ac2e7b3841..4a5573e86e 100644 =2D-- a/guix/lint.scm +++ b/guix/lint.scm @@ -957,8 +957,11 @@ patch could not be found." =20 ;; Check whether we're reaching tar's maximum file name length. (let ((prefix (string-length (%distro-directory))) =2D (margin (string-length "guix-2.0.0rc3-10000-1234567890/")) =2D (max 99)) + ;; Margin approximating the largest path that "make dist" might + ;; create, with a release candidate version, 123456 commits, and + ;; git commit hash abcde0. + (margin (string-length "guix-92.0.0rc3-123456-abcde0/")) + (max 151)) (filter-map (match-lambda ((? string? patch) (if (> (+ margin (if (string-prefix? (%distro-direct= ory) @@ -968,7 +971,7 @@ patch could not be found." max) (make-warning package =2D (G_ "~a: file name is too long") + (G_ "~a: file name is too long which may break = 'make dist'") (list (basename patch)) #:field 'patch-file-names) #f)) diff --git a/tests/lint.scm b/tests/lint.scm index 9a91dd5426..8fa0172cf7 100644 =2D-- a/tests/lint.scm +++ b/tests/lint.scm @@ -506,17 +506,17 @@ (file-name "x.patch"))))))))) (check-patch-file-names pkg))) =20 =2D(test-equal "patches: file name too long" +(test-equal "patches: file name too long which may break 'make dist'" (string-append "x-" =2D (make-string 100 #\a) =2D ".patch: file name is too long") + (make-string 152 #\a) + ".patch: file name is too long which may break 'make dist= '") (single-lint-warning-message (let ((pkg (dummy-package "x" (source (dummy-origin (patches (list (string-append "x-" =2D (make-string 100 #\a) + (make-string 152 #\a) ".patch")))))))) (check-patch-file-names pkg)))) =20 =2D-=20 2.30.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYaFM6AAKCRDcUY/If5cW qrj8AQD02tkebDhmrwJhDJUUy/Ya8U3RnzVIobf7lumScSirtgEAiZCehNi6fGBv IT1c4uugIN52Oh2OqM+EsPJRbAxZOgM= =3hkQ -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 28 12:02:21 2021 Received: (at 51985) by debbugs.gnu.org; 28 Nov 2021 17:02:21 +0000 Received: from localhost ([127.0.0.1]:36284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrNZF-0004Wn-2q for submit@debbugs.gnu.org; Sun, 28 Nov 2021 12:02:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrNZD-0004WY-N7 for 51985@debbugs.gnu.org; Sun, 28 Nov 2021 12:02:19 -0500 Received: from [2001:470:142:3::e] (port=38420 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrNZ7-0002fY-VV; Sun, 28 Nov 2021 12:02:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=7FSJm1UK42QlW/KJXtiQB/7HFe967+QNFNFIAfG7alo=; b=Rv1cZD4Z00Clg+8bqFc7 vxcaqV+BhutKRDPW6JRopR1XQrCt06Mnsu+e4a1XTOI51VDh6afGV3tVXTFTbQ4aRZExOIWX6e0WR GxMSpFpOKD7p4RuaNq7OCgdNQmcvPiJ2UvajrVWxmuUGST7ZN9xdsQKeIDl2fYK2lgmC7aDX+7yTX xuFf2XKsls2zZIjV+3Z2BxNrme5yfqo5qwvqYbd9nV6Q/Ly4TfLdwar554LO+ccCZ+8m8h0qE/qlb R4wphcQv4ziqA3ATANI6eD6BJq3gjTqMk+70Vxlpk1U7g6VnNffXtUw3IeoGoBAlJwulq6PDPBsRM 08xa8XsmxTlQoQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:63194 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrNZ7-00076w-PM; Sun, 28 Nov 2021 12:02:13 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Vagrant Cascadian Subject: Re: bug#51985: lint: Adjust patch file length check. References: <875ysnsvnt.fsf@yucca> <877dd0ph9g.fsf@gnu.org> <8735nl5jri.fsf@ponder> <8735nke61x.fsf@gnu.org> <87ee72fwv0.fsf@ponder> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 Frimaire an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 28 Nov 2021 18:02:10 +0100 In-Reply-To: <87ee72fwv0.fsf@ponder> (Vagrant Cascadian's message of "Fri, 26 Nov 2021 13:08:51 -0800") Message-ID: <87lf18b4dp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51985 Cc: 51985@debbugs.gnu.org, philip@philipmcgrath.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Vagrant Cascadian skribis: > On 2021-11-25, Ludovic Court=C3=A8s wrote: [...] >> I think independently of the switch to ustar, it=E2=80=99s a good idea f= or =E2=80=98guix >> lint=E2=80=99 to warn about long patch file names, but to warn a bit less >> frequently than today. >> >> In that spirit, your patch is still relevant and worth applying IMO. > > Sure, although while I'm mucking around... I went ahead and did some > real-world testing of file lengths usable by ustar. > > Using ustar adds a significant buffer, though less than one might think > in the case of guix-VERSION/gnu/packages/patches/*.patch (~151 > characters vs. ~99). > > I'm guessing this is plenty buffer though, most existing patches were > only a theoretical problem... almost to the point that maybe even > removing the check entirely might be fine. Like I wrote, I think it=E2=80=99s good to have this check even if there we= re no hard limits, mostly as a style guideline. > From c0738574a3571977855d655c157ab0ea0f9be6ef Mon Sep 17 00:00:00 2001 > From: Vagrant Cascadian > Date: Fri, 26 Nov 2021 12:13:45 -0800 > Subject: [PATCH] lint: Adjust patch file length check. > > With the switch to "ustar" format in commit > bdf5c16ac052af2ca9d5c3acc4acbc08fd9fdbea, the maximum file length has > increased. > > * guix/lint.scm (check-patch-file-names): Adjust margin used to check for > patch file lengths. Increase allowable patch file length appropriate to= new > tar format. Extend warning to explain that long files may break 'make d= ist'. > * tests/lint.scm: Update tests accordingly. [...] > + (G_ "~a: file name is too long which may brea= k 'make dist'") I think you need a comma before =E2=80=9Cwhich=E2=80=9D, but other than tha= t LGTM! :-) Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 18 03:27:07 2021 Received: (at 51985-done) by debbugs.gnu.org; 18 Dec 2021 08:27:07 +0000 Received: from localhost ([127.0.0.1]:41239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myV3b-0001Zc-Gp for submit@debbugs.gnu.org; Sat, 18 Dec 2021 03:27:07 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:39062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myV3Z-0001Z6-Iz for 51985-done@debbugs.gnu.org; Sat, 18 Dec 2021 03:27:05 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100e]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 6EA9E1AA2C; Sat, 18 Dec 2021 00:26:59 -0800 (PST) From: Vagrant Cascadian To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#51985: lint: Adjust patch file length check. In-Reply-To: <87lf18b4dp.fsf@gnu.org> References: <875ysnsvnt.fsf@yucca> <877dd0ph9g.fsf@gnu.org> <8735nl5jri.fsf@ponder> <8735nke61x.fsf@gnu.org> <87ee72fwv0.fsf@ponder> <87lf18b4dp.fsf@gnu.org> Date: Sat, 18 Dec 2021 00:26:50 -0800 Message-ID: <87pmpu8gj9.fsf@ponder> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51985-done Cc: 51985-done@debbugs.gnu.org, philip@philipmcgrath.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-11-28, Ludovic Court=C3=A8s wrote: > Vagrant Cascadian skribis: >> On 2021-11-25, Ludovic Court=C3=A8s wrote: ... >> From c0738574a3571977855d655c157ab0ea0f9be6ef Mon Sep 17 00:00:00 2001 >> From: Vagrant Cascadian >> Date: Fri, 26 Nov 2021 12:13:45 -0800 >> Subject: [PATCH] lint: Adjust patch file length check. >> >> With the switch to "ustar" format in commit >> bdf5c16ac052af2ca9d5c3acc4acbc08fd9fdbea, the maximum file length has >> increased. >> >> * guix/lint.scm (check-patch-file-names): Adjust margin used to check for >> patch file lengths. Increase allowable patch file length appropriate t= o new >> tar format. Extend warning to explain that long files may break 'make = dist'. >> * tests/lint.scm: Update tests accordingly. > > [...] > >> + (G_ "~a: file name is too long which may bre= ak 'make dist'") > > I think you need a comma before =E2=80=9Cwhich=E2=80=9D, but other than t= hat LGTM! :-) Pushed as 5f547a5c425cc99553ea713703e09a8db9f3c38b with the suggested comma, and a brief comment explaining what the magic number "151" was about. That should bright all the patches into compliance with lint as far as file length goes, and should work with the ustar format for the "make dist" produced tarballs. Don't get too crazy with the extra ~50 characters! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYb2bTgAKCRDcUY/If5cW qsnMAQDtqRlxdhb0TlUbiNPakFExNOK2GUTkQ8I5+7KW3Js4kAD/QKRsfe1tEqqO lidYhHvSCxGFGgcTpRv8VZcW/laotQ0= =s4KP -----END PGP SIGNATURE----- --=-=-=-- From unknown Wed Aug 20 00:02:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 15 Jan 2022 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator