GNU bug report logs - #51981
[PATCH 0/1] Fix cross-compilation of packages that use go-build-system

Previous Next

Full log

Message #15 received at 51981 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 51981 <at> debbugs.gnu.org
Subject: Re: [PATCH 0/1] Fix cross-compilation of packages that use
 go-build-system
Date: Sat, 14 May 2022 09:23:20 +0200

[Message part 1 (text/plain, inline)]

> [PATCH 1/1] build: Fix cross compilation for go-build-system
Nice.

> +              ;; Set the output path for the build
> +              (string-append "-o="
> +                (assoc-ref outputs "out") "/bin/"
> +                (package-name->name+version
> +                  (strip-store-file-name (assoc-ref outputs "out"))))

Maybe add a comment on why the simpler "GOBIN" isn't used instead, such
that it won't be incorrectly simplified in the future.  I'm not sure if
this is correct though, what if the name of the binary differs from the
package name?  Or was if the go package has multiple binaries?


I found it at <https://patches.guix-patches.cbaines.net/project/guix-patches/patch/877dd36fvc.fsf <at> rekahsoft.ca/>,
but it doesn't seem to be in data.guix-patches.cbaines.net <https://data.guix-patches.cbaines.net/compare?base_commit=256c3e714a459af6db2343c9120c7180c5a14462&target_commit=9630c40d89c8f778c4961b49e30275f35a45948c> anymore,
maybe you could resend the patch as a v2?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.