From unknown Sat Jun 14 03:54:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#51981] (no subject) Resent-From: "Collin J. Doering" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Nov 2021 20:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51981 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 51981@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163735306123288 (code B ref -1); Fri, 19 Nov 2021 20:18:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Nov 2021 20:17:41 +0000 Received: from localhost ([127.0.0.1]:40611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moAKL-00063Y-G1 for submit@debbugs.gnu.org; Fri, 19 Nov 2021 15:17:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:33006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moAKK-00063R-91 for submit@debbugs.gnu.org; Fri, 19 Nov 2021 15:17:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moAKK-0003sl-4I for guix-patches@gnu.org; Fri, 19 Nov 2021 15:17:40 -0500 Received: from [2607:f8b0:4864:20::f2a] (port=42498 helo=mail-qv1-xf2a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moAKF-0003AL-LB for guix-patches@gnu.org; Fri, 19 Nov 2021 15:17:39 -0500 Received: by mail-qv1-xf2a.google.com with SMTP id b17so7891334qvl.9 for ; Fri, 19 Nov 2021 12:17:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rekahsoft.ca; s=google; h=user-agent:from:to:date:message-id:mime-version; bh=4icf3bRtgKiz0LAERPlb7jTDwea+iTFNnZ+q8n9+RFo=; b=Pm2d0ESrJg0nvDeL7+IZSen0mVn8hkPqJAHD/yYTFH7uanJA9K3WJ2NnqTs6/tbnKH DTZDSH0kpHedc3oPQV47U/1jMOi1RWU43XzlZTCVBPJwQMxTrel67Nc3toysPnrHmSiw q9RQVnpyIai/Hy/8lN2srzZXqvnWARHHC5w8nSBwu2Kg41DOGh5XGdPaNpSt3DilYIUb aUN4nswaxgyO7GsX23WII2hv8xPktPwfXBGpD9Ev6rv3pR0A8t1vVoiWD4iD7ml9e0fR Wa2avrt1jiTcp7gjS73ddcnA8RfmKd+igd0dc1hox8ejVqjz+ZXtB/F3ES+8BQIFHIs8 OdCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:user-agent:from:to:date:message-id:mime-version; bh=4icf3bRtgKiz0LAERPlb7jTDwea+iTFNnZ+q8n9+RFo=; b=Gq/hNAC4kPJnelsPXpe1DlFOCfpF+wQFOuQTlwFyq2ABLbRTtWN10EK3zO9rhxqIbT +8eu371pp7bVDcJF8Af7K82MUTqUzxCNo3Um9ku4bLw8LgCqp7Xq5WoUh5KLmRiKNk0I RUs2ytZUdSNpTupVXz93z+zpv+S221gb2xzzElNyfouXD79TYKG64j36lZHptHHD25z3 EzDcvPoKnQjIqpX198b6vjxG2woSen/PdAd0RI74AxwG7QU9oqNA3h6URNgN+FkM3DYn BE8g8fy1JUhuTdVebPBu91Ao9f6Q+nd4F0onCL21Musd4C4QKrG1/sH2xVhal5kRxwoH ODEQ== X-Gm-Message-State: AOAM531noCp+pDw5rjgGM9UcGpSIl2trfW2sA7p4LrJQImf+btfSkdSm agY1uRgIx6C1l4XUxIDpleGu0egv7qb2QA== X-Google-Smtp-Source: ABdhPJyWj4o8rTjRpxmp2LOB4OTU8LwpBaRIpwTJLjOf6oCv/YhHm38GnBD4h4ZE0QsA3WBdKsobpw== X-Received: by 2002:a0c:f8cc:: with SMTP id h12mr75910808qvo.6.1637353052269; Fri, 19 Nov 2021 12:17:32 -0800 (PST) Received: from rekahsoft-work (cpe0008a20f982f-cm64777d666260.cpe.net.cable.rogers.com. [99.255.210.233]) by smtp.gmail.com with ESMTPSA id bk18sm407329qkb.35.2021.11.19.12.17.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 12:17:31 -0800 (PST) User-agent: mu4e 1.6.10; emacs 27.2 From: "Collin J. Doering" Date: Fri, 19 Nov 2021 14:59:07 -0500 Message-ID: <87bl2f6gti.fsf@rekahsoft.ca> MIME-Version: 1.0 Content-Type: text/plain X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::f2a (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::f2a; envelope-from=collin@rekahsoft.ca; helo=mail-qv1-xf2a.google.com X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MISSING_SUBJECT=1.799, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Hi all, This patch resolves an issue I discovered when attempting to cross-compile packages that use the go-build-system. Namely, prior to this patch, running 'guix build --target=arm-unknown-linux-gnueabihf ' where '' is some package that uses to go-build-system (for example, 'fzf'), would result in the following error in the build log: --8<---------------cut here---------------start------------->8--- go install: cannot install cross-compiled binaries when GOBIN is set Building 'github.com/junegunn/fzf' failed. Here are the results of `go env`: GO111MODULE="off" GOARCH="arm" GOBIN="/gnu/store/8xcs9vna6zyl814j78raynccm7mqqk0h-fzf-0.25.0/bin" GOCACHE="/tmp/go-cache" GOENV="/homeless-shelter/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOINSECURE="" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/tmp/guix-build-fzf-0.25.0.drv-0" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/gnu/store/y5rwacd5l4q26pxis28wsmswj2603hkw-go-1.14.15" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/gnu/store/y5rwacd5l4q26pxis28wsmswj2603hkw-go-1.14.15/pkg/tool/linux_amd64" GCCGO="gccgo" GOARM="7" AR="ar" CC="/gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0/bin/gcc" CXX="g++" CGO_ENABLED="0" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -marm -fmessage-length=0 -fdebug-prefix-map=/tmp/guix-build-fzf-0.25.0.drv-0/go-build219362912=/tmp/go-build -gno-record-gcc-switches" command "go" "install" "-v" "-x" "-ldflags=-s -w" "github.com/junegunn/fzf" failed with status 1 --8<---------------cut here---------------end--------------->8--- The important bit is the first line, which indicates that 'GOBIN' cannot be set when cross-compiling. This has been the case in go from what I can tell for numerous years (atleast 2019). This patch removes the setting of 'GOBIN' and adjusts the go-build-systems build function to us 'go build' instead of 'go install'. Collin J. Doering (1): build: Fix cross compilation for go-build-system guix/build/go-build-system.scm | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 2.33.1 -- Collin J. Doering http://rekahsoft.ca http://blog.rekahsoft.ca http://git.rekahsoft.ca From unknown Sat Jun 14 03:54:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#51981] [PATCH 1/1] build: Fix cross compilation for go-build-system References: <87bl2f6gti.fsf@rekahsoft.ca> In-Reply-To: <87bl2f6gti.fsf@rekahsoft.ca> Resent-From: "Collin J. Doering" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Nov 2021 20:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51981 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 51981@debbugs.gnu.org Received: via spool by 51981-submit@debbugs.gnu.org id=B51981.163735428825577 (code B ref 51981); Fri, 19 Nov 2021 20:39:01 +0000 Received: (at 51981) by debbugs.gnu.org; 19 Nov 2021 20:38:08 +0000 Received: from localhost ([127.0.0.1]:40625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moAe7-0006eT-Ky for submit@debbugs.gnu.org; Fri, 19 Nov 2021 15:38:07 -0500 Received: from mail-qv1-f42.google.com ([209.85.219.42]:38759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moAe6-0006e0-Oe for 51981@debbugs.gnu.org; Fri, 19 Nov 2021 15:38:07 -0500 Received: by mail-qv1-f42.google.com with SMTP id a24so7942096qvb.5 for <51981@debbugs.gnu.org>; Fri, 19 Nov 2021 12:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rekahsoft.ca; s=google; h=user-agent:from:to:subject:date:message-id:mime-version; bh=lpVfeW0sCsA8Kz2dra1X63GLrzo+ZGZs7Crh8ktfZDQ=; b=jMb7nuZ+ymebVhdneh95/QFvFNjUVi9Ii6PIyMcb69TTBsfMTbfE+fljFDzt5iVIY+ ikCtC3Udtl9B5Yx/ePgQsUngLfowdWSJnZMOdQ5K3D6kusEYLGB5I2IXZp2De69odFrk fBlxMUMUVlzQ3cEplkj7BnaAaKX6s3Y01ua44SlWHbnrOZqQehIkPQ8IDMmzay/eVfgV 8EDf9yQvezacCOMH3qcM8APHfnTbhK6GTfrs+b308K6bTmn/GaLYXs0wEKcMBZcOH9yd YYapiqM9z34bn/n11ubW9FWAgUQWcA5G31YlcSFb2HR1Ht04zp3ECRT4pc/EaIDdYup7 ouKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=lpVfeW0sCsA8Kz2dra1X63GLrzo+ZGZs7Crh8ktfZDQ=; b=ee1kwt/aiFtOFJjkmZdof7VDzVfUEjAs0KE7uUdYR6Kjis8U6pqgaMjXVpQTMfqXBB VVxy1PcUCgS2zvM+VJNHrYSYcE0X7tXr8zYpgOOLSqLABPGADExIcJUstT4WzOaUf4PI CGItV4icJ6hrORx5+3N4fjUuJcSQVGsUAvI14ozXRx7m/s24+tK+nhncPTQkfwSRn5mP oqEmEc70I529EyZrHJu8sc1Xl/0EEwvhkLpUaDbPTD3fwhoAJlhHpdUIpJ7NUw42m1pL i9QXK1nPxd/MEvBl9I0fJIdZX6qU8J8mO4ytYJlLAyaGAkzeEk3ZiVSeTuJeiSZuEOpF u2Yw== X-Gm-Message-State: AOAM533DTi6h+1iV7M8GFlSuF976DBTs0jj2EVKTczCpQYtD3Jwzr2Oo Ny26xRkLKedfBGP6PNCUJuHcJ9MM+UdyoA== X-Google-Smtp-Source: ABdhPJwCpEc3w9BHyW77Kf9ppZq2Gbmh6TY3xmUMjw45N38iEdMVHVdL6RarQGiw2eE2qk6ThURcXA== X-Received: by 2002:ad4:5aa1:: with SMTP id u1mr78360148qvg.44.1637354280819; Fri, 19 Nov 2021 12:38:00 -0800 (PST) Received: from rekahsoft-work (cpe0008a20f982f-cm64777d666260.cpe.net.cable.rogers.com. [99.255.210.233]) by smtp.gmail.com with ESMTPSA id o5sm368676qkl.50.2021.11.19.12.38.00 for <51981@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 12:38:00 -0800 (PST) User-agent: mu4e 1.6.10; emacs 27.2 From: "Collin J. Doering" Date: Fri, 19 Nov 2021 15:37:34 -0500 Message-ID: <877dd36fvc.fsf@rekahsoft.ca> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --- guix/build/go-build-system.scm | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm index 4768ee8562..f36e98f47a 100644 --- a/guix/build/go-build-system.scm +++ b/guix/build/go-build-system.scm @@ -148,7 +148,6 @@ (define* (setup-go-environment #:key inputs outputs goos goarch #:allow-other-ke ;; currently support modules, so turn modules off to continue using the old ;; GOPATH behavior. (setenv "GO111MODULE" "off") - (setenv "GOBIN" (string-append (assoc-ref outputs "out") "/bin")) ;; Make sure we're building for the correct architecture and OS targets ;; that Guix targets. @@ -234,14 +233,19 @@ (define (go-inputs inputs) (_ #f)) inputs)))) -(define* (build #:key import-path build-flags #:allow-other-keys) +(define* (build #:key outputs import-path build-flags #:allow-other-keys) "Build the package named by IMPORT-PATH." (with-throw-handler #t (lambda _ - (apply invoke "go" "install" + (apply invoke "go" "build" "-v" ; print the name of packages as they are compiled "-x" ; print each command as it is invoked + ;; Set the output path for the build + (string-append "-o=" + (assoc-ref outputs "out") "/bin/" + (package-name->name+version + (strip-store-file-name (assoc-ref outputs "out")))) ;; Respectively, strip the symbol table and debug ;; information, and the DWARF symbol table. "-ldflags=-s -w" -- 2.33.1 -- Collin J. Doering http://rekahsoft.ca http://blog.rekahsoft.ca http://git.rekahsoft.ca From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 19 15:48:41 2021 Received: (at control) by debbugs.gnu.org; 19 Nov 2021 20:48:42 +0000 Received: from localhost ([127.0.0.1]:40630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moAoL-0006yf-Mw for submit@debbugs.gnu.org; Fri, 19 Nov 2021 15:48:41 -0500 Received: from mail-qk1-f174.google.com ([209.85.222.174]:40582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moAoJ-0006yL-Vv for control@debbugs.gnu.org; Fri, 19 Nov 2021 15:48:41 -0500 Received: by mail-qk1-f174.google.com with SMTP id p4so11481287qkm.7 for ; Fri, 19 Nov 2021 12:48:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rekahsoft.ca; s=google; h=user-agent:from:to:subject:date:message-id:mime-version; bh=nklc7hb4RAfS6n5IIfT5wnKsqhg+VEKCWz58H/2A+Nw=; b=hgP2brUsVuKHG2ms7ub5w8MtDTj+oJkpRVa+/rRG2wTqwdRrCEJF8pGwHXftWwYnbS pS9adUQiI6F6QXJrraKgRIbd/rldFp0SCRIEK6pu0J1pCVFGZ5KOwAWYm3LLmJVSJuxR zDCnJ1nhM7t2o/AqC0YbtIp0yhjWY36a9P8RM27WJ8kQQ4vA//gsGV6OuEze98kqnReN /Dz3932xCCzyzOPzhBhuvhHJZuIj1ggr/dz4WAPDlfqgW18t3+HU59HzMda4BfQNehSb vaJ3o62du/+lkYiABo6ERUyn39r+UhrYrkNrbZ6ll0jNEjTM6EQoYR7nSrSmtqEJgUR5 t7Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=nklc7hb4RAfS6n5IIfT5wnKsqhg+VEKCWz58H/2A+Nw=; b=klN4x7nyyesBN8IV8VDlwLrDUYKfrfAgrRKtgoM21CuPx6t2E2TymuDO4UeQ/KFdkw +GDARdmHMyJcDuNE5gqZGXGKTzayOyrpr3/SszQ96YS0mHBwfLmKY8h3s5ro5q89Rk6q IyBgkJTvSA7/C+2Z+a4gvlUGw8eFIZEXBczfig5oV2oIsio7urovSa8rhyMq/tVvhkwH j/gV8z3mtVSJIcbQmRM0BTAcyEn8Nj2ZsnW88ExmUExhVbReRURLpL0RCUUZat5rMfhQ LP3kmZ3cs/PrIWdNPZARbGUzkvRFFjUId7Vx1pfiDYWXMhDGabtsm3rL2sc01l2BbykH XByw== X-Gm-Message-State: AOAM533LTBZikW91QnUkAA5ObdIeNCvpSqIdY9YYvju5NfKs+C8s7pe6 0Qye44i4NXdZ2QW3swfA3foKlmfA8Tm4Kw== X-Google-Smtp-Source: ABdhPJw/TwyzCt/YfDUTB+iLf5SkiWBo7ajv012UOCpw0SAEO+AANzoUzxgTytaZO+QH2dRLNjdeqQ== X-Received: by 2002:a05:620a:1479:: with SMTP id j25mr31412804qkl.139.1637354914132; Fri, 19 Nov 2021 12:48:34 -0800 (PST) Received: from rekahsoft-work (cpe0008a20f982f-cm64777d666260.cpe.net.cable.rogers.com. [99.255.210.233]) by smtp.gmail.com with ESMTPSA id m4sm433529qtu.87.2021.11.19.12.48.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 12:48:33 -0800 (PST) User-agent: mu4e 1.6.10; emacs 27.2 From: "Collin J. Doering" To: control@debbugs.gnu.org Subject: Adjust title Date: Fri, 19 Nov 2021 15:46:32 -0500 Message-ID: <8735nr6fdr.fsf@rekahsoft.ca> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) retitle 51981 [PATCH 0/1] Fix cross-compilation of packages that use go-build-system -- Collin J. Doering http://rekahsoft.ca http://blog.rekahsoft.ca http://git.rekahsoft.ca From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 19 16:16:38 2021 Received: (at control) by debbugs.gnu.org; 19 Nov 2021 21:16:38 +0000 Received: from localhost ([127.0.0.1]:40677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moBFO-0001Ze-MN for submit@debbugs.gnu.org; Fri, 19 Nov 2021 16:16:38 -0500 Received: from mail-qk1-f182.google.com ([209.85.222.182]:33436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moBFN-0001ZQ-2g for control@debbugs.gnu.org; Fri, 19 Nov 2021 16:16:37 -0500 Received: by mail-qk1-f182.google.com with SMTP id de30so11617797qkb.0 for ; Fri, 19 Nov 2021 13:16:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rekahsoft.ca; s=google; h=user-agent:from:to:subject:date:message-id:mime-version; bh=osa5trQ+Aky2jVgAxr8ZEBmUuv1PGLDTVHUyx6dvmGE=; b=ZxSIt5cFb9MLz88T0bL0T/9bGY5Ms8BRNXYUVEhtlBsuOg3ycGnR8Qr+MJYpcZ1Lsa bCkBZsu5JdY9msCa0IH35TJiAr3es5UvI4QW9XboV2MDODAEdNGTy4e44FTebyUjC3wd 5Mi33sy9ZdM0YSG8cb5mBETwI4j4zUsvcXJpg1Z09dYNzIFZwXAsmG6mNIjijVzYV5u5 mng1C8j/8N72R9lh1zVEHucMwWhaV64Ha5D2LOCJLwdtub0euzF7ETI3Uj1InQaloii+ qMIpl3+BZ8B7NM9Y7049TdQbGItmB0TTyonuKic+hCRKGfOVlGPokcLfijnd41ZLqNYZ YJsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=osa5trQ+Aky2jVgAxr8ZEBmUuv1PGLDTVHUyx6dvmGE=; b=JpGo4nZ+3eCOWZP+X3m4I5VNDhK/p3lvuWPgwM/YIOT9fwn+y4aYoHzQGaUEff/B56 +osJ10uer0f6mDBOo/hdCPf7qhWaWlSOOf8uMRLJakug2C5NUVApI99cKB6wamaILCVF ADrfWFf/QHVvfIzEG3V+FuD50wVxqIVBgVOWcB54gCSdV6KMQD9jcpY2cnKZ+7SpG4ET Uha/hpx9qPo+XtNDXfz/VIRSy1PjuTzX7nsd8FAscPcRXX8BGnSQHWYJwxCYOeoSJNrP QnpiR03bb+CvqVzy+Z0gZPW5XjMN4P/SqWVhqgQXFOjHbfn6Rston+/8a1g5lD52OtQ6 gzVA== X-Gm-Message-State: AOAM530XdvL+ttP08Qn71dUB7DoTD2pP6lACYQnkMo/H4tJrp78kICfV L9ByjtajWEVKjJxajSFNnDG8LFBcZBOoTQ== X-Google-Smtp-Source: ABdhPJwsJvTLb3qGwHRQgjf708NsnvqsZahXsR925XdbgfkDEfl3TfhuiZTMYAsHShh8Qr6cFOx1aA== X-Received: by 2002:a37:f90a:: with SMTP id l10mr29869456qkj.402.1637356591480; Fri, 19 Nov 2021 13:16:31 -0800 (PST) Received: from rekahsoft-work (cpe0008a20f982f-cm64777d666260.cpe.net.cable.rogers.com. [99.255.210.233]) by smtp.gmail.com with ESMTPSA id h5sm524297qkn.62.2021.11.19.13.16.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 13:16:31 -0800 (PST) User-agent: mu4e 1.6.10; emacs 27.2 From: "Collin J. Doering" To: control@debbugs.gnu.org Subject: Add patch tag Date: Fri, 19 Nov 2021 16:15:49 -0500 Message-ID: <87pmqv4ziq.fsf@rekahsoft.ca> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 51981 patch -- Collin J. Doering http://rekahsoft.ca http://blog.rekahsoft.ca http://git.rekahsoft.ca From unknown Sat Jun 14 03:54:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#51981] [PATCH 0/1] Fix cross-compilation of packages that use go-build-system References: <87bl2f6gti.fsf@rekahsoft.ca> In-Reply-To: <87bl2f6gti.fsf@rekahsoft.ca> Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 May 2022 07:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51981 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51981@debbugs.gnu.org Received: via spool by 51981-submit@debbugs.gnu.org id=B51981.165251300315245 (code B ref 51981); Sat, 14 May 2022 07:24:02 +0000 Received: (at 51981) by debbugs.gnu.org; 14 May 2022 07:23:23 +0000 Received: from localhost ([127.0.0.1]:45653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npm7X-0003xp-KX for submit@debbugs.gnu.org; Sat, 14 May 2022 03:23:23 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:53814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npm7W-0003xh-Fm for 51981@debbugs.gnu.org; Sat, 14 May 2022 03:23:22 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id WXPL2700X4UW6Th01XPMwX; Sat, 14 May 2022 09:23:21 +0200 Message-ID: <2d39676f4b73229ca654ce67ea3fce57b50edc53.camel@telenet.be> From: Maxime Devos Date: Sat, 14 May 2022 09:23:20 +0200 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-mHqkM+/0ebr+TJS9krLi" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1652513001; bh=awgziKDHzfVHI+pE6M/COvUi1y/liiDZK5yHPQOZ3ZQ=; h=Subject:From:To:Date; b=UKKQPwZi4QrGJaUofczO3p/l5DPdjObSG/Mq/QlTxwLCaFnB2VD2NdAnAk4Qv5euC jSi3P1DhvpieVYJQz3XejMjgXleOUnFNcD2xMdnKSjXOBxzRKrNaoxYNrajpbIuoXr TcUkSQ32q0JlCtx/F59iVSrAQKcYYD0tVGoM/P1DGvZoMD+Teeu3k8zU8CuvBDQxLH a5gVTbK1iaSVUpJPypOcqpUFZHP+JEoSBQuWaBMGqVvAbsWxZ+jOkZqzcxwLSuPg7W YRZREmLjASdT+pg+RDSbS03Hxc2tfb7b9t4wAFwmSpPRSRR0pH29iJPkiTLSpNhA0B 0OsmmdV+VQPBQ== X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-mHqkM+/0ebr+TJS9krLi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > [PATCH 1/1] build: Fix cross compilation for go-build-system Nice. > + ;; Set the output path for the build > + (string-append "-o=3D" > + (assoc-ref outputs "out") "/bin/" > + (package-name->name+version > + (strip-store-file-name (assoc-ref outputs "out")))) Maybe add a comment on why the simpler "GOBIN" isn't used instead, such that it won't be incorrectly simplified in the future. I'm not sure if this is correct though, what if the name of the binary differs from the package name? Or was if the go package has multiple binaries? I found it at , but it doesn't seem to be in data.guix-patches.cbaines.net anymor= e, maybe you could resend the patch as a v2? Greetings, Maxime. --=-mHqkM+/0ebr+TJS9krLi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYn9Y6BccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7txmAPsHZR8ey69tGab+YdcTB+Xnf2eA CRUJ/qNZ+zNB+d/BUAD/ZBvTM7F5NYI3/9cqHLB/RkrJWlCVo/x3LZd4ft4ZvQA= =en1m -----END PGP SIGNATURE----- --=-mHqkM+/0ebr+TJS9krLi--