GNU bug report logs - #5198
23.1; find-file tramp ipv6 not a wildcard

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5198 in the body.
You can then email your comments to 5198 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1; find-file tramp ipv6 not a wildcard
Date: Sun, 13 Dec 2009 11:01:47 +1100

find-file thinks a tramp ipv6 filename like /[::1]:/etc/passwd has a
wildcard and dispatches it to file-expand-wildcards.  Eg.

    M-: (debug-on-entry 'file-expand-wildcards)
    C-x C-f
    /[::1]:/etc/passwd

gives

    file-expand-wildcards("/scp:[::1]:/etc/passwd" t)

I believe it shouldn't do this, ie. should not look at the remote
identifier part when considering wildness.

I struck this nosing around some options and defadvice tramp has for
xemacs remote filename forms, but the ipv6 raw address form tickles it
too.  Tramp thread "defadvice file-expand-wildcards ad-do-it value" at
http://comments.gmane.org/gmane.emacs.tramp/6980


Not sure how bad this is.  It may depend how good file-expand-wildcards
is on remote filenames.  I seem to sometimes get max-specl-depth
exceeded by its recursion, but I don't have a good reproducing for that
yet, and in any case that would be a separate bug.



In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

Message #8 received at 5198 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 5198 <at> debbugs.gnu.org
Subject: bug#5198: 23.1; find-file tramp ipv6 not a wildcard
Date: Sun, 20 Dec 2009 11:40:51 +0100

Kevin Ryde <user42 <at> zip.com.au> writes:

> Michael Albinus <michael.albinus <at> gmx.de> writes:
>>
>> I've added a check in `file-expand-wildcards' to handle this case.
>
> Would find-file-noselect look at
>
>     (file-remote-p filename 'localname)
>
> like file-expand-wildcards now too?

No necessarily. It calls itself recursively with the result of
file-expand-wildcards.

> And/or would there be merit in a function that checked if there's
> wildcards in a filename (ie. anything file-expand-wildcards could
> expand), rather than a string-match?  It might help if new wildness was
> added one day, like bash style {xx,yy,zz} alternations or something.

Maybe. OTOH, one could introduce it, when the need arises.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.