GNU bug report logs - #51923
[PATCH] gnu: Add megapixels.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51923 in the body.
You can then email your comments to 51923 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add megapixels.
Date: Wed, 17 Nov 2021 16:07:04 +0000

Hi,

this adds support for the camera on PinePhone.

Also when I run lint it errors:

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
error: remote-refs: unbound variable

The problem is in the updater not handling the url https://git.sr.ht/~martijnbraam/megapixels.

* gnu/packages/gnome.scm (megapixels): New variable.

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 19520f335a..7d53784533 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1137,6 +1137,42 @@ freedesktop.org desktop notification specification.")
     (home-page "https://wiki.gnome.org/Projects/NotificationDaemon")
     (license license:gpl2+)))

+(define-public megapixels
+  (package
+    (name "megapixels")
+    (version "1.3.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://git.sr.ht/~martijnbraam/megapixels")
+             (commit version)))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0dagp1sh5whnnllrydk7ijjid0hmvcbdm8kkzq2g168khdfn80jm"))))
+    (build-system meson-build-system)
+    (native-inputs `(("pkg-config" ,pkg-config)
+                     ("gtk:bin"
+                      ,gtk "bin")       ; for gtk-update-icon-cache
+                     ("glib:bin"
+                      ,glib "bin")      ; glib-compile-schemas, etc.
+                     ("desktop-file-utils"
+                      ,desktop-file-utils) ; for update-desktop-database
+                     ("zbar" ,zbar)
+                     ("libtiff" ,libtiff)
+                     ("cmake" ,cmake)))
+    (inputs `(("libhandy" ,libhandy)
+              ("perl-image-exiftool" ,perl-image-exiftool)
+              ("imagemagick" ,imagemagick)
+              ("libraw" ,libraw)
+              ("gtk" ,gtk)))
+    (synopsis "Camera application")
+    (description "This package provides camera application that knows
+how to deal with the media request api.")
+    (home-page "https://git.sr.ht/~martijnbraam/megapixels")
+    (license license:gpl3+)))
+
 (define-public mm-common
   (package
     (name "mm-common")

base-commit: b7b982228a7256afcb83d0b05a098139c2e1a644
--
2.33.0

Message #8 received at 51923 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: phodina <phodina <at> protonmail.com>
Cc: 51923 <at> debbugs.gnu.org
Subject: Re: [bug#51923] [PATCH] gnu: Add megapixels.
Date: Wed, 17 Nov 2021 18:47:15 +0100

Petr,

'Nother quickie.

On 2021-11-17 17:07, phodina via Guix-patches via wrote:
> The problem is in the updater not handling the url
> https://git.sr.ht/~martijnbraam/megapixels.

Good thing 'he development and maintainership of Megapixels has been 
moved to gitlab.com/postmarketos/megapixels' then :-)

Could you update the URL and try again?  If you want you can report 
and/or investigate Guix's apparent failure to deal with sr.ht 
separately.

> +       (file-name (string-append name "-" version ".tar.gz"))
                                                     ^^^^^^^^^
Use git-file-name here for convenience and to reduce the chances of such 
paste-os.

> +    (native-inputs `(("pkg-config" ,pkg-config)
> +                     ("gtk:bin"
> +                      ,gtk "bin")       ; for gtk-update-icon-cache
> +                     ("glib:bin"
> +                      ,glib "bin")      ; glib-compile-schemas, etc.
> +                     ("desktop-file-utils"
> +                      ,desktop-file-utils) ; for 
> update-desktop-database
> +                     ("zbar" ,zbar)
> +                     ("libtiff" ,libtiff)
> +                     ("cmake" ,cmake)))

Please add a newline after native-inputs so you don't have to split 
inputs over 2 lines like this.  Since we're here anyway, order these 
alphabetically.

> +    (inputs `(("libhandy" ,libhandy)
> +              ("perl-image-exiftool" ,perl-image-exiftool)
> +              ("imagemagick" ,imagemagick)
> +              ("libraw" ,libraw)
> +              ("gtk" ,gtk)))

Same newline.

> +    (synopsis "Camera application")

So... ignoring the redundant 'application', this is a one-word synopsis. 
 This seems to be for mobile devices, so 'Camera applications for mobile 
devices', I guess.

> +    (description "This package provides camera application that knows
> +how to deal with the media request api.")

Whose obscure 'media request API'?  Why does that matter?  Etc.

This seems (more?) pertinent:

- Megapixels only captures raw frames and stores .dng files.
- It captures a 5 frame burst and saves it to a temporary location.
- It runs a (customisable? dunno) postprocessing script to generate the 
final JPEG file and saves it to the Pictures directory.
- It uses OpenGL to debayer the raw sensor data for the preview.

Etc.  Descriptions should not be 1-2 lines long.

> +    (home-page "https://git.sr.ht/~martijnbraam/megapixels")

Also update to GitLab?

I'll build this later today, but I don't expect to find any issues with 
the package :-)

Kind regards,

T G-R

Sent from a Web browser.  Excuse or enjoy my brevity.

Message #11 received at 51923 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 51923 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: Add megapixels.
Date: Mon, 29 Nov 2021 11:02:20 +0000

[Message part 1 (text/plain, inline)]

Hi Tobias,

thanks for the review. Please see the attached updated patch.

Have you had time to test it?

Petr

[v2-0001-gnu-Add-megapixels.patch (text/x-patch, attachment)]

Message #14 received at 51923 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: phodina <phodina <at> protonmail.com>
Cc: 51923 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add megapixels.
Date: Mon, 29 Nov 2021 15:39:04 +0100

Petr,

phodina 写道：
> thanks for the review. Please see the attached updated patch.

Thanks!

‘a camera application’; ‘JPEG files’; but that can be tweaked by 
the final committer.

> Have you had time to test it?

Can I?  Does it run on real (& x86) computers?  How?

I assumed that it didn't.  That's why I suggested adding ‘for 
mobile devices’.  I don't own any.

λ 
/gnu/store/dn1780g27gcshqfmxilvc96kg0x72x6h-megapixels-1.3.0/bin/megapixels
Renderdoc not found
Could not read device name from device tree
Could not find any config file
λ

(And the ‘--help’ option is broken.  :-/)

Kind regards,

T G-R

Message #17 received at 51923 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: phodina <phodina <at> protonmail.com>, 51923 <at> debbugs.gnu.org
Subject: Re: bug#51923: [PATCH] gnu: Add megapixels.
Date: Fri, 10 Dec 2021 15:24:38 +0100

Hi Tobias,

What do you think are the next steps for this patch?

TIA!

Ludo’.

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

> Petr,
>
> phodina 写道：
>> thanks for the review. Please see the attached updated patch.
>
> Thanks!
>
> ‘a camera application’; ‘JPEG files’; but that can be tweaked by the
> final committer.
>
>> Have you had time to test it?
>
> Can I?  Does it run on real (& x86) computers?  How?
>
> I assumed that it didn't.  That's why I suggested adding ‘for mobile
> devices’.  I don't own any.
>
> λ
> /gnu/store/dn1780g27gcshqfmxilvc96kg0x72x6h-megapixels-1.3.0/bin/megapixels
> Renderdoc not found
> Could not read device name from device tree
> Could not find any config file
> λ
>
> (And the ‘--help’ option is broken.  :-/)
>
> Kind regards,
>
> T G-R

Message #20 received at 51923 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: phodina <phodina <at> protonmail.com>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 51923 <at> debbugs.gnu.org
Subject: Re: bug#51923: [PATCH] gnu: Add megapixels.
Date: Tue, 03 Jan 2023 19:42:34 -0500

Hi Petr,

phodina <phodina <at> protonmail.com> writes:

> Hi Tobias,
>
> thanks for the review. Please see the attached updated patch.
>
> Have you had time to test it?

I wanted to try it out, but it doesn't apply cleanly anymore.  Would you
mind submitting a rebased patch?

-- 
Thanks,
Maxim

Message #23 received at 51923 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: maxim.cournoyer <at> gmail.com
Cc: me <at> tobias.gr, 51923 <at> debbugs.gnu.org
Subject: Re: bug#51923: [PATCH] gnu: Add megapixels.
Date: Wed, 04 Jan 2023 01:25:44 +0000

[Message part 1 (text/plain, inline)]

Hi Maxim,

it's indeed quite old and I'm working on Pine64 devices so I'll try to send an updated patch soon.

----
Petr

-------- Original Message --------
On Jan 4, 2023, 1:42 AM, Maxim Cournoyer wrote:

> Hi Petr,
>
> phodina <phodina <at> protonmail.com> writes:
>
>> Hi Tobias,
>>
>> thanks for the review. Please see the attached updated patch.
>>
>> Have you had time to test it?
>
> I wanted to try it out, but it doesn't apply cleanly anymore. Would you
> mind submitting a rebased patch?
>
> --
> Thanks,
> Maxim

[Message part 2 (text/html, inline)]

Message #28 received at 51923-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: phodina <phodina <at> protonmail.com>
Cc: me <at> tobias.gr, 51923-done <at> debbugs.gnu.org
Subject: Re: [bug#51923] [PATCH] gnu: Add megapixels.
Date: Wed, 23 Apr 2025 17:30:15 +0900

Hi,

phodina <phodina <at> protonmail.com> writes:

> Hi Maxim,
>
> it's indeed quite old and I'm working on Pine64 devices so I'll try to send an updated patch soon.

I've pushed a rather heavily modified revision at the latest version in
commit e042751c321.  It'd be nice if you could let me know if it works
correctly on your device, as I can't test it.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.