From unknown Tue Jun 17 22:09:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#51888 <51888@debbugs.gnu.org> To: bug#51888 <51888@debbugs.gnu.org> Subject: Status: [PATCH 0/1] import: opam: Warn instead of leave when fetching fails. Reply-To: bug#51888 <51888@debbugs.gnu.org> Date: Wed, 18 Jun 2025 05:09:45 +0000 retitle 51888 [PATCH 0/1] import: opam: Warn instead of leave when fetching= fails. reassign 51888 guix-patches submitter 51888 zimoun severity 51888 normal tag 51888 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 16 05:10:58 2021 Received: (at submit) by debbugs.gnu.org; 16 Nov 2021 10:10:58 +0000 Received: from localhost ([127.0.0.1]:57301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmvQY-0003Mr-9C for submit@debbugs.gnu.org; Tue, 16 Nov 2021 05:10:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:38220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmvQX-0003Mj-D9 for submit@debbugs.gnu.org; Tue, 16 Nov 2021 05:10:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmvQX-0001Y7-95 for guix-patches@gnu.org; Tue, 16 Nov 2021 05:10:57 -0500 Received: from [2a00:1450:4864:20::335] (port=52047 helo=mail-wm1-x335.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmvQR-0006oh-QI for guix-patches@gnu.org; Tue, 16 Nov 2021 05:10:56 -0500 Received: by mail-wm1-x335.google.com with SMTP id z200so16392857wmc.1 for ; Tue, 16 Nov 2021 02:10:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fa89j6TUgPDYEkSByPtZj/A4Gya1GurwrtdSNVk+fkE=; b=MkUBz3bVK6BGB69PYkqx2ZfRXDNx1IElhBxaS+Lfxu3SUCWSB+O4DKnj7GTcXmP+Qx cs8ozrk5NaLMs3s/XtUfKwnXcdO3AACP5/97dDDbENRR/GTklEpn5tACe+IQ6xDTKbUb XQjztXITbyjYos3kYifTy3QE+tw30lb5zAwmix/4pXEXAOvZUg3ZyghuxEoORYwmpFqL KTaguoPwqejsJpXk8+lnoE5px8mtSYZNRKKLOoqvWlVhuNMg/U8uLRJ6cYRaNFLknwHf 0G6kYvzPgN3g6VDiVY0qkDzt7CR6GxpbgBqbhCo24N8tdxi48Z8xlNyivB5o2OXz0MS5 fd9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fa89j6TUgPDYEkSByPtZj/A4Gya1GurwrtdSNVk+fkE=; b=QuW6ylfFQlw3dPFhEkqhD7b9RzKNPWkE6yjkVKL0fx52Rv1Qyj01L85gT6ihgPEGUV KPY0S6QoQif3ePJ9VfNtD3k349qVX5NIcijYNCK7oihlbqL7uuqb03sSb6Vpex2ezgql VnLxI70vJWSyDZFtE/YLgjgI6ZKph6a4Kwqq8AdUm6vzd1RNtVora01XPenbmhgijo4i hbc+sGwbVilKbwMQtrCm5a0iI8VKiv6Hy6RJjwKEAT5LzPB6e1wBeqf4myT0729Vw/YS JIaaOM56Z4xZXaX6+CummY2/V4a06hCskdnCvJEn6kmk9+QG4fJ8FQFZOgH/X4/ig62V RB9A== X-Gm-Message-State: AOAM531n8UEitFVWFYcTIwAW85mC8ThbUJchDuglExmd0KwEMjMpG5Yy Rp3eogc3OHfdAbJA2hyUiXjORssthKM= X-Google-Smtp-Source: ABdhPJwwk+V3NNziGlqRNqfHO4VxWCT4KgBsmQsdFA0m6ecqPkRFFQbL1k75CLHNlH8kZ2RqqkTAjQ== X-Received: by 2002:a05:600c:190b:: with SMTP id j11mr6223874wmq.112.1637057449855; Tue, 16 Nov 2021 02:10:49 -0800 (PST) Received: from localhost.localdomain ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id f15sm2410256wmg.30.2021.11.16.02.10.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 02:10:49 -0800 (PST) From: zimoun To: guix-patches@gnu.org Subject: [PATCH 0/1] import: opam: Warn instead of leave when fetching fails. Date: Tue, 16 Nov 2021 11:10:43 +0100 Message-Id: <20211116101043.58471-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Debbugs-CC: julien@lepiller.eu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::335 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x335.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, It is possible to use another OPAM repository when importing, for instance "guix import opam --repo=https://coq.inria.fr/opam/released" -- although Coq packages are generally not built using OCaml or Dune build-system, another story. :-) Or even, a package using OCaml or Dune build system but not included in Opam repositories supported by Guix. However, if this package uses OCaml or Dune build system, then 'refresh' leaves which is annoying. For instance, consider: --8<---------------cut here---------------start------------->8--- $ guix lint -L /tmp/pkgs example /tmp/pkgs/mine.scm:8:2: example@0 : champ de licence invalide /tmp/pkgs/mine.scm:23:14: example@0 : le synopsis ne devrait pas commencer par un nom de paquet /tmp/pkgs/mine.scm:22:15: example@0 : Erreur de certificat TLS : X.509 server certificate for 'exmaple.org' does not match: C=US,ST=California,L=test,O=testexample,OU=testexample,CN=testexp guix lint: erreur : le paquet « example » est introuvable --8<---------------cut here---------------end--------------->8--- The trivial patch instead turns this error to a warning which allows to run all the checkers: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix lint -L /tmp/pkgs example /tmp/pkgs/mine.scm:8:2: example@0: invalid license field /tmp/pkgs/mine.scm:23:14: example@0: synopsis should not start with the package name /tmp/pkgs/mine.scm:22:15: example@0: TLS certificate error: X.509 server certificate for 'exmaple.org' does not match: C=US,ST=California,L=test,O=testexample,OU=testexample,CN=testexp guix lint: warning: opam: package 'example' not found /tmp/pkgs/mine.scm:12:6: warning: failed to fetch Git repository for example /tmp/pkgs/mine.scm:12:6: example@0: updater 'opam' failed to find upstream releases /tmp/pkgs/mine.scm:12:6: example@0: scheduled Software Heritage archival --8<---------------cut here---------------end--------------->8--- here 'archival'. Note that the failure is correctly handled by 'lint' when the early leave skips. Note that it could be better that 'opam-fetch' raises an error in order to be catched by caller and thus make all the UI consistent. However, this requires a revamp of all inporters... Cheers, simon Example of file /tmp/pkgs/mine.scm: --8<---------------cut here---------------start------------->8--- (define-module (mine) #:use-module (guix packages) #:use-module (guix build-system ocaml) #:use-module (guix git-download)) (define-public example (package (name "example") (version "0") (source (origin (method git-fetch) (uri (git-reference (url "https://example.org") (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 (base32 "0m5si9dsv96z92gy4xaqz8mzyz8zp7j1sp542l0wzsp5xgyfpc7i")))) (build-system ocaml-build-system) (home-page "https://exmaple.org") (synopsis "Example") (description "This is an exmaple.") (license #f))) --8<---------------cut here---------------end--------------->8--- zimoun (1): import: opam: Warn instead of leave when fetching fails. guix/import/opam.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 122396075f12b013b6bde56dafb895587b95bc9d -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 16 05:12:46 2021 Received: (at 51888) by debbugs.gnu.org; 16 Nov 2021 10:12:46 +0000 Received: from localhost ([127.0.0.1]:57307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmvSH-0003QR-PT for submit@debbugs.gnu.org; Tue, 16 Nov 2021 05:12:45 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:36647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmvSF-0003QB-Mr for 51888@debbugs.gnu.org; Tue, 16 Nov 2021 05:12:44 -0500 Received: by mail-wr1-f45.google.com with SMTP id s13so36518806wrb.3 for <51888@debbugs.gnu.org>; Tue, 16 Nov 2021 02:12:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ebnu2/IGmN1laGqpS5bFawIC6ZiGRpIw03bYKK7TDLg=; b=a4jQExqu/epzlNPNuitWB8C2fzNtlZqCKQv15z84dPidoD0J848YaVdrOxWV9S2o5h zsjD4MhCJWkMsJ/ZR4h0g8ECb8KgHyCGl3UI6O3sfd0WRYvs8ppaOUco2RYJvYVTl0pe rYFBYeohC4HEHC2DJjSME4sMnlXtJkveL2ziZYx0sPIrc9HORYf/h35lujL0WExCkgoW SEtPMviab+YPmsRGGAhMCp0EEPNbH2FBFdm0JxtWrULN8BnAmKeG9rin32j95trgyRco ptzOmsrhHctpzmb0gTDEclZIYBlsU9RaZR0eQFsE9liYXcEMJmYZrIWBd6QHoIB9o14q UaWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ebnu2/IGmN1laGqpS5bFawIC6ZiGRpIw03bYKK7TDLg=; b=lmrLCFs9QiI4nz/uWSCSfTmA/2Abm/7Ct6iRjT7Xpo6SoC8ixRXzDuAmQcRenEJpC8 W0xrLzBa1O94GfQH22rnBiQnSZahi/5w7uOsGITPXB/6dyj9ZY83IF9QUj4YTES6N7bz dT6s/MtjcqBlcBjSGtVkXSIf5JGeVIGEubpimckiYBHTesbq61cVyQ17MnhCaHpmS754 Thf3Cmqp6gRzG2QnqAfB09UDnn5E/a3t2rWI1BmdZUu4za9ZV5rCl0duaPQdlDC/z5qc y9K2hO790vTxCB9tY+uvfgTXIPiawssPkG1UwGzDoW+8PTiCnJ/SoPSgiosrJ7GSjBRG REUQ== X-Gm-Message-State: AOAM533bgSNAQnuKk5rg+SGTKy3hly4/j8te8aCB1Rtoz16P/ohbctL8 fEYXafqYW7oWJ1zMuwzEnEEsfPy6mJQ= X-Google-Smtp-Source: ABdhPJxypyD9QETYrAocM2s4ilb5ZEbZZrlXG00EO0FtHazQFqXMJbu76s2qIij69qfL7IC18YtwiQ== X-Received: by 2002:a05:6000:1869:: with SMTP id d9mr7732515wri.416.1637057557896; Tue, 16 Nov 2021 02:12:37 -0800 (PST) Received: from localhost.localdomain ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id m14sm23232930wrp.28.2021.11.16.02.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 02:12:37 -0800 (PST) From: zimoun To: 51888@debbugs.gnu.org Subject: [PATCH 1/1] import: opam: Warn instead of leave when fetching fails. Date: Tue, 16 Nov 2021 11:12:34 +0100 Message-Id: <20211116101234.58528-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51888 Cc: julien@lepiller.eu, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/import/opam.scm (opam-featch): Warn instead of leave when fetching fails. --- guix/import/opam.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/opam.scm b/guix/import/opam.scm index fe13d29f03..0804526e3a 100644 --- a/guix/import/opam.scm +++ b/guix/import/opam.scm @@ -318,7 +318,7 @@ (define* (opam-fetch name #:optional (repositories-specs '("opam"))) (_ others))) #f (filter-map get-opam-repository repositories-specs)) - (leave (G_ "package '~a' not found~%") name))) + (warning (G_ "opam: package '~a' not found~%") name))) (define* (opam->guix-package name #:key (repo '()) version) "Import OPAM package NAME from REPOSITORIES (a list of names, URLs or local -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 16 08:03:03 2021 Received: (at 51888) by debbugs.gnu.org; 16 Nov 2021 13:03:03 +0000 Received: from localhost ([127.0.0.1]:57461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmy75-0004jE-Ev for submit@debbugs.gnu.org; Tue, 16 Nov 2021 08:03:03 -0500 Received: from lepiller.eu ([89.234.186.109]:38982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmy73-0004id-4P for 51888@debbugs.gnu.org; Tue, 16 Nov 2021 08:03:02 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 5bdf5a80; Tue, 16 Nov 2021 13:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=B84jMFBNYC+D waLrPG6JCm1AinuhKly/MzoxvDWJtwk=; b=Xk2dUgvKpU/ahgnue2L4I8kfoZlA 8G9lXkz5yzDpv4+hoZBzcL6EmhF7kCUj9Z8JwWU5WQr+sR7rc28qSck4o4mNWM3t yjZIHDzAP4zyKzR9JU5t+ilApyx47UrjtbML1yq5ljfCYSMLDB+N+VtQhkp5D6uX qkGKdjzWidiA7d7qMhWrMX0KTg54fMw4/75AWq3kNAfYmSIVTiq7LqDjS05XqAfo jk5r6U+Lts0S8n/MaupuypdouDBS064qwMVTvZPyJavgVqLoJbirs7VYyDG0QlZ3 JYe52Lf9Cq4xqa7bedcOed2Ti9ZgR72d/p7U3TBy9noz6DxXTkUYwoRLGQ== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 1dc7dfd4 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 16 Nov 2021 13:02:56 +0000 (UTC) Date: Tue, 16 Nov 2021 14:02:48 +0100 From: Julien Lepiller To: zimoun Subject: Re: [bug#51888] [PATCH 0/1] import: opam: Warn instead of leave when fetching fails. Message-ID: <20211116140248.1dcf61e5@tachikoma.lepiller.eu> In-Reply-To: <20211116101043.58471-1-zimon.toutoune@gmail.com> References: <20211116101043.58471-1-zimon.toutoune@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.24; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51888 Cc: 51888@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le Tue, 16 Nov 2021 11:10:43 +0100, zimoun a =C3=A9crit : > Hi, >=20 > It is possible to use another OPAM repository when importing, for > instance "guix import opam --repo=3Dhttps://coq.inria.fr/opam/released" > -- although Coq packages are generally not built using OCaml or Dune > build-system, another story. :-) Or even, a package using OCaml or > Dune build system but not included in Opam repositories supported by > Guix. >=20 Hi, I already had a patch for that, which is a bit more complex, at https://issues.guix.gnu.org/51091. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 16 10:33:46 2021 Received: (at 51888) by debbugs.gnu.org; 16 Nov 2021 15:33:46 +0000 Received: from localhost ([127.0.0.1]:58928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn0Sw-0003Z1-Fe for submit@debbugs.gnu.org; Tue, 16 Nov 2021 10:33:46 -0500 Received: from mail-il1-f174.google.com ([209.85.166.174]:40794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn0Su-0003Yb-OH for 51888@debbugs.gnu.org; Tue, 16 Nov 2021 10:33:45 -0500 Received: by mail-il1-f174.google.com with SMTP id k1so20807339ilo.7 for <51888@debbugs.gnu.org>; Tue, 16 Nov 2021 07:33:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mBqPgns7wW1b8oZWp0e+VWAtI3q5f1jz+49zQENG5Ag=; b=dhVK0flcyMebTnEs6TdBsl6COPLHgkLj/i7bA692nKnf15ka+S/mtVCn/+w6wa/sz3 bFLIVnGAxbDkv+kxnRBDMxeBuj1tQfTVNyxgdJ0o0MhLb5E/9BeV/2B2Oio8z3zjP8pc bHb0RU8CP/fXgYcqiZsfyn/RwT5H5p0kCK/fI9xWPNAAxL+2BYnh7WpM9sPn83oym1FM poi9yUH04o2JMFkPjDN76xX+df6j00X+PvJ7sWp7ELvqkQG7rK53tPzN/PQAoy+iI6OA BcGuCSMSzN1vtG9+la9vF1xDvVN2egvpKKXNOunyhzyN52lzWTuAP7kf7dqnt1iHwKkt ldow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mBqPgns7wW1b8oZWp0e+VWAtI3q5f1jz+49zQENG5Ag=; b=hQYHIv6QfrgJ54xSRfwOBthVg9hgBQVz2FujEjA4LpXfxrFmA7lCzrINgQYZfqmDd3 CF0sztVhP6RtcmQptM2G2Adt4bFPEPr3gHkQb+ajFfFAfzh3r3C8woMYw0Ru0QmUkYIg c7NxPfftwx9G+GdCFao1D3VSnaugVCPDIrKmU7j0eF0r3pf7XHBVgJnFTPlFjIxcfmO8 1o1eF8wE7rBMzXfiPWZy6sfqdu/bbTa/lYONXuAKoDzQVCnGEVPi9I6GYQTLppj8kl3K JJGHvnC01UVQGMjNvgQxkp8wYrMyDWv0FAXAFtTvP1U71V4d8mbKrYQRsqcpMMss6kQs RDhQ== X-Gm-Message-State: AOAM531KnooYbAyUo0ue59BEtyTdjIpxZ/2+zgmPe2d1dv4q80jCCgm1 +9WTnk9+6uXs4d1GJfJEbMeD/R2bWVFD6v7tEwGtGS8zRkU= X-Google-Smtp-Source: ABdhPJwN/DSgKkK0nRhc8fbDGrdQkcyIZTTVMQUODVHXrrBGx2aDOS3HBNmuIw+trsExDc23NK7vBjPF87Z1XTwiAQY= X-Received: by 2002:a05:6e02:1210:: with SMTP id a16mr5429002ilq.75.1637076819050; Tue, 16 Nov 2021 07:33:39 -0800 (PST) MIME-Version: 1.0 References: <20211116101043.58471-1-zimon.toutoune@gmail.com> <20211116140248.1dcf61e5@tachikoma.lepiller.eu> In-Reply-To: <20211116140248.1dcf61e5@tachikoma.lepiller.eu> From: zimoun Date: Tue, 16 Nov 2021 16:33:28 +0100 Message-ID: Subject: Re: [bug#51888] [PATCH 0/1] import: opam: Warn instead of leave when fetching fails. To: Julien Lepiller Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51888 Cc: 51888@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Tue, 16 Nov 2021 at 14:03, Julien Lepiller wrote: > I already had a patch for that, which is a bit more complex, at Sorry, I missed it. > https://issues.guix.gnu.org/51091. WDYT? Your patch LGTM. I am not convinced that all the complexity is worth; compared to the proposed trivial change. ;-) >From my opinion, the way is a common error for the all importers and raise it; all the catch happening in 'guix/scripts/'. That's another story. :-) One minor comment, in 'latest-release' I would write "opam: package '~a' not found~%" otherwise the message "guix lint: warning: package 'example' not found" looks odd (at least to me :-)). Feel free to close this issue and the other once you pushed a fix. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 19 06:59:16 2021 Received: (at 51888) by debbugs.gnu.org; 19 Nov 2021 11:59:16 +0000 Received: from localhost ([127.0.0.1]:38253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo2Y0-0006oY-Iu for submit@debbugs.gnu.org; Fri, 19 Nov 2021 06:59:16 -0500 Received: from lepiller.eu ([89.234.186.109]:39274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo2Xy-0006oP-Ct for 51888@debbugs.gnu.org; Fri, 19 Nov 2021 06:59:15 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 9726848b; Fri, 19 Nov 2021 11:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=OkkMrG6a5Wh0 AxKCuJLoyyZlq116PZw+n5RgW2YIobY=; b=GEf7iOlG4Fry8Dnc+u+KBKtd8mbQ n9oqhKRHN5WefPaqnPdASeDMBGswqV5hUu2WWAKu6X/BFSjgvhTbfS9ClPbfLmdA QkiYQG+zPgouNQKeSnCbmWg+X8+3anzT2SKaguKbWYo6uR93jAr482grggAq+Y2C oV86ZOzC2mdTpR+KvjPt2qdVkoCJQm39JTpFqDa1d+1Ur7NP0td4x25OwfqhJmEz 6LKRJ3qsH32mekEqGJJRDNQ97W+s3IaDNVQbCreLUuEpw+MwOW/LxUX3xzqLk37e v3TxtU3GhyMn2xwtaa2alstCAoj8zLZzvQoF2Imu4YatLwZDD2BLSq3Zmw== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 4fdd7ce5 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 19 Nov 2021 11:59:12 +0000 (UTC) Date: Fri, 19 Nov 2021 12:59:00 +0100 From: Julien Lepiller To: zimoun Subject: Re: [bug#51888] [PATCH 0/1] import: opam: Warn instead of leave when fetching fails. Message-ID: <20211119125900.621b1975@tachikoma.lepiller.eu> In-Reply-To: <20211116101043.58471-1-zimon.toutoune@gmail.com> References: <20211116101043.58471-1-zimon.toutoune@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.24; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51888 Cc: 51888@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pushed to master as b5d51bb19e790baee9b16a3325397ec92d8e7625, thanks! From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 19 07:00:14 2021 Received: (at 51888-done) by debbugs.gnu.org; 19 Nov 2021 12:00:14 +0000 Received: from localhost ([127.0.0.1]:38257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo2Yv-00074i-Qx for submit@debbugs.gnu.org; Fri, 19 Nov 2021 07:00:14 -0500 Received: from lepiller.eu ([89.234.186.109]:39282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo2Yu-00072H-AE for 51888-done@debbugs.gnu.org; Fri, 19 Nov 2021 07:00:12 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 476d64f4 for <51888-done@debbugs.gnu.org>; Fri, 19 Nov 2021 12:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=G3tAZSUonCVh YWhFoPlP/c4WjJuZYqL5OumIwM5z4Q0=; b=X1wdEWPRqWNIdi++ya1+4jcSlR3R LK1sOexdS5a17GqmuuLfzZd1HA6EZ4x5GrMBnnuONkTwa8JZA9CA3TuhIrRnNvE2 QWjQnASlhETG89jnHZsUvGNIOlYb684muZ48ono8yPH9HqLfaq0oC6K+yh2B8WSw rlQAB9lF7tIj1f51JfEyVrBbtCGTcEL5vFe2sFyJd8EvLfQ+uIWMC6D0qtJ+jR/8 xIPKIveapC00SaSOyZSsQoTf+5bbqCp1QfBtcW7RD/VOQYCAA5h49BXP71py8Uc6 KuaXqthVSZq30l7Qqfq/tm9tgKiQuAy2i2H88cP32B3s9k5afnNDJCFvnA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 32d21496 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for <51888-done@debbugs.gnu.org>; Fri, 19 Nov 2021 12:00:11 +0000 (UTC) Date: Fri, 19 Nov 2021 13:00:05 +0100 From: Julien Lepiller Subject: Re: [bug#51888] [PATCH 0/1] import: opam: Warn instead of leave when fetching fails. Message-ID: <20211119130005.25118216@tachikoma.lepiller.eu> In-Reply-To: <20211116101043.58471-1-zimon.toutoune@gmail.com> References: <20211116101043.58471-1-zimon.toutoune@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.24; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Forgot to close. Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 1.2 MISSING_HEADERS Missing To: header -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-Debbugs-Envelope-To: 51888-done Cc: 51888-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Forgot to close. From unknown Tue Jun 17 22:09:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 17 Dec 2021 12:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator