GNU bug report logs - #51838
[PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp.

Previous Next

Full log

Message #344 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: Philip McGrath <philip <at> philipmcgrath.com>
Cc: 51838 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#51838] [PATCH v3 06/43] guix: node-build-system: Add
 #:absent-dependencies argument.
Date: Sun, 12 Dec 2021 15:31:10 +0000

[Message part 1 (text/plain, inline)]

Philip McGrath <philip <at> philipmcgrath.com> writes:

> * guix/build-system/node.scm (lower, node-build): Add optional
> argument #:absent-dependencies with default of ''(). Pass it on
> to the build-side code.
> * guix/build/node-build-system.scm (patch-dependencies): Respect
> the #:absent-dependencies argument, removing specified npm
> packages from the "dependencies" or "devDependencies" tables
> in "package.json".

Nice, I like this new option, I've needed this functionnality before as
well. For instance I've seen dependencies like "prebuild-install" [0]
for which the whole purepose is to download binaries instead of building
them... in Guix we always want to remove those dependencies.

I'd suggest to add documentation for this new option in the manual, but
that could be done as a follow-up.

[0]: https://www.npmjs.com/package/prebuild-install

Thanks,
Pierre

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.