GNU bug report logs -
#51838
[PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp.
Previous Next
Reported by: Philip McGrath <philip <at> philipmcgrath.com>
Date: Sun, 14 Nov 2021 12:43:01 UTC
Severity: normal
Tags: patch
Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Your bug report
#51838: [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp.
which was filed against the guix-patches package, has been closed.
The explanation is attached below, along with your original report.
If you require more details, please reply to 51838 <at> debbugs.gnu.org.
--
51838: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51838
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
Am Samstag, dem 08.01.2022 um 10:33 -0500 schrieb Philip McGrath:
> My intention was to acknowledge that the basic approach of
> 'delete-dependencies' was your idea. But, again, whatever you like!
That hardly counts as intellectual property in my opinion, it's not
like I revolutionized anything in the scope of Guix.
The new node-build-system is live now, so you can rewrite JSON and
delete dependencies as much as you want on master. Please allow for
other users to actually make use of it before writing up your next
proposal. We'll only be able to see our shortcomings by having a large
number of people try it in the real world.
Thanks and good night :)
[Message part 3 (message/rfc822, inline)]
This patch series adds support to `node-build-system` for building native
add-ons using `node-gyp`. To confirm that the changes to the build system
work, the patch series also adds two packages (plus a few dependencies)
representing two major ways of writing Node.js native add-ons:
1. `node-openzwave-shared` uses `node-nan`: “Native Abstractions for Node.js”.
2. `node-sqlite3` uses the Node-API via `node-addon-api`.
The patches are adapted from part of a series by Pierre Langlois
at <https://issues.guix.gnu.org/49946>: you can find discussion of an earlier
version of this spun-off series from <https://issues.guix.gnu.org/49946#71>
to <https://issues.guix.gnu.org/49946#83>.
They are also available in a Git repository
at <https://gitlab.com/philip1/guix-patches/-/tree/wip-node-npm-gyp-hist-9>.
In the earlier discussion, Pierre and I both thought it was quite confusing
that the Scheme variable `node` refers to the bootstrap Node.js, while
`node-lts` refers to the newer Node.js that a package specification of
`"node"` would resolve to. My analysis is
at <https://issues.guix.gnu.org/49946#75> (tl;dr it seems like an unintentional
mistake), and Pierre suggested a solution
in <https://issues.guix.gnu.org/49946#81>. I haven't taken that on in this patch
series, but I do think its worth considering.
Philip McGrath (11):
gnu: node: Avoid duplicating build phases.
gnu: node: Update to 10.24.1 for bootstrapping.
guix: node-build-system: Support compiling add-ons with node-gyp.
gnu: Add node-inherits.
gnu: Add node-safe-buffer.
gnu: Add node-string-decoder.
gnu: Add node-readable-stream.
gnu: Add node-nan.
gnu: Add node-openzwave-shared.
gnu: Add node-addon-api.
gnu: Add node-sqlite3.
gnu/packages/node-xyz.scm | 335 +++++++++++++++++++++++++++++++
gnu/packages/node.scm | 143 +++++--------
gnu/packages/zwave.scm | 55 +++++
guix/build-system/node.scm | 11 +-
guix/build/node-build-system.scm | 23 +++
5 files changed, 473 insertions(+), 94 deletions(-)
--
2.32.0
This bug report was last modified 3 years and 195 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.