GNU bug report logs - #51809
29.0.50; [PATCH] Support for outline default state in Diff buffers

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Matthias Meulien <orontee <at> gmail.com>
Cc: 51809 <at> debbugs.gnu.org
Subject: bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers
Date: Tue, 11 Jan 2022 19:46:05 +0200

>> (...)  Also xref works nicely, although I don't know why it requires
>> `outline-apply-default-state' after enabling `outline-minor-mode':
>
> It's a mistake to rely on `hack-local-variables-hook' to call
> `outline-apply-default-state' when Outline minor mode is enabled since
> `hack-local-variables-hook' is run after processing a file's local
> variable specs.

There is also such a case possible where the file begins with a prop-line:

  # -*- mode: outline-minor; -*-

and ends with the Local Variables section, e.g.:

  # outline-default-state: 2

`hack-local-variables-hook' can handle such case in `outline-minor-mode'.

> I'll send an updated patch after some time using this.

Now you can take in use a new hook added in bug#52855 that allows
applying the default state after vc-diff finishes:

  (add-hook 'vc-diff-finish-functions 'outline-apply-default-state)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.