GNU bug report logs - #51809
29.0.50; [PATCH] Support for outline default state in Diff buffers

Previous Next

Full log

Message #141 received at control <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Matthias Meulien <orontee <at> gmail.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 51809 <at> debbugs.gnu.org
Subject: Re: bug#51809: 29.0.50; [PATCH] Support for outline default state
 in Diff buffers
Date: Wed, 16 Feb 2022 21:20:33 +0200

close 51809 29.0.50
thanks

>> My first impression is that setting `outline-level' to
>> `diff--outline-level' inconditionnaly should work but since I don't
>> understand why `diff-outline-regex' hasn't been defined in terms of
>> `diff-file-header-re' and `diff-hunk-header-re' I guess I am missing
>> some subtleties.
>>
>> (Note that there's another minor bug when `diff-buffer-type` isn't equal
>> to 'git: `diff--font-lock-prettify` should be a no-op since the regexp
>> written there match only Git generated diffs, confirmed by the FIXME
>> string "This has only been tested with Git's diff output." written in
>> the implementation).
>
> Here's the corresponding patch:

Thanks for the quick fix!  I confirm that it works even when
`diff-buffer-type' is nil.  So now your patch is pushed to master,
and this request is closed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.