From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 12 21:51:56 2021 Received: (at submit) by debbugs.gnu.org; 13 Nov 2021 02:51:56 +0000 Received: from localhost ([127.0.0.1]:46317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlj91-0006YG-RX for submit@debbugs.gnu.org; Fri, 12 Nov 2021 21:51:56 -0500 Received: from lists.gnu.org ([209.51.188.17]:52666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlj8w-0006Y3-Px for submit@debbugs.gnu.org; Fri, 12 Nov 2021 21:51:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlj8w-0006uP-CY for bug-guix@gnu.org; Fri, 12 Nov 2021 21:51:50 -0500 Received: from [2607:f8b0:4864:20::82a] (port=36551 helo=mail-qt1-x82a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlj8u-0006gt-TB for bug-guix@gnu.org; Fri, 12 Nov 2021 21:51:50 -0500 Received: by mail-qt1-x82a.google.com with SMTP id t11so10323370qtw.3 for ; Fri, 12 Nov 2021 18:51:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=J+ky7ibqiF1xDJvr5GY3i3AvBqw87K1jjvFD6OqUD/Y=; b=XTjtQa2pLa85uIQ5blsZVRFCEvXweSus4C8uzuMpvh+DowOPQvdhK8nPZpsWMsXnPd JDmsa6P7XskJXYzGtYGCde8Z5GI3qkRFKo/9Va0T0Zp3T8H9oVGSpw5GjwKw7R/bCqgm yN9bQMUSRK75DHw+AkR5ShR8l8VtMD0sDxG2NfCgHEdCz4dHmbzNww6Zk/D36KrH1B6a UK10C++YEEk1y00/VFpWhV+vJko0jJz6u3zZMN7OUNwshGPFM4fK7bIju5nj4x4mUpdu NDqOiJ/AH3Gd/5bVVd+SJU/yWZMzl2BzJImqhdphSYzbrtgSyFbS694OqmuZ0unlFCBU S0Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=J+ky7ibqiF1xDJvr5GY3i3AvBqw87K1jjvFD6OqUD/Y=; b=gcLr35IvoJBlLwdW8SXR8nx0+/pkA2/vgiHgjKlbonfZMLF/0Ov5ZTfedIQEeQu+Uj avezy5bG0OgEVu5OT7tsy7Dk35L7JkqdUWoKNSxvvM7NMpetQsrhI2H3k0kOqgW7zjdM LhWQRyJCRkjOYrvw8EsaIO2NNK5WYjCkkNz9lhF+t+XiJCr8HN4Mx9UDTBu8uzxqHcsw fdzVYF0aPQ9o8CGnxpxj3RK/L618GomOAU3ehVHKWRWoDDcvOHDezGChX0Xu41BuY8hu A+D17zGDXoFa6wMfDMXMYpqv8IhkGsLPzmY0oWsgQyObLlq/2rcq4A24ghrWMcyQIvSz tW7g== X-Gm-Message-State: AOAM5305k6F1N2t+cMPe60VA68FgTp+PiHLDLXJZf9898U+P8H6XrxaT 3y0gPq6EoMSWGQPVU8WBsUkotDczdSynnEPk X-Google-Smtp-Source: ABdhPJz+qwmQ2Z2uZOfPYlDDzt5gbw44csJ6XkyD5e87MLpnplQ9windOJ/8ILpgwtos6z5wy/lbFQ== X-Received: by 2002:ac8:5b83:: with SMTP id a3mr13354718qta.62.1636771907140; Fri, 12 Nov 2021 18:51:47 -0800 (PST) Received: from hurd (dsl-10-149-119.b2b2c.ca. [72.10.149.119]) by smtp.gmail.com with ESMTPSA id t35sm4698077qtc.83.2021.11.12.18.51.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 18:51:46 -0800 (PST) From: Maxim Cournoyer To: bug-guix Subject: No warning when attempting to build unsupported system with --system Date: Fri, 12 Nov 2021 21:51:45 -0500 Message-ID: <87o86oix8e.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::82a (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::82a; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x82a.google.com X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) BAYES_20=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello Guix, I was surprised that: --8<---------------cut here---------------start------------->8--- guix build fpc --system=armhf-linux --8<---------------cut here---------------end--------------->8--- would send me in a dead end without any word of caution, given that armhf-linux is *not* listed in the supported-systems field. We should at least warn near the beginning of the build, and remind of that fact at the end of the build in case of failure. Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 17 10:44:33 2022 Received: (at 51801) by debbugs.gnu.org; 17 Feb 2022 15:44:33 +0000 Received: from localhost ([127.0.0.1]:52504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKixE-0001yz-Gr for submit@debbugs.gnu.org; Thu, 17 Feb 2022 10:44:33 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:37110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKixA-0001yh-CL for 51801@debbugs.gnu.org; Thu, 17 Feb 2022 10:44:23 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 8701DB6D; Thu, 17 Feb 2022 16:44:13 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rs8YsaFnWcfY; Thu, 17 Feb 2022 16:44:11 +0100 (CET) Received: from ribbon (unknown [193.50.110.222]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 91ED5112; Thu, 17 Feb 2022 16:44:10 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#51801: No warning when attempting to build unsupported system with --system References: <87o86oix8e.fsf@gmail.com> Date: Thu, 17 Feb 2022 16:44:09 +0100 In-Reply-To: <87o86oix8e.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 12 Nov 2021 21:51:45 -0500") Message-ID: <874k4xmrau.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: 8701DB6D X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-patch]; DBL_PROHIBIT(0.00)[2.0.0.2:email,2.0.0.0:email]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:+,4:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 51801 Cc: 51801@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! Maxim Cournoyer skribis: > I was surprised that: > > guix build fpc --system=3Darmhf-linux > > would send me in a dead end without any word of caution, given that > armhf-linux is *not* listed in the supported-systems field. > > We should at least warn near the beginning of the build, and remind of > that fact at the end of the build in case of failure. I came up with the patches below. The first part forbids unsupported packages altogether in user-facing commands: =E2=80=98guix install=E2=80=99, =E2=80=98guix shell=E2=80=99, etc= . Until now, they=E2=80=99d just start building things that were bound to fail. The second part adds a mere warning for =E2=80=98guix build=E2=80=99 (it do= es not repeat it at the end, though). Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-packages-package-transitive-supported-systems-ignore.patch Content-Transfer-Encoding: quoted-printable >From 1b02db917f6b24b7c41dc20e2833fff452d9b900 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Ludovic=3D20Court=3DC3=3DA8s?=3D Date: Thu, 17 Feb 2022 16:04:15 +0100 Subject: [PATCH 1/3] packages: 'package-transitive-supported-systems' ignor= es '%current-target-system'. Previously 'package-transitive-supported-systems' would enter an infinite loop over the cross-compilation tool chain if %CURRENT-TARGET-SYSTEM was set. * guix/packages.scm (package-transitive-supported-systems)[supported-system= s-procedure]: Pass explicit SYSTEM and TARGET parameters. * tests/packages.scm ("supported-package? vs. %current-target-system"): New test. --- guix/packages.scm | 4 ++-- tests/packages.scm | 10 ++++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/guix/packages.scm b/guix/packages.scm index 9d5b23eb8a..3f0262602d 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright =C2=A9 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020,= 2021 Ludovic Court=C3=A8s +;;; Copyright =C2=A9 2012-2022 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2014, 2015, 2017, 2018, 2019 Mark H Weaver ;;; Copyright =C2=A9 2015 Eric Bavier ;;; Copyright =C2=A9 2016 Alex Kost @@ -1235,7 +1235,7 @@ (define supported-systems (_ systems))) (package-supported-systems package) - (bag-direct-inputs (package->bag package)))))) + (bag-direct-inputs (package->bag package system #f)))))) =20 supported-systems) =20 diff --git a/tests/packages.scm b/tests/packages.scm index 55b1c4064f..02bdba5f98 100644 --- a/tests/packages.scm +++ b/tests/packages.scm @@ -508,6 +508,16 @@ (define read-at (and (supported-package? p "x86_64-linux") (supported-package? p "armhf-linux")))) =20 +(test-assert "supported-package? vs. %current-target-system" + ;; The %CURRENT-TARGET-SYSTEM value should have no influence. + (parameterize ((%current-target-system "arm-linux-gnueabihf")) + (let ((p (dummy-package "foo" + (build-system gnu-build-system) + (supported-systems '("x86_64-linux" "armhf-linux"))))) + (and (supported-package? p "x86_64-linux") + (not (supported-package? p "i686-linux")) + (supported-package? p "armhf-linux"))))) + (test-skip (if (not %store) 8 0)) =20 (test-assert "package-source-derivation, file" base-commit: 6481dbda5100e9b0ff9c5221280d2c0cadd663b7 --=20 2.34.0 --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0002-profiles-profile-derivation-rejects-unsupported-pack.patch Content-Transfer-Encoding: quoted-printable >From d492eab963522f2dcea7bad1016fe6b718ddffed Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Ludovic=3D20Court=3DC3=3DA8s?=3D Date: Thu, 17 Feb 2022 16:06:39 +0100 Subject: [PATCH 2/3] profiles: 'profile-derivation' rejects unsupported packages. Previously user-facing commands would happily start building packages even if they do not support that system. With this change, all the user-facing commands reject unsupported packages without going further. * guix/profiles.scm (profile-derivation): Add #:allow-unsupported-packages?. Define 'check-supported-packages' and honor #:allow-unsupported-packages?. * tests/guix-pack.sh, tests/guix-package.sh, tests/guix-shell.sh: Ensure that unsupported packages are rejected. --- guix/profiles.scm | 22 ++++++++++++++++++++-- tests/guix-pack.sh | 5 ++++- tests/guix-package.sh | 13 ++++++++++++- tests/guix-shell.sh | 5 ++++- 4 files changed, 40 insertions(+), 5 deletions(-) diff --git a/guix/profiles.scm b/guix/profiles.scm index 9715a769aa..bad9b95519 100644 --- a/guix/profiles.scm +++ b/guix/profiles.scm @@ -33,7 +33,7 @@ (define-module (guix profiles) #:use-module ((guix utils) #:hide (package-name->name+version)) #:use-module ((guix build utils) #:select (package-name->name+version mkdir-p)) - #:use-module ((guix diagnostics) #:select (&fix-hint)) + #:use-module ((guix diagnostics) #:select (&fix-hint formatted-message)) #:use-module (guix i18n) #:use-module (guix records) #:use-module (guix packages) @@ -1860,6 +1860,7 @@ (define* (profile-derivation manifest (name "profile") (hooks %default-profile-hooks) (locales? #t) + (allow-unsupported-packages? #f) (allow-collisions? #f) (relative-symlinks? #f) system target) @@ -1868,7 +1869,9 @@ (define* (profile-derivation manifest the monadic procedures listed in HOOKS--such as an Info 'dir' file, etc. Unless ALLOW-COLLISIONS? is true, a '&profile-collision-error' is raised if entries in MANIFEST collide (for instance if there are two same-name packa= ges -with a different version number.) +with a different version number.) Unless ALLOW-UNSUPPORTED-PACKAGES? is t= rue +or TARGET is set, raise an error if MANIFEST contains a package that does = not +support SYSTEM. =20 When LOCALES? is true, the build is performed under a UTF-8 locale; this a= dds a dependency on the 'glibc-utf8-locales' package. @@ -1878,12 +1881,27 @@ (define* (profile-derivation manifest =20 When TARGET is true, it must be a GNU triplet, and the packages in MANIFEST are cross-built for TARGET." + (define (check-supported-packages system) + ;; Raise an error if a package in MANIFEST does not support SYSTEM. + (map-manifest-entries + (lambda (entry) + + (match (manifest-entry-item entry) + ((? package? package) + (unless (supported-package? package system) + (raise (formatted-message (G_ "package ~a does not support ~a") + (package-full-name package) system))= )) + (_ #t))) + manifest)) + (mlet* %store-monad ((system (if system (return system) (current-system))) (target (if target (return target) (current-target-system))) + (ok? -> (or allow-unsupported-packages? target + (check-supported-packages system))) (ok? (if allow-collisions? (return #t) (check-for-collisions manifest system diff --git a/tests/guix-pack.sh b/tests/guix-pack.sh index 0339221ac2..1356a74083 100644 --- a/tests/guix-pack.sh +++ b/tests/guix-pack.sh @@ -1,6 +1,6 @@ # GNU Guix --- Functional package management for GNU # Copyright =C2=A9 2018 Chris Marusich -# Copyright =C2=A9 2018, 2019, 2020 Ludovic Court=C3=A8s +# Copyright =C2=A9 2018, 2019, 2020, 2022 Ludovic Court=C3=A8s # # This file is part of GNU Guix. # @@ -36,6 +36,9 @@ export GUIX_BUILD_OPTIONS test_directory=3D"`mktemp -d`" trap 'chmod -Rf +w "$test_directory"; rm -rf "$test_directory"' EXIT =20 +# Reject unsuppoted packages. +! guix pack intelmetool -s armhf-linux -n + # Compute the derivation of a pack. drv=3D"`guix pack coreutils -d --no-grafts`" guix gc -R "$drv" | grep "`guix build coreutils -d --no-grafts`" diff --git a/tests/guix-package.sh b/tests/guix-package.sh index 92ab565c5b..d1b383d2ad 100644 --- a/tests/guix-package.sh +++ b/tests/guix-package.sh @@ -1,5 +1,5 @@ # GNU Guix --- Functional package management for GNU -# Copyright =C2=A9 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2= 021 Ludovic Court=C3=A8s +# Copyright =C2=A9 2012-2022 Ludovic Court=C3=A8s # Copyright =C2=A9 2013 Nikita Karetnikov # # This file is part of GNU Guix. @@ -59,6 +59,17 @@ test -L "$profile" && test -L "$profile-1-link" ! test -f "$profile-2-link" test -f "$profile/bin/guile" =20 +# Unsupported packages cannot be installed. +! guix package -e '(begin (use-modules (guix) (gnu packages base)) (packag= e (inherit sed) (supported-systems (list))))' -n +case $(uname -m) in + x86_64|i[3456]86) + ! guix package -i novena-eeprom -n + break;; + *) + ! guix package -i intelmetool -n + break;; +esac + # Collisions are properly flagged (in this case, 'g-wrap' propagates # guile@2.2, which conflicts with guile@2.0.) ! guix package --bootstrap -n -p "$profile" -i g-wrap guile@2.0 diff --git a/tests/guix-shell.sh b/tests/guix-shell.sh index 23ff1c5bcf..6340f90574 100644 --- a/tests/guix-shell.sh +++ b/tests/guix-shell.sh @@ -1,5 +1,5 @@ # GNU Guix --- Functional package management for GNU -# Copyright =C2=A9 2021 Ludovic Court=C3=A8s +# Copyright =C2=A9 2021-2022 Ludovic Court=C3=A8s # # This file is part of GNU Guix. # @@ -35,6 +35,9 @@ guix shell --bootstrap --pure guile-bootstrap -- guile --= version # '--ad-hoc' is a thing of the past. ! guix shell --ad-hoc guile-bootstrap =20 +# Rejecting unsupported packages. +! guix shell -s armhf-linux intelmetool -n + # Ignoring unauthorized files. cat > "$tmpdir/guix.scm" <From d4368c8c307f61b5346df540aaf329b8495fe32c Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Ludovic=3D20Court=3DC3=3DA8s?=3D Date: Thu, 17 Feb 2022 16:23:42 +0100 Subject: [PATCH 3/3] guix build: Warn when attempting to build an unsupport= ed package. Fixes . Reported by Maxim Cournoyer . * guix/scripts/build.scm (options->derivations)[warn-if-unsupported]: New procedure. [compute-derivation]: Use it. * tests/guix-build.sh: Add test. --- guix/scripts/build.scm | 22 ++++++++++++++++++++-- tests/guix-build.sh | 12 +++++++++++- 2 files changed, 31 insertions(+), 3 deletions(-) diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm index 97e2f5a167..d9cdb6e5e0 100644 --- a/guix/scripts/build.scm +++ b/guix/scripts/build.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright =C2=A9 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020,= 2021, 2021 Ludovic Court=C3=A8s +;;; Copyright =C2=A9 2012-2022 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2013 Mark H Weaver ;;; Copyright =C2=A9 2020 Marius Bakke ;;; Copyright =C2=A9 2020 Ricardo Wurmus @@ -559,11 +559,29 @@ (define systems (define things-to-build (map transform (options->things-to-build opts))) =20 + (define warn-if-unsupported + (let ((target (assoc-ref opts 'target))) + (if target + (lambda (package system) + ;; We cannot tell whether PACKAGE supports TARGET. + package) + (lambda (package system) + (match package + ((? package? package) + (unless (supported-package? package system) + (warning (package-location package) + (G_ "package ~a does not support ~a~%") + (package-full-name package) system)) + package) + (x x)))))) + (define (compute-derivation obj system) ;; Compute the derivation of OBJ for SYSTEM. (match obj ((? package? p) - (let ((p (or (and graft? (package-replacement p)) p))) + (let ((p (warn-if-unsupported + (or (and graft? (package-replacement p)) p) + system))) (match src (#f (list (package->derivation store p system))) diff --git a/tests/guix-build.sh b/tests/guix-build.sh index 86e41e2927..9cbf8fe26d 100644 --- a/tests/guix-build.sh +++ b/tests/guix-build.sh @@ -1,5 +1,5 @@ # GNU Guix --- Functional package management for GNU -# Copyright =C2=A9 2012, 2013, 2014, 2016, 2017, 2018, 2019, 2020, 2021 Lu= dovic Court=C3=A8s +# Copyright =C2=A9 2012-2014, 2016-2022 Ludovic Court=C3=A8s # Copyright =C2=A9 2020 Marius Bakke # Copyright =C2=A9 2021 Chris Marusich # @@ -31,6 +31,16 @@ guix build --version guix build -e '(@ (gnu packages bootstrap) %bootstrap-glibc)' -S test "`guix build -e '(@ (gnu packages bootstrap) %bootstrap-glibc)' -S`" = =3D "" =20 +# Warn when attempting to build an unsupported package. +case "$(guix build intelmetool -s armhf-linux -v0 -n 2>&1)" in + *warning:*intelmetool*support*armhf*) + true + break;; + *) + false; + break;; +esac + # Should pass. guix build -e '(@@ (gnu packages bootstrap) %bootstrap-guile)' | \ grep -e '-guile-' --=20 2.34.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 18 08:18:10 2022 Received: (at 51801-done) by debbugs.gnu.org; 18 Feb 2022 13:18:10 +0000 Received: from localhost ([127.0.0.1]:53659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nL39G-0006My-9u for submit@debbugs.gnu.org; Fri, 18 Feb 2022 08:18:10 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:37430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nL39F-0006Mk-2Z for 51801-done@debbugs.gnu.org; Fri, 18 Feb 2022 08:18:09 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 9CB861A4; Fri, 18 Feb 2022 14:18:03 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0GZ-QyCUbVSi; Fri, 18 Feb 2022 14:18:03 +0100 (CET) Received: from ribbon (unknown [193.50.110.222]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 9F49018E; Fri, 18 Feb 2022 14:18:02 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#51801: No warning when attempting to build unsupported system with --system References: <87o86oix8e.fsf@gmail.com> <874k4xmrau.fsf@gnu.org> Date: Fri, 18 Feb 2022 14:18:02 +0100 In-Reply-To: <874k4xmrau.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 17 Feb 2022 16:44:09 +0100") Message-ID: <87bkz4jotx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: 9CB861A4 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 51801-done Cc: 51801-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Ludovic Court=C3=A8s skribis: > Maxim Cournoyer skribis: > >> I was surprised that: >> >> guix build fpc --system=3Darmhf-linux >> >> would send me in a dead end without any word of caution, given that >> armhf-linux is *not* listed in the supported-systems field. >> >> We should at least warn near the beginning of the build, and remind of >> that fact at the end of the build in case of failure. > > I came up with the patches below. > > The first part forbids unsupported packages altogether in user-facing > commands: =E2=80=98guix install=E2=80=99, =E2=80=98guix shell=E2=80=99, e= tc. Until now, they=E2=80=99d just > start building things that were bound to fail. > > The second part adds a mere warning for =E2=80=98guix build=E2=80=99 (it = does not repeat > it at the end, though). I went ahead and pushed them: 0ca26437cb guix build: Warn when attempting to build an unsupported packa= ge. 5a57313918 profiles: 'profile-derivation' rejects unsupported packages. 0572737a62 packages: 'package-transitive-supported-systems' ignores '%cur= rent-target-system'. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 19 21:46:22 2022 Received: (at 51801) by debbugs.gnu.org; 20 Feb 2022 02:46:22 +0000 Received: from localhost ([127.0.0.1]:59026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLcEw-0000IV-Gl for submit@debbugs.gnu.org; Sat, 19 Feb 2022 21:46:22 -0500 Received: from mail-qv1-f49.google.com ([209.85.219.49]:38497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLcEu-0000II-Uf for 51801@debbugs.gnu.org; Sat, 19 Feb 2022 21:46:21 -0500 Received: by mail-qv1-f49.google.com with SMTP id d3so23122251qvb.5 for <51801@debbugs.gnu.org>; Sat, 19 Feb 2022 18:46:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:cc:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-transfer-encoding; bh=jnodyWmx6P4OBR1LEeUy6qsRAGFZkSXONMkZXsg41dE=; b=JlOL7Q9gliKVQq/sTQSNqlrKDBrhv/hau5E0KFxWvC4LEX90HfB6c7NOZ1MbCGKOB+ VamNrQluOIoTDvHgAV55lUIiCg68LQAgQxiuKfzat87q2T/8uXWU6To0pTm+BgW5m/nb rRETutXLfHmE/c41ih9iXQjn5RjHTQmReuia9qCuULq1mW/6vaIzY8q+TUpEgxEtUwXx MxRtjl0zFYuYn+PKIMvtxmgSPnzG9k4vcdGTOteIx+itAVU7U2vXVbd3oDnCaUCwgh3e LwhBybE4FfNnqLNTx3RT0LO8+UIGLI7FQiSr7FUtKWri82DXyryPh6bbfcbvw/kIKrjG habA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=jnodyWmx6P4OBR1LEeUy6qsRAGFZkSXONMkZXsg41dE=; b=iBolSw5lTPIbsujlTBaEN3kSBzGTPh8On4wDODsuG6gIl8rnLFdhkhgO6JiefN2Oo2 UwhlaH7bhJj6cJtdthMork7nJ3vQ2WGPl3BCWSrH7NbuCl6EKEcCH9X4+RwR8h5wQyFh 8jzi72xHRLSoqTPCM+t0DwDcW5x/lUo2Us1B5D6T7/VfVdHcVpbuM6CjymUE4DGEFFuA RyA1IaEYwRWsbFvTDai6rZARCM3L7oeIS2cOiv1YqElvwO+LKtP0P6zLfNB/r9Pd2cpT bpRcMpg/SE6J8A5IZEGGJLAEa+plPSxIR7rlzJ+hxZKs/k7uGcBRbYejoVmQ/FLAyoVy K5Wg== X-Gm-Message-State: AOAM5332P8qn5+i7ag2mVFtcQdN/Q5zxvLIshQyftlMTVU8POMYWbBCI tVJt2jvZb9/6JpWyZZtFpi/aa+y4rkA= X-Google-Smtp-Source: ABdhPJwqM3oUUy1Th6+CsPZLD4aZbQ1kts28XODEzW/wbiwiYNUzH7OsHyTr0n/tgdz+AGUGxRM2XA== X-Received: by 2002:a05:6214:c63:b0:42c:dedc:e59 with SMTP id t3-20020a0562140c6300b0042cdedc0e59mr11365477qvj.125.1645325175234; Sat, 19 Feb 2022 18:46:15 -0800 (PST) Received: from hurd (dsl-153-17.b2b2c.ca. [66.158.153.17]) by smtp.gmail.com with ESMTPSA id e9sm29164311qtx.37.2022.02.19.18.46.14 for <51801@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Feb 2022 18:46:14 -0800 (PST) From: Maxim Cournoyer Subject: Re: bug#51801: closed (Re: bug#51801: No warning when attempting to build unsupported system with --system) References: <87bkz4jotx.fsf@gnu.org> <87o86oix8e.fsf@gmail.com> Date: Sat, 19 Feb 2022 21:46:13 -0500 In-Reply-To: (GNU bug Tracking System's message of "Fri, 18 Feb 2022 13:19:01 +0000") Message-ID: <874k4uqmq2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Ludo, > From: Ludovic Courtès > Subject: Re: bug#51801: No warning when attempting to build unsupported system with --system > To: Maxim Cournoyer > Cc: 51801-done@debbugs.gnu.org > Date: Fri, 18 Feb 2 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 MISSING_HEADERS Missing To: header -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (maxim.cournoyer[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.49 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.49 listed in wl.mailspike.net] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 51801 Cc: 51801@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Hi Ludo, > From: Ludovic Court=C3=A8s > Subject: Re: bug#51801: No warning when attempting to build unsupported s= ystem with --system > To: Maxim Cournoyer > Cc: 51801-done@debbugs.gnu.org > Date: Fri, 18 Feb 2022 14:18:02 +0100 (1 day, 13 hours, 27 minutes ago) > > Ludovic Court=C3=A8s skribis: > >> Maxim Cournoyer skribis: >> >>> I was surprised that: >>> >>> guix build fpc --system=3Darmhf-linux >>> >>> would send me in a dead end without any word of caution, given that >>> armhf-linux is *not* listed in the supported-systems field. >>> >>> We should at least warn near the beginning of the build, and remind of >>> that fact at the end of the build in case of failure. >> >> I came up with the patches below. >> >> The first part forbids unsupported packages altogether in user-facing >> commands: =E2=80=98guix install=E2=80=99, =E2=80=98guix shell=E2=80=99, = etc. Until now, they=E2=80=99d just >> start building things that were bound to fail. >> >> The second part adds a mere warning for =E2=80=98guix build=E2=80=99 (it= does not repeat >> it at the end, though). > > I went ahead and pushed them: > > 0ca26437cb guix build: Warn when attempting to build an unsupported pac= kage. > 5a57313918 profiles: 'profile-derivation' rejects unsupported packages. > 0572737a62 packages: 'package-transitive-supported-systems' ignores '%c= urrent-target-system'. Thank you! Maxim From unknown Wed Sep 10 10:23:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 20 Mar 2022 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator