From unknown Tue Sep 09 18:22:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#51798 <51798@debbugs.gnu.org> To: bug#51798 <51798@debbugs.gnu.org> Subject: Status: bashtop does not run without glibc installed in profile Reply-To: bug#51798 <51798@debbugs.gnu.org> Date: Wed, 10 Sep 2025 01:22:05 +0000 retitle 51798 bashtop does not run without glibc installed in profile reassign 51798 guix submitter 51798 Lenny H=C3=A4ndler severity 51798 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 12 19:36:36 2021 Received: (at submit) by debbugs.gnu.org; 13 Nov 2021 00:36:36 +0000 Received: from localhost ([127.0.0.1]:46245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlh21-00035p-Ro for submit@debbugs.gnu.org; Fri, 12 Nov 2021 19:36:36 -0500 Received: from lists.gnu.org ([209.51.188.17]:39474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlfSi-0000S2-PC for submit@debbugs.gnu.org; Fri, 12 Nov 2021 17:56:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlfSi-0005jz-BN for bug-guix@gnu.org; Fri, 12 Nov 2021 17:56:00 -0500 Received: from gateway24.websitewelcome.com ([192.185.50.73]:38169) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlfSg-0006Td-DF for bug-guix@gnu.org; Fri, 12 Nov 2021 17:55:59 -0500 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 879421674E for ; Fri, 12 Nov 2021 16:55:45 -0600 (CST) Received: from gator3130.hostgator.com ([50.87.144.166]) by cmsmtp with SMTP id lfSTmtJRQgm2UlfSTmUFsP; Fri, 12 Nov 2021 16:55:45 -0600 X-Authority-Reason: nr=8 Received: from dslb-002-202-166-237.002.202.pools.vodafone-ip.de ([2.202.166.237]:49786 helo=[10.0.0.195]) by gator3130.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mlfSS-000Mcg-IM for bug-guix@gnu.org; Fri, 12 Nov 2021 16:55:44 -0600 To: bug-guix@gnu.org From: =?UTF-8?Q?Lenny_H=c3=a4ndler?= Subject: bashtop does not run without glibc installed in profile Message-ID: <0fe8420a-dae9-92e8-5dfb-b52260a7c669@lennyhaendler.com> Date: Fri, 12 Nov 2021 23:55:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.15.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator3130.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lennyhaendler.com X-BWhitelist: no X-Source-IP: 2.202.166.237 X-Source-L: No X-Exim-ID: 1mlfSS-000Mcg-IM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: dslb-002-202-166-237.002.202.pools.vodafone-ip.de ([10.0.0.195]) [2.202.166.237]:49786 X-Source-Auth: lenny@lennyhaendler.com X-Email-Count: 1 X-Source-Cap: bWlrZTIzMTI7bWlrZTIzMTI7Z2F0b3IzMTMwLmhvc3RnYXRvci5jb20= X-Local-Domain: yes Received-SPF: pass client-ip=192.185.50.73; envelope-from=lenny@lennyhaendler.com; helo=gateway24.websitewelcome.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 12 Nov 2021 19:36:33 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) the script needs both uname and locale. If glibc is not installed in profile, it aborts. However glibc is not listed as a dependency. When I install glibc it works. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 14 09:02:16 2021 Received: (at 51798) by debbugs.gnu.org; 14 Nov 2021 14:02:17 +0000 Received: from localhost ([127.0.0.1]:49504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmG5I-0006YP-LT for submit@debbugs.gnu.org; Sun, 14 Nov 2021 09:02:16 -0500 Received: from jpoiret.xyz ([206.189.101.64]:33514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmG5G-0006YH-NH for 51798@debbugs.gnu.org; Sun, 14 Nov 2021 09:02:15 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 57097184F2A; Sun, 14 Nov 2021 14:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1636898533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ri2YkiCTsEQ3SG2bOzAbrCmj6MRI3WNVusxuD6JcAc0=; b=dmjTJ2YqgWZABoRgQlJZKVGoGUgo1KTcpQCUKX1RvkbecqBGLH7t0dJUgiHHQ6J0xZq+Da JDENl849VsDP3vubj2o4LcU3lkZDAQKbfJp9Up17z2DEAwfVf0lj3rXnwPbLc+zGm9K0B8 y67Q1T4GSiSvfh5r2PW+Xj9c4MkYZ3XWVnPWoXzjTNDLXNtYDM3XSupFmElRpCMNGh2vG7 kOSw93hyE+VEeFzdyCOCKAtMu2ymQU1hRU4uw8rbNIP0DpBG+P5IHJr2wbK9yD3JTR/6cV L7AUxkpOnqpZUVmvZl9ojX1jxC4Ra2f6b5D26wR4uywwiwRcSmct6f3bKh+o0g== From: Josselin Poiret To: =?UTF-8?q?Lenny=20H=C3=A4ndler?= , 51798@debbugs.gnu.org Subject: [PATCH] gnu: bashtop: Add dependencies and wrap program with PATH Date: Sun, 14 Nov 2021 14:01:37 +0000 Message-Id: <20211114140137.13868-1-dev@jpoiret.xyz> In-Reply-To: <0fe8420a-dae9-92e8-5dfb-b52260a7c669@lennyhaendler.com> References: <0fe8420a-dae9-92e8-5dfb-b52260a7c669@lennyhaendler.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: ++++ Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Level: **** X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: You're right, none of the needed dependencies of bashtop were actually present in the package definition. Here is a patch that does work on my machine using `guix shell --pure bashtop -- bashtop`. Best, Josselin Poiret -- >8 -- Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: 51798 Cc: Josselin Poiret X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: You're right, none of the needed dependencies of bashtop were actually present in the package definition. Here is a patch that does work on my machine using `guix shell --pure bashtop -- bashtop`. Best, Josselin Poiret -- >8 -- Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager You're right, none of the needed dependencies of bashtop were actually present in the package definition. Here is a patch that does work on my machine using `guix shell --pure bashtop -- bashtop`. Best, Josselin Poiret -- >8 -- * gnu/packages/admin.scm (bashtop): Add dependencies, wrap the script so that it can access the commands it needs. --- gnu/packages/admin.scm | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index 2a7b0f310d..8f9125212c 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -71,6 +71,7 @@ (define-module (gnu packages admin) #:use-module (guix build-system python) #:use-module (guix build-system ruby) #:use-module (guix build-system trivial) + #:use-module (guix build-system copy) #:use-module (guix download) #:use-module (guix git-download) #:use-module ((guix licenses) #:prefix license:) @@ -670,11 +671,29 @@ (define-public bashtop (sha256 (base32 "07nlr6vmyb7yihaxj1fp424lmhwkdjl6mls92v90f6gsvikpa13v")))) - (build-system gnu-build-system) + (build-system copy-build-system) (arguments - '(#:make-flags (list (string-append "PREFIX=" %output)) - #:tests? #f ; bats test fails with loading load.bash - #:phases (modify-phases %standard-phases (delete 'configure)))) + '(#:install-plan '(("./bashtop" "./bin/bashtop")) + #:phases (modify-phases %standard-phases + (add-after 'install 'wrap + (lambda* (#:key outputs #:allow-other-keys) + (let ((paths (map (lambda (program) + (dirname (which program))) + '("awk" "dd" "grep" "ip" + "locale" "ps" "sed"))) + (bashtop (string-append (assoc-ref outputs + "out") + "/bin/bashtop"))) + (wrap-program bashtop + `("PATH" ":" = ,paths)))))))) + (inputs + `(("coreutils" ,coreutils) + ("gawk" ,gawk) + ("glibc" ,glibc) ; for 'locale' + ("grep" ,grep) + ("iproute" ,iproute) + ("procps" ,procps) + ("sed" ,sed))) (home-page "https://github.com/aristocratos/bashtop") (synopsis "Linux/OSX/FreeBSD resource monitor") (description "Resource monitor that shows usage and stats for processor, -- 2.33.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 14 10:20:11 2021 Received: (at 51798) by debbugs.gnu.org; 14 Nov 2021 15:20:11 +0000 Received: from localhost ([127.0.0.1]:51344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmHIg-0002o8-PA for submit@debbugs.gnu.org; Sun, 14 Nov 2021 10:20:11 -0500 Received: from jpoiret.xyz ([206.189.101.64]:37412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmHIe-0002ny-VX for 51798@debbugs.gnu.org; Sun, 14 Nov 2021 10:20:09 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 973D0184F5F; Sun, 14 Nov 2021 15:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1636903208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zA5iaEqTSZhG6BrniMzDsKleWvoopaMZEFtKoCt3JDI=; b=sI4Zw9fvC3FiUgWNrCTLDnNiqA8DmqHGsVj6Qc8qkcxNnS0Oo7tM83poRDMJOx/pzfO/dL 7gKSX64h2/hk3Pm1mU2WW4s+Xzyq22hH8FmlvNXfjxkM5tDXQ3085WagXFWWI5wx229Rpw dD7YrVUA54VpqtNi9dFlJYznNO8rTARGBlEXTnDqq59+XjTTG2TJ+xafze7y1i9/OI7UYE TEaoYXP89tpulFQMoCR4UxVKapVxzaYp5T60VQ2GBqrsiKCWlp8zkXrD/uvca+kyI7z/Xk OmhhcpKY8ErzOPJUhjzeLZdb3b4yBEQJTJfoOwHjy9t+tJ50920/xQp6S0IZYw== From: Josselin Poiret To: =?UTF-8?q?Lenny=20H=C3=A4ndler?= , 51798@debbugs.gnu.org Subject: [PATCH v2] gnu: bashtop: Add dependencies and wrap program with PATH Date: Sun, 14 Nov 2021 15:19:49 +0000 Message-Id: <20211114151949.19754-1-dev@jpoiret.xyz> In-Reply-To: <20211114140137.13868-1-dev@jpoiret.xyz> References: <20211114140137.13868-1-dev@jpoiret.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: / Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Sorry for the noise, but the patch I just sent wasn't up to satisfaction: using `which` in the build phases breaks cross-compilation, and the build-system change was a bit of an unwarranted change. Here's a modified patch! Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: 51798 Cc: Josselin Poiret X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Sorry for the noise, but the patch I just sent wasn't up to satisfaction: using `which` in the build phases breaks cross-compilation, and the build-system change was a bit of an unwarranted change. Here's a modified patch! Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Sorry for the noise, but the patch I just sent wasn't up to satisfaction: using `which` in the build phases breaks cross-compilation, and the build-system change was a bit of an unwarranted change. Here's a modified patch! Best, Josselin Poiret -- >8 -- * gnu/packages/admin.scm (bashtop): Add dependencies, wrap the script so that it can access the commands it needs. --- gnu/packages/admin.scm | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index 2a7b0f310d..fe3987a9b8 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -674,7 +674,29 @@ (define-public bashtop (arguments '(#:make-flags (list (string-append "PREFIX=" %output)) #:tests? #f ; bats test fails with loading load.bash - #:phases (modify-phases %standard-phases (delete 'configure)))) + #:phases (modify-phases %standard-phases + (delete 'configure) + (add-after 'install 'wrap + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((path (map (lambda (input) + (string-append (assoc-ref inputs + input) + "/bin")) + '("coreutils" "gawk" "glibc" "grep" + "iproute" "procps" "sed"))) + (bashtop (string-append (assoc-ref outputs + "out") + "/bin/bashtop"))) + (wrap-program bashtop + `("PATH" ":" = ,path)))))))) + (inputs + `(("coreutils" ,coreutils) + ("gawk" ,gawk) + ("glibc" ,glibc) ; needed for the 'locale' binary + ("grep" ,grep) + ("iproute" ,iproute) + ("procps" ,procps) + ("sed" ,sed))) (home-page "https://github.com/aristocratos/bashtop") (synopsis "Linux/OSX/FreeBSD resource monitor") (description "Resource monitor that shows usage and stats for processor, -- 2.33.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 14 16:33:18 2021 Received: (at 51798) by debbugs.gnu.org; 14 Nov 2021 21:33:18 +0000 Received: from localhost ([127.0.0.1]:51898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmN7m-0000Os-BT for submit@debbugs.gnu.org; Sun, 14 Nov 2021 16:33:18 -0500 Received: from andre.telenet-ops.be ([195.130.132.53]:51090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmN7j-0000Of-TY for 51798@debbugs.gnu.org; Sun, 14 Nov 2021 16:33:17 -0500 Received: from [192.168.192.254] ([178.119.10.153]) by andre.telenet-ops.be with bizsmtp id JMZD2600A3J72EA01MZDUy; Sun, 14 Nov 2021 22:33:14 +0100 Message-ID: <66d97324a177c60a7b52b54e88a35945870d4ef8.camel@telenet.be> Subject: Re: bug#51798: [PATCH v2] gnu: bashtop: Add dependencies and wrap program with PATH From: Maxime Devos To: Josselin Poiret , Lenny =?ISO-8859-1?Q?H=E4ndler?= , 51798@debbugs.gnu.org Date: Sun, 14 Nov 2021 21:33:13 +0000 In-Reply-To: <20211114151949.19754-1-dev@jpoiret.xyz> References: <20211114140137.13868-1-dev@jpoiret.xyz> <20211114151949.19754-1-dev@jpoiret.xyz> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1636925594; bh=RcDx3t7BYXxdPji4e1I9qbX8jJDRWwGEVaJwCwO7Jt4=; h=Subject:From:To:Date:In-Reply-To:References; b=b3OzfsFnzR7VsjRXMaP+LDjmjI4PBMDIFIG2KXAO1Dni/POHO3Eyx/hsU8HM0F3wm JrLAVE4M6GdD123WpAWSsmONpvK5eis94luj876Wzy0cLQuJ2sLgdtHgPgyjGtOTDP UOV/ohD2MXlmyy4iIEleGdGfr2pUZNn+FXSps6d0RnpN18Q1d4v4y5Td53VgNH9JSq cHq+3mE4VhXjnfDGflUqnY1Z3IibxajPurcybWFKq/Lsv96rpofDY3b1zKdKNIKoR3 6KCJWfyfxzvOleTCz60JsXwDwqjdyL5RIBrgAHX/puMwoTtKEiKK3xPpN1p1CGafNp kwwQhOv6dySSQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51798 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Josselin Poiret via Bug reports for GNU Guix schreef op zo 14-11-2021 om 15:19 [+0000]: > +                       (wrap-program bashtop The input "bash-minimal" is missing. Adding that input is required for cross-compilation (otherwise a native bash instead of a bash for the target is used). It should be reported by guix lint. Greetings, Maxime. -- not hacking on guix for a while, only occassionally looking at IRC logs and bug reports. E-mails are unsigned until backup is located.