From unknown Sun Jun 22 17:14:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#51794 <51794@debbugs.gnu.org> To: bug#51794 <51794@debbugs.gnu.org> Subject: Status: 29.0.50; invalid input events generated from a mouse click for the tab bar Reply-To: bug#51794 <51794@debbugs.gnu.org> Date: Mon, 23 Jun 2025 00:14:40 +0000 retitle 51794 29.0.50; invalid input events generated from a mouse click fo= r the tab bar reassign 51794 emacs submitter 51794 Mark Kennedy severity 51794 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 12 16:03:05 2021 Received: (at submit) by debbugs.gnu.org; 12 Nov 2021 21:03:05 +0000 Received: from localhost ([127.0.0.1]:46070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mldhQ-0005xG-Ip for submit@debbugs.gnu.org; Fri, 12 Nov 2021 16:03:05 -0500 Received: from lists.gnu.org ([209.51.188.17]:60018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlday-0005lr-Ct for submit@debbugs.gnu.org; Fri, 12 Nov 2021 15:56:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlday-0005pl-0v for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2021 15:56:24 -0500 Received: from [2607:f8b0:4864:20::b30] (port=44712 helo=mail-yb1-xb30.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mldav-0001LF-No for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2021 15:56:23 -0500 Received: by mail-yb1-xb30.google.com with SMTP id q74so26866373ybq.11 for ; Fri, 12 Nov 2021 12:56:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=WgNcZCDz/Gqp+I0fNZeOIzxBM4vrUWaYV62YAIXx96c=; b=eUxkGOR8RC4fn1geed4cnKNw47Dr0WguG/Br30y1StfEz3+n+wzgPqQTJLZeLCChPL XgmW8f6C7/+59jwwSg9uq7/1oLAffeix0ImpWlgjl9K2F1TLjwedznxVa8hV4VT2r6NS uXjvAX+dm4bV7806dNzQds/FJx50SWTAz9xbxcqEB9LEYkhnhjBNqgIYaajYdQ2R5vfF cuPo5MKeIl7RYKyjvfGfZ9vnaSg/yKby7LRN52lLXFhNpkmlRkRDKKM7qXEf3quiLTR5 CHZYksB0GwwczN1xDEQ+YxJCo8URpxaZLLEaQjtWS2JdE/7E2Q5LSVYsbfTOCBx69+WK V/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=WgNcZCDz/Gqp+I0fNZeOIzxBM4vrUWaYV62YAIXx96c=; b=ehVkkwlW4nfCqN3ODzpBtThmoxTM7n7PkZK94A82wr1wpwR525e7bkU7l5ZBTCm5tB x2+u0cg7HghDo8s2cbHhGGIiORCCj1WMWc0nNqTRey/4lOhLltQpBC1uclY69JSuBzhd ju7oUx5Tiqtkz4jK1nBwaFLNirjscRKhnluMvs4Brzv+C0SnYDhUWv3K8AjfOrvdfHvC IKQsCHMcd7Zr33C7fXcrn/uykF3ZQYeFK/9k1XuyIU8yZCbLrfNstWKP8+veec4ebpY2 0FJ1pKh614ZUun47X3J5iiPkP/xxatiCKGXTqViS1cQmPiaJ2F+LE/Pue3Qc6V1QiFHR AUpQ== X-Gm-Message-State: AOAM530h8rf+Mg7auOodBImObfSKa7/+PiSDFAaT50k2pP/j4UYSzTgp el3y/k1kQyouB2+d57isTnoF6HyD0jDlaS4cyEPG0PWxQXeEPg== X-Google-Smtp-Source: ABdhPJw7eKcXWhEZMYyIgLXU+m39Di1I266nMfbigTDpWagUwhadn0Z57s2VFMUHXhXMEhiV5v61GWcLUvbGxz0jGqg= X-Received: by 2002:a9d:6855:: with SMTP id c21mr15089176oto.357.1636750193968; Fri, 12 Nov 2021 12:49:53 -0800 (PST) MIME-Version: 1.0 From: Mark Kennedy Date: Fri, 12 Nov 2021 15:49:45 -0500 Message-ID: Subject: 29.0.50; invalid input events generated from a mouse click for the tab bar To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::b30 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::b30; envelope-from=mark.t.kennedy@gmail.com; helo=mail-yb1-xb30.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 12 Nov 2021 16:03:03 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) CAVEAT: this has not been reproduced under an "emacs -Q" 1) launch an emacs with two windows 2) one window has a number of tabs with text files in each 3) the other window has at least one tab with a scala source file, in scala mode, using LSP 4) the emacs instance is configured to use lsp-metals 5) clicking on the tabs in the text file window works as expected (e.g. selection, closing) 6) clicking on a tab in the window with the scala source file triggers the message " is undefined". 7) switching from scala mode to fundamental mode restores the correct tab behavior. 8) switching back to scala mode from fundamental mode restores the failing behavior as you can see from the generated environment info below, the environment is *compilicated*. bisecting this is out of the question. i'm hoping that someone could focus on the presence of the "" in the generated input sequence since it implies that the lisp symbol nil was somehow passed into the input event queue. In GNU Emacs 29.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4) of 2021-11-12 built on new.mofjwutu.com Repository revision: 12d554e5c54487d753a133c048e262f3d54019bd Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Fedora Linux 35 (Workstation Edition) Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=none locale-coding-system: utf-8-unix Major mode: Scala Minor modes in effect: lsp-headerline-breadcrumb-mode: t lsp-diagnostics-mode: t lsp-modeline-workspace-status-mode: t lsp-modeline-diagnostics-mode: t lsp-modeline-code-actions-mode: t lsp-completion-mode: t indent-guide-mode: t subword-mode: t save-place-mode: t desktop-save-mode: t global-display-line-numbers-mode: t display-line-numbers-mode: t beacon-mode: t pyvenv-mode: t shell-dirtrack-mode: t pcre-mode: t dynamic-completion-mode: t msb-mode: t winner-mode: t savehist-mode: t which-function-mode: t global-page-break-lines-mode: t global-hi-lock-mode: t hi-lock-mode: t icomplete-mode: t dap-tooltip-mode: t dap-ui-many-windows-mode: t dap-ui-controls-mode: t dap-ui-mode: t which-key-mode: t lsp-ui-mode: t lsp-ui-doc-mode: t lsp-ui-sideline-mode: t company-mode: t treemacs-filewatch-mode: t treemacs-follow-mode: t treemacs-git-mode: t treemacs-fringe-indicator-mode: t lsp-lens-mode: t dap-auto-configure-mode: t dap-mode: t lsp-managed-mode: t lsp-mode: t yas-minor-mode: t flycheck-mode: t override-global-mode: t hl-todo-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t tab-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/mtk/.emacs.d/elpa/teco-20200707.2309/teco hides /usr/local/share/emacs/site-lisp/teco /home/mtk/.emacs.d/elpa/transient-20211105.100/transient hides /usr/local/share/emacs/29.0.50/lisp/transient Features: (shadow sort mail-extr emacsbug sendmail names edebug autoload tar-mode arc-mode archive-mode cl-print debug backtrace teco magit-utils crm jka-compr apropos cus-start eieio-opt speedbar ezimage dframe shortdoc misearch multi-isearch add-log mm-archive message yank-media dired dired-loaddefs rfc822 mml mml-sec epa derived gnus-util rmail rmail-loaddefs mailabbrev gmm-utils mm-decode mm-bodies mm-encode lsp-headerline lsp-icons url-http url-gw url-cache url-auth mule-util lsp-diagnostics lsp-modeline company-oddmuse company-keywords company-etags company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-cmake company-semantic company-template company-bbdb vc-git vc-dispatcher lsp-zig lsp-steep lsp-svelte lsp-sqls lsp-yaml lsp-xml lsp-vimscript lsp-vhdl lsp-vetur lsp-html lsp-verilog lsp-vala lsp-v lsp-toml lsp-terraform lsp-tex lsp-sorbet lsp-solargraph lsp-rust lsp-rf lsp-r lsp-purescript lsp-pylsp lsp-pyls lsp-pwsh lsp-php lsp-perl lsp-ocaml lsp-nix lsp-nim lsp-markdown lsp-lua lsp-kotlin lsp-json lsp-javascript lsp-haxe lsp-groovy lsp-hack lsp-graphql lsp-go lsp-completion lsp-gdscript lsp-fsharp lsp-fortran lsp-eslint lsp-erlang lsp-elixir lsp-elm lsp-dockerfile lsp-dhall lsp-d lsp-css lsp-csharp gnutls lsp-crystal lsp-cmake lsp-clojure lsp-semantic-tokens lsp-clangd dom lsp-beancount lsp-bash lsp-angular lsp-ada lsp-actionscript ccls ccls-member-hierarchy ccls-inheritance-hierarchy ccls-call-hierarchy ccls-tree ccls-code-lens ccls-semantic-highlight ccls-common scala-mode scala-mode-prettify-symbols scala-mode-imenu scala-mode-map scala-mode-fontlock scala-mode-indent scala-mode-paragraph scala-mode-syntax scala-mode-lib disp-table indent-guide hlinum linum cap-words superword subword saveplace desktop frameset display-line-numbers beacon highlight-indentation flymake-proc flymake warnings company-capf help-fns radix-tree elpy elpy-rpc pyvenv eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util elpy-shell elpy-profile elpy-django elpy-refactor diff-mode python tramp-sh tramp tramp-loaddefs trampver tramp-integration tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp format-spec ido files-x etags fileloop generator pcre2el rxt re-builder completion msb winner savehist which-func page-break-lines hi-lock avoid icomplete server use-package-delight lsp-pyright dap-mouse dap-ui gdb-mi gud bui bui-list bui-info bui-entry bui-core bui-history bui-button bui-utils cus-edit pp cus-load dap-java lsp-java request mailheader autorevert mail-utils cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs which-key lsp-ui lsp-ui-flycheck lsp-ui-doc goto-addr lsp-ui-imenu lsp-ui-peek lsp-ui-sideline lsp-ui-util face-remap company hydra flycheck-package package-lint let-alist finder finder-inf projectile lisp-mnt mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr grep ibuf-ext ibuffer ibuffer-loaddefs lsp-metals view lsp-metals-treeview lsp-treemacs lsp-treemacs-themes treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-interface treemacs-extensions treemacs-mouse-interface treemacs-tags treemacs-persistence treemacs-filewatch-mode treemacs-follow-mode treemacs-rendering treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals treemacs-fringe-indicator treemacs-scope pulse treemacs-faces treemacs-icons treemacs-themes treemacs-core-utils pfuture hl-line treemacs-logging treemacs-customization treemacs-macros lsp-metals-protocol lsp-lens dap-mode dap-launch posframe dap-overlays lsp-mode lsp-protocol aws-snippets go-snippets yasnippet-snippets yasnippet xref project tree-widget wid-edit spinner pcase network-stream puny nsm rmc markdown-mode color thingatpt noutline outline lv inline imenu ht filenotify ewoc epg rfc6068 epg-config compile text-property-search comint ring flycheck-eldev flycheck ansi-color find-func use-package-bind-key bind-key easy-mmode importmagic f dash s epc ctable edmacro kmacro concurrent deferred hl-todo use-package-ensure ialign align cl-extra use-package-core tab-line trim page-menu cperl-mode facemenu help-mode rx cl advice info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq gv subr-x byte-opt bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 2036788 1830354) (symbols 48 68716 737) (strings 32 376913 356206) (string-bytes 1 16103230) (vectors 16 171799) (vector-slots 8 2498201 708904) (floats 8 877 5477) (intervals 56 205896 121072) (buffers 992 50)) From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 13 02:18:49 2021 Received: (at 51794) by debbugs.gnu.org; 13 Nov 2021 07:18:49 +0000 Received: from localhost ([127.0.0.1]:46407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlnJJ-0005EC-FP for submit@debbugs.gnu.org; Sat, 13 Nov 2021 02:18:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlnJF-0005Dy-A8 for 51794@debbugs.gnu.org; Sat, 13 Nov 2021 02:18:48 -0500 Received: from [2001:470:142:3::e] (port=39320 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlnJA-0000t7-3D; Sat, 13 Nov 2021 02:18:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MHS3491tP6Bos5MGVCAgHFwzZ/WoZV2AzqrZKRTSQDw=; b=kc+pVo18RLqZ gLVAdAyIN1cwSKdETr7MtEHE7c2jqvEGCBPNzgQOhMmxkjiWSoOYZs/d79N3V3Kd5G8zBHETvZWui dJaYj6cToW4ymeeY9YDxs/KpkG/x3fM5AAwcUJb2uU+wu+FBAs/DPpYtu2HC6G9WvmxreDHZqz3+I JM6qKaQVvBeYAC/5SkZKxdhcV9CYOi7PNHYwiHvXBN/dZsHd51pPMaZ4yS07oTspyBxW9ivv/9WjR LAJYsRAGOhsYIokPp/e8URhnw2qOs4z57yLoLaoG9P0p/3agfFRR+xz5Tyc/0SEegVFXRhemDmM3K cf6FPSNj1Rvna0EQWjBNDw==; Received: from [87.69.77.57] (port=3268 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlnJ9-0000cw-Eg; Sat, 13 Nov 2021 02:18:39 -0500 Date: Sat, 13 Nov 2021 09:18:21 +0200 Message-Id: <83tuggy14y.fsf@gnu.org> From: Eli Zaretskii To: Mark Kennedy In-Reply-To: (message from Mark Kennedy on Fri, 12 Nov 2021 15:49:45 -0500) Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mark Kennedy > Date: Fri, 12 Nov 2021 15:49:45 -0500 > > 1) launch an emacs with two windows > 2) one window has a number of tabs with text files in each > 3) the other window has at least one tab with a scala source file, > in scala mode, using LSP > 4) the emacs instance is configured to use lsp-metals > 5) clicking on the tabs in the text file window works as expected > (e.g. selection, closing) > 6) clicking on a tab in the window with the scala source file triggers > the message " is undefined". > 7) switching from scala mode to fundamental mode restores the correct > tab behavior. > 8) switching back to scala mode from fundamental mode restores the > failing behavior Does scala mode rebind mouse clicks to some of its commands? If so, please show those rebindings. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 13 08:43:41 2021 Received: (at 51794) by debbugs.gnu.org; 13 Nov 2021 13:43:42 +0000 Received: from localhost ([127.0.0.1]:46744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mltJl-0001Br-M4 for submit@debbugs.gnu.org; Sat, 13 Nov 2021 08:43:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mltJi-0001Bd-Io for 51794@debbugs.gnu.org; Sat, 13 Nov 2021 08:43:40 -0500 Received: from [2001:470:142:3::e] (port=50702 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mltJa-00061a-PZ; Sat, 13 Nov 2021 08:43:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=He6sMb8VCe5apNA078HJUzbP189SljSTM00xcaH7o2c=; b=JNC2Sm56DwkZ eR3cJt20hoP9fnOzLcMmLNmBY6D5a4SAt9o2MiT+r+y1e/OMg2pXA27l7XYx/kp1bVd8JuVh9cyBB Em2ZRnEFu57aqZmk9Z5C2Xc/IC8iZsUDVHQ1lefpH7u6kPPUEv6jXRsOBrmVc56BiT1yBFOUeo+yg SH7n5ejA6MJnp+N+WLimt/n32+bAhD638VfghqVFpKJRx8IsLF4Ddwq302cBf5b6sg1SMG1XFSQ3O 5kK5vZsYuHkCNl5ItYxZoy9FMKhVXXE1tPJn7gMBnAzxCuoOhsAg/Qyq71Nr38TbJj7XmSkdJ3Mfw UFthpyDu9pswWamy0nz4LA==; Received: from [87.69.77.57] (port=3575 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mltJV-0008EM-Ix; Sat, 13 Nov 2021 08:43:30 -0500 Date: Sat, 13 Nov 2021 15:43:09 +0200 Message-Id: <83h7cgxjbm.fsf@gnu.org> From: Eli Zaretskii To: Mark Kennedy In-Reply-To: (message from Mark Kennedy on Sat, 13 Nov 2021 08:37:37 -0500) Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar References: <83tuggy14y.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [Please use Reply All to reply, so that the bug tracker is CC'ed.] > From: Mark Kennedy > Date: Sat, 13 Nov 2021 08:37:37 -0500 > > it doesn't rebind anything significant. but i'm not sure that theory > could explain the key sequence ' ' unless it had > mistakenly bound it to a keyboard macro? what do you think the > presence of the '' as a keyboard event means? from where could > that originate? That nil means Emacs didn't recognize the part of the window/frame where you clicked. Is it possible to provide a complete recipe for reproducing the problem, starting from "emacs -Q" and loading the minimum number of additional features required for seeing the problem? From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 13 09:41:22 2021 Received: (at 51794) by debbugs.gnu.org; 13 Nov 2021 14:41:22 +0000 Received: from localhost ([127.0.0.1]:46814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mluDa-00076H-4U for submit@debbugs.gnu.org; Sat, 13 Nov 2021 09:41:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mluDX-000761-Uo for 51794@debbugs.gnu.org; Sat, 13 Nov 2021 09:41:20 -0500 Received: from [2001:470:142:3::e] (port=52750 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mluDS-0004sB-MX; Sat, 13 Nov 2021 09:41:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PJQOkd/UoZoZxrcFr2rVlzsdlQ4Yfyw4SGxhL9NbtMA=; b=Vor7g6r+EsT3 Wo90ITJKNfUfeJRncsfMqq1F0Oiy354W45HzPkvtP2jFwHX5MCBDko8YeJhYXmfMfbzgCVb+GqYX7 D5pVdN/1CPhlyLgrX+rEDI+0ieyC4mKwbZLPmnoFDLyRsiCx6piqe3JrNo4asVF5i02QiSgjl024a UNpygDAQxClTCRT5BaGR5g9fRDviNP04y1mnEmZOXvhMl5qOW8g0E4oZUIyjAeCJ1ZDVzevi1no7D c60vYnn7w8AXIDmeBaM4NmaeLNuY550ugCGQxsPx4EoSPIphUoX4LsWY7I5fqH2WITOo6t1n9hT0Z M6MkcUX1wK3cdwOYC9MHKg==; Received: from [87.69.77.57] (port=3176 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mluDS-0003JU-BT; Sat, 13 Nov 2021 09:41:14 -0500 Date: Sat, 13 Nov 2021 16:40:58 +0200 Message-Id: <83fss0xgn9.fsf@gnu.org> From: Eli Zaretskii To: Mark Kennedy In-Reply-To: (message from Mark Kennedy on Sat, 13 Nov 2021 08:50:08 -0500) Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [PLEASE USE REPLY ALL TO REPLY, SO THAT THE BUG TRACKER IS CC'ED.] > From: Mark Kennedy > Date: Sat, 13 Nov 2021 08:50:08 -0500 > > reproducing from -Q is a nightmare. your comment that it did not > recognize the part of the window frame is what i want to focus on. > the window containing the scala mode buffer contains tab-bar tabs. i > am clicking in either a tab (on the close icon) or to the right of the > tab list on the "open new empty tab" icon (still within the tab bar). > how could that generate the input event? I don't know. That's why I asked for a recipe: to try debugging it myself. If it isn't practical to provide a recipe, you will have to debug it on your system. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 13 09:52:43 2021 Received: (at 51794) by debbugs.gnu.org; 13 Nov 2021 14:52:43 +0000 Received: from localhost ([127.0.0.1]:46822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mluOZ-0007Qa-Fw for submit@debbugs.gnu.org; Sat, 13 Nov 2021 09:52:43 -0500 Received: from mail-oi1-f177.google.com ([209.85.167.177]:34308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mluOU-0007QF-8Q for 51794@debbugs.gnu.org; Sat, 13 Nov 2021 09:52:41 -0500 Received: by mail-oi1-f177.google.com with SMTP id t19so24168934oij.1 for <51794@debbugs.gnu.org>; Sat, 13 Nov 2021 06:52:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pLJWzPOOb2huFmEKDaR/DkX87K1UMfo4W3RXMSn07Sg=; b=EzfFAEEsLbypsDfaHDGvRvSofLoPwBI+u69DFuMIFTHeLT2qhj51BbyKcaePh2txG/ Ybir3mUIB1EEkOnSdgXwQADFMkme2zGIcfCx87T2KIf07bR68fiHS2G9pKfjCLWFcpR7 GiY2Zm4lYqW+J6nGsiUjMQDGg+0zVAFT/k7emga5bwhPuLnMF5NvjH3dv0hnAQVY+3AO Fzwd+I7KHyKjfVwq1mkpLF9hUmWKKocOe1wc8pVI5m2dYiB3UMHm6qWM83MC3Mqdhhvt 5JmCeBuHFvWVepdUYcI6DrG07KmYI6Z6BIP6MDXXu5SeNejC9TQPErIZ8Sktmxl5rWdW kMFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pLJWzPOOb2huFmEKDaR/DkX87K1UMfo4W3RXMSn07Sg=; b=QRTiSSyBcliBdXSmrDx7lF+8Ude020YhN+H+ieC96GF6HQylly2Nd98YLwnecDGEOq UmKx2KFY9CE9YJH9vPNeK9pd/MsYPMVU9Lyc85d6gaKSwJGwGGHo/lIfaJ50qNMEy6lI M10lFs89nGWfRChsbPadlEvUfOmWe7ZQDH/2KxS38qHe6UUs86a7eA2BUmXB3CEt8Kbh Z5pFiqrw9jAV1+ofl7V8wkG4FqopeUHXbj1Sxzmyt80Q2tLRtIlvleCz7KTgpdzdTtJO /BhGbKd8QYmJwuPDXPpHk1T8nF28377RjPyK0yzGPtIJWyLrEGCZTx0f9fVJH5srKoKV IciQ== X-Gm-Message-State: AOAM533ul8zJpd/5YzhPWwkdUlfRrowgvzRsTrBNYnk5J2Z9rgRjF2og eZ1+4vMyuNJ2FlW3xesT947+/LkPGqDQTGrYm9k= X-Google-Smtp-Source: ABdhPJzca9HL9WmSs3TJbN0O8I68jF5WzdUR9+IWPXaTirdvdtzfp/IUXtF/3e2l2nyCeK81kJHAsY5bMKxs7c8eJjQ= X-Received: by 2002:a05:6808:15a:: with SMTP id h26mr33889755oie.123.1636815152449; Sat, 13 Nov 2021 06:52:32 -0800 (PST) MIME-Version: 1.0 References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> In-Reply-To: <83fss0xgn9.fsf@gnu.org> From: Mark Kennedy Date: Sat, 13 Nov 2021 09:52:21 -0500 Message-ID: Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) i'm willing to attempt to debug it myself but not via the -Q route. i prefer to focus on where the bad input event stream is being created. any suggestions about where to put an elisp or C breakpoint to go after this? /mark On Sat, Nov 13, 2021 at 9:41 AM Eli Zaretskii wrote: > > [PLEASE USE REPLY ALL TO REPLY, SO THAT THE BUG TRACKER IS CC'ED.] > > > From: Mark Kennedy > > Date: Sat, 13 Nov 2021 08:50:08 -0500 > > > > reproducing from -Q is a nightmare. your comment that it did not > > recognize the part of the window frame is what i want to focus on. > > the window containing the scala mode buffer contains tab-bar tabs. i > > am clicking in either a tab (on the close icon) or to the right of the > > tab list on the "open new empty tab" icon (still within the tab bar). > > how could that generate the input event? > > I don't know. That's why I asked for a recipe: to try debugging it > myself. If it isn't practical to provide a recipe, you will have to > debug it on your system. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 13 10:30:06 2021 Received: (at 51794) by debbugs.gnu.org; 13 Nov 2021 15:30:06 +0000 Received: from localhost ([127.0.0.1]:47911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mluyk-0000FJ-63 for submit@debbugs.gnu.org; Sat, 13 Nov 2021 10:30:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mluyi-0000EN-Sk for 51794@debbugs.gnu.org; Sat, 13 Nov 2021 10:30:05 -0500 Received: from [2001:470:142:3::e] (port=54092 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mluyd-0002GN-Lq; Sat, 13 Nov 2021 10:29:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IOajcUh+CB4e5xztyxyqPuX2DIqIXoJC5l5hMXUwsCs=; b=hXpoe4R7Tx6Q zq04Nmexhx1utd9JaQ/9+1QdzvNAw/VpwyBNXVmW1RzmLAR5vQuNqLGxuEPxJ2/0TZS95csyCd2hU luH6A22FJFGuVa1jm8oqiMPZzr6hmJvVXMKv+Ln7Oq3AD9QPT16YfdT6Ca8R0HamvLrDSz3TwjuZ7 wnrrMlPBFJ83cQjX9Os69XSN55Zq+fv6yk4T8GApIBWqUuuoPpxcWY1UFrxCEWKdr+tBmSUi93i20 +B0RpvpI6GoEb2USkWHZbVvrJfw2SXHqyUdnK9vR9ZpwAE4zI4QYx7lbPPSjk84axQWneOdeWlmiG VahL1tH8/UyQUni16Pay5w==; Received: from [87.69.77.57] (port=2218 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mluyd-0000LQ-AE; Sat, 13 Nov 2021 10:29:59 -0500 Date: Sat, 13 Nov 2021 17:29:44 +0200 Message-Id: <835yswxedz.fsf@gnu.org> From: Eli Zaretskii To: Mark Kennedy In-Reply-To: (message from Mark Kennedy on Sat, 13 Nov 2021 09:52:21 -0500) Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mark Kennedy > Date: Sat, 13 Nov 2021 09:52:21 -0500 > Cc: 51794@debbugs.gnu.org > > i'm willing to attempt to debug it myself but not via the -Q route. i > prefer to focus on where the bad input event stream is being created. > any suggestions about where to put an elisp or C breakpoint to go > after this? In keyboard.c, under "case MOUSE_CLICK_EVENT:", step through the code until you get to this line: position = make_lispy_position (f, event->x, event->y, event->timestamp); then step into make_lispy_position, and see what it produces. (I hope I got the code right; apologies if not.) From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 13 10:44:02 2021 Received: (at 51794) by debbugs.gnu.org; 13 Nov 2021 15:44:02 +0000 Received: from localhost ([127.0.0.1]:47939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlvCE-0000cF-9i for submit@debbugs.gnu.org; Sat, 13 Nov 2021 10:44:02 -0500 Received: from mail-ot1-f45.google.com ([209.85.210.45]:40544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlvCA-0000bZ-99 for 51794@debbugs.gnu.org; Sat, 13 Nov 2021 10:44:00 -0500 Received: by mail-ot1-f45.google.com with SMTP id v15-20020a9d604f000000b0056cdb373b82so10942338otj.7 for <51794@debbugs.gnu.org>; Sat, 13 Nov 2021 07:43:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4FlIZ9iODZC6DV2YyrwN6Ik+vpnEqqihkmaU0N7x/3s=; b=qka7z/Kk6ADsN44/mPW6q24L6qN1MsPO14ixetjQ6JsFFZC8m5PUBzG6R/GUUJ4ti1 q7lbipiRpZorhgjYahkBBpKJfXxFRR8xM1jhURaNTLpGdm7l3AFMAZb68RPINooAkapC /PbCCVnILaPR/l5nTLA1DHk3ZN5hvbEmuuFDQmLOfenlmNThiTOgppN+N+zZ00LgyYdn wERJM2FTMQolHqjPhnjgJU1PircYnXXGTz8Imqew6OnBzIlhiMNzNYUz6YqM38rBXCQF XfKaweoWysTR9U5zscWl+PrLSbtGNW7aaqn6gnyje6an6lcTQ4v4HSgJCpRQBD2ZbwpW eUOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4FlIZ9iODZC6DV2YyrwN6Ik+vpnEqqihkmaU0N7x/3s=; b=Ojfg5NSo7XLVlyJyEKQu0Vsl8QjrS4z1SXm9/gcLZ7GdMBpHiyXs6oCNvXTDUI+rPv wA0K57j96wRt1xhOQjzdorPUZL6YgYjQwmzs+tc2ciLtxYWuIq4ShADqUd78/IGcKcrI iSGVJcQyJUl/qT6ro4ofE+uuwteMdfHAkRKNHk76DV3r4F05UGVid6gde9r3emB+2ubs 7ct/YEsQxo59eN5PhpD+RSOlr1K4BfRrhbstNDi0WfBoXIh60PzBnymyk9iNw7oaXcDD ZKKilAJnM5a563BpQyCS1AuImTfJ08ZjR5kmsZs232qJueh6Rf6sc7iZ/Hwtr0fRgmvi LXaA== X-Gm-Message-State: AOAM5336MqNVYeVIuUrG46/63vwVPLy2fpYr9jcIS5zhkPAqJfA8KIBb Ek7gRu3Sjb2YEU3kZc39QleET5lcCK9Ye25/B/MGsQZ8ApU= X-Google-Smtp-Source: ABdhPJyFRSVuJJjQH73qxd+Nz5DcuK6/M5VoQ03q6vGDcmwBvbQDRhgMg6C3LwjAuYmSPP1VTzJywkis7rZHUn9waXE= X-Received: by 2002:a9d:6855:: with SMTP id c21mr19973563oto.357.1636818232047; Sat, 13 Nov 2021 07:43:52 -0800 (PST) MIME-Version: 1.0 References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> In-Reply-To: <835yswxedz.fsf@gnu.org> From: Mark Kennedy Date: Sat, 13 Nov 2021 10:43:39 -0500 Message-ID: Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000487adc05d0ad716e" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000487adc05d0ad716e Content-Type: text/plain; charset="UTF-8" Thanks, I'll check it out. On Sat, Nov 13, 2021, 10:30 AM Eli Zaretskii wrote: > > From: Mark Kennedy > > Date: Sat, 13 Nov 2021 09:52:21 -0500 > > Cc: 51794@debbugs.gnu.org > > > > i'm willing to attempt to debug it myself but not via the -Q route. i > > prefer to focus on where the bad input event stream is being created. > > any suggestions about where to put an elisp or C breakpoint to go > > after this? > > In keyboard.c, under "case MOUSE_CLICK_EVENT:", step through the > code until you get to this line: > > position = make_lispy_position (f, event->x, event->y, > event->timestamp); > > then step into make_lispy_position, and see what it produces. > > (I hope I got the code right; apologies if not.) > --000000000000487adc05d0ad716e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, I'll check it out.=C2=A0

On Sat, Nov 13, 2021= , 10:30 AM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Mark Kenne= dy <mark.t.kennedy@gmail.com>
> Date: Sat, 13 Nov 2021 09:52:21 -0500
> Cc: 51794@debbugs.gnu.org
>
> i'm willing to attempt to debug it myself but not via the -Q route= .=C2=A0 i
> prefer to focus on where the bad input event stream is being created.<= br> > any suggestions about where to put an elisp or C breakpoint to go
> after this?

In keyboard.c, under "case MOUSE_CLICK_EVENT:", step through the<= br> code until you get to this line:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 position =3D make_lispy_position = (f, event->x, event->y,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 event->timestamp);

then step into make_lispy_position, and see what it produces.

(I hope I got the code right; apologies if not.)
--000000000000487adc05d0ad716e-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 18 18:39:42 2021 Received: (at 51794) by debbugs.gnu.org; 18 Nov 2021 23:39:42 +0000 Received: from localhost ([127.0.0.1]:37402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnr0H-0002WD-Sl for submit@debbugs.gnu.org; Thu, 18 Nov 2021 18:39:42 -0500 Received: from mail-oi1-f178.google.com ([209.85.167.178]:39520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnr0G-0002Vw-61 for 51794@debbugs.gnu.org; Thu, 18 Nov 2021 18:39:40 -0500 Received: by mail-oi1-f178.google.com with SMTP id bf8so17942108oib.6 for <51794@debbugs.gnu.org>; Thu, 18 Nov 2021 15:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3XyCUrmog/LM/2wJSqdtbDk9GK63AicIJQjQZrd0p/s=; b=jDXFGcsqW4pycN4AwvUaC9G4DbXvMiGq1/4TJH2PtYxEkv3dcs1HoeDqIHZyyiCRAX blzMCAt8rD42KHVFI3x4MlN29WN+qaQtOBT+9Zng0Jc7qOeU3clgdPXelTe1osEgDK1s vI6V4iIzp9VvZK1ILPFDwnatq3r+IhPB3z32mI20d8uggVxM/nSQiBEuLa/A9PmytakL w1FE83k1tCzUSYyu16GBv39EiXlIDKB4eWoUBMVMWG9t+OsiBe2WkFUvO1WNq2ml8CSI Eu6YMeVC30usksIlO2W96Vx06t/ZR7c4BcxklWqCgZx1g6vb2j6BU4X9JJvTjHZ8ktfm QlCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3XyCUrmog/LM/2wJSqdtbDk9GK63AicIJQjQZrd0p/s=; b=o9/UO/yVnLGnJKOsxPy5+zVuZsRFiBBnowzii1kJtMdCjjmAXnZWdtPllMnjUuriFR 0sQ2Gfk6ZuA3nk1n2Tvubo27PuLk7feT7TmseInnyVBqlIdY4NtMO8lazDRSKV1dgRek izKIwMs4gXsXWvV78RG1wFyZX/U2k/4otKBH4KjSNyB34HyRgK7Jabx1Oe1gWDcvyFRF gPJY9poUhTmCrNOyEbAehkbk4ABMkh6AryKDeWP5JtKqXVvE4NXo5cjhKSGRo/8GhkFq l4qrqRP6bdDZrGYd5eQms/1yuvht0xdFNFr6upM+F1V+M2W2cKSrqiAA7gPbCjyTrjwq REtQ== X-Gm-Message-State: AOAM530myHrUC6rx7nrlb1plFSF/j1OfYf1ip7QgzwvfqeFjyH7WmXrr Ym3kROpdrU/of4RTY692mqEkSx0PpcQtuz/QydM= X-Google-Smtp-Source: ABdhPJzq+bHVzpZRh79YeJTwfVQZ1TP+4KuULmNwTgztBbta/zr593phhaFnZMVdq4lqjnSd2/LG2yOICAVVY92weEI= X-Received: by 2002:a05:6808:2081:: with SMTP id s1mr884861oiw.170.1637278774236; Thu, 18 Nov 2021 15:39:34 -0800 (PST) MIME-Version: 1.0 References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> In-Reply-To: From: Mark Kennedy Date: Thu, 18 Nov 2021 18:39:23 -0500 Message-ID: Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) bug fix #50993 is the bug. it made make_lispy_position skip setting posn to the tab_bar if track_mouse is non-nil. why track_mouse is nil for some frames and not for others i didn't look into. thoughts/comments? /mark On Sat, Nov 13, 2021 at 10:43 AM Mark Kennedy wrote: > > Thanks, I'll check it out. > > On Sat, Nov 13, 2021, 10:30 AM Eli Zaretskii wrote: >> >> > From: Mark Kennedy >> > Date: Sat, 13 Nov 2021 09:52:21 -0500 >> > Cc: 51794@debbugs.gnu.org >> > >> > i'm willing to attempt to debug it myself but not via the -Q route. i >> > prefer to focus on where the bad input event stream is being created. >> > any suggestions about where to put an elisp or C breakpoint to go >> > after this? >> >> In keyboard.c, under "case MOUSE_CLICK_EVENT:", step through the >> code until you get to this line: >> >> position = make_lispy_position (f, event->x, event->y, >> event->timestamp); >> >> then step into make_lispy_position, and see what it produces. >> >> (I hope I got the code right; apologies if not.) From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 19 02:01:25 2021 Received: (at 51794) by debbugs.gnu.org; 19 Nov 2021 07:01:25 +0000 Received: from localhost ([127.0.0.1]:37754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnxtl-0001ET-CI for submit@debbugs.gnu.org; Fri, 19 Nov 2021 02:01:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnxtj-000199-N6 for 51794@debbugs.gnu.org; Fri, 19 Nov 2021 02:01:24 -0500 Received: from [2001:470:142:3::e] (port=52140 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnxte-0001dw-Af; Fri, 19 Nov 2021 02:01:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uHQs6AJ6yWJUDQAGOeaPn5CoAvLnvb+OnSOmNgShs7c=; b=Q/BPEzK20D8C iRxRtUnZEkcQxKMAT51f7Hgt4Lxpqh8+9G+GP6q47TrLkquYJP1j6CV9bfv+6iLJM6Y5f1EVMWgt0 s11vbxMnL848TIsjtnb0SQDEjJ6f6smTo0Fl11ljlljFVvM7ymC1fC43yMf+4CAyWBC+VkFtt98td uJqjL4tmPUj+xjkaO2OrBsmL94P7LF5FV4O9pdxo242y0LL9zQoyzXGALqrtTbVUB53yGQSeErDcT O75Grk+x+R9YXHb/Awn1+6ttpLPF7MMX5YRyGduXrIhVNngWceuc1khoWj345bu1Wj/wmd7e4JLWa oufBqShCHkI+Z+LMwp6yXA==; Received: from [87.69.77.57] (port=4514 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnxtd-0006Iw-SZ; Fri, 19 Nov 2021 02:01:18 -0500 Date: Fri, 19 Nov 2021 09:01:16 +0200 Message-Id: <83pmqwwrwj.fsf@gnu.org> From: Eli Zaretskii To: Mark Kennedy , martin rudalics In-Reply-To: (message from Mark Kennedy on Thu, 18 Nov 2021 18:39:23 -0500) Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mark Kennedy > Date: Thu, 18 Nov 2021 18:39:23 -0500 > Cc: 51794@debbugs.gnu.org > > bug fix #50993 is the bug. it made make_lispy_position skip setting > posn to the tab_bar if track_mouse is non-nil. why track_mouse is nil > for some frames and not for others i didn't look into. > thoughts/comments? Please do look into that last part, because we need to understand the situations in which this happens well enough to devise a solution. We don't want to revert that fix because it will re-introduce a larger problem. Specifically, why does this happen to you only under those customizations and not in "emacs -Q"? Martin, any suggestions? From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 19 02:54:24 2021 Received: (at 51794) by debbugs.gnu.org; 19 Nov 2021 07:54:24 +0000 Received: from localhost ([127.0.0.1]:37887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnyj2-0003f2-4P for submit@debbugs.gnu.org; Fri, 19 Nov 2021 02:54:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnyj0-0003eq-Oj for 51794@debbugs.gnu.org; Fri, 19 Nov 2021 02:54:23 -0500 Received: from [2001:470:142:3::e] (port=53772 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnyiv-0000rr-8c; Fri, 19 Nov 2021 02:54:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=guLSpfUjZNiYdHTNVUWISJI89zaClXCtyd2FfCV3M9o=; b=O1SvzFk0Gxj7 9r4xnjtcdTJOIHX+HeTDJVDmuH8xRknyfPa6ARJUwODPvsdpb6p9neMdJnxVHeVwPHgGGn4RlSzTd CuI1yVx95bHwtw4RF4TkOukT3NBp2cnLsYH0ZMugtnLfke1j0u2LmQW9nDjbonb7fKo2yPTq+3x7D vimhq2noMONVUZ2gwHbDeqtftYPiXMbTCvuBnGT0l3ZtDC/NMufhs2+PxRs38UQQpgRnSPuZHjG2j s8JY4kl5zIwJHhw4idtwWCj/PG7cRUhRsA/yanEC7JImAOLuDYLJIa18xul83xw8LfH9EpwowEGE4 iedIA23DgOChyWCNF1eoyg==; Received: from [87.69.77.57] (port=3766 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnyiv-00064i-1f; Fri, 19 Nov 2021 02:54:17 -0500 Date: Fri, 19 Nov 2021 09:54:16 +0200 Message-Id: <83a6i0wpg7.fsf@gnu.org> From: Eli Zaretskii To: mark.t.kennedy@gmail.com In-Reply-To: <83pmqwwrwj.fsf@gnu.org> (message from Eli Zaretskii on Fri, 19 Nov 2021 09:01:16 +0200) Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> <83pmqwwrwj.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51794 Cc: rudalics@gmx.at, 51794@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 19 Nov 2021 09:01:16 +0200 > From: Eli Zaretskii > Cc: 51794@debbugs.gnu.org > > Specifically, why does this happen to you only under those > customizations and not in "emacs -Q"? Could it be that some package you load enables mouse-tracking? if so, which one, and for what purpose? From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 19 04:27:03 2021 Received: (at 51794) by debbugs.gnu.org; 19 Nov 2021 09:27:03 +0000 Received: from localhost ([127.0.0.1]:38021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo0Ah-0008LW-Be for submit@debbugs.gnu.org; Fri, 19 Nov 2021 04:27:03 -0500 Received: from mout.gmx.net ([212.227.15.19]:48097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo0Ae-0008L0-LL for 51794@debbugs.gnu.org; Fri, 19 Nov 2021 04:27:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1637314014; bh=IV0SUYxdJqTxkdT3WT34u8ye6G7w4lK+4cD9tFAOAc4=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=QtMPdeZxU/6NkQ0pDJW1zzY/uybmTf+7M0ZGbqZQab1kQIgkcMurZDyosCbmKKgHz lvOmGMNmD77+mlHO2HMTNwl0S9aTl+sK/svErRycSihFUaJ7b7Z5hnWmFMUOgevR/I XJZraWrU2ixszMqZ0/vlz4GzRvR5y45q8YlwH1n4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([213.142.96.197]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MkHQh-1mPcaF0bs1-00khgK; Fri, 19 Nov 2021 10:26:54 +0100 Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar To: Eli Zaretskii , Mark Kennedy References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> <83pmqwwrwj.fsf@gnu.org> From: martin rudalics Message-ID: Date: Fri, 19 Nov 2021 10:26:52 +0100 MIME-Version: 1.0 In-Reply-To: <83pmqwwrwj.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------102B1983BFF77B68711102E7" Content-Language: en-US X-Provags-ID: V03:K1:HFFHmgj7ikvdbUC21ZpoGTy/manipBpju8Ug2zkWwQA0kgCLgEn t/oVm9VseCmf6MuJLVfNqJOFlKYKviPwka+FasEDLor7FIqMVssySu9PsWNETk05MhDcd5u ZlO+swr4HYiGeUJxOZLAsowA1Ytkm7ne2vXQVT9fNGXxGeBvP8hYKgU+Y+5co4AsDFI72LA m3Uoqsjefjb1Sti9QBkng== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:jN1AGXCQfOM=:PZXUXlOP2d1mEpf+V5dmVe vNvqYN1+BuODnjXog27bwMxhnkXIgPxgoHcBVKaz0LpjUXL7OrHSW3QLj9CV7QJDtPfUbYMdy 6G9SqNgmJwtFHDC4e4HKimeo1z2KpI/2KYFpOxze9nRkavUKqLUQnDdwwXI4+JXpA2KVCEocO MziVmDPkxtFq6rvNwZJfzwqsJtRLWhfQHZJsjHHuQBamGSbuy/NEUNlPfd5y25kRU0k1idppv tPkfyHLvGLrNrOtvnI6O2kForspZx/2tqX93kEPkfdPP2RkWB1j08JMcZoBfJZOKgaZoutWw0 u9uc2mbBczLqzTOnFeQGXnGvWeu2YKzXoE8OoSl5umGO2Ngoj7WtsU5V0HmyyFBxK6zE4BZIr 3HDv67WJRpap9ER56m76D66bjLUOj3yn+lFZXq8oimBzq3Q+cgl8cgqC+8OfqTeAGyjeailRN DnJKOYHU4vY0xnsC7Y3gjzoaM2pMovKQ1fc1IwXsNSui2P3xK7zgYw0Jxo3K1l/GVwQ28rTp5 CNT3LFSttd/f1c/Aibt+22XUaxhz7K+yL90SNPXqYUGn1+za97CZFSV6yGNova/ZswWrghZWc J7R2Kx5nySsZPnYD4rMIF6rmUAtQclzMYbcs/OF4GADGbUjjnHiVy4F4cFw950qKD//ZJtUFG z7Ny3n23X8ztHqSEmHVtEUKlc3xr5JpBjYp9OHj4iH63rYVZFhCToK4B/4jY85x/VFTpT3EF1 3/T2mMp6nsY1lKULocMWvpXrhAQ2dlk8Zfzt18sbWxWUCVXX71K0ZlnjySwNa5m65toK7Hrdm nlxj0f0XhZLGsoEau8+cDHwmOypOpUIQm5wzx/hEOSpWbNEekpSMN0GNIABy1V2CctiGM8CbB P4GKvmki428AVnZB+fI3H3HD5WjrH0Nkk9Umpw8BKLZKSBgbaqMIplJD0kMAyYIOuRYFGS6ao kdZWQcE51YtBIQ2wuGL4IxgaZxX4D7Q2c0pHdarDTN7MQaNM6LO3BHG7f9BOLTNHNXtJBMuvt w3yUcCeGrR2wVc4wpcjyZQ1sLNdL4T4YnGMFP7YkG0meLQ8dXhW9f/MmHugT8yxOAPR9CVWcH vDKXjlxX8NYKWU= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------102B1983BFF77B68711102E7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit >> bug fix #50993 is the bug. it made make_lispy_position skip setting >> posn to the tab_bar if track_mouse is non-nil. why track_mouse is nil >> for some frames and not for others i didn't look into. >> thoughts/comments? > > Please do look into that last part, because we need to understand the > situations in which this happens well enough to devise a solution. We > don't want to revert that fix because it will re-introduce a larger > problem. Specifically, why does this happen to you only under those > customizations and not in "emacs -Q"? > > Martin, any suggestions? Maybe the attached patch helps. martin --------------102B1983BFF77B68711102E7 Content-Type: text/x-patch; name="track-mouse.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="track-mouse.diff" diff --git a/lisp/mouse-drag.el b/lisp/mouse-drag.el index ecfb359b36..98e18a5c86 100644 =2D-- a/lisp/mouse-drag.el +++ b/lisp/mouse-drag.el @@ -282,6 +282,7 @@ mouse-drag-drag (setq window-last-row (- (window-height) 2) window-last-col (- (window-width) 2)) (track-mouse + (setq track-mouse 'drag-dragging) (while (progn (setq event (read--potential-mouse-event) end (event-end event) diff --git a/lisp/mouse.el b/lisp/mouse.el index 7bac6dd07b..c94862d01b 100644 =2D-- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -1615,7 +1615,7 @@ mouse-drag-track (goto-char (nth 1 range))) (setf (terminal-parameter nil 'mouse-drag-start) start-event) - (setq track-mouse t) + (setq track-mouse 'drag-tracking) (setq auto-hscroll-mode nil) (set-transient-map diff --git a/src/keyboard.c b/src/keyboard.c index a99d14cb4c..abd9635a92 100644 =2D-- a/src/keyboard.c +++ b/src/keyboard.c @@ -5136,7 +5136,7 @@ make_lispy_position (struct frame *f, Lisp_Object x,= Lisp_Object y, This issue should be properly handled by 'mouse-drag-track' and friends, so the below is only a temporary workaround. */ - if (NILP (track_mouse)) + if (NILP (track_mouse) || EQ (track_mouse, Qt)) posn =3D EQ (window_or_frame, f->tab_bar_window) ? Qtab_bar : Qtool_bar; /* Kludge alert: for mouse events on the tab bar and tool bar, keyboard.c wants the frame, not the special-purpose window --------------102B1983BFF77B68711102E7-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 19 08:18:39 2021 Received: (at 51794) by debbugs.gnu.org; 19 Nov 2021 13:18:39 +0000 Received: from localhost ([127.0.0.1]:38395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo3mo-0005VI-VK for submit@debbugs.gnu.org; Fri, 19 Nov 2021 08:18:39 -0500 Received: from mail-ot1-f42.google.com ([209.85.210.42]:43765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo3ml-0005UU-Dk for 51794@debbugs.gnu.org; Fri, 19 Nov 2021 08:18:37 -0500 Received: by mail-ot1-f42.google.com with SMTP id h16-20020a9d7990000000b0055c7ae44dd2so16757729otm.10 for <51794@debbugs.gnu.org>; Fri, 19 Nov 2021 05:18:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YYj1dshkyU1SM4kIiZyCVakqUmsB3AkXesXEUhYGVCs=; b=msZEa1KhhU7BVsSICgVsM/pbi/woMf6N5xyAO+hrTrUE1kMsfqUOuu8ehKufjfu1ME p53uvTrjGkQt9z7Y3wcg8izSeGbJ1gdCCkdUac4gmYehllFP484dA+EJ5JzdGu6ycch2 uZu+isZ3G+qaVe+N6ycA3Aw7JuyJaPKoita1Zme7xprAXEL5H5HfoN75QD5Qoc/Fz33r TFGxgE/qh5oQAKmRemm6fqUmKgl1se+aQCbZZypxz3tW7K7gFUc9rDYW3jf3JQh89oLM WFUpgSvAymbPNxapavuhHRlbaNta6ZCJr2Iqlbm+cnt9rr8at8nzzehePhtqQnVMvl0A Pmlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YYj1dshkyU1SM4kIiZyCVakqUmsB3AkXesXEUhYGVCs=; b=x+FuXGevZ7FZfHAU1B4BsTWPRngT6SjPOiDIHhBkezuLC7sFuWhd1Jq6pE6XrW+OnA kTYLsRQUsL6lPAaUmEUxoBcYX/LRivQsmvaPfO5MTDEkT2ntUzjmJGJwrr/m3RvmcsB2 W0bv+PlDGffyJUzdH08meo/cGRKizwY+BqIje+l7CE8t/EuFbIOtngEIwf2iXNhuQAQh uZdLE3DV+7LhHnS8atx4VbL80dOKxpKKrPQ5lbw7xsu5crnqXWWVLmr8YH8REC+KUonZ zzbhOa1DAthmeajr5oseLQVM2nzTPFNZHjRrO4rJAe+sDwhDhn4mB9T8lVO1oIrp09JS xa2g== X-Gm-Message-State: AOAM533vn0b1B94bzzuxvD6EbNxW08OfPzbuUqnTFnuBAcANs3+IA902 fkXZcJR0Ze7jW3f6XLvGV2fZyaKeC2gChCBVzLk= X-Google-Smtp-Source: ABdhPJz4/XHXli3jCUCzrwODAQyfpH8OYV1t4Vb/y2GkX0XQyZRAQbc9uzh61gcLhOV0kL35tOXX1BbTlhftmN8HdE0= X-Received: by 2002:a9d:6b87:: with SMTP id b7mr4662050otq.204.1637327909802; Fri, 19 Nov 2021 05:18:29 -0800 (PST) MIME-Version: 1.0 References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> <83pmqwwrwj.fsf@gnu.org> In-Reply-To: From: Mark Kennedy Date: Fri, 19 Nov 2021 08:18:19 -0500 Message-ID: Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar To: martin rudalics Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) that patch fixed the problem i observed. thanks to both of you! /mark On Fri, Nov 19, 2021 at 4:26 AM martin rudalics wrote: > > >> bug fix #50993 is the bug. it made make_lispy_position skip setting > >> posn to the tab_bar if track_mouse is non-nil. why track_mouse is nil > >> for some frames and not for others i didn't look into. > >> thoughts/comments? > > > > Please do look into that last part, because we need to understand the > > situations in which this happens well enough to devise a solution. We > > don't want to revert that fix because it will re-introduce a larger > > problem. Specifically, why does this happen to you only under those > > customizations and not in "emacs -Q"? > > > > Martin, any suggestions? > > Maybe the attached patch helps. > > martin From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 20 03:03:10 2021 Received: (at 51794) by debbugs.gnu.org; 20 Nov 2021 08:03:10 +0000 Received: from localhost ([127.0.0.1]:41572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moLL4-0005nA-4I for submit@debbugs.gnu.org; Sat, 20 Nov 2021 03:03:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moLKz-0005ma-Ou for 51794@debbugs.gnu.org; Sat, 20 Nov 2021 03:03:09 -0500 Received: from [2001:470:142:3::e] (port=60020 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moLKu-0004LD-EW; Sat, 20 Nov 2021 03:03:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=F4XvITd/0Xlb8KIBTmngaxP1aXd3wN5zRKLygi9tmkw=; b=ZShkhqMMGA65 hdlzAK+MInSjuXeYiVz52Wr5SpUQtK+4K5WgsJ+6pyjSBRfI3UnG8JtSiZxkCQQWYcMsAc2ysTQwo hIlsPUJf8ZXGH7ExfXpybk906vQmkJoQNA3hjW4IW7fqGhtKa6xzepDHTGmIRtwUqmZsr6GyMloMo Wezakqm1M1VTV/2Cv3IR6Mnk5sf5Eu+Otfr7Z/GU3gIlm0XaccHo7tE0x5WOrH6fOZSC1f2tfpMUy hmOcqOcsedIWOv+i2kZtvB5c0R6PuBeiOt9mpikckmr6fwvfdW4WW+TmQBmkWkMFsBDZ0F5cRVocw oTnV+Fp16Vj1WsAQaPcIig==; Received: from [87.69.77.57] (port=1233 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moLKt-0001Es-FZ; Sat, 20 Nov 2021 03:03:00 -0500 Date: Sat, 20 Nov 2021 10:03:02 +0200 Message-Id: <83h7c7tft5.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: (message from martin rudalics on Fri, 19 Nov 2021 10:26:52 +0100) Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> <83pmqwwrwj.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org, mark.t.kennedy@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 51794@debbugs.gnu.org > From: martin rudalics > Date: Fri, 19 Nov 2021 10:26:52 +0100 > > >> bug fix #50993 is the bug. it made make_lispy_position skip setting > >> posn to the tab_bar if track_mouse is non-nil. why track_mouse is nil > >> for some frames and not for others i didn't look into. > >> thoughts/comments? > > > > Please do look into that last part, because we need to understand the > > situations in which this happens well enough to devise a solution. We > > don't want to revert that fix because it will re-introduce a larger > > problem. Specifically, why does this happen to you only under those > > customizations and not in "emacs -Q"? > > > > Martin, any suggestions? > > Maybe the attached patch helps. Thanks. Please install this on the emacs-28 branch, but please add comments explaining why we need this special symbol. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 20 03:49:05 2021 Received: (at 51794) by debbugs.gnu.org; 20 Nov 2021 08:49:05 +0000 Received: from localhost ([127.0.0.1]:41637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moM3U-0007Ol-To for submit@debbugs.gnu.org; Sat, 20 Nov 2021 03:49:05 -0500 Received: from mout.gmx.net ([212.227.17.21]:35113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moM3T-0007OA-BL for 51794@debbugs.gnu.org; Sat, 20 Nov 2021 03:49:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1637398136; bh=5xGpiE3+2Z2Y7FndL5CluIc0N6Vp6IrGiJ8tXK2QtYE=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=PrsDNsORcC5JPdmKVoZICKJppwEJudndGKBqdGbih/rHKWLP65XwzjNaV9dKUwgpT 4rzp1mrHMYIv6+xseOpodmcjCjG6Soux7M80oX/Zl5bskdfT8jK2e519KR3L1iKeSr BLd77eukpEX3W/587DwYA3hML8P9DScwYrv8xLPU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.5]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M5QJJ-1mpj6D3ASj-001VVD; Sat, 20 Nov 2021 09:48:56 +0100 Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar To: Eli Zaretskii References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> <83pmqwwrwj.fsf@gnu.org> <83h7c7tft5.fsf@gnu.org> From: martin rudalics Message-ID: <6ceafce2-eee9-5d93-6300-1f1b430b3f65@gmx.at> Date: Sat, 20 Nov 2021 09:48:55 +0100 MIME-Version: 1.0 In-Reply-To: <83h7c7tft5.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:LCpnF0tN8B7UrudC31deEs93o6v+iAYjEdqbQ0CMDFdHTYTv62X fbP/WWxipL6muippF89yfPP90q0AJnNwaCSF0QzTbTccXp1WW1fHY88zfpvSiUdoB+KzmhE Sda621rBIrLc5XYaeookhQXd0d0iFccuqtatMxJb/1sCR96b2vIWFWMdx21yyphnhmZ5ZMQ QbSg5oFfr64iN5zAfCAKg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:RprHQUFCxvo=:VaT0nRRJULZzEVZYKLyML1 Zs58wntFcgeIMAs4ybISU4eaLF+4vIUZ1yOQhf4pmvNR4M5vVVaVSrwNolTdCsMMdeb2hgZhE QfVvAg2ILCnTi1TJ/k5jXK593DfGh9U0n9k293O7JXIXGW4PiocCi+BQrN/R8445R7+4njCbm +oakl3hSKd2ilZCo5V7aRyAAIlBGVHvaabRtbeExgy5a8JSOIWJCTcJ1x6KtJdHq3nAZPkE5I QBm9hydMIonTMzITwJrO6kL8PJksLhKXSyxdFCTNUqjqWtVUzxHqivHXfEojvkXzx/BnU/Tfc YT148AWrdEY4lr3Ks3InKV05+/DrUi8Xuk9vtSg53kcmcEZ3Y/HjKPAiMugsrkhqh/yUTpBHB rKNGFwh8NlOf7t/6LpWNNooERtJTX2ouNjYLKL0CKVvQOH2djxK+GgMxqYCSk2UAKnQclx5en rmxuROoMEtro4G/ITo6PnAPLJYrrHg0zrt/BiGZoxCyXuk5Ka+gdmSIKinX6+i8298V+dt1Df 311ltSq3IMUkKGwKZ1fpuhqEHAQ+kxUw0KNX9wkbQ/8nhqkWX2EMPaqcf866tjyDwS01y+fIO dOVw3xOAUvWK639jE2o9QZElIpOQlkLRpe9AmMQwXyI38nHZh478YFm7SUoMbAwfz+yl7I3uT VEFqCH9yAgr24M+ff8v7B06UGVJG33UP+mWGtqbbNN0iKVk0mYLWAzi926JlnGPnGd/Dmz2zC aGrXbrD9YhECRuOKVhdlMDM4/FqS5dFH5qHNGXbF/p/RnRacQzNiUVYWcjCPa51jURriLCPGW 10fxJZlc438ebUZCLuXpu1uLVUS66ki7Qi4EK3E9G5oIEHhlOml4WStLeBa0mVwzZOnPWvZWP 0aNA+QWDixOWkY2Z5gN1WLmGUZfBksuj+QMoTl5CceWxM/V8RwJllZpTgdx6dlCKWawg9IPnb PSzpVuAnqGY97jqNd3ipQUp9ie51ifLmMumsTuVrxfNSU2dPB+Yw/fZjr5R/Q8/GeyEj+izNk IzLYJ32UKBVDmZvJmTADkmJ+WYn04Odt7dQwjVv9j6YfH7fYSq2PMQeDDum1IoxQcEBY66tQz +hbhkGIMvLtXnY= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org, mark.t.kennedy@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Thanks. Please install this on the emacs-28 branch, I'll try to do that. > but please add > comments explaining why we need this special symbol. We don't need a "special" symbol, anything non-nil but 't' will do. I'll add a comment in that sense. martin From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 20 04:07:37 2021 Received: (at 51794) by debbugs.gnu.org; 20 Nov 2021 09:07:37 +0000 Received: from localhost ([127.0.0.1]:41655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moMLR-0007vN-7v for submit@debbugs.gnu.org; Sat, 20 Nov 2021 04:07:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moMLP-0007vC-Rb for 51794@debbugs.gnu.org; Sat, 20 Nov 2021 04:07:36 -0500 Received: from [2001:470:142:3::e] (port=35028 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moMLK-0001ED-GI; Sat, 20 Nov 2021 04:07:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=znBb284gR0BLOlM4Kza0nyksyW7UJNlsgeVoO2GuSbU=; b=aYXauh9Gvq1m 1r+MvT+BnV5bAOj5rw/HBdVwaOTpi4/PJ6wHLK/sCFO3k9kYE4ZFmXtyqqPmTiSZD4CTqF3Ld93tk BisGSDpBubn+3eRuCJsZZ1rXwu69w7EsdGPCu6ghZZtBlLVEEBUbq4ymBRaxpklW863tvKfqiCEHM uOL4blgDN8vyfJs68yS9r9g5LtUrgTEAgetBPe85dCFVuawFJ7NPJ4/zdUKUpCWdZWxwy5gV2nGm4 isA+JfbNmcC5y1PZOb+l13GUEG/9mSHwZDHpXhMKupaOX2wos9O+LImYJ+cdxkm0nh8WJnoLO1Q+3 zK2G15FpfH5H7ykex/EMIA==; Received: from [87.69.77.57] (port=1201 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moMLK-0001Bc-5s; Sat, 20 Nov 2021 04:07:30 -0500 Date: Sat, 20 Nov 2021 11:07:32 +0200 Message-Id: <838rxjtctn.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <6ceafce2-eee9-5d93-6300-1f1b430b3f65@gmx.at> (message from martin rudalics on Sat, 20 Nov 2021 09:48:55 +0100) Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> <83pmqwwrwj.fsf@gnu.org> <83h7c7tft5.fsf@gnu.org> <6ceafce2-eee9-5d93-6300-1f1b430b3f65@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org, mark.t.kennedy@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: mark.t.kennedy@gmail.com, 51794@debbugs.gnu.org > From: martin rudalics > Date: Sat, 20 Nov 2021 09:48:55 +0100 > > > Thanks. Please install this on the emacs-28 branch, > > I'll try to do that. If you have problems, please post the patch and I will install it. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 20 04:56:30 2021 Received: (at 51794) by debbugs.gnu.org; 20 Nov 2021 09:56:30 +0000 Received: from localhost ([127.0.0.1]:41749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moN6k-0003Cq-Do for submit@debbugs.gnu.org; Sat, 20 Nov 2021 04:56:30 -0500 Received: from mout.gmx.net ([212.227.17.20]:49631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moN6b-0003CT-SJ for 51794@debbugs.gnu.org; Sat, 20 Nov 2021 04:56:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1637402174; bh=2g3t79eSRncuzg6p2mgfrNJvGZ4FwKXJnqd30ePOsi8=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=TdebA6IA8g6aVMWlerepqmcbQfLgCxWqYcWsvySjR0uVZeDUOEAm9AtiksarHcp8e rPjZNlCxsGJrVXTJpQm2BVJ5bDf7R/CIRLq5zK+V6N1Duk5qxPoownkSUeApmMUu+8 4LuvE89/j8wTkuHfrWpqhMEJ9pNaqoLwd41iC8nM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.37]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MWzjt-1n8RD51AUL-00XH1s; Sat, 20 Nov 2021 10:56:14 +0100 Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar To: Eli Zaretskii References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> <83pmqwwrwj.fsf@gnu.org> <83h7c7tft5.fsf@gnu.org> <6ceafce2-eee9-5d93-6300-1f1b430b3f65@gmx.at> <838rxjtctn.fsf@gnu.org> From: martin rudalics Message-ID: <87028c49-bee3-4246-c812-f385124be815@gmx.at> Date: Sat, 20 Nov 2021 10:56:13 +0100 MIME-Version: 1.0 In-Reply-To: <838rxjtctn.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------494034832B2E95933AFC1C74" Content-Language: en-US X-Provags-ID: V03:K1:yEkmZA+UFvif+zvNvJynSJwm6tGfiR6mueBPN7QfBgwzBGaMGk7 b5gNPuqmCb72NLNlrzZ6I5JF0NJc6AvzwV1g6LJKd6sJ3zNa3qGp75UF4SxNTvs27tM7sGa HvFembnWZh7ntcb833Eh3lSfaNROZ8sBak53oGsHv6F+UT6kwSFtwvRGdDfDlCnXhDzabVU DiAaZPpk4r2VKAYbalrTA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:yq30xI5ulu8=:tt2aZVlk2NkfIjOBKyk55R n63e9T6ykKVtIzCRNM+3LKyiUJj9H86VZ9KyGIGoCeMvaf1AbCTZOWn45To8jVQFo9TgBsgXw YAfEwEnqH/o6FE1VX3pUJvokIBT7u8A33fScKpKFKfUFif5G9bR4gO2NGni/nvdr8+hq11Y9e eewq7tjTfI29Fhh5crfIqg9WL3bveEaXa4ctN+7fIYX9Gparf1+pFUf3RG6dMXYsmlGHEAmGN 5t+lBPo1ZaURhKYF6Xsxzd7Lqd2yxPWnoMR4/O08EdfD76wZDX8iXY8auUHi4GAxAMnLh38ys EUarrsYVrkV01DkdMPpS0Oua14IF9nLXhIN9VWR6VRfUlPb529fw7OR0+7X9RWLgc6dson6NL VcluwvfcnTEjzNjfwwbZmCu67GNqBd+bScaSdgIF3XzjVPSAptwo3dS4X9mWWnt9i4+vkZw3/ sP1qE2vSF/Jey59Rz9x9LNI0+wu9+2paX/TF8AHx34PZKYlIepdY9ZhgZ7MK/LySK1Izdbu2/ vinzkQAuNcAhWHPT6n2UDy6KDgNSyYTsMMptKUOP6hcbr1CEBCOjQXy1yOMlvj8yEE92qDLAW gZ0wk5N4NlWmkGLYBYrZHKa7QyCA1mYbZkGee65smOyINxWFNBc8u58lRg0oFU/8ABZsQrpY/ J5Jw3rVR8zdayOCd9EA6+ermRiqgV/0AQSQ5mQjlA7GVVefxTFuk2ycwlD0+EOZzNjmAD2EqL xUVpf6C3kq/fO7v8WN/Vx+KM+jxRzAQ/FZLjxrlDYLoRU/L73xe4Df+Mcwwd7dX3COVsxbuw7 0DDCgfvZYhuPEeQ1Zu7sBuZXDQfWjArhM1hisq+hYpJXj2DbIYlXux4ZiSupesOIZ2kLDxXkS vwiV1VyztIMuKlHN1SSYqdiHAuabGxw+jV61rABVQLCJGN5J+cRPetTo2XtylgnJgSlO5NtYi RR3ltEU3TjudWVa1E87FRHcRemM8TJuzkzbytq4gREeyVxtE50PIdcZ17UDBSCphFJsZ50uON BCjtYGmkUSPXmY+ifz0UJ4+LmpQeMYYwZDCaOrex0Hsy1DtKRS/xwnZirLtN5l9Or+KexcCuI bRT43HyA6nxSVs= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51794 Cc: 51794@debbugs.gnu.org, mark.t.kennedy@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------494034832B2E95933AFC1C74 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > If you have problems, please post the patch and I will install it. Attached. ChangeLog would go as: Report mouse events on tab or tool bar when 'track-mouse' is t (Bug#51794) * lisp/mouse.el (mouse-drag-track) * lisp/mouse-drag.el (mouse-drag-drag): Set 'track-mouse' to some value neither t nor nil (Bug#51794). * src/keyboard.c (make_lispy_position): If track_mouse is Qt, report event on tool or tab bar (Bug#51794). Please fix everything as you see fit. Thanks, martin --------------494034832B2E95933AFC1C74 Content-Type: text/x-patch; name="track-mouse.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="track-mouse.diff" diff --git a/lisp/mouse-drag.el b/lisp/mouse-drag.el index ecfb359b36..0cdba6b4d0 100644 =2D-- a/lisp/mouse-drag.el +++ b/lisp/mouse-drag.el @@ -282,6 +282,8 @@ mouse-drag-drag (setq window-last-row (- (window-height) 2) window-last-col (- (window-width) 2)) (track-mouse + ;; Set 'track-mouse' to something neither nil nor t (Bug#51794). + (setq track-mouse 'drag-dragging) (while (progn (setq event (read--potential-mouse-event) end (event-end event) diff --git a/lisp/mouse.el b/lisp/mouse.el index 7bac6dd07b..8497c50363 100644 =2D-- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -1615,7 +1615,8 @@ mouse-drag-track (goto-char (nth 1 range))) (setf (terminal-parameter nil 'mouse-drag-start) start-event) - (setq track-mouse t) + ;; Set 'track-mouse' to something neither nil nor t (Bug#51794). + (setq track-mouse 'drag-tracking) (setq auto-hscroll-mode nil) (set-transient-map diff --git a/src/keyboard.c b/src/keyboard.c index a99d14cb4c..451863a28a 100644 =2D-- a/src/keyboard.c +++ b/src/keyboard.c @@ -5124,19 +5124,20 @@ make_lispy_position (struct frame *f, Lisp_Object = x, Lisp_Object y, #endif ) { - /* FIXME: While track_mouse is non-nil, we do not report this + /* While 'track-mouse' is neither nil nor t, do not report this event as something that happened on the tool or tab bar since - that would break mouse dragging operations that originate from - an ordinary window beneath and expect the window to auto-scroll - as soon as the mouse cursor appears above or beneath it - (Bug#50993). Since this "fix" might break track_mouse based - operations originating from the tool or tab bar itself, such - operations should set track_mouse to some special value that - would be recognized by the following check. - - This issue should be properly handled by 'mouse-drag-track' and - friends, so the below is only a temporary workaround. */ - if (NILP (track_mouse)) + that would break mouse drag operations that originate from an + ordinary window beneath that bar and expect the window to + auto-scroll as soon as the mouse cursor appears above or + beneath it (Bug#50993). We do allow reports for t, because + applications may have set 'track-mouse' to t and still expect a + click on the tool or tab bar to get through (Bug#51794). + + FIXME: This is a preliminary fix for the bugs cited above and + awaits a solution that includes a convention for all special + values of 'track-mouse' and their documentation in the Elisp + manual. */ + if (NILP (track_mouse) || EQ (track_mouse, Qt)) posn =3D EQ (window_or_frame, f->tab_bar_window) ? Qtab_bar : Qtool_bar; /* Kludge alert: for mouse events on the tab bar and tool bar, keyboard.c wants the frame, not the special-purpose window --------------494034832B2E95933AFC1C74-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 20 05:09:01 2021 Received: (at 51794-done) by debbugs.gnu.org; 20 Nov 2021 10:09:01 +0000 Received: from localhost ([127.0.0.1]:41770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moNIq-0005mF-Ro for submit@debbugs.gnu.org; Sat, 20 Nov 2021 05:09:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moNIo-0005ly-4o for 51794-done@debbugs.gnu.org; Sat, 20 Nov 2021 05:08:59 -0500 Received: from [2001:470:142:3::e] (port=39902 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moNIi-0004Yr-MK; Sat, 20 Nov 2021 05:08:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QHYf1Lzpp7lKNl7VTN3qKtMTB3Cr+m7orZFyhDHsdeE=; b=nJo8cCl1mIWT +TzK6duvkZbSzPfjjd+fTCtethW/0omrEaBVJS2O5ik/EaR1TKYCRC+aJkxyzWEdtv2Bz/hdEMAEN a8IedO7TZeEUtAJLEhjUSz4pmk+X931bT4LpzT2aOdswekQN6RiktQHSyqV/nIlWOqG77mLKzoDzK 7RgvcbbPPFIsPv48LD8vADKBW/sF53sWowXu1CuHzQzmpsDucKAmBn/wjm0Kro6Ln1SD0gAatMVDn RsxwS+JyXVT4tkVUVgB85yC3Dg7VpmQVj52BsqyP3nxG9OanEB2w73Vqjxy3+Ruad05jHQwJDQeSe G6ld7xuWOLhw1DKG069kmw==; Received: from [87.69.77.57] (port=1036 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moNIi-0003Qx-Bg; Sat, 20 Nov 2021 05:08:52 -0500 Date: Sat, 20 Nov 2021 12:08:54 +0200 Message-Id: <831r3bt9zd.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <87028c49-bee3-4246-c812-f385124be815@gmx.at> (message from martin rudalics on Sat, 20 Nov 2021 10:56:13 +0100) Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> <83pmqwwrwj.fsf@gnu.org> <83h7c7tft5.fsf@gnu.org> <6ceafce2-eee9-5d93-6300-1f1b430b3f65@gmx.at> <838rxjtctn.fsf@gnu.org> <87028c49-bee3-4246-c812-f385124be815@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51794-done Cc: 51794-done@debbugs.gnu.org, mark.t.kennedy@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: mark.t.kennedy@gmail.com, 51794@debbugs.gnu.org > From: martin rudalics > Date: Sat, 20 Nov 2021 10:56:13 +0100 > > > If you have problems, please post the patch and I will install it. > > Attached. ChangeLog would go as: > > > Report mouse events on tab or tool bar when 'track-mouse' is t (Bug#51794) > > * lisp/mouse.el (mouse-drag-track) > * lisp/mouse-drag.el (mouse-drag-drag): Set 'track-mouse' to some > value neither t nor nil (Bug#51794). > * src/keyboard.c (make_lispy_position): If track_mouse is Qt, > report event on tool or tab bar (Bug#51794). > > > Please fix everything as you see fit. > > Thanks, martin Thanks, installed, and closing the bug. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 04:12:46 2021 Received: (at 51794-done) by debbugs.gnu.org; 21 Nov 2021 09:12:46 +0000 Received: from localhost ([127.0.0.1]:44247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moity-0000jh-9e for submit@debbugs.gnu.org; Sun, 21 Nov 2021 04:12:46 -0500 Received: from mout.gmx.net ([212.227.17.20]:50597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moitw-0000jT-3r for 51794-done@debbugs.gnu.org; Sun, 21 Nov 2021 04:12:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1637485957; bh=28QeeNzt7Hu0LEfdDNyFNyXeu9NN+nBBRx2GW9cQjaM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=lRlYdveaTzaAd7eSAzgYyc5X58ENzAN3mE3dQLo47G48WSXpXlb+bBv6bBVZDk2GC OwJmj2wItS8ssa96TWXPA8uKFAxBb03Mj3L04GztHGWrVBdvtehUrnGlVP8L8KLsEQ uMmsYbP1+1dRbyveTAZ7To8rG9ISZf2CwhZcfrDo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([213.142.96.19]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N3siG-1mgAFA3YtU-00zm6G; Sun, 21 Nov 2021 10:12:36 +0100 Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar To: Eli Zaretskii References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> <83pmqwwrwj.fsf@gnu.org> <83h7c7tft5.fsf@gnu.org> <6ceafce2-eee9-5d93-6300-1f1b430b3f65@gmx.at> <838rxjtctn.fsf@gnu.org> <87028c49-bee3-4246-c812-f385124be815@gmx.at> <831r3bt9zd.fsf@gnu.org> From: martin rudalics Message-ID: Date: Sun, 21 Nov 2021 10:12:35 +0100 MIME-Version: 1.0 In-Reply-To: <831r3bt9zd.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:1y/WAy3uaDMDw1K4bUyg8AuVaUFygn5288TITCUwjuHoNQeizFP TDQFhQ306hJnt/Tvkm8LmIV6Bn9DpEsFiHBw2HXEjEEWNOYnZbhGQUMmiLb1VK7B/StFpSJ Y1YwYWCTjw8BQ/ZK7q9yzCUG8fh8V8R9isezJpsrbJlTkt3ixxUjdaNcGOBvsW0WE8jFtXi UQhwvZ82ppg5z3jSKL1VQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:f9kE2fIHTkw=:e2xew4eHNgO0DLZQoI9zs1 YwsofavZAR1VbQf2fkoszj0moziQXPAMEomXQWZ3t9XPXDos45i5M/yLqxML2r1NOrpUD380P pe9GK3pkYPExQwsGGMKNdQmdy24w0WdH8T3cUT5UveG+dDiO5Il3LECd3GxYU6jNSyZAXtuGn oj18mvXP9QsPB6m+RBv0jSjQt7tk8Xll8/iX/XY06h+ZspAkakD1fzjoO/xiK+DUV0pjhS3Mf G0UW0904o7ovs7jLeoYVe4HfG5FXetttuQw/DPkOe8RTbspMN9vDzKELuu31VC1AODy3k1h5w HQEjFWW9daL1pqP9UgnJQjej8v387fzJlvgAmlUM6mecwty+OxaBAa0bkvl84ASFDyaiDGDb3 bSs0p2/GV8yInNq5WZ6T/mqfQbdgIdSecV7aRA3OONQDrRUki8hDNkISzT/YaGo9HRF/Mp6Vm Jk1a6dP8MLFcE++O9DmPKYzZCVPzXjtS6ZzMBb7oUsmuy6fcnlmdb3BYhp5soo/Wv9ysi4Hj1 PM77eZv22jAtXqj3wJqMDR9KXg2OIKdPeyGH4hI68fZVLnoZC5v3q34eLZnSsqqa+/FoO6r0B TThgkC6hvzojf2tOUtt/BF11PvpNzpjC2eLHiuSaYv+DAxfa32gRgls6ZCJyWjNjfrNh7saQa UN+Zs5cgx5//dfqhRpu4NExyMpwj96sBUTa25nyIigszyy4w6KvMZGWFGsXxzh7zYq3S57yUj 7hnaIuJ4GQCQZrm4iWDTF0HyylFd3nyzuXtMOZ5pkSRYGGBZdAfdnNZr45oVJ7D2R48VUeizN vige3yCPPjx4zdF9uCRyWWv/L8PnoP1zkwjtVuQwaWhpSjaUoSWf77crta6wxyJzcBsxVNrTe cwMXisXMh6yC6wX/TNtN2spK6XS4dTbIeJwtNQJECVz/QfqzA5G/6dPiDmLLcQ2CRIIPbQYYy lZmE5F75UrhQv6+9bmX62GHi+gUk+FlbjsgM9ksyjXdet1kFSbkOY7SVK3Eq5VOKUTwmnApJY /t9pVxvUdB7j92qOvLLym4nj231eDReplVGzLdRXs3xJ3oVXAP2VGe5azvPji0F2i5N6Cq3H+ gn42GZVX6S/ces= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51794-done Cc: 51794-done@debbugs.gnu.org, mark.t.kennedy@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Thanks, installed, and closing the bug. Thanks for helping. martin From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 09:57:06 2021 Received: (at 51794-done) by debbugs.gnu.org; 21 Nov 2021 14:57:06 +0000 Received: from localhost ([127.0.0.1]:45801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mooHC-00066X-0H for submit@debbugs.gnu.org; Sun, 21 Nov 2021 09:57:06 -0500 Received: from mail-ot1-f41.google.com ([209.85.210.41]:37887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mooH9-000661-Va for 51794-done@debbugs.gnu.org; Sun, 21 Nov 2021 09:57:04 -0500 Received: by mail-ot1-f41.google.com with SMTP id h19-20020a9d3e53000000b0056547b797b2so24895379otg.4 for <51794-done@debbugs.gnu.org>; Sun, 21 Nov 2021 06:57:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FJEEw8vx8v65OBGUo+i9fMfaLg0/hwxAtSW0TaD58AI=; b=U0dBOfOVSiB6CW3aGo6G/LWXLvEe7BMzrPWfu9THH5Oz6iukHEX5Mg8mCEM7l7vfgo DCCJH++m7T0HW4PdFqFs3V/rT/zdeWUHcMOF5aLh/2wPmIcGMFZLt0aMbjY1smExXsYH Cx404bC6mpuA3ato+drQ85y9y4nTdfkLPiW5JXU9jOn9v4p8SOA9Sa+0UArAG+QlJ0On DbOE/b95GiwAhYw72e2/PJCXoVy/UYMOVmZazgt0Ezmlh2cwSpcAfzv8IfM+lY5Maz6I w/RgtwoBXdavXBYX0Vl/Ub9w1x42EghfdRiPcw58TqnK3JDIqRpEmQSsfShQQCRHsbnN MmrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FJEEw8vx8v65OBGUo+i9fMfaLg0/hwxAtSW0TaD58AI=; b=un1N+PWpxf3aqsNuZqkg16zi8gysnwJZYB7FaPK/qazxhnjOfb2DPFT6IbV4xJ3ayp pOxHFTgYz/TZtE8vGu80iFqcFo9jog+ivdQrDPc/n9X0op6eEoXhfw6LLgNJuGgVkP6F wyrexGZxYRK84YnHNgtDwJDyilXtCDjkV5lH+YvERJGXmooztIRQ3BbCGnZCBvWEOrGJ TqnO6lrz4B4b5qJ4qT0t//g3RT1odKOuBSrRXOZP6RytfZTdjY/w3nWid0PE70hc9qd2 vDmiRTUsw1Io3P1jawzZFGk0+1DAAzovGEu+FY+NS55OOSF0UFDTE70pTPjECxms7gpE DdkA== X-Gm-Message-State: AOAM530lNnN8QHqH9vCbPYlED9UlcawUrDHCm+1HkRnbS4e/EoB5+dZg iiTIk46ida4Mji2t+EumTePJ9F7T4I8A06mK8XA= X-Google-Smtp-Source: ABdhPJxNODFt3SlMunAotaRzqtz6Kn9B1O/Y4ZgAOkjrKmnZbCv8pCgAAomvcjyYK42aOKr/Of/0iuhC+RgeuowSH5Q= X-Received: by 2002:a9d:6855:: with SMTP id c21mr19182934oto.357.1637506618172; Sun, 21 Nov 2021 06:56:58 -0800 (PST) MIME-Version: 1.0 References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> <83pmqwwrwj.fsf@gnu.org> <83h7c7tft5.fsf@gnu.org> <6ceafce2-eee9-5d93-6300-1f1b430b3f65@gmx.at> <838rxjtctn.fsf@gnu.org> <87028c49-bee3-4246-c812-f385124be815@gmx.at> <831r3bt9zd.fsf@gnu.org> In-Reply-To: From: Mark Kennedy Date: Sun, 21 Nov 2021 09:56:47 -0500 Message-ID: Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar To: martin rudalics Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51794-done Cc: Eli Zaretskii , 51794-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) quick question only indirectly related to the fix. why would it go into the emacs-28 branch and not the HEAD branch? if you're busy, don't worry about answering. or both branches? /mark On Sun, Nov 21, 2021 at 4:12 AM martin rudalics wrote: > > > Thanks, installed, and closing the bug. > > Thanks for helping. > > martin > > From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 10:00:21 2021 Received: (at 51794-done) by debbugs.gnu.org; 21 Nov 2021 15:00:21 +0000 Received: from localhost ([127.0.0.1]:45809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mooKL-0006D7-Kd for submit@debbugs.gnu.org; Sun, 21 Nov 2021 10:00:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mooKJ-0006Ct-Ow for 51794-done@debbugs.gnu.org; Sun, 21 Nov 2021 10:00:20 -0500 Received: from [2001:470:142:3::e] (port=52606 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mooKE-0008GV-8x; Sun, 21 Nov 2021 10:00:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iVHDoxT2QWB/qPdTqNglY5zygyVyxFYdAd3NJSUt8Qc=; b=iyROQhD5hrMT qW29ZffKIi4m4a7MC6Kd5sF7uCv8st9mcNO6MYAByGkIQapGnu1WSlC87W+hOwT8n41fz+NJ/inEZ oN7mQwVi74z6EMisVf/lxX9S6R2WXnbd8rqOPvgTCSC0siimeyFWDzUf+IAPSq8DGk9z2i34YlaYz JdN4d1NKbXUft1DHvL4X1gQa19UitAC+TSQh3kP9o1V/PKvAoKsUEHITzNTnbmFRQjpGA01+GnPfz mYwpxa1CEnacum4UwGbMsjeshMfU8bBu89LLodC/h4qvngpGEu73CZcrXV9Y4Oe4GjylpLTaWArVk /bJY4T89yFxAqW9os8aXiQ==; Received: from [87.69.77.57] (port=4670 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mooK2-0007km-GY; Sun, 21 Nov 2021 10:00:02 -0500 Date: Sun, 21 Nov 2021 17:00:07 +0200 Message-Id: <83tug5r1u0.fsf@gnu.org> From: Eli Zaretskii To: Mark Kennedy In-Reply-To: (message from Mark Kennedy on Sun, 21 Nov 2021 09:56:47 -0500) Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> <83pmqwwrwj.fsf@gnu.org> <83h7c7tft5.fsf@gnu.org> <6ceafce2-eee9-5d93-6300-1f1b430b3f65@gmx.at> <838rxjtctn.fsf@gnu.org> <87028c49-bee3-4246-c812-f385124be815@gmx.at> <831r3bt9zd.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51794-done Cc: rudalics@gmx.at, 51794-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mark Kennedy > Date: Sun, 21 Nov 2021 09:56:47 -0500 > Cc: Eli Zaretskii , 51794-done@debbugs.gnu.org > > quick question only indirectly related to the fix. why would it go > into the emacs-28 branch and not the HEAD branch? if you're busy, > don't worry about answering. or both branches? The release branch gets merged to master quite regularly, so this is not a problem, and the bonus is that the same commit exists on master as well. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 21 10:20:28 2021 Received: (at 51794-done) by debbugs.gnu.org; 21 Nov 2021 15:20:28 +0000 Received: from localhost ([127.0.0.1]:45838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moodo-0006i0-14 for submit@debbugs.gnu.org; Sun, 21 Nov 2021 10:20:28 -0500 Received: from mail-oo1-f41.google.com ([209.85.161.41]:46877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moodn-0006hp-1W for 51794-done@debbugs.gnu.org; Sun, 21 Nov 2021 10:20:27 -0500 Received: by mail-oo1-f41.google.com with SMTP id p2-20020a4adfc2000000b002c2676904fdso5524205ood.13 for <51794-done@debbugs.gnu.org>; Sun, 21 Nov 2021 07:20:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Aie197Lv+yBaNGM21V/WeFo3pNqhNXadw+J4K2DI5L8=; b=me7A3E3MdwqeEO7pTZp7dOnRik+tId1pGTiEqZ9fUQ9ogrYCQ/XUIs7yhWrqiclR5U RfkAuWXoXwmmai6TOcYGDksaYqJYpIitdEd+S+fXbMGRxeGjs/KpGAyvotpXyxNswnhY yTxb7nKMvHVS1NEH2/9Ayr13sDPj2dEWdWL5boZ8jV6vjfsBA/K0b+TBDgTGdM29EAP0 NlkBqa0C1wkh3faqKZc1Jqwgt+vNNMS1s7hDLBbyE2Bf3tCITJHrgy/3AF/Wm4eL2Gtv cLjvQmWwcc3G4p9V/5PwyP+X7V4bxM5ujiACs0xxrGtF4QxOofCj5JvzmtWUld8hh2tP knnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Aie197Lv+yBaNGM21V/WeFo3pNqhNXadw+J4K2DI5L8=; b=gQZxRRiZH1sjaKNuUNE3GCxP63bz/rIjfdCO+/8sPowhyZjDixAiWmUc/QNS5aGr/8 zBBpYNnxUh+riE27BJvP5m9FKJbDRiXd6FUq7b/tayADKq5vXwRsNRsBUwuxUB9kGx6f IQ8XB02t/cKBhla0Et25m+3RXcwCObwhLBDm9OafHRx+UqpGBYOS1+NDFWcy1WFY48fb AuNId0zEnn0/qCNUyG9jTqZwcyGEvFv6DTFUCr5teYaoAPlYZFjIGMGLqv2Zey8ci+i+ sZcxi3ff/Dvqgb4d5RYz6a++qZ9lX3BADFPRZyE3qgJmtUc5mJOwoHXcE6g7zIfJ8DjU aSnA== X-Gm-Message-State: AOAM531HnE0i4bQ3lzvE1vPQhbSxh55bxnFnY/SRaYiqY37AxVJrnbG6 3LDdgiNF2FcNfmo5IAdXbQgibT+Mv9ucjoT4F0g= X-Google-Smtp-Source: ABdhPJz2cpaKbU8/UljWdPAyadpMCp+AWUKoA3u5OkST81ZLmveCbnfOZqBnOYNj5iJu8TNnEQRIsc2/8u+Lp04ABjI= X-Received: by 2002:a4a:cf12:: with SMTP id l18mr22184385oos.25.1637508021317; Sun, 21 Nov 2021 07:20:21 -0800 (PST) MIME-Version: 1.0 References: <83tuggy14y.fsf@gnu.org> <83h7cgxjbm.fsf@gnu.org> <83fss0xgn9.fsf@gnu.org> <835yswxedz.fsf@gnu.org> <83pmqwwrwj.fsf@gnu.org> <83h7c7tft5.fsf@gnu.org> <6ceafce2-eee9-5d93-6300-1f1b430b3f65@gmx.at> <838rxjtctn.fsf@gnu.org> <87028c49-bee3-4246-c812-f385124be815@gmx.at> <831r3bt9zd.fsf@gnu.org> <83tug5r1u0.fsf@gnu.org> In-Reply-To: <83tug5r1u0.fsf@gnu.org> From: Mark Kennedy Date: Sun, 21 Nov 2021 10:20:09 -0500 Message-ID: Subject: Re: bug#51794: 29.0.50; invalid input events generated from a mouse click for the tab bar To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000ed752f05d14e0bfd" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51794-done Cc: martin rudalics , 51794-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ed752f05d14e0bfd Content-Type: text/plain; charset="UTF-8" Got it. Thanks! On Sun, Nov 21, 2021, 10:00 AM Eli Zaretskii wrote: > > From: Mark Kennedy > > Date: Sun, 21 Nov 2021 09:56:47 -0500 > > Cc: Eli Zaretskii , 51794-done@debbugs.gnu.org > > > > quick question only indirectly related to the fix. why would it go > > into the emacs-28 branch and not the HEAD branch? if you're busy, > > don't worry about answering. or both branches? > > The release branch gets merged to master quite regularly, so this is > not a problem, and the bonus is that the same commit exists on master > as well. > --000000000000ed752f05d14e0bfd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Got it. Thanks!

On Sun, Nov 21, 2021, 10:00 AM Eli Zaretsk= ii <eliz@gnu.org> wrote:
> From: Mark Kennedy <mark.t.ke= nnedy@gmail.com>
> Date: Sun, 21 Nov 2021 09:56:47 -0500
> Cc: Eli Zaretskii <eliz@gnu.org>, 51794-done@debbugs.gnu.o= rg
>
> quick question only indirectly related to the fix.=C2=A0 why would it = go
> into the emacs-28 branch and not the HEAD branch?=C2=A0 if you're = busy,
> don't worry about answering.=C2=A0 or both branches?

The release branch gets merged to master quite regularly, so this is
not a problem, and the bonus is that the same commit exists on master
as well.
--000000000000ed752f05d14e0bfd-- From unknown Sun Jun 22 17:14:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Dec 2021 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator