From unknown Fri Aug 15 16:22:38 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#51780] [PATCH] environment: Fix =?UTF-8?Q?=E2=80=98--check=E2=80=99?= with exported PS1 variable. Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Nov 2021 23:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51780 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51780@debbugs.gnu.org Cc: Thiago Jung Bauermann X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1636675018473 (code B ref -1); Thu, 11 Nov 2021 23:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Nov 2021 23:56:58 +0000 Received: from localhost ([127.0.0.1]:42544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlJwA-00007Z-91 for submit@debbugs.gnu.org; Thu, 11 Nov 2021 18:56:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:44762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlJw8-00007R-Dx for submit@debbugs.gnu.org; Thu, 11 Nov 2021 18:56:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlJw8-00079v-65 for guix-patches@gnu.org; Thu, 11 Nov 2021 18:56:56 -0500 Received: from mx.kolabnow.com ([212.103.80.154]:33798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlJw6-00068L-0w for guix-patches@gnu.org; Thu, 11 Nov 2021 18:56:55 -0500 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id A5638709 for ; Fri, 12 Nov 2021 00:56:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:subject:subject:from:from:received :received:received; s=dkim20160331; t=1636675010; x=1638489411; bh=L+36DT02j+6dBoaNJt5S9t+2YBVTDvk4kKW0EEmXXDo=; b=wQpTLcRE7638 T9NJjruPGp/J+q+yD0+PvVTA7oys/h9fg98/98/vC4ytn+ump5yNB8XlzZwy/XYc uH+lFVSD+0Sz1emWNMYmWOyrcqPLsqvOCh3Dy9XQaWbyF6ffbaUhbKIJYinUacBj o92n9vwIYIGdEizopcwn6gGqNZOWAiKlZ8lse8x0vC8W3ixvOOgixvTfIa243cF3 1EP4jicxqhlR4I/hM8RqQK1y4DYxHuxch1vXdwhm0tqMPNlWEShlLQszWituVeIu 2M2/26tJIjfx7O4UsZ2sEE3meNSF/okKfkzKb/hW+zkw73/rXfkT3X+Vmiy0Pozb qKcdQvPIb1N6k7etiDmzG+oty8K+xswPM7CZrKLf8TeBR4IF8HxI9SvfkS4rEW3I wDKgtVWAPRC/bLObzEuhb8VMg/JvGUGr2UKEgC6v5VP1OemaTrIwi3Hf3JWR1bIw RNNi4FEV5CYSqlQY4kgwQfBK6yhXslp8vemAT5r/24EH00vpHFUFABbeytIs+K0i mi1XvZ1aBX/8illPRw+s9csKUopiGlPXQlkK3U2GaFG6iud4GswXvosa0fyuy5Zi hums0kr3frVWP55J5SXObZDDp/0cmPCftdMVnf/e7Kj5/AcQvOVNz5OplKPGrp1L Ire1CfhyNwvEG/QW6D6zPz8irXJcwY0= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZkA8AJ0B5rS9 for ; Fri, 12 Nov 2021 00:56:50 +0100 (CET) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by mx.kolabnow.com (Postfix) with ESMTPS id F1F7E5C1 for ; Fri, 12 Nov 2021 00:56:49 +0100 (CET) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx001.mykolab.com (Postfix) with ESMTPS id E8CDF901; Fri, 12 Nov 2021 00:47:05 +0100 (CET) From: Thiago Jung Bauermann Date: Thu, 11 Nov 2021 20:46:48 -0300 Message-Id: <20211111234648.672963-1-bauermann@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=212.103.80.154; envelope-from=bauermann@kolabnow.com; helo=mx.kolabnow.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) If your .bashrc (unnecessarily) exports PS1 and you’re in a non-login shell, Guix crashes: --8<---------------cut here---------------start------------->8--- user@popigai:~$ guix shell --check coreutils guix shell: checking the environment variables visible from shell '/bin/bash'... Backtrace: 14 (primitive-load "/home/user/.config/guix/current/bin/g…") In guix/ui.scm: 2206:7 13 (run-guix . _) 2169:10 12 (run-guix-command _ . _) In ice-9/boot-9.scm: 1752:10 11 (with-exception-handler _ _ #:unwind? _ # _) 1752:10 10 (with-exception-handler _ _ #:unwind? _ # _) In guix/store.scm: 658:37 9 (thunk) 1320:8 8 (call-with-build-handler _ _) 1320:8 7 (call-with-build-handler # …) In guix/status.scm: 800:4 6 (call-with-status-report _ _) In guix/scripts/environment.scm: 951:12 5 (_) In guix/store.scm: 2119:24 4 (run-with-store # …) In guix/scripts/environment.scm: 521:35 3 (_ _) In unknown file: 2 (string=? ("PS1" . "${debian_chroot:+($debian_chroot)…") …) In ice-9/boot-9.scm: 1685:16 1 (raise-exception _ #:continuable? _) 1685:16 0 (raise-exception _ #:continuable? _) ice-9/boot-9.scm:1685:16: In procedure raise-exception: In procedure string=: Wrong type argument in position 1 (expecting string): ("PS1" . "${debian_chroot:+($debian_chroot)}\\[\\033[01;32m\\]\\u@\\h\\[\\033[00m\\]:\\[\\033[01;34m\\]\\w\\[\\033[00m\\]${EXTRA}\\$ ") user@popigai:~$ --8<---------------cut here---------------end--------------->8--- This is because the match pattern doesn’t expect `(vhash-assoc "PS1" actual)` to return a pair. * guix/scripts/environment.scm (validate-child-shell-environment): Change match pattern to expect a pair. --- guix/scripts/environment.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm index 8176de4a5e8c..821f20e2f223 100644 --- a/guix/scripts/environment.scm +++ b/guix/scripts/environment.scm @@ -517,7 +517,7 @@ (define-syntax-rule (warn exp ...) (unless warned? (match (vhash-assoc "PS1" actual) (#f #f) - (str + ((_ . str) (when (and (getenv "PS1") (string=? str (getenv "PS1"))) (warning (G_ "'PS1' is the same in sub-shell~%")) (display-hint (G_ "Consider setting a different prompt for base-commit: 893a31ec20f47b979c1be9fb8b942809228ba4c9 From unknown Fri Aug 15 16:22:38 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Thiago Jung Bauermann Subject: bug#51780: closed (Re: bug#51780: [PATCH] environment: Fix =?UTF-8?Q?=E2=80=98--check=E2=80=99?= with exported PS1 variable.) Message-ID: References: <87ilwu8jsc.fsf@gnu.org> <20211111234648.672963-1-bauermann@kolabnow.com> X-Gnu-PR-Message: they-closed 51780 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 51780@debbugs.gnu.org Date: Sun, 14 Nov 2021 22:17:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1636928222-12516-1" This is a multi-part message in MIME format... ------------=_1636928222-12516-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #51780: [PATCH] environment: Fix =E2=80=98--check=E2=80=99 with exported PS= 1 variable. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 51780@debbugs.gnu.org. --=20 51780: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51780 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1636928222-12516-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 51780-done) by debbugs.gnu.org; 14 Nov 2021 22:17:00 +0000 Received: from localhost ([127.0.0.1]:51931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmNo4-0003EL-7o for submit@debbugs.gnu.org; Sun, 14 Nov 2021 17:17:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmNo2-00039F-Pq for 51780-done@debbugs.gnu.org; Sun, 14 Nov 2021 17:16:59 -0500 Received: from [2001:470:142:3::e] (port=39182 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmNnx-0003xB-JY; Sun, 14 Nov 2021 17:16:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=oLmmRUk6TiulLMVSm/a48n+0D0vguCeoNBWZKuDCTOA=; b=XdUkxm032JQL8ZUjqwab JoKikgaUV6Wc0X/znn/1j78sAZvW+KfBPyigdR74/wyHxRIE8xlaf6sbDpKrYu9EFlx6bXIgkNk3H er40h/stdLk2QrV5PyI57mNtwvHHDQ8tkLWSMTg0darQ/GPzHXGvbxagOGs4d+kHt6bO8uTcHYvo5 7K7gKkUopOpG1JJyP66HFIbhzn03Pk2KRuvo8Hzm+hBYbScfb+qBIYg0k1lh6+1JLKADojotxW1o8 4s4B1/aDI8iXiSi61LgUlEzpxwiAR2jghN8HwSR71xlCWAzQ/QLQjclbw8WJA2wFQVXapJhuvHsOE jsKVBUyCRpjNaQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:56989 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmNnx-0008Hk-B5; Sun, 14 Nov 2021 17:16:53 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Thiago Jung Bauermann Subject: Re: bug#51780: [PATCH] environment: Fix =?utf-8?B?4oCYLS1jaGVj?= =?utf-8?B?a+KAmQ==?= with exported PS1 variable. References: <20211111234648.672963-1-bauermann@kolabnow.com> Date: Sun, 14 Nov 2021 23:16:51 +0100 In-Reply-To: <20211111234648.672963-1-bauermann@kolabnow.com> (Thiago Jung Bauermann's message of "Thu, 11 Nov 2021 20:46:48 -0300") Message-ID: <87ilwu8jsc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51780-done Cc: 51780-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Thiago Jung Bauermann skribis: > If your .bashrc (unnecessarily) exports PS1 and you=E2=80=99re in a non-l= ogin > shell, Guix crashes: > > user@popigai:~$ guix shell --check coreutils > guix shell: checking the environment variables visible from shell '/bin/b= ash'... > Backtrace: > 14 (primitive-load "/home/user/.config/guix/current/bin/g=E2=80= =A6") > In guix/ui.scm: > 2206:7 13 (run-guix . _) > 2169:10 12 (run-guix-command _ . _) > In ice-9/boot-9.scm: > 1752:10 11 (with-exception-handler _ _ #:unwind? _ # _) > 1752:10 10 (with-exception-handler _ _ #:unwind? _ # _) > In guix/store.scm: > 658:37 9 (thunk) > 1320:8 8 (call-with-build-handler _ _) > 1320:8 7 (call-with-build-handler # =E2=80=A6) > In guix/status.scm: > 800:4 6 (call-with-status-report _ _) > In guix/scripts/environment.scm: > 951:12 5 (_) > In guix/store.scm: > 2119:24 4 (run-with-store # =E2= =80=A6) > In guix/scripts/environment.scm: > 521:35 3 (_ _) > In unknown file: > 2 (string=3D? ("PS1" . "${debian_chroot:+($debian_chroot)=E2= =80=A6") =E2=80=A6) > In ice-9/boot-9.scm: > 1685:16 1 (raise-exception _ #:continuable? _) > 1685:16 0 (raise-exception _ #:continuable? _) > > ice-9/boot-9.scm:1685:16: In procedure raise-exception: > In procedure string=3D: Wrong type argument in position 1 (expecting stri= ng): ("PS1" . "${debian_chroot:+($debian_chroot)}\\[\\033[01;32m\\]\\u@\\h\= \[\\033[00m\\]:\\[\\033[01;34m\\]\\w\\[\\033[00m\\]${EXTRA}\\$ ") > user@popigai:~$ > > This is because the match pattern doesn=E2=80=99t expect `(vhash-assoc "P= S1" actual)` > to return a pair. > > * guix/scripts/environment.scm (validate-child-shell-environment): Change > match pattern to expect a pair. Oops, good catch! Applied, thanks. Ludo=E2=80=99. ------------=_1636928222-12516-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Nov 2021 23:56:58 +0000 Received: from localhost ([127.0.0.1]:42544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlJwA-00007Z-91 for submit@debbugs.gnu.org; Thu, 11 Nov 2021 18:56:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:44762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlJw8-00007R-Dx for submit@debbugs.gnu.org; Thu, 11 Nov 2021 18:56:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlJw8-00079v-65 for guix-patches@gnu.org; Thu, 11 Nov 2021 18:56:56 -0500 Received: from mx.kolabnow.com ([212.103.80.154]:33798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlJw6-00068L-0w for guix-patches@gnu.org; Thu, 11 Nov 2021 18:56:55 -0500 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id A5638709 for ; Fri, 12 Nov 2021 00:56:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:subject:subject:from:from:received :received:received; s=dkim20160331; t=1636675010; x=1638489411; bh=L+36DT02j+6dBoaNJt5S9t+2YBVTDvk4kKW0EEmXXDo=; b=wQpTLcRE7638 T9NJjruPGp/J+q+yD0+PvVTA7oys/h9fg98/98/vC4ytn+ump5yNB8XlzZwy/XYc uH+lFVSD+0Sz1emWNMYmWOyrcqPLsqvOCh3Dy9XQaWbyF6ffbaUhbKIJYinUacBj o92n9vwIYIGdEizopcwn6gGqNZOWAiKlZ8lse8x0vC8W3ixvOOgixvTfIa243cF3 1EP4jicxqhlR4I/hM8RqQK1y4DYxHuxch1vXdwhm0tqMPNlWEShlLQszWituVeIu 2M2/26tJIjfx7O4UsZ2sEE3meNSF/okKfkzKb/hW+zkw73/rXfkT3X+Vmiy0Pozb qKcdQvPIb1N6k7etiDmzG+oty8K+xswPM7CZrKLf8TeBR4IF8HxI9SvfkS4rEW3I wDKgtVWAPRC/bLObzEuhb8VMg/JvGUGr2UKEgC6v5VP1OemaTrIwi3Hf3JWR1bIw RNNi4FEV5CYSqlQY4kgwQfBK6yhXslp8vemAT5r/24EH00vpHFUFABbeytIs+K0i mi1XvZ1aBX/8illPRw+s9csKUopiGlPXQlkK3U2GaFG6iud4GswXvosa0fyuy5Zi hums0kr3frVWP55J5SXObZDDp/0cmPCftdMVnf/e7Kj5/AcQvOVNz5OplKPGrp1L Ire1CfhyNwvEG/QW6D6zPz8irXJcwY0= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZkA8AJ0B5rS9 for ; Fri, 12 Nov 2021 00:56:50 +0100 (CET) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by mx.kolabnow.com (Postfix) with ESMTPS id F1F7E5C1 for ; Fri, 12 Nov 2021 00:56:49 +0100 (CET) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx001.mykolab.com (Postfix) with ESMTPS id E8CDF901; Fri, 12 Nov 2021 00:47:05 +0100 (CET) From: Thiago Jung Bauermann To: guix-patches@gnu.org Subject: [PATCH] =?UTF-8?q?environment:=20Fix=20=E2=80=98--check=E2=80=99?= =?UTF-8?q?=20with=20exported=20PS1=20variable.?= Date: Thu, 11 Nov 2021 20:46:48 -0300 Message-Id: <20211111234648.672963-1-bauermann@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=212.103.80.154; envelope-from=bauermann@kolabnow.com; helo=mx.kolabnow.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Thiago Jung Bauermann X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) If your .bashrc (unnecessarily) exports PS1 and you’re in a non-login shell, Guix crashes: --8<---------------cut here---------------start------------->8--- user@popigai:~$ guix shell --check coreutils guix shell: checking the environment variables visible from shell '/bin/bash'... Backtrace: 14 (primitive-load "/home/user/.config/guix/current/bin/g…") In guix/ui.scm: 2206:7 13 (run-guix . _) 2169:10 12 (run-guix-command _ . _) In ice-9/boot-9.scm: 1752:10 11 (with-exception-handler _ _ #:unwind? _ # _) 1752:10 10 (with-exception-handler _ _ #:unwind? _ # _) In guix/store.scm: 658:37 9 (thunk) 1320:8 8 (call-with-build-handler _ _) 1320:8 7 (call-with-build-handler # …) In guix/status.scm: 800:4 6 (call-with-status-report _ _) In guix/scripts/environment.scm: 951:12 5 (_) In guix/store.scm: 2119:24 4 (run-with-store # …) In guix/scripts/environment.scm: 521:35 3 (_ _) In unknown file: 2 (string=? ("PS1" . "${debian_chroot:+($debian_chroot)…") …) In ice-9/boot-9.scm: 1685:16 1 (raise-exception _ #:continuable? _) 1685:16 0 (raise-exception _ #:continuable? _) ice-9/boot-9.scm:1685:16: In procedure raise-exception: In procedure string=: Wrong type argument in position 1 (expecting string): ("PS1" . "${debian_chroot:+($debian_chroot)}\\[\\033[01;32m\\]\\u@\\h\\[\\033[00m\\]:\\[\\033[01;34m\\]\\w\\[\\033[00m\\]${EXTRA}\\$ ") user@popigai:~$ --8<---------------cut here---------------end--------------->8--- This is because the match pattern doesn’t expect `(vhash-assoc "PS1" actual)` to return a pair. * guix/scripts/environment.scm (validate-child-shell-environment): Change match pattern to expect a pair. --- guix/scripts/environment.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm index 8176de4a5e8c..821f20e2f223 100644 --- a/guix/scripts/environment.scm +++ b/guix/scripts/environment.scm @@ -517,7 +517,7 @@ (define-syntax-rule (warn exp ...) (unless warned? (match (vhash-assoc "PS1" actual) (#f #f) - (str + ((_ . str) (when (and (getenv "PS1") (string=? str (getenv "PS1"))) (warning (G_ "'PS1' is the same in sub-shell~%")) (display-hint (G_ "Consider setting a different prompt for base-commit: 893a31ec20f47b979c1be9fb8b942809228ba4c9 ------------=_1636928222-12516-1-- From unknown Fri Aug 15 16:22:38 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#51780] [PATCH] environment: Fix =?UTF-8?Q?=E2=80=98--check=E2=80=99?= with exported PS1 variable. Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 Nov 2021 04:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51780 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 51780-done@debbugs.gnu.org Received: via spool by 51780-done@debbugs.gnu.org id=D51780.163703523618485 (code D ref 51780); Tue, 16 Nov 2021 04:01:02 +0000 Received: (at 51780-done) by debbugs.gnu.org; 16 Nov 2021 04:00:36 +0000 Received: from localhost ([127.0.0.1]:56697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmpe7-0004o5-Um for submit@debbugs.gnu.org; Mon, 15 Nov 2021 23:00:36 -0500 Received: from mx.kolabnow.com ([212.103.80.155]:9658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmpe5-0004nc-OW for 51780-done@debbugs.gnu.org; Mon, 15 Nov 2021 23:00:34 -0500 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id B8208C8D; Tue, 16 Nov 2021 05:00:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:date:subject:subject :from:from:received:received:received; s=dkim20160331; t= 1637035227; x=1638849628; bh=AVz6QCaTLLTptKD7jkoQBc7EurradnPmiL9 lmd2j6BQ=; b=LZG+8lU04ozBKEoB6e1MqTNKFNtO/+j2POiB2sSSVkchvelLuJe KSVR/SxpxWjUAD6CU7aiF2veD23b7PNHHUQfGWDnWPUrRmnB6wlVBsKEFXFsvvjj AdAKyfUb62b4IKYlzaqh+qy/AcYl0E3/wMmps4IuJdAVcPZq87StGOGFNlFPj1s4 UB4QwvahzknVQ73yhPVoYm2+m3rHrAV9o6nZmdBdBezrqNjkVWQ3+5gW1gUTlHSr vLhYQyr/sQlfoyZFNSmFwr/39pCesIPbbnhULvGV8Qzej3Afp3/eM1lYGCFXJvqQ j0wjqtsdTVvd1K4XnlZKdongrjuGjKwmCs1bDNQOv6cuROnH24kzS1mkPMI/w2SB lLzIoDuTZ17mImvomixtm8P9YNER89c1xAwCkmB4HmVhDoIDTttNimlQ6eJFj4pe 4Qoeqhrdp/Ko5ckK9BVxMiTibWGGQviOf0lK2wMB/tJ/jTzHG7OPvWR8yGhdWjDl jOjGFt5VQONOovMWk20cR5skVzoMhdkeJpzjEuVvaq1VY9Ura80UHOJGN+oaNwLE 1078meGYbxQMs1uPMW/uCxt29/0hslRXUl6EG2fneja4cIbpFyqH4eRCVsBRk7rc 7t7JyuksB6068uxJ9NuFTnPWrO6fzp675PLzdylLQx7dE6a0C6vkydC0= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IKeXqhQTMtSP; Tue, 16 Nov 2021 05:00:27 +0100 (CET) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by mx.kolabnow.com (Postfix) with ESMTPS id 53AC1685; Tue, 16 Nov 2021 05:00:26 +0100 (CET) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx002.mykolab.com (Postfix) with ESMTPS id 7CFA15547; Tue, 16 Nov 2021 05:00:25 +0100 (CET) From: Thiago Jung Bauermann Date: Tue, 16 Nov 2021 01:00:13 -0300 Message-ID: <2254970.72j8z63hLH@popigai> In-Reply-To: <87ilwu8jsc.fsf@gnu.org> References: <20211111234648.672963-1-bauermann@kolabnow.com> <87ilwu8jsc.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Ludo, Em domingo, 14 de novembro de 2021, =E0s 19:16:51 -03, Ludovic Court=E8s=20 escreveu: > Oops, good catch! Applied, thanks. Thank you! =2D-=20 Thanks, Thiago