From unknown Fri Jun 20 20:05:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51778: 29.0.50; gnus-search uses `message' instead of `gnus-message' Resent-From: "Jose A. Ortega Ruiz" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 11 Nov 2021 22:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51778 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: To: 51778@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163666797621259 (code B ref -1); Thu, 11 Nov 2021 22:00:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Nov 2021 21:59:36 +0000 Received: from localhost ([127.0.0.1]:42492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlI6Z-0005Wo-IR for submit@debbugs.gnu.org; Thu, 11 Nov 2021 16:59:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:48996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlI6X-0005Wh-Uo for submit@debbugs.gnu.org; Thu, 11 Nov 2021 16:59:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlI6U-0006CY-T4 for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 16:59:33 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:38805) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlI6O-0000Tt-3b for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 16:59:27 -0500 Received: (Authenticated sender: mail@jao.io) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 7C4B4200003 for ; Thu, 11 Nov 2021 21:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jao.io; s=gm1; t=1636667956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=KntUx9mKMxoH+XhRwZQ0vZw72+8cv2aSIf0NabB7MrI=; b=fxqVXYWBj4xYHG9kWNaaXnNLYOARlHAtvFEQY1eZDQG+AxzY8YxKkWGawAjS03dGcp4Cnu 8zmy50fhxpr/8LmX+vSOGQiunwFax2L5r5nR943z7Rmlr0na6ZmAX5x3j+nBBFMOho68cq PBznjeCopqU1ec7q9n6qSjNkRzpmHFpSEoCm46c5sIIPa04038tPmNuOgc6S/gkaYXV8oG v1tPISjVArdnDOLoXdXeTq2e0BodwpbG+C4GomDII4TKmgDAASZPwt9mYGowBMWQeUPaSD TgeaZhhupEri6QwCOsJ3b+cJp3sNl6oIAcrkPmYd8q+RI8rH1Hpbqp/MQRsakg== Received: from localhost (osgiliath.local [local]) by osgiliath.local (OpenSMTPD) with ESMTPA id f5be1309 for ; Thu, 11 Nov 2021 21:59:15 +0000 (UTC) From: "Jose A. Ortega Ruiz" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: Date: Thu, 11 Nov 2021 21:59:15 +0000 Message-ID: <87h7cixsjw.fsf@gnus.jao.io> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=217.70.178.232; envelope-from=mail@jao.io; helo=relay12.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Hi, In gnus-search, there are several logs (some of them quite verbose when one's iterating over long lists of groups) using `message'. I think that it'd be better to use `gnus-message' instead, with levels as appropriate. That way one can avoid (or enable!) them via gnus-verbose. I'm attaching a patch changing them all to level 7, since they looked like debug messages to me; but it's just a suggestion. Thanks! jao --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Use-gnus-message-for-logging-in-gnus-search.patch >From 0ea1df942474f8decb71a71c7f2ed03d86ef8991 Mon Sep 17 00:00:00 2001 From: jao Date: Thu, 11 Nov 2021 21:54:19 +0000 Subject: [PATCH] Use gnus-message for logging in gnus-search --- lisp/gnus/gnus-search.el | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el index 3157358804..a4d319b4b8 100644 --- a/lisp/gnus/gnus-search.el +++ b/lisp/gnus/gnus-search.el @@ -1018,7 +1018,7 @@ gnus-search-run-search (single-search (gnus-search-single-p query)) (grouplist (or groups (gnus-search-get-active srv))) q-string artlist group) - (message "Opening server %s" server) + (gnus-message 7 "Opening server %s" server) (gnus-open-server srv) ;; We should only be doing this once, in ;; `nnimap-open-connection', but it's too frustrating to try to @@ -1062,7 +1062,7 @@ gnus-search-run-search (when (nnimap-change-group (gnus-group-short-name group) server) (with-current-buffer (nnimap-buffer) - (message "Searching %s..." group) + (gnus-message 7 "Searching %s..." group) (let ((result (gnus-search-imap-search-command engine q-string))) (when (car result) @@ -1075,7 +1075,7 @@ gnus-search-run-search (vector group artn 100)))) (cdr (assoc "SEARCH" (cdr result)))) artlist)))) - (message "Searching %s...done" group)))) + (gnus-message 7 "Searching %s...done" group)))) (nreverse artlist)))) (cl-defmethod gnus-search-imap-search-command ((engine gnus-search-imap) @@ -1330,8 +1330,8 @@ gnus-search-run-search (erase-buffer) (if groups - (message "Doing %s query on %s..." program groups) - (message "Doing %s query..." program)) + (gnus-message 7 "Doing %s query on %s..." program groups) + (gnus-message 7 "Doing %s query..." program)) (setq proc (apply #'start-process (format "search-%s" server) buffer program cp-list)) (while (process-live-p proc) @@ -1837,8 +1837,8 @@ gnus-search-run-search (mapcar (lambda (x) (let ((group x) artlist) - (message "Searching %s using find-grep..." - (or group server)) + (gnus-message 7 "Searching %s using find-grep..." + (or group server)) (save-window-excursion (set-buffer buffer) (if (> gnus-verbose 6) @@ -1893,8 +1893,8 @@ gnus-search-run-search (vector (gnus-group-full-name group server) art 0) artlist)) (forward-line 1))) - (message "Searching %s using find-grep...done" - (or group server)) + (gnus-message 7 "Searching %s using find-grep...done" + (or group server)) artlist))) grouplist)))) -- 2.33.1 --=-=-=-- From unknown Fri Jun 20 20:05:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51778: 29.0.50; gnus-search uses `message' instead of `gnus-message' Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 12 Nov 2021 01:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51778 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: To: "Jose A. Ortega Ruiz" Cc: Debbugs control , 51778@debbugs.gnu.org Received: via spool by 51778-submit@debbugs.gnu.org id=B51778.16366802339205 (code B ref 51778); Fri, 12 Nov 2021 01:24:02 +0000 Received: (at 51778) by debbugs.gnu.org; 12 Nov 2021 01:23:53 +0000 Received: from localhost ([127.0.0.1]:42681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlLIG-0002OO-VX for submit@debbugs.gnu.org; Thu, 11 Nov 2021 20:23:53 -0500 Received: from mail.ericabrahamsen.net ([52.70.2.18]:38964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlLIE-0002O7-Hh; Thu, 11 Nov 2021 20:23:51 -0500 Received: from localhost (c-71-197-232-156.hsd1.wa.comcast.net [71.197.232.156]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id B5901FA023; Fri, 12 Nov 2021 01:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1636680224; bh=oWG+M8KWnpP4CF+QouFowcZa5RAFtsnPm0/z4wIdCHk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ymLdkdrMIrqBFzLWOdixtcH1BQPPcdTfW4zcZuZwW9ZsL2w7SCVJUwjA4gBVsSfqG kPq3z458ESy8AFZtRtauPNJxdzSNPu8ismHzOQlt1RNWXRIvgVf1h8hi1ZJC6szO4B uib6y/WGkwnvl6FHhfe0xtCYe7IYfbA1npAOsu0o= From: Eric Abrahamsen References: <87h7cixsjw.fsf@gnus.jao.io> Date: Thu, 11 Nov 2021 17:23:42 -0800 In-Reply-To: <87h7cixsjw.fsf@gnus.jao.io> (Jose A. Ortega Ruiz's message of "Thu, 11 Nov 2021 21:59:15 +0000") Message-ID: <87sfw2qi8x.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 51335 quit "Jose A. Ortega Ruiz" writes: > Hi, > > In gnus-search, there are several logs (some of them quite verbose when > one's iterating over long lists of groups) using `message'. I think > that it'd be better to use `gnus-message' instead, with levels as > appropriate. That way one can avoid (or enable!) them via gnus-verbose. > > I'm attaching a patch changing them all to level 7, since they looked > like debug messages to me; but it's just a suggestion. Yes, this is an excellent suggestion, and should be part of the work ongoing in bug#51335. Thanks! From unknown Fri Jun 20 20:05:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51778: 29.0.50; gnus-search uses `message' instead of `gnus-message' Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 12 Nov 2021 01:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51778 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: To: "Jose A. Ortega Ruiz" Cc: 51778@debbugs.gnu.org Received: via spool by 51778-submit@debbugs.gnu.org id=B51778.16366804239542 (code B ref 51778); Fri, 12 Nov 2021 01:28:01 +0000 Received: (at 51778) by debbugs.gnu.org; 12 Nov 2021 01:27:03 +0000 Received: from localhost ([127.0.0.1]:42691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlLLK-0002Tq-NM for submit@debbugs.gnu.org; Thu, 11 Nov 2021 20:27:03 -0500 Received: from mail.ericabrahamsen.net ([52.70.2.18]:39042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlLLI-0002TI-WE for 51778@debbugs.gnu.org; Thu, 11 Nov 2021 20:27:01 -0500 Received: from localhost (c-71-197-232-156.hsd1.wa.comcast.net [71.197.232.156]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 18132FA023; Fri, 12 Nov 2021 01:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1636680415; bh=T9FkbycCUjRszHXpQqBTMXx//m5KqXmIv47NC0m7Tw0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YnXTsJwSrajQE3ffznA9/Yytjaz/CtAV8fTolM8Kua2YK8e4/aqr2DWTcwltwZxtP /7Ydbv9we1TOhCqjh/BCIxbNceEmBn6sPR2pFkOWAjG9Xgh3ZMiOAV/vlQ3JaeFLOX 2d/i1ALG6TF/7h0bx5K1ok8KsTR5nU5a7hkhVUHY= From: Eric Abrahamsen References: <87h7cixsjw.fsf@gnus.jao.io> <87sfw2qi8x.fsf@ericabrahamsen.net> Date: Thu, 11 Nov 2021 17:26:53 -0800 In-Reply-To: <87sfw2qi8x.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 11 Nov 2021 17:23:42 -0800") Message-ID: <87o86qqi3m.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eric Abrahamsen writes: > merge 51335 > quit Obviously I still don't know how this works, anyway this should be rolled in with bug#51335. From unknown Fri Jun 20 20:05:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51778: 29.0.50; gnus-search uses `message' instead of `gnus-message' Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 12 Nov 2021 03:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51778 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: To: Eric Abrahamsen Cc: "Jose A. Ortega Ruiz" , 51778@debbugs.gnu.org Received: via spool by 51778-submit@debbugs.gnu.org id=B51778.16366881816538 (code B ref 51778); Fri, 12 Nov 2021 03:37:01 +0000 Received: (at 51778) by debbugs.gnu.org; 12 Nov 2021 03:36:21 +0000 Received: from localhost ([127.0.0.1]:42799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlNMT-0001hO-4q for submit@debbugs.gnu.org; Thu, 11 Nov 2021 22:36:21 -0500 Received: from quimby.gnus.org ([95.216.78.240]:60558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlNMQ-0001hA-E4 for 51778@debbugs.gnu.org; Thu, 11 Nov 2021 22:36:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=u5p4Qi60iDcjZhFFVD+VZvej5tBwvoX1dV+jDVqhOlk=; b=T3PMalJon7CuhHzcmdUIWVT1bk z6zPqsXc4aaJRenNYtJo9hVFm9Y5vzoVgOAHWwCQr6X5TRoyVvOz2qK0MEwfQtiX6+5iVcYvxR3LW j8o7SynrfAjgmhvr6kkSOJVkRF4yLR8UDWy1vKjwC0DddlhbZAuep1ECuvjmas42uCeo=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlNMH-0003gA-Vz; Fri, 12 Nov 2021 04:36:12 +0100 From: Lars Ingebrigtsen References: <87h7cixsjw.fsf@gnus.jao.io> <87sfw2qi8x.fsf@ericabrahamsen.net> <87o86qqi3m.fsf@ericabrahamsen.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXf399/foAkJCb/ //8aMSjyAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+ULDAIxCQtexUAAAAGFSURBVCjPhZLNboJAFIUP BIiykkRMOyvTaNLwFEOjXWMiprLqwiZ1noJ20TUuNCkr2ohh7lP2zmDTZWc13z2XOfcH4O+M4KzS aOzH4zW8DL6XRojyKDOag+UCqQf4BQGrSEo4G6KcAxyMFR3z0uYVpNexqhu+k2YZ8zxeQyJzNhpI sVpyPhKqK1z2Fy35E6JTh8vnyxMLLrWHOQ5EHZcTqBIusg86szJUC6eWMyQHhoHaK8IUQ+PptaKd yGnfxFjevamSJFsCAkrrgCounz1vEv0aUGfuEIOwGrmkHiqGrX/LkaOyPrIQQGgrADb0KCEaZUHV 7yUmTULcCPank0bIQEb55gT3CgkdMziNsMAzyEeD54C4IhAbJJpteyCZkOm+tKCFhcpC5SvJ0PRp CA2cLQDBmR/QV8XtemgL84xROtv6Hpgx7Mzy/C33H1Ar7bR2DL6qS2Eg4MX4okBid5chGwZLhBZ2 rKawSp7zapyvGWI7SLGAJ8cmKeZ53//+PixlI/xzfgA4zIj9xqxzCwAAACV0RVh0ZGF0ZTpjcmVh dGUAMjAyMS0xMS0xMlQwMjo0OTowOSswMDowMBA//9wAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEt MTEtMTJUMDI6NDk6MDkrMDA6MDBhYkdgAAAAAElFTkSuQmCC X-Now-Playing: Sonic Youth's _Goo_: "Titanium Expose" Date: Fri, 12 Nov 2021 04:36:09 +0100 In-Reply-To: <87o86qqi3m.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 11 Nov 2021 17:26:53 -0800") Message-ID: <87fss22ggm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eric Abrahamsen writes: > Eric Abrahamsen writes: > >> merge 51335 >> quit > > Obviously I still don't know how this works, anyway this should be > rolled in with bug#51335. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eric Abrahamsen writes: > Eric Abrahamsen writes: > >> merge 51335 >> quit > > Obviously I still don't know how this works, anyway this should be > rolled in with bug#51335. I think "forcemerge" works better... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Jun 20 20:05:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Jose A. Ortega Ruiz" Subject: bug#51778: closed (Re: bug#51778: 29.0.50; gnus-search uses `message' instead of `gnus-message') Message-ID: References: <8735n9zjgz.fsf@ericabrahamsen.net> <87h7cixsjw.fsf@gnus.jao.io> X-Gnu-PR-Message: they-closed 51778 X-Gnu-PR-Package: emacs,gnus Reply-To: 51778@debbugs.gnu.org Date: Fri, 03 Dec 2021 17:29:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1638552541-16299-1" This is a multi-part message in MIME format... ------------=_1638552541-16299-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #51778: 29.0.50; gnus-search uses `message' instead of `gnus-message' which was filed against the emacs,gnus package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 51778@debbugs.gnu.org. --=20 51778: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51778 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1638552541-16299-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 51778-done) by debbugs.gnu.org; 3 Dec 2021 17:28:26 +0000 Received: from localhost ([127.0.0.1]:52164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtCMD-0004E6-RO for submit@debbugs.gnu.org; Fri, 03 Dec 2021 12:28:26 -0500 Received: from mail.ericabrahamsen.net ([52.70.2.18]:46926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtCM8-0004Ds-Kr for 51778-done@debbugs.gnu.org; Fri, 03 Dec 2021 12:28:24 -0500 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 68C92FFD79; Fri, 3 Dec 2021 17:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1638552494; bh=7LtqyNqYyuA0FJ1U7nL3d+l9mbZhGfEaqS6z0Ga7ac8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=m1jaqRxwr+VMZG9OXtrt6YNUfatnKTx6wbsugg2W2E2Q7k+HeqdqJRwGE+SEzlQ+J MndUvyqXfZWvDVFskz/0FZTFbpTszARs2TZl7iCiM1IM39GyYnuxbFzGTKR1JQEz8b iT0HlxINvZErLF/Fm7tBDAQkzfYE826LsDqyjN4o= From: Eric Abrahamsen To: Lars Ingebrigtsen Subject: Re: bug#51778: 29.0.50; gnus-search uses `message' instead of `gnus-message' References: <87h7cixsjw.fsf@gnus.jao.io> <87sfw2qi8x.fsf@ericabrahamsen.net> <87o86qqi3m.fsf@ericabrahamsen.net> <87fss22ggm.fsf@gnus.org> Date: Fri, 03 Dec 2021 09:28:12 -0800 In-Reply-To: <87fss22ggm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 12 Nov 2021 04:36:09 +0100") Message-ID: <8735n9zjgz.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51778-done Cc: "Jose A. Ortega Ruiz" , 51778-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Eric Abrahamsen writes: > >> Eric Abrahamsen writes: >> >>> merge 51335 >>> quit >> >> Obviously I still don't know how this works, anyway this should be >> rolled in with bug#51335. > > I think "forcemerge" works better... I haven't had time to sit and work on the larger project of logging, etc, so I'm doing some spot fixes first. ------------=_1638552541-16299-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Nov 2021 21:59:36 +0000 Received: from localhost ([127.0.0.1]:42492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlI6Z-0005Wo-IR for submit@debbugs.gnu.org; Thu, 11 Nov 2021 16:59:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:48996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlI6X-0005Wh-Uo for submit@debbugs.gnu.org; Thu, 11 Nov 2021 16:59:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlI6U-0006CY-T4 for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 16:59:33 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:38805) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlI6O-0000Tt-3b for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 16:59:27 -0500 Received: (Authenticated sender: mail@jao.io) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 7C4B4200003 for ; Thu, 11 Nov 2021 21:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jao.io; s=gm1; t=1636667956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=KntUx9mKMxoH+XhRwZQ0vZw72+8cv2aSIf0NabB7MrI=; b=fxqVXYWBj4xYHG9kWNaaXnNLYOARlHAtvFEQY1eZDQG+AxzY8YxKkWGawAjS03dGcp4Cnu 8zmy50fhxpr/8LmX+vSOGQiunwFax2L5r5nR943z7Rmlr0na6ZmAX5x3j+nBBFMOho68cq PBznjeCopqU1ec7q9n6qSjNkRzpmHFpSEoCm46c5sIIPa04038tPmNuOgc6S/gkaYXV8oG v1tPISjVArdnDOLoXdXeTq2e0BodwpbG+C4GomDII4TKmgDAASZPwt9mYGowBMWQeUPaSD TgeaZhhupEri6QwCOsJ3b+cJp3sNl6oIAcrkPmYd8q+RI8rH1Hpbqp/MQRsakg== Received: from localhost (osgiliath.local [local]) by osgiliath.local (OpenSMTPD) with ESMTPA id f5be1309 for ; Thu, 11 Nov 2021 21:59:15 +0000 (UTC) From: "Jose A. Ortega Ruiz" To: bug-gnu-emacs@gnu.org Subject: 29.0.50; gnus-search uses `message' instead of `gnus-message' User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) X-Debbugs-Package: emacs,gnus X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: Date: Thu, 11 Nov 2021 21:59:15 +0000 Message-ID: <87h7cixsjw.fsf@gnus.jao.io> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=217.70.178.232; envelope-from=mail@jao.io; helo=relay12.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Hi, In gnus-search, there are several logs (some of them quite verbose when one's iterating over long lists of groups) using `message'. I think that it'd be better to use `gnus-message' instead, with levels as appropriate. That way one can avoid (or enable!) them via gnus-verbose. I'm attaching a patch changing them all to level 7, since they looked like debug messages to me; but it's just a suggestion. Thanks! jao --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Use-gnus-message-for-logging-in-gnus-search.patch >From 0ea1df942474f8decb71a71c7f2ed03d86ef8991 Mon Sep 17 00:00:00 2001 From: jao Date: Thu, 11 Nov 2021 21:54:19 +0000 Subject: [PATCH] Use gnus-message for logging in gnus-search --- lisp/gnus/gnus-search.el | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el index 3157358804..a4d319b4b8 100644 --- a/lisp/gnus/gnus-search.el +++ b/lisp/gnus/gnus-search.el @@ -1018,7 +1018,7 @@ gnus-search-run-search (single-search (gnus-search-single-p query)) (grouplist (or groups (gnus-search-get-active srv))) q-string artlist group) - (message "Opening server %s" server) + (gnus-message 7 "Opening server %s" server) (gnus-open-server srv) ;; We should only be doing this once, in ;; `nnimap-open-connection', but it's too frustrating to try to @@ -1062,7 +1062,7 @@ gnus-search-run-search (when (nnimap-change-group (gnus-group-short-name group) server) (with-current-buffer (nnimap-buffer) - (message "Searching %s..." group) + (gnus-message 7 "Searching %s..." group) (let ((result (gnus-search-imap-search-command engine q-string))) (when (car result) @@ -1075,7 +1075,7 @@ gnus-search-run-search (vector group artn 100)))) (cdr (assoc "SEARCH" (cdr result)))) artlist)))) - (message "Searching %s...done" group)))) + (gnus-message 7 "Searching %s...done" group)))) (nreverse artlist)))) (cl-defmethod gnus-search-imap-search-command ((engine gnus-search-imap) @@ -1330,8 +1330,8 @@ gnus-search-run-search (erase-buffer) (if groups - (message "Doing %s query on %s..." program groups) - (message "Doing %s query..." program)) + (gnus-message 7 "Doing %s query on %s..." program groups) + (gnus-message 7 "Doing %s query..." program)) (setq proc (apply #'start-process (format "search-%s" server) buffer program cp-list)) (while (process-live-p proc) @@ -1837,8 +1837,8 @@ gnus-search-run-search (mapcar (lambda (x) (let ((group x) artlist) - (message "Searching %s using find-grep..." - (or group server)) + (gnus-message 7 "Searching %s using find-grep..." + (or group server)) (save-window-excursion (set-buffer buffer) (if (> gnus-verbose 6) @@ -1893,8 +1893,8 @@ gnus-search-run-search (vector (gnus-group-full-name group server) art 0) artlist)) (forward-line 1))) - (message "Searching %s using find-grep...done" - (or group server)) + (gnus-message 7 "Searching %s using find-grep...done" + (or group server)) artlist))) grouplist)))) -- 2.33.1 --=-=-=-- ------------=_1638552541-16299-1--