Subject: Re: [PATCH] gnu: Add font-source-code-pro.

From: Liliana Marie Prikler <[email-masked]>
Date: Mon, 15 Nov 2021 20:56:21 +0100

Hi,

Am Donnerstag, den 11.11.2021, 19:22 +0000 schrieb phodina:
> * gnu/packages/fonts.scm (font-source-code-pro): New variable.
> 
> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
> index 3f36a71bdd..9ac7e9e127 100644
> --- a/gnu/packages/fonts.scm
> +++ b/gnu/packages/fonts.scm
> @@ -1470,6 +1470,26 @@ (define-public font-sarasa-gothic
>       "Sarasa Gothic is a programming font based on Iosevka and
> Source Han Sans,
>  most CJK characters are same height, and double width as ASCII
> characters.")))
> 
> +(define-public font-source-code-pro
> +  (package
> +    (name "font-source-code-pro")
> +    (version "2.038")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "
> https://github.com/adobe-fonts/source-code-pro")
> +                    (commit (string-append version "R-ro/1.058R-
> it/1.018R-VAR"))))
Am I allowed to ask WTF this versioning scheme is?  Should we just pin
a hash instead?
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "00h4v3rmxyyaxni6nywacxvjnji2g2pi0b4js1yx0g67fvrv2ga
> g"))))
> +    (build-system font-build-system)
> +    (synopsis "Font for coding environments")
> +    (description "Font Source Code Pro is sedigned as a companion to
> Source
> +Sans.")
This scrediption is not very scrediptive ;)  Jokes aside, I'd add "[It]
preserves the design features and vertical proportions of Source Sans,
but alters the glyph widths so that they are uniform across all glyphs
and weights." so that Adobe bois know what they're getting.
> +    (home-page "https://fonts.google.com/specimen/Source+Code+Pro")
I'm not sure whether linking to Google fonts of all places is good
praxis.  Might want to link to Github instead.  FWIW the repo
advertises this: https://adobe-fonts.github.io/source-code-pro/

Cheers