Subject: bug#51774: closed (Re: [PATCH v2] gnu: font-adobe-source-code-pro: Update to 2.032R-ro-1.052R-it-1.012R-VAR.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 17 Nov 2021 17:19:02 +0000

Your bug report

#51774: [PATCH] gnu: Add font-source-code-pro.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
51774: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51774
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [PATCH v2] gnu: font-adobe-source-code-pro: Update to 2.032R-ro-1.052R-it-1.012R-VAR.
From: Liliana Marie Prikler <[email-masked]>
To: phodina <[email-masked]>
Cc: "[email-masked]" <[email-masked]>, [email-masked]
Date: Wed, 17 Nov 2021 18:17:57 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Am Mittwoch, den 17.11.2021, 12:25 +0000 schrieb phodina:
> Hi Liliana,
> 
> > This regexp could be simplified by noticing that it's always
> > 
> > <VERSION>R-<TAG>/<VERSION>R-<TAG>/<VERSION>R-<TAG>, whereas we use
> > 
> > <VERSION>R-<TAG>-<VERSION>R-<TAG>-<VERSION>R-<TAG>. So simply use a
> > 
> > regexp that matches <VERSION>R-<TAG>- and then replace just the
> > dash
> > 
> > with a slash. That being said, I'm not sure how much cleaner this
> > is
> > 
> > compared to let-binding
> > 
> > Cheers.
> 
> Thanks. I saw the pattern just I have issue writing down the regexp
> in Guile. Now you made me learn them properly :-D
> 
> 
> * gnu/packages/fonts (font-adobe-source-code-pro): Update to
>   2.032R-ro-1.052R-it-1.012R-VAR and update regexp in commit.
--
Please really really really insert comments that shouldn't turn up in
the commit log here.  It makes it way easier if we don't have to strip
them.

Pushed with some slight adjustments to the ChangeLog and aforementioned
stripping.

Cheers

Subject: [PATCH] gnu: Add font-source-code-pro.
From: phodina <[email-masked]>
To: Guix Patches <[email-masked]>
Date: Thu, 11 Nov 2021 19:22:13 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/fonts.scm (font-source-code-pro): New variable.

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 3f36a71bdd..9ac7e9e127 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -1470,6 +1470,26 @@ (define-public font-sarasa-gothic
      "Sarasa Gothic is a programming font based on Iosevka and Source Han Sans,
 most CJK characters are same height, and double width as ASCII characters.")))

+(define-public font-source-code-pro
+  (package
+    (name "font-source-code-pro")
+    (version "2.038")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/adobe-fonts/source-code-pro")
+                    (commit (string-append version "R-ro/1.058R-it/1.018R-VAR"))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "00h4v3rmxyyaxni6nywacxvjnji2g2pi0b4js1yx0g67fvrv2gag"))))
+    (build-system font-build-system)
+    (synopsis "Font for coding environments")
+    (description "Font Source Code Pro is sedigned as a companion to Source
+Sans.")
+    (home-page "https://fonts.google.com/specimen/Source+Code+Pro")
+    (license license:silofl1.1)))
+
 (define-public font-space-grotesk
   (package
     (name "font-space-grotesk")
--
2.33.0