Subject: bug#51765: closed (Re: [PATCH 1/6] gnu: python-asdf: Update to 2.8.3)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 30 Jan 2022 15:08:02 +0000

Your bug report

#51765: [PATCH]: gnu: Add python-gwcs

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
51765: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51765
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [PATCH 1/6] gnu: python-asdf: Update to 2.8.3
From: Vinicius Monego <[email-masked]>
To: Sharlatan Hellseher <[email-masked]>, [email-masked]
Date: Sun, 30 Jan 2022 15:07:03 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Em sex, 2022-01-14 às 23:40 +0000, Sharlatan Hellseher escreveu:
> * gnu/packages/astronomy.scm: (python-asdf): Update to 2.8.3
>   Refactor package style.
>   [inputs]->[propagated-inputs]: To satisfy sanity checks of other
>   packages depended on python-asdf. Add new input python-jmespath
> ---
>  gnu/packages/astronomy.scm | 37 +++++++++++++++++++-----------------
> -
>  1 file changed, 19 insertions(+), 18 deletions(-)
> 
> diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
> index a7a07fa3a8..f1392c55e3 100644
> --- a/gnu/packages/astronomy.scm
> +++ b/gnu/packages/astronomy.scm
> @@ -1269,34 +1269,35 @@ (define-public python-sep
>  (define-public python-asdf
>    (package
>      (name "python-asdf")
> -    (version "2.7.4")
> +    (version "2.8.3")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (pypi-uri "asdf" version))
>         (sha256
> -        (base32
> "1mj52l2m8pbhiqacgjakjpvqi8kyx470yw151lcsswbq5wp0rsc6"))))
> +        (base32
> "0i4vq1hsympjgb1yvn4ql0gm8j1mki9ggmj03533kmg0nbzp03yy"))))
>      (build-system python-build-system)
>      (arguments
> -     ;; TODO: (Sharlatan-20210207T165820+0000): Tests depend on
> astropy, astropy
> -     ;; depends on asdf. Disable circular dependence.
> -     `(#:tests? #f))
> +     ;; NOTE: (Sharlatan-20211229T201059+0000): Tests depend on
> astropy and
> +     ;; gwcs, astropy gwcs depend on asdf. Disable circular
> dependence.
> +     (list #:tests? #f))
>      (native-inputs
> -     `(("packaging" ,python-packaging)
> -       ("semantic-version" ,python-semantic-version)
> -       ("setuptools-scm" ,python-setuptools-scm)))
> -     (inputs
> -      `(("importlib-resources" ,python-importlib-resources)
> -        ("jsonschema" ,python-jsonschema)
> -        ("numpy" ,python-numpy)
> -        ("pyyaml" ,python-pyyaml)))
> -     (home-page "https://github.com/asdf-format/asdf")
> -     (synopsis "Python tools to handle ASDF files")
> -     (description
> -      "The Advanced Scientific Data Format (ASDF) is a next-
> generation
> +     (list python-setuptools-scm
> +           python-semantic-version
> +           python-packaging))
> +    (propagated-inputs
> +     (list python-importlib-resources
> +           python-jsonschema
> +           python-jmespath
> +           python-numpy
> +           python-pyyaml))
> +    (home-page "https://github.com/asdf-format/asdf")
> +    (synopsis "Python tools to handle ASDF files")
> +    (description
> +     "The Advanced Scientific Data Format (ASDF) is a next-
> generation
>  interchange format for scientific data.  This package contains the
> Python
>  implementation of the ASDF Standard.")
> -     (license license:bsd-3)))
> +    (license license:bsd-3)))
>  
>  (define-public python-astroalign
>    (package

Ideally this change should be in two separate commits: one to propagate
inputs and another to update, but I'm going to leave this one as is for
this time.

I also made the following changes:

- Adjusted commit messages
- Set schema variables as non-public
- Changed descriptions
- Moved gwcs definition closer to the other variables
- Updated your copyright line
  
and pushed the whole series, thanks!

Subject: [PATCH]: gnu: Add python-gwcs
From: Sharlatan Hellseher <[email-masked]>
To: [email-masked]
Date: Thu, 11 Nov 2021 13:17:49 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

successfully built
/gnu/store/w870dhpqfq5ycggj9510kj1y54wqgz7v-python-gwcs-0.16.1.drv

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
From 5504205f6fcff3741c86bc8e9d203ea5da2ab431 Mon Sep 17 00:00:00 2001
From: Sharlatan Hellseher <[email-masked]>
Date: Thu, 11 Nov 2021 13:14:41 +0000
Subject: [PATCH] gnu: Add python-gwcs

* gnu/packages/astronomy.scm: (python-gwcs): New variable.
---
 gnu/packages/astronomy.scm | 43 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index fc8959faad..59708e8e6b 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -708,6 +708,49 @@ (define-public python-astropy
 astronomy and astrophysics.")
     (license license:bsd-3)))
 
+(define-public python-gwcs
+  (package
+   (name "python-gwcs")
+   (version "0.16.1")
+   (source
+    (origin
+     (method url-fetch)
+     (uri (pypi-uri "gwcs" version))
+     (sha256
+      (base32 "0xjmv0v8bdzhpq61gvp76bx17pbcvxs8vp2gmn0rgs01zkrg8csk"))))
+   (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key inputs outputs tests? #:allow-other-keys)
+             (when tests?
+               (add-installed-pythonpath inputs outputs)
+               (invoke "python" "-m" "pytest" "--pyargs" "gwcs")))))))
+   (native-inputs
+    `(("python-jsonschema" ,python-jsonschema)
+      ("python-pytest" ,python-pytest)
+      ("python-pytest-doctestplus" ,python-pytest-doctestplus)
+      ("python-pyyaml" ,python-pyyaml)
+      ("python-semantic-version" ,python-semantic-version)
+      ("python-setuptools-scm" ,python-setuptools-scm)))
+   (propagated-inputs
+    `(("python-asdf" ,python-asdf)
+      ("python-astropy" ,python-astropy)
+      ("python-numpy" ,python-numpy)
+      ("python-scipy" ,python-scipy)))
+   (home-page "https://gwcs.readthedocs.io/en/latest/")
+   (synopsis "Generalized World Coordinate System")
+   (description
+    "Generalized World Coordinate System (GWCS) is an Astropy affiliated package
+providing tools for managing the World Coordinate System of astronomical data.
+
+GWCS takes a general approach to the problem of expressing transformations
+between pixel and world coordinates.  It supports a data model which includes the
+entire transformation pipeline from input coordinates (detector by default) to
+world coordinates.  It is tightly integrated with Astropy.")
+   (license license:bsd-3)))
+
 (define-public libnova
   (package
     (name "libnova")
-- 
2.33.1