Subject: Re: [bug#51739] [PATCH 3/3] gnu: Add rdate.

From: Leo Famulari <[email-masked]>
Date: Wed, 10 Nov 2021 17:29:44 -0500

On Wed, Nov 10, 2021 at 03:08:17AM +0000, phodina via Guix-patches via wrote:
> * gnu/packages/time.scm (rdate): New variable.

Thanks for the patch!

> +(define-public rdate
> +  (let ((commit "91d84610e3695e90a884e2953908e95a856a9b74")
> +        (revision "1"))
> +    (package
> +      (name "rdate")
> +      (version commit)

As described in the manual section Version Numbers [0], we should use the
git-version procedure to create the package's version. As the most
recent Git tag before the specified commit is 1.4, it would be like
this:

(version (git-version "1.4" revision commit))

> +      (synopsis "Get date and time based on RFC 868")
> +      (description "@code{rdate} connects to an RFC 868 time server over a TCP/IP
> +network, printing the returned time and/or setting the system clock.")
> +      (home-page "https://www.aelius.com/njh/rdate/")
> +      (license license:gpl2))))

The license header of 'src/rdate.c' says "version 2 of the License, or
(at your option) any later version.", so the license is gpl2+.

Can you send a revised patch?

[0] https://guix.gnu.org/manual/en/html_node/Version-Numbers.html