GNU bug report logs - #51735
[PATCH] tests: fix test logic for pcre-context

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#51735: closed ([PATCH] tests: fix test logic for pcre-context)
Date: Thu, 11 Nov 2021 02:26:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 10 Nov 2021 18:25:18 -0800
with message-id <b00e097f-a027-b4ad-3e52-e43b2ecd3910 <at> cs.ucla.edu>
and subject line Re: bug#51735: [PATCH] tests: fix test logic for pcre-context
has caused the debbugs.gnu.org bug report #51735,
regarding [PATCH] tests: fix test logic for pcre-context
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
51735: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51735
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Carlo Marcelo Arenas Belón <carenas <at> gmail.com>
To: bug-grep <at> gnu.org
Cc: Carlo Marcelo Arenas Belón <carenas <at> gmail.com>
Subject: [PATCH] tests: fix test logic for pcre-context
Date: Tue,  9 Nov 2021 17:02:39 -0800

Included in the original bug #20957, but corrupted somehow in
transit as the required NUL characters are missing.

Add a simpler version of the test case that uses plain characters
and match the -z data and output to show the equivalence.

Note the output is still not correct as it is missing the expected
LF characters, but a full fix will have to wait until PCRE2.

Signed-off-by: Carlo Marcelo Arenas Belón <carenas <at> gmail.com>
---
 tests/pcre-context | 40 ++++++++++++++++++++++------------------
 1 file changed, 22 insertions(+), 18 deletions(-)

diff --git a/tests/pcre-context b/tests/pcre-context
index b910a20..77cb863 100755
--- a/tests/pcre-context
+++ b/tests/pcre-context
@@ -4,29 +4,33 @@
 require_pcre_
 
 cat >in <<'EOF'
-Preceded by 0 empty lines.
-
-Preceded by 1 empty line.
-
-
-Preceded by 2 empty lines.
-
-
-
-Preceded by 3 empty lines.
-
-
-
-
-Preceded by 4 empty lines.
+b0
+ab1
+aab2
+aaab3
+aaaab4
+EOF
+test $? -eq 0 || framework_failure_
 
+cat >exp <<'EOF'
+b3
+ab4
 EOF
 test $? -eq 0 || framework_failure_
 
+grep -Po '(?<=aaa).*' in >out || fail_ 'grep -Po failed'
+compare exp out || fail=1
+
+printf 'NUL preceded by 0 empty lines.\0' >in &&
+printf '\nNUL preceded by 1 empty line.\0' >>in &&
+printf '\n\nNUL preceded by 2 empty lines.\0' >>in &&
+printf '\n\n\nNUL preceded by 3 empty lines.\0' >>in &&
+printf '\n\n\n\nNUL preceded by 4 empty lines.\0' >>in &&
+printf '\n' >>in || framework_failure_
+
 printf '%s\0' \
-       'Preceded by 2 empty lines.' \
-       'Preceded by 3 empty lines.' \
-       'Preceded by 4 empty lines.' >exp || framework_failure_
+       'NUL preceded by 3 empty lines.' \
+       'NUL preceded by 4 empty lines.' >exp || framework_failure_
 
 fail=0
 
-- 
2.34.0.rc1.349.g8f33748433

[Message part 3 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Carlo Marcelo Arenas Belón <carenas <at> gmail.com>
Cc: 51735-done <at> debbugs.gnu.org
Subject: Re: bug#51735: [PATCH] tests: fix test logic for pcre-context
Date: Wed, 10 Nov 2021 18:25:18 -0800

[Message part 4 (text/plain, inline)]

Thanks, I installed that with the attached minor fixup patch afterwards.

[0001-tests-fix-pcre-test-typo.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.