GNU bug report logs - #51712
29.0.50; [PATCH] New function `xwidget-webkit-load-html'

Previous Next

Full log

Message #17 received at 51712 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: larsi <at> gnus.org, 51712 <at> debbugs.gnu.org
Subject: Re: bug#51712: 29.0.50; [PATCH] New function
 `xwidget-webkit-load-html'
Date: Wed, 10 Nov 2021 07:56:02 +0800

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> Then I'd suggest not to have it defined on non-GTK builds for now.  It
> is confusing to have a function that silently does nothing (after
> wasting some cycles).

Thanks, I'll keep that in mind.

> I'd say that TEXT should be a string.  The name itself doesn't
> necessarily say so.

Fixed, thanks.
>> +Optional argument @var{base-uri}, which should be a string, specifies
>> +the location of web resources, such as the resource @samp{foo.png} in
>> +the HTML tag @samp{<img src="foo.png">}.  It defaults to
>> +@samp{about:blank}.

> Hmm... this is better, but at least I am still in the dark regarding
> the need for this optional argument.  E.g., what would happen if you
> use that tag, but don't specify the URI?

I'm in the dark too.  I am not a web developer, and browser engines are
remarkably lax about these things, but hopefully Lars can explain better
(after all, shr must deal with these things too), so I added him to the
Ccs.

> This still leaves me wondering why the entry talks about temporary
> files.

Previously, loading custom markup into a widget required using a
temporary file to store the markup.

>> +DEFUN ("xwidget-webkit-load-html", Fxwidget_webkit_load_html,
>> +       Sxwidget_webkit_load_html, 2, 3, 0,
>> +       doc: /* Make XWIDGET's WebKit widget render text.
>                                                       ^^^^
> "text" should be in CAPS.

Thanks.

[0001-Add-xwidget-webkit-load-html.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.