From unknown Sat Aug 16 00:30:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#51707 <51707@debbugs.gnu.org> To: bug#51707 <51707@debbugs.gnu.org> Subject: Status: 29.0.50; [PATCH] Fix a crash on X when trying to show a tiny xwidget inside a tiny window Reply-To: bug#51707 <51707@debbugs.gnu.org> Date: Sat, 16 Aug 2025 07:30:42 +0000 retitle 51707 29.0.50; [PATCH] Fix a crash on X when trying to show a tiny = xwidget inside a tiny window reassign 51707 emacs submitter 51707 Po Lu severity 51707 normal tag 51707 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 09 02:39:07 2021 Received: (at submit) by debbugs.gnu.org; 9 Nov 2021 07:39:07 +0000 Received: from localhost ([127.0.0.1]:60657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkLil-0000Nd-1H for submit@debbugs.gnu.org; Tue, 09 Nov 2021 02:39:07 -0500 Received: from lists.gnu.org ([209.51.188.17]:36152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkLii-0000NU-2p for submit@debbugs.gnu.org; Tue, 09 Nov 2021 02:39:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkLih-0002cn-8F for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 02:39:03 -0500 Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]:44367) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkLie-0002ro-LC for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 02:39:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636443538; bh=WlSHb49WCvuppWOygS93SMwv4GhmRgmhgcoS5Ay2VlI=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=LPB5zwd9SOu2NVj81+bXisheCfJ3Dxi1EvGlkmoR4DSuA4uboF8dmLRMj7oI6cPKgDYEwPkzWfMsyh3QX/lBru/okfHyi2s9dx/jexqUIWLq17DQCyqLgjfKUvVuUJ8tYYOykif8xWTry5VDPSCzsR32B9m3uGo+pZyjWC/P33TAohERCDkKi1OoXFgQ05332Hq3myoNAypQx3qLe310tkEk/aqNEEie1+ESzk+YRXjBffblWYlmW5oD6yHXKgJ7jYAPXk6mnolcpop1rNeguQ9PogMF8vQ3xWhQbzn+BeRfdLzPxxjb0xYknK2Na9lfwz6sDaiMR7J0IOk/bWQD6w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636443538; bh=1cSYp6cvwCkCMenM2+2sVrK8i8DnQYdeRi8r6p/kqQo=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=rN1qy2SvbnHrFA/9YF/PMqesH/ccAwHYt8FXI0dd6wrEC4MubXO7UCILdWb2RrRmjQ1QRR5u18HV0yuRYU3nv+rJx3xRHRIm4dQdSZkxODTjEk0oNJdsEogIg3vuqkBRgSMF8xT31HGKc+J1hfDV01z8hl6ALClCuNUskxruZHkYvSNI+i48egE/YGcOCNp4/Vs2/0U7QPPDiQ1bHpx7Kgxwe1ygNQZmhBjTiYkgN0ZeYRRYaLFfGN3z/clx8OkuXYJpTiIPPCm88sevYbALgMWrcmVMXfH2ucRELClZDoeME0jUdBzRa27OcpowdGnre+Quv/x3+ZNEz5e15gHEXQ== X-YMail-OSG: iNZTdSgVM1l0cjfix9G6RGMA_yvx03pWYKQXb7Sn0jGrOwXQvW7.tkdCZv1TDyG DZFzDQ5lvFEy1cZDoEYlV05jNeXJPYMV8FTM0YY3tSfKqwwUIKvjw.CZaErtH51Q7pm4SFUPFUGI roMN9am7PPy3RDPq6vs_G4gRnxZ4jIvcbwGeXY8VYOyZyKajcjp526pgNYuMl7LQuW_bnUCaUdTh Ymgsh0xnUlyiQj2qZQccdvqw2WIrEcqgxsPRbth2B0HIDtPV9pxk5MV1.01fRNt3irtPx4bCWBZb 8.hzw6cx0Lb68jM.6CVDqTyWpEQ.8.oaWDRjvgZcphdHExeTvO29dJ8jyaDnRQqMje49VgjCOLh8 lbeMMGTm.F45jDbp6q21htdZufNB_ujsXD_MHS.SMvn2MP6kpZRbUQECn1LcQPDJ1.0Bi.AQwNN6 Do_d4FYYLFgV6w0xErtk.VTEvockJyCRCHMu_vGL_FRgI7OJVCU_vo69m3EcTuM5COt1ksMGuXP5 _.wBYqcJQVdkf55GDmv9M66f8uH4BPAe1wl93egA94q8Aguwiwo2AWf.XI2pd51GPiZzscNRd5z. Zb7BzJxRp6UDtjsA0uYvAjZnIbkhMoIdMF23BUcUf2nC3pExobzhnccyyubCmT9EpPb20qs_.Twg PXU2XP3hPW2WXOQ_DLD0yuxtcezwy.0nWcf7GvOWlQOaOp2jqb8807refe9EenyLeBoBqNqm1GuS tE9SAKLlTRS8oC8mqGQ2bLovlqMqAqgQXtiKF_W8T5tCHLlgB4mIm8_Ki0wvMoPF2Y_YbOEzCyUp J2jWivOhjfXE70KJPrlJ3EyOvXrUEkD09bTbwJi1MHB7awIBFsKOLde.JmlsjU.xa.ySxs29n5SM M8uEfNJ9vCTxxJ4VHF3ZKZd6Df..BW6FBrfMtDJI4ZEY98AR6u7l5b2RmkvZMt5Y1alvseQi1lh5 JI3LVukycZaPDaLgaBamAdhJAKpCUOHTexkMVAsUE7SsFkf2gkiyvas.j601_VIj3WMxNTK3SsMi HCQMmkKZDbQUxO42jMbn.AVghNLCc0Ga3M2Z4iooUt8PCeCvHn84m6HkR.QfEWuzkjKqBglx11nr yP2J6rypVmlELfnqlLcJiIbaBFKzingXu94Xuy00kFuprZLmBZ.7lwi7yROEE53236S659oz5Q_S 5NWqzh.DooXK7sxSqdg8dmsx8Za5k1ba1XRto8ew0aBLO1FAqFR3LJQw8_EybdTLqJfSGeYWmbvv uD_n83LD0zzrjgrK7etX.wmLHyy8SeyNIzpTECKAgr_KJ7f09iV5SqaF_H47mX2Gwo84FK1UhzlI v1.gIlPuBEB_NugzFPjSOss7BKcJzlEs9y6j40sH6W5cn0FFvOqEg.mxSWe65DGE0Mlig9nhKMIw fukQvl_SHGuuZ2PwzLDg872KJBhI6zWybe61KQU1hRfp9_CncGPlxNKgj6B0je0rbYC1jQEFRZp0 6i3y0JZJ_4el8x1z19eZ2_YCGYaGH44QOc5mOKvYaI_O4KS7grI8ZN4w_DxawHsgxaFL9LttNb0l Tp6mB9T__JwVia2tioFiJrEUwwo_5wa_B2.UStyE7Q5_LmjYyeF78Ndo38WSPptVuhPIdUcKInU1 04_0qk3oh9KDPuSVSKxLgnMkdpnWsD.8qas2NGeCjKch2DdNvwJDjGN8SKul_gCcfw1l8FX9KwyI iUm9lDs6Kc8LVLD9DBx9iM2S45rXDn1bIo_PufvzNYKmJOweZv384thwKCVVQ14r21IYK1vBL03I mCtNjUWBm08FA9sdthSmKbisE.T2uONIxnQe_n.mjZGbZmEtIdIbz6Ur7w_SdktajkPoIXQGUrnB QpwCnZp6SGNLjhcou1SgHhJdiICy_EL0W2ZUWBOtu_gtHuXuv6iW.maH7fCOEz2BoCVzfKsi7ndi zfzp3EPJipDTmF50v8Hti6gDJY6sNgjMRFD2OMtLaYPdugOT5JkXeVS9IH3MY_SKdUTdiBp6D6RA LFe44jsSvahtxwiWH30bjKFDoLHU7FeGvfMe7XuxKq7YyIKfQTh0CBzFgf92yvfTDHCX1QRq1Sk8 3ju5yJXBMnPSjsZmdxbakA2RYKX1C.nhbh8MfFEwDmcI5g_Ve5gmHW8hkEsuWxxFt5r2SkDkkZxy 7ziIvyGI3HKZQpC3uq.AOG_VkZfHnfCxQtKN59hqNUU89JaH527M7NwDZsB5LPAyqkWFpxXV4dbX fkNja02K4qFTUdP9wkTiszNKBOVOJbJHj9g-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Tue, 9 Nov 2021 07:38:58 +0000 Received: by kubenode503.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 470de75b59c69a08de037a3f853c44f4; Tue, 09 Nov 2021 07:38:55 +0000 (UTC) From: Po Lu To: bug-gnu-emacs@gnu.org Subject: 29.0.50; [PATCH] Fix a crash on X when trying to show a tiny xwidget inside a tiny window Date: Tue, 09 Nov 2021 15:38:51 +0800 Message-ID: <87lf1x93sk.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" References: <87lf1x93sk.fsf.ref@yahoo.com> X-Mailer: WebService/1.1.19266 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1844 Received-SPF: pass client-ip=66.163.185.33; envelope-from=luangruo@yahoo.com; helo=sonic313-10.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) --=-=-= Content-Type: text/plain Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Prevent-BadValue-errors-when-creating-tiny-xwidget-v.patch >From da3b274bb17c7283bc73fefc4bc38803ef895523 Mon Sep 17 00:00:00 2001 From: Po Lu Date: Tue, 9 Nov 2021 15:37:01 +0800 Subject: [PATCH] Prevent BadValue errors when creating tiny xwidget views * src/xwidget.c (x_draw_glph_string): Avoid resizing xwidget views to an invalid size. --- src/xwidget.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/xwidget.c b/src/xwidget.c index d3a8d5eb82..fc76ce307e 100644 --- a/src/xwidget.c +++ b/src/xwidget.c @@ -1439,6 +1439,13 @@ x_draw_xwidget_glyph_string (struct glyph_string *s) a.event_mask = (ExposureMask | ButtonPressMask | ButtonReleaseMask | PointerMotionMask | EnterWindowMask | LeaveWindowMask); + if (clip_right - clip_left <= 0 + || clip_bottom - clip_top <= 0) + { + unblock_input (); + return; + } + xv->wdesc = XCreateWindow (xv->dpy, FRAME_X_WINDOW (s->f), x + clip_left, y + clip_top, clip_right - clip_left, @@ -1484,8 +1491,17 @@ x_draw_xwidget_glyph_string (struct glyph_string *s) #ifdef USE_GTK if (!wdesc_was_none && !moved) { - XResizeWindow (xv->dpy, xv->wdesc, clip_right - clip_left, - clip_bottom - clip_top); + if (clip_right - clip_left <= 0 + || clip_bottom - clip_top <= 0) + { + XUnmapWindow (xv->dpy, xv->wdesc); + xv->hidden = true; + } + else + { + XResizeWindow (xv->dpy, xv->wdesc, clip_right - clip_left, + clip_bottom - clip_top); + } XFlush (xv->dpy); cairo_xlib_surface_set_size (xv->cr_surface, clip_right - clip_left, clip_bottom - clip_top); -- 2.31.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 09 18:53:09 2021 Received: (at 51707) by debbugs.gnu.org; 9 Nov 2021 23:53:09 +0000 Received: from localhost ([127.0.0.1]:36244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkavN-00007a-Ib for submit@debbugs.gnu.org; Tue, 09 Nov 2021 18:53:09 -0500 Received: from quimby.gnus.org ([95.216.78.240]:36082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkavK-000071-Hl for 51707@debbugs.gnu.org; Tue, 09 Nov 2021 18:53:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EzjCq6eKLs97tJ7IVqu0gCEaoruNG+kqdDvmV+fnWHQ=; b=Efh9OfH1KYEoJA0KYFQxY9ZQ/9 dxTPzQiFxx3xma9fZXpAvgAWUpoa+De8aZNBm26OjkIGTu7RlEgnkXSoxHUQHjMZXci2iAaQ65V9T 59SDDwUTHuO1QpfR8iExLX+HiWobCZm/dGsndMUpz8bw0owT9M0SvnHwW6E7fDkeg+Js=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkavB-0007mB-Ch; Wed, 10 Nov 2021 00:52:59 +0100 From: Lars Ingebrigtsen To: Po Lu Subject: Re: bug#51707: 29.0.50; [PATCH] Fix a crash on X when trying to show a tiny xwidget inside a tiny window References: <87lf1x93sk.fsf.ref@yahoo.com> <87lf1x93sk.fsf@yahoo.com> X-Now-Playing: Kate Bush's _Remastered (3): Never For Ever_: "Blow Away" Date: Wed, 10 Nov 2021 00:52:56 +0100 In-Reply-To: <87lf1x93sk.fsf@yahoo.com> (Po Lu's message of "Tue, 09 Nov 2021 15:38:51 +0800") Message-ID: <875yt0naxz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Po Lu writes: > Thanks. Thanks; now pushed. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51707 Cc: 51707@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Po Lu writes: > Thanks. Thanks; now pushed. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 09 18:53:13 2021 Received: (at control) by debbugs.gnu.org; 9 Nov 2021 23:53:13 +0000 Received: from localhost ([127.0.0.1]:36247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkavQ-00007p-OH for submit@debbugs.gnu.org; Tue, 09 Nov 2021 18:53:13 -0500 Received: from quimby.gnus.org ([95.216.78.240]:36098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkavP-00007Q-FR for control@debbugs.gnu.org; Tue, 09 Nov 2021 18:53:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XuGbsz81qWx5UHu/ogJmIIwWhqCreUh+1YmMFdOfMKA=; b=qprZZBtUhj5FuVl/Tiw+fOREfu MtbLbY/mEmnO6yLfB4n6kpJBUvkFtNhX3LfbdOarVtjUZFeP7pvIKlqGuVsTwy0EurkpsGx9CY5gf aqe2ulYRRkP42ZuKKw/XyMblylks8jSbYsAg7GlSWjmo1VJr+swqh/KW9Ryyg0ugSr+g=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkavH-0007mM-H1 for control@debbugs.gnu.org; Wed, 10 Nov 2021 00:53:05 +0100 Date: Wed, 10 Nov 2021 00:53:03 +0100 Message-Id: <874k8knaxs.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #51707 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 51707 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 51707 29.1 quit From unknown Sat Aug 16 00:30:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 08 Dec 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator