From unknown Sat Aug 16 18:40:57 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#51682 <51682@debbugs.gnu.org> To: bug#51682 <51682@debbugs.gnu.org> Subject: Status: 29.0.50; [PATCH] Raise an error if creating an unknown xwidget type Reply-To: bug#51682 <51682@debbugs.gnu.org> Date: Sun, 17 Aug 2025 01:40:57 +0000 retitle 51682 29.0.50; [PATCH] Raise an error if creating an unknown xwidge= t type reassign 51682 emacs submitter 51682 Po Lu severity 51682 normal tag 51682 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 08 02:08:06 2021 Received: (at submit) by debbugs.gnu.org; 8 Nov 2021 07:08:06 +0000 Received: from localhost ([127.0.0.1]:55884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjylC-0000a8-8W for submit@debbugs.gnu.org; Mon, 08 Nov 2021 02:08:06 -0500 Received: from lists.gnu.org ([209.51.188.17]:57280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjyl7-0000Zi-9t for submit@debbugs.gnu.org; Mon, 08 Nov 2021 02:08:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjyl6-0000Yb-VP for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2021 02:08:00 -0500 Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:40149) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjyl4-0002Gf-Bl for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2021 02:08:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636355276; bh=iyeeaSQWmu9wLaem2s/AEJgAfFfrBpp/LFsLqmqFtNw=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=KsTmfvFSpZjeYNl+IMxl+SVD4Z7n/bgzYHq8OsYcJLk9OAanJyGzX7K8AYEyht849dilPGKuALodwQEKKrios3DJUqvM3JX0reucZeOPV20xxM2my508KwFSUeLnK6jD2hpEDmDjeMbpaPrrSdLu9ww6UIDjaK1zgKhqWFC8eBIyNuJPWTUh/36CEXlYxp6WiSmyNB0cANVGAG9ortofBM5PvR4A2f5xjRK9RsuHxWrjAY5C3M7VwW5L5OU5wUKNnZlZpM7mu2GR7sFxiCNX3NGdfzCNoYg9f23Cfbq0XJ8bagutO4bPAQuT+CdexCCuHAJ/CUXKLI46wC4jhuQ1Kw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636355276; bh=vMmlYxClaQ624vRiGg4f6pYrWIb3K9AA6/NV5CTbf7b=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=S6+ejsY11s9Im2JAGt/YNtrQrUb7jzC+I4a8+rtI7uwMsu2x0DlrbQD6h13rfomxiBaypv/FGqG8eS0Z6EN3Qi5NrQ0d1q4eCIHQZo7z+JF51xm+VG0hasc6z8d717O4TiodpR/g76q3QPX7Ipurxj0aCXkmrk6W0miUbFu6JfMBDR6GBxn8otu2B304DcrsewZHSoww6Lua714c2DD72gHvX0Hhwv0zyu+O3+0xdbKBnwY44p4GPribrNH2L6NK+XixdzKwoKKnWZ7+jNGf4LI4Dp8AqmFUPwYmdzIKzEKQc61m+omJiw149zo3S0fMpAQ88rIMMv+0CV3214fGmw== X-YMail-OSG: zfVbbfgVM1nJaSZQ8hLHeRvlWAYgJRf7UJYtT5ovRpWz1QSNAJDigijwFEwPC2m a2O6TTYYMY5U56XBbySdW51qqjs0a7WhaWR4MV2j_zu4tziHsqeWt0cDhW1fdleTEnM4UMhoKbXa k0AoBgWTOcic2GatvjphORc4inlG3O3QgRQaDu09I1Aa._3GAYg6NonCvGTYmISmoW1YpZSF1emo ja4DMOPa.ipwkSn2Jou8YyzY.F02dWPf8VNXmsTs826Y4NWGEo5yTgfEMqbiIaU5ucv.ouu3kKiL kVH0KtsjAnDktlM_Sh8mz_aXt5KcCdrjmXIP8O_n7yPxbqx9fjMGSr6y.2UMLpsDwIPjW8H0_9sK uvDuO8FZtg9jonP.mJNUtJ1Xqkaos_WX_zCr26dzr3MUZNj47LSU59mXcvjUqzvxYdYnLoWP.jGb vjVDxuqKJiCrS9tmDqapd8i1mxJ7K9oNfw09_tuLPSmNuNvkpelXVUN278.wUSix_PDL4892WNJV LlfyDA3lx_rSg6HAK2hg2v2H1Cnh.9fratWBh7npzAmMZZMokqx__YhMrnOgSzlz5IrIwO69u_Jm sBZd.cz0kPDviuv9hsDi_du9Kgh26oPGpaIhgMAvXtRm8IK8Qwu4zhLGI0CFUV8W8S54oDvqrcMn wizwnRiV4K5Av_pEJCJvwcCFc5rbf94mU8mICHROxEfFJPsY7atWLP1M5lICRhAryCPpdDiml8dP t654wxK9cn22V8gibMeED0oqPB4zMVCUVvMZGItHdTW7g3.wMhi7eMI4kKOuPxPHPTTQebUkf4tB nKnnt_.8Z2P6FILcU.AB9ktpZMsI7.JX6OhaWBK95aWPYwzMWPOt3bpcSe09qaw2Ngxyt9vdovh4 gvWYkZqYiOFHD0XAF17WLZay.V56Mq0BmawwbOp2zHChm9StEz7X6Y5C04bRBiaPCspw0U9s2QKd AtVPbfAV.xBbVyLz9.jo9l7lMyGoac2Vqcf03l5WTv1hHxIHRymuSotsu__mJvzYq4nES8osIjhA WaSFokE0C.tkkvigcKFwk4iRU42RrTrIGTFySNCvsDWEt3b7ASOfBcU8VE69cFqf6Nt8U4z7cbB4 1nMewAIRnpzVd8HBmSr4D2kktVPXCBg9NzDaah37ve8OSU5TdaEO7EFYnDakwQ08iQlj5I87xsYJ I5rp.zyYEuyPiS5q65FDujdUF31hQUbKVZuGt27IFNDPbUCcwOGIZ2qIsOLR47isTR.sjBPCQUPI .6NOiSZFh8_ICkGaylUiBW8zpANwciFeRBj55jG55laPh4H9asEO.sqtqz6Uq0AxS9p3uODGYPGq bGWw9E2BcXpCF8mztNxI9JtyJSKrFlUb.Q9Jh1miynBY74PfYWgdKjDrKkmXBqc0KFYANTkPpBVr tnd4a7ZBrdJifT6Sa1f_nu8hEwzTkP7VqVqOqmruLMARiG8C_Ifn1pkk.F7Rr9Hnu0nu2EL4sQag BtZ2Bor88C1raKNjeUTnotMQ5lCnO5SVmm5LDniKpqEj1egYCpwmfQpEoxURp1YEeq6Moaf8ksPJ MuNsMPrmvFQjfEP87Jzl9S3ifgBWTkUUQh3pTAL03zZpLKk5oSfGiQxbdBArmAecjOWbPLZyxEih Dj8bFjFif7NnQxnmPTba5zd6AlUmyEE52ba608QuYyHBXg2wUgt1Ih9uXnTcuA7yNOj.pxmqUpPD EXAsQBS6qMtYx5lx0yTHQL57TVrB878CD8BLTb3teUHhJqEG9I8pXXbDlMLJveWNKoWdOQ.RE7wK 2MYBP1xSt4V0ndP66rKPNolZJ1fUFszFEBUqYhILfD5JgxGlgNCQrOpOtZgNSvlvy1bcPnj1nL_N EkoOg.7nPiyDXAE0eSv9J631vxRRq74oj5LgHvk7H7uk38FDfEMyDa2ltnzmjMJ0cSZsOEmGbfVA 8Y.BbvHHJ6mbYeaxlkZBof5vo3TBPYW9MIkvLpdEWYtNtkjj7puW_XntrHNpcvI9BcbL1ffcQkG7 BBuiWI3gRUErpVLGmp.9E31ua.uqb7xAEaiviY8djsrrYlSG63RPnFxx0TcQP7J19EJlwgTWgb_1 URS8MelBfwjbdMBZDZpjWiaLqTKiCywPTwMG53PZqjJxWBEsPFj4zfc0E9qiMmLssENKRu03t7Vx qZJMWUCMWupOe_8e9LfYkAOUStCI9afy2n6CdCY64RT9CFQrCMsyVppWEU4RSBI0RPoUCfemXnDo 47o45H.ZnsdsJMlQbFnicOANt4BiTjJU- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Mon, 8 Nov 2021 07:07:56 +0000 Received: by kubenode514.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 62c128b5df7be8bbe89122b9a663d46b; Mon, 08 Nov 2021 07:07:49 +0000 (UTC) From: Po Lu To: bug-gnu-emacs@gnu.org Subject: 29.0.50; [PATCH] Raise an error if creating an unknown xwidget type Date: Mon, 08 Nov 2021 15:07:45 +0800 Message-ID: <87y25znn0e.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" References: <87y25znn0e.fsf.ref@yahoo.com> X-Mailer: WebService/1.1.19266 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1010 Received-SPF: pass client-ip=66.163.190.31; envelope-from=luangruo@yahoo.com; helo=sonic307-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) --=-=-= Content-Type: text/plain Otherwise code can create bogus xwidgets for whom widget_osr and widgetwindow_osr are NULL, which can cause crashes. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Raise-an-error-if-creating-an-unknown-xwidget-type.patch >From c9155cfe0f1c8c0d51c81db01a0e942f6bed4345 Mon Sep 17 00:00:00 2001 From: Po Lu Date: Mon, 8 Nov 2021 15:06:10 +0800 Subject: [PATCH] Raise an error if creating an unknown xwidget type * src/xwidget.c (Fmake_xwidget): Error if TYPE is invalid. --- src/xwidget.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/xwidget.c b/src/xwidget.c index 2d9351308e..ec0c283c80 100644 --- a/src/xwidget.c +++ b/src/xwidget.c @@ -128,6 +128,9 @@ DEFUN ("make-xwidget", CHECK_FIXNAT (width); CHECK_FIXNAT (height); + if (!EQ (type, Qwebkit)) + error ("Bad xwidget type"); + struct xwidget *xw = allocate_xwidget (); Lisp_Object val; xw->type = type; -- 2.31.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 08 23:04:29 2021 Received: (at 51682) by debbugs.gnu.org; 9 Nov 2021 04:04:29 +0000 Received: from localhost ([127.0.0.1]:60216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkIMo-0004cV-Cc for submit@debbugs.gnu.org; Mon, 08 Nov 2021 23:04:29 -0500 Received: from quimby.gnus.org ([95.216.78.240]:54868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkIMn-0004cH-0C for 51682@debbugs.gnu.org; Mon, 08 Nov 2021 23:04:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c79VObrnlUK2Dy8BUcjA2u6q/N/nW/kSRwW2LTFcP/8=; b=o04l0nAT4zAjfbf39yI4Y2gF43 gTM4qFtBwNgJ9ox19XvISikaaxHSefsN9KHZkej21/zUDFByhtj4ExFYdwNNgs18nz9LAZGcgOGyq QCdHu+TqrF2S9e4tKFvl6xatS5sA+dLOj1qYwrVV52Khl1a4gG51vbteXxNyM8BPb83w=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkIMb-0008Nv-ER; Tue, 09 Nov 2021 05:04:06 +0100 From: Lars Ingebrigtsen To: Po Lu Subject: Re: bug#51682: 29.0.50; [PATCH] Raise an error if creating an unknown xwidget type References: <87y25znn0e.fsf.ref@yahoo.com> <87y25znn0e.fsf@yahoo.com> X-Now-Playing: Nine's _Rogue Pulse: Gravity Collapse (10)_: "Damaru-Hasta" Date: Tue, 09 Nov 2021 05:04:00 +0100 In-Reply-To: <87y25znn0e.fsf@yahoo.com> (Po Lu's message of "Mon, 08 Nov 2021 15:07:45 +0800") Message-ID: <871r3qt1ov.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Po Lu writes: > Otherwise code can create bogus xwidgets for whom widget_osr and > widgetwindow_osr are NULL, which can cause crashes. Thanks; pushed to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51682 Cc: 51682@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Po Lu writes: > Otherwise code can create bogus xwidgets for whom widget_osr and > widgetwindow_osr are NULL, which can cause crashes. Thanks; pushed to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 08 23:04:31 2021 Received: (at control) by debbugs.gnu.org; 9 Nov 2021 04:04:31 +0000 Received: from localhost ([127.0.0.1]:60219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkIN3-0004cv-FH for submit@debbugs.gnu.org; Mon, 08 Nov 2021 23:04:31 -0500 Received: from quimby.gnus.org ([95.216.78.240]:54882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkIMv-0004cY-Q2 for control@debbugs.gnu.org; Mon, 08 Nov 2021 23:04:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q+Oi+E/Ice4XTVq/szgq7scHOi2hcRCzAfFiiPpNHL4=; b=j53WKU4UWc81lJtiTE9VNj/Ftj Nqzxb8RjN0Ek+1DyTjwvLhrnyJc+h2dhkplAT6qMX9ar2wIjXWZzxxCDGRFODCImZs0SaeKiVHZI4 e4k4+2yNU3l8u5Qzh6u2EcpR2N9XHQemCrPfyIK7weajlNnbR3fBEe+X/MXGoL+CtqVg=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkIMk-0008O5-Mp for control@debbugs.gnu.org; Tue, 09 Nov 2021 05:04:16 +0100 Date: Tue, 09 Nov 2021 05:04:10 +0100 Message-Id: <87zgqern45.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #51682 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 51682 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 51682 29.1 quit From unknown Sat Aug 16 18:40:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 07 Dec 2021 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator