GNU bug report logs - #51676
[PATCH] gnu: Add python-miniupnpc

Previous Next

Full log

View this message in rfc822 format

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Stephen Paul Weber <singpolyma <at> singpolyma.net>, 51676 <at> debbugs.gnu.org
Cc: Stephen Paul Weber <singpolyma <at> singpolyma.net>
Subject: [bug#51676] [PATCH v2] gnu: Add python-miniupnpc
Date: Wed, 09 Feb 2022 15:07:47 +0100

[Message part 1 (text/plain, inline)]

Stephen schrieb am Donnerstag der 13. Januar 2022 um 20:09 -05:

> * gnu/packages/python-xyz.scm (python-miniupnpc): New variable.
> ---
>  gnu/packages/python-xyz.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 0091165d37..0ad5dfd85c 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -3150,6 +3150,40 @@ server.")
>       "@code{pafy} is a python library to retrieve YouTube content and metadata.")
>      (license license:lgpl3+)))
>  
> +(define-public python-miniupnpc
> +  (package
> +    (name "python-miniupnpc")
> +    (version "2.2.3")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/miniupnp/miniupnp")
> +         (commit "miniupnpc_2_2_3")))

The version should not be hard-coded.  You could use
‘string-replace-substring’ from (ice-9 string-fun).

  (string-replace-substring version "." "_")


> +       (file-name
> +        (git-file-name name version))
> +       (sha256
> +        (base32 "0h7smsp1fnwsmgg3n70813ln9j5y20g61x25s4kn91vzkbbq9188"))))

I am getting a hash mismatch

--8<---------------cut here---------------start------------->8---
expected hash: 0h7smsp1fnwsmgg3n70813ln9j5y20g61x25s4kn91vzkbbq9188
actual hash:   03q1rlzvfzm15g1bfw2zqzavlsyaypnaf2k3cz6ha7k5rirkdy0l
--8<---------------cut here---------------end--------------->8---

> +    (build-system python-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'subdir
> +           (lambda _
> +             (chdir "miniupnpc")
> +             (setenv "CC" ,(cc-for-target))
> +             (substitute* "Makefile"
> +               (("SH = /bin/sh") (string-append "SH = " (which "bash"))))

Nitpick: Could we just match on /bin/sh?

> +             #t)))))

Phases don’t have to return #t.

> +    (inputs (list python)) ; We are building a Python extension.
> +    (native-inputs (list which))
> +    (synopsis "UPnP client for Python")
> +    (description "Miniupnpc is a client library for Python programs to set up
> +port forwards using UPnP.")

Acronyms should be expanded at least once, see “17.4.4 Synopses and
Descriptions” in the manual.

  @acronym{UPnP, Universal Plug and Play}

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.