From unknown Mon Aug 18 17:53:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#51663] [PATCH] gnu: u-boot: Fix rk3399 boot from emmc. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 07 Nov 2021 14:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51663@debbugs.gnu.org Cc: Vagrant Cascadian X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163629601528657 (code B ref -1); Sun, 07 Nov 2021 14:41:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Nov 2021 14:40:15 +0000 Received: from localhost ([127.0.0.1]:52219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjjL8-0007S2-Vj for submit@debbugs.gnu.org; Sun, 07 Nov 2021 09:40:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:55298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjjL4-0007Ro-MU for submit@debbugs.gnu.org; Sun, 07 Nov 2021 09:40:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:32812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjjL1-0001uF-NO for guix-patches@gnu.org; Sun, 07 Nov 2021 09:40:04 -0500 Received: from mout.gmx.net ([212.227.17.21]:52455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjjKv-00089d-Ks for guix-patches@gnu.org; Sun, 07 Nov 2021 09:40:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1636295988; bh=NfnN2TEGs1LasGe2D96wxZmlyYMiMdzEW25HuXWHSRA=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=kwlVoLVKmt9x3/UOx6QYeVOXFLLO2ZQ4BzzuQkmq2kzKqps182df8yYbF5v1tfFSk S04o1XppQtKFpG2daQL9Vqws373t5FxTnxLvsP03tIibyfcb8ac+zvwBg1sDeBrpC3 rWmxtrSRDBAoJZ56YKMzDVFgePl+5k3wNtslQZHY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mt79F-1mTrHJ1EN7-00tTPB; Sun, 07 Nov 2021 15:39:48 +0100 User-agent: mu4e 1.6.9; emacs 27.2 From: Pierre Langlois Date: Sun, 07 Nov 2021 14:34:09 +0000 Message-ID: <87a6igav2l.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:9HJZEQ3OmJryLQZfeV8l7/t7pPOCm4/Jj7+8/9B1e8R4D6HxiDG 1+3OmuATXwCTf5Eb/yoWjwi+OwoflerYcGA8gAJfd+e8J4FEZzLkh07z4rrWDT7FMeGdcY7 GVDvchTiCayQINy1tW9iZdnIn/iEkfBhzonUetoFS2q4XYCvFJdRXAv/h393sruIn1+Xv8l QRYCwnA1bjH0jKlW/B2CQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Og5GUBFUeBU=:/+EjLXBqLYiPWS6Kkq6kum a7xwgkhItmeGEwyDmDw0HMhNPJZw9NqcoA2LBsCuRIaaveU7AjrNWr8RZutDWtfQCmBQv9zUW cmWNF0Q2dtmrEOs4xYeGmGVDhe8pleMlhoWoXvqw9nT2AY2Ve/zpUdKaQ1gA5MyakV869rFj4 vH1PUrsLuu7EpoA0g9YRWNIx9KM0U7dCg8seMM6AbVSNmcTtZf+c2NAHL29qUsTXRc5Kp17xD PSk6UqeZH3fbrcqwONVcuJUM1zs8GO0i49cGS4qXuWKv6HM+71r6spXOenpsMq0TM+bB/AXdw atl+VUvLvPIIvDWDBr8YCcO7LHgBE5cdoA0qxEJ59W1AKUl049nlZ+PACx+bYXY7r6v9AnTgP r7CD2rTzlVh5kmoo6R/dePF0pS8zSn3F5rqUZ95chJS2eQPMEZ8YWRlQzGPP/wWedf4WWfnph suVuHYzPQoED3tPullqwVhd+9ptnG9gLv9kSPrij6LfkMhVs8YnXUf2NxG22ZlW7BWAreL9Xf /oHnHloit4/D50IG3IHtvJwLQobYMsQ1NLdc3MakN6j+txCqI+bo5O3b4jq7c4ZxK1wIfb5uW io9HcgSsV2Lzy/GHmp39af8MhzEkcVori4mKjliWGCpN1npSZ/I7D63KH+DvLbvNem3xubjfZ FLMKQ+13k/Kng+XKkpm9AZP3h5VJpdKneJsx6TbSdWx16oop3mzkkuvo/tKeohHQoRJTDGYE2 Qv65Yijj5DFRiVTEYyJTS08eAGxk9p6iyc2/MiJXGHBN9o37S19lG+YxugscvIn/A8GueYylm dFlIqNQH43HP3wY9aRncAaA9P79v7jbg0BWhc29WZBCtqc7ohQubC8UMT4fnhEbaezPQlNtKt Uwsb48T2Qqz9Ff0XuMqijja/fs6Af4g8av2QD7FJv6YIsnfHXnUIXEXo+ydF3rBYiWg5eeGu1 0yBsmjQaa+aTS2UTUpg29cKDnF9ql3H3YBrFYv4fSXUrkbsIQ2oKkOMaGaY2gRzJ256SsKrcs F4QbiEBSdvl9KPUOYHe1pras4uu6BCtvGvSinqc4BWvBaOhvDFnBbS9a/EGxhP2ZWC6elN3Zx HfCAVPho57MYso= Received-SPF: pass client-ip=212.227.17.21; envelope-from=pierre.langlois@gmx.com; helo=mout.gmx.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain Hi Guix! I'm afraid the last u-boot update broke booting the rockpro64 and pinebook-pro from the eMMC card :-/. Going through the u-boot ML, I saw that it was reported [0], and this fix [1] should be applied. So here's a patch! I tested it on on both the pinebook-pro and rockpro64. OK to apply? Thanks, Pierre [0]: https://lists.denx.de/pipermail/u-boot/2021-November/466329.html [1]: https://patchwork.ozlabs.org/project/uboot/patch/20211101044347.17822-1-yifeng.zhao@rock-chips.com/ --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmGH5TMYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UJUQH/2m0UVp+kjnRCRMs4gZ77XVO 68E+/JXH3qi480QCUtZPhGD7HlTounAP3RrMntDINSAZ4E5Hu74778GkAQxvyWNY iCbtzZexa0p1ZKUOppSEesHk97WgDzQZTpchDrrKOxvPWASjPTGT8HBN4W+nmCHx BFhe2eOPiDQKMyQtWv9wiPcFwpx7bLiZNntm/DW7awRMgztS59v3As30yv/UXsZS 6GFSYeoQb5Y3IpiPv536z7mOwJo3i4CoEH4UAHSCkpCnXQjDA84yYZoErbzW9mxA G2JXc8JnEF6LjrkNSjVvhLfax9RRmfm3+pAPiW835xFpSfFrtfnxIOy96rfL/sw= =UFLW -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-u-boot-Fix-rk3399-boot-from-emmc.patch Content-Transfer-Encoding: quoted-printable =46rom 4dea90a439f749f9f54407603c01eabf9900a75e Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Fri, 5 Nov 2021 20:38:45 +0000 Subject: [PATCH] gnu: u-boot: Fix rk3399 boot from emmc. * gnu/packages/bootloaders.scm (%u-boot-rk3399-enable-emmc-phy-patch): New variable. (u-boot)[origin]: Register it. * gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. =2D-- gnu/local.mk | 1 + gnu/packages/bootloaders.scm | 8 +++++- .../u-boot-rk3399-enable-emmc-phy.patch | 26 +++++++++++++++++++ 3 files changed, 34 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.pat= ch diff --git a/gnu/local.mk b/gnu/local.mk index 05258ac054..0f98d6ce56 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -1842,6 +1842,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/u-boot-rockchip-inno-usb.patch \ %D%/packages/patches/u-boot-sifive-prevent-reloc-initrd-fdt.patch \ %D%/packages/patches/u-boot-riscv64-fix-extlinux.patch \ + %D%/packages/patches/u-boot-rk3399-enable-emmc-phy.patch \ %D%/packages/patches/ucx-tcp-iface-ioctl.patch \ %D%/packages/patches/ungoogled-chromium-extension-search-path.patch \ %D%/packages/patches/ungoogled-chromium-ffmpeg-compat.patch \ diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 706ddf0207..c93af2241f 100644 =2D-- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -504,6 +504,11 @@ (define %u-boot-allow-disabling-openssl-patch ;; https://lists.denx.de/pipermail/u-boot/2021-October/462728.html (search-patch "u-boot-allow-disabling-openssl.patch")) +(define %u-boot-rk3399-enable-emmc-phy-patch + ;; Fix emmc boot on rockpro64 and pinebook-pro. + ;; https://lists.denx.de/pipermail/u-boot/2021-November/466329.html + (search-patch "u-boot-rk3399-enable-emmc-phy.patch")) + (define u-boot (package (name "u-boot") @@ -512,7 +517,8 @@ (define u-boot (patches (list %u-boot-rockchip-inno-usb-patch %u-boot-allow-disabling-openssl-patch - %u-boot-sifive-prevent-relocating-initrd-fdt)) + %u-boot-sifive-prevent-relocating-initrd-fdt + %u-boot-rk3399-enable-emmc-phy-patch)) (method url-fetch) (uri (string-append "https://ftp.denx.de/pub/u-boot/" diff --git a/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch b/gn= u/packages/patches/u-boot-rk3399-enable-emmc-phy.patch new file mode 100644 index 0000000000..f14a9ce104 =2D-- /dev/null +++ b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch @@ -0,0 +1,26 @@ +adapting commit ac804143cf ("mmc: rockchip_sdhci: add phy and clock +config for rk3399") to fix the issue "Not found emmc phy device". + +Signed-off-by: Yifeng Zhao +--- + + arch/arm/dts/rk3399-u-boot.dtsi | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/arch/arm/dts/rk3399-u-boot.dtsi b/arch/arm/dts/rk3399-u-boot= .dtsi +index 73922c328a..716b9a433a 100644 +--- a/arch/arm/dts/rk3399-u-boot.dtsi ++++ b/arch/arm/dts/rk3399-u-boot.dtsi +@@ -88,6 +88,10 @@ + u-boot,dm-pre-reloc; + }; + ++&emmc_phy { ++ u-boot,dm-pre-reloc; ++}; ++ + &grf { + u-boot,dm-pre-reloc; + }; +-- +2.17.1 =2D- 2.33.1 --=-=-=-- From unknown Mon Aug 18 17:53:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#51663] [PATCH] gnu: u-boot: Fix rk3399 boot from emmc. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Nov 2021 16:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: Vagrant Cascadian , 51663@debbugs.gnu.org Received: via spool by 51663-submit@debbugs.gnu.org id=B51663.163673328525721 (code B ref 51663); Fri, 12 Nov 2021 16:09:01 +0000 Received: (at 51663) by debbugs.gnu.org; 12 Nov 2021 16:08:05 +0000 Received: from localhost ([127.0.0.1]:45817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlZ5w-0006gn-VZ for submit@debbugs.gnu.org; Fri, 12 Nov 2021 11:08:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlZ5r-0006gD-DU for 51663@debbugs.gnu.org; Fri, 12 Nov 2021 11:08:03 -0500 Received: from [2001:470:142:3::e] (port=47362 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlZ5m-0006YH-1l; Fri, 12 Nov 2021 11:07:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=TJCZwa9DJQ/tV0xbX5VZsWJ1fQ/M+9Aj3ArIZzFXV/w=; b=hnUbkve9EKDXMIi+2UmS DF/p4FlEdS1gEr0s4K00RdF7sbYgOZbj//BqgkR2tmKkAJHKV1pBVHv5o7qt3UME2dx6Uz6GoSvLe W6CxrMqrndceLmOBPjYbZyQf/XVrv6NOTyJ1cXqoZ9G2u71SRcs3xlfZjHYhgSohoTfVELXHIZjvr 8b3zF6Ko57kL4tg+NifP8cB4q9d0WLDhlUslvWm5qV7AAzEkeLjA8CUnrhAWp7vDLkR7YvRN5PpJH Lic4bOC7FomaEl/X9Yq31wEyaD/yR1OFTAMiYO4sS7GTGuveS2NPqloV5vwjEVhy9MYBdZevFJRs9 xLI+kzHyLWjjbQ==; Received: from [2a01:e0a:19b:d9a0:b4a5:c7aa:fee0:cc15] (port=60374 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlZ5l-0003Ma-PY; Fri, 12 Nov 2021 11:07:53 -0500 From: Mathieu Othacehe References: <87a6igav2l.fsf@gmx.com> Date: Fri, 12 Nov 2021 16:07:52 +0000 In-Reply-To: <87a6igav2l.fsf@gmx.com> (Pierre Langlois's message of "Sun, 07 Nov 2021 14:34:09 +0000") Message-ID: <87ilwxjr1j.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Pierre, > + %u-boot-rk3399-enable-emmc-phy-patch)) You could add a comment to indicate that this can probably be removed when updating u-boot. Otherwise, looks fine! Thanks, Mathieu From unknown Mon Aug 18 17:53:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#51663] [PATCH] gnu: u-boot: Fix rk3399 boot from emmc. Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Nov 2021 18:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: 51663@debbugs.gnu.org Received: via spool by 51663-submit@debbugs.gnu.org id=B51663.16367416147105 (code B ref 51663); Fri, 12 Nov 2021 18:27:02 +0000 Received: (at 51663) by debbugs.gnu.org; 12 Nov 2021 18:26:54 +0000 Received: from localhost ([127.0.0.1]:45953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlbGH-0001qX-R2 for submit@debbugs.gnu.org; Fri, 12 Nov 2021 13:26:54 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:37664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlbGF-0001qC-3U for 51663@debbugs.gnu.org; Fri, 12 Nov 2021 13:26:52 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100b]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 073E21AC25; Fri, 12 Nov 2021 10:26:45 -0800 (PST) From: Vagrant Cascadian In-Reply-To: <87a6igav2l.fsf@gmx.com> References: <87a6igav2l.fsf@gmx.com> Date: Fri, 12 Nov 2021 10:26:22 -0800 Message-ID: <87sfw1fcxd.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On 2021-11-07, Pierre Langlois wrote: > I'm afraid the last u-boot update broke booting the rockpro64 and > pinebook-pro from the eMMC card :-/. Going through the u-boot ML, I saw > that it was reported [0], and this fix [1] should be applied. > > So here's a patch! I tested it on on both the pinebook-pro and > rockpro64. > > OK to apply? > > Thanks, > Pierre > > [0]: https://lists.denx.de/pipermail/u-boot/2021-November/466329.html > [1]: https://patchwork.ozlabs.org/project/uboot/patch/20211101044347.17822-1-yifeng.zhao@rock-chips.com/ ... > diff --git a/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch > new file mode 100644 > index 0000000000..f14a9ce104 > --- /dev/null > +++ b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch > @@ -0,0 +1,26 @@ > +adapting commit ac804143cf ("mmc: rockchip_sdhci: add phy and clock > +config for rk3399") to fix the issue "Not found emmc phy device". I'm a little confused about this comment in the patch... is ac804143cf the commit which fixed the issue or broke it? is there a reference to an upstream commit and/or issue that fixes it? Otherwise, looks good to me! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYY6xzwAKCRDcUY/If5cW qj4tAP9xp3kjNdQRD0G2XcyZsBB2P4uRK4PD+1as9DjK2CQtOgD/XcasWYxuwG65 AvPXgm3XJFocV2uw2E+7Oe13kxSFiQw= =XEWo -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Aug 18 17:53:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#51663] [PATCH] gnu: u-boot: Fix rk3399 boot from emmc. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 13 Nov 2021 14:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vagrant Cascadian Cc: Pierre Langlois , 51663@debbugs.gnu.org Received: via spool by 51663-submit@debbugs.gnu.org id=B51663.163681308424977 (code B ref 51663); Sat, 13 Nov 2021 14:19:01 +0000 Received: (at 51663) by debbugs.gnu.org; 13 Nov 2021 14:18:04 +0000 Received: from localhost ([127.0.0.1]:46782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mltr2-0006Un-4S for submit@debbugs.gnu.org; Sat, 13 Nov 2021 09:18:04 -0500 Received: from mout.gmx.net ([212.227.17.21]:46117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mltqy-0006UB-NK for 51663@debbugs.gnu.org; Sat, 13 Nov 2021 09:18:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1636813072; bh=PzHhrZZYW/UUzQZaXqTfcoWgMDZdDMqMzPJIcL0kca0=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=J5EF3MhnM11PoAJGQfli+gAzIzCm5f15bouJ61KWmsaAjHrl02DEV0Thml6sx+6td YD2f3qEXiEHua+Rq1wj8/2tw4owrWz0Vm5QKTY4bGHr4llzsz83IEfPrwg35ouDp6d f/U3jgOKG0EkOse/J3ctAik1HCQeE6nbjn1LAY+I= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MBUqF-1mqbct0gpj-00D1S0; Sat, 13 Nov 2021 15:17:52 +0100 References: <87a6igav2l.fsf@gmx.com> <87sfw1fcxd.fsf@yucca> User-agent: mu4e 1.6.9; emacs 27.2 From: Pierre Langlois Date: Sat, 13 Nov 2021 13:35:09 +0000 In-reply-to: <87sfw1fcxd.fsf@yucca> Message-ID: <87ee7kcf79.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:W4k+CJtxMdyj0pIm5RgE7cOlM3mx4yIMuIcE7pUP8bvIXk/AcRK vcAxMUdlVk7qw2KeuN2ghemXxuS9KxRDanFBr/nq8aGklWt3njpULduN90+HwyGbeWSY5nq i/az4X1toJL2vx+nQM0461korcOuQ5zt37IJXwZA42J0co1pXt1Gu3/X6GeWRUBa4/mk2yJ x59FfjVdKxHjM6wGv+yIg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/tFDT/k9S8c=:r9NRewB1NldQGPEd/PK2j8 M8k2Ynh7ZDtVFGltOeac5DoBnXTztZNaTj91Oixot9bQeKyP+C8NejBYtVNZQb13q4yqC7WSC xzQOtjPLpaSTDcV9eutQISRnajbkpWa0MAb6xsc1Jo9JSQz9vxfhtpqiXLsyDrgwvoHnSF/RF 0k4BKIBAxJm8kZ/wAryO6KcPmgku/M2gxeOONL8c4peUxsvmbzt+6IJYh9PKjzBIeHwtnQUOJ 7Bx2v/tra0EZWuTdnV4nr8XUHK3sS31sbK38V4ac6vrStGnP+J67rmW2CTYDuYOgjwQRQ5d4z 9t8KM5yHyNNLmta+ITUxPR9/SBY6soy2DG/HUuG5a2YICk7IeaOR6XNzecdxAwfNaafVjbIX3 nmjAFtYXsYL+IzLEwxWw/uBeyJVPmyE/K8gviffqfie2KHoRuJ0tFjRAiu53ztp6hSuJXPh1W /vOSMzX0fvMGy37zUdmknxqckS7HvPqMWj4A470cpvhgLBD3xqGd09KWvwONAH50sSX78Jk+4 AKvXrT3YuaGJtJ/Ee07xSUXcwjQ8O2CxtXwXMPQwYV+pMdgMLB6ngkWi8gV1+1kINhPh+OJHJ IUuUOavZh1zz+Hg99iSSH1XWf3mEBP3PbuKPO+e6/FtQIsCsUi+97Cq8tekPJPUFt+jvtocvs VTAGXDy2hinG/lQHOMBiHWOVNx6CWlB/V6yL8KLG5KdcrJg9MHikRXmValRjzwZGR7hkHistM XsVncU132b1SWbC/Ztg418eYS9Z0y1OaziVOVS88QLOwGNgI/2IZc7KicMz6+lv3fha7HDkx1 9/CXWw7pSs/Kv1o95k/Mluk7tmdLPiMFwaxD6SlngkBrpzHuh3NJkZWLE93w1x7MXq1RQlexp b+mJSW86UX4PKfRuxpeW+m3jyv4x6o74C/ivG8Hos9KsD9U5dyFy9yNm1nojqTVm5q3/tF3e/ ZwAQAUIExqIINbDUBo5Ie0MhHITZcks6kQAjwwFJeGcAq0OHMp4R55YpFhCmv+4+e75/t1cqA OruRLtysI6v1wCsxsoSmj68JGg0YPhJo6d5Dg/A5gEV50x+DTWapKSQwBAFiBRZbBKk9utZbx 8IQ+LETmisPhLI= X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi, Vagrant Cascadian writes: > [[PGP Signed Part:Undecided]] > On 2021-11-07, Pierre Langlois wrote: >> I'm afraid the last u-boot update broke booting the rockpro64 and >> pinebook-pro from the eMMC card :-/. Going through the u-boot ML, I saw >> that it was reported [0], and this fix [1] should be applied. >> >> So here's a patch! I tested it on on both the pinebook-pro and >> rockpro64. >> >> OK to apply? >> >> Thanks, >> Pierre >> >> [0]: https://lists.denx.de/pipermail/u-boot/2021-November/466329.html >> [1]: https://patchwork.ozlabs.org/project/uboot/patch/20211101044347.17822-1-yifeng.zhao@rock-chips.com/ > ... >> diff --git a/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch >> new file mode 100644 >> index 0000000000..f14a9ce104 >> --- /dev/null >> +++ b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch >> @@ -0,0 +1,26 @@ >> +adapting commit ac804143cf ("mmc: rockchip_sdhci: add phy and clock >> +config for rk3399") to fix the issue "Not found emmc phy device". > > I'm a little confused about this comment in the patch... is ac804143cf > the commit which fixed the issue or broke it? is there a reference to an > upstream commit and/or issue that fixes it? Yeah it's not very clear to me either, I think ac804143cf is the commit that introduced the regression indeed. Doing a bit of digging, I don't think the fix was merged upstream yet though :-(. Instead, I see Fedora opted to revert the problematic patch, along with another dependent one. Probably before the fix was posted to the list: https://src.fedoraproject.org/rpms/uboot-tools/c/37df227bc0961f9f0dc4dafa9e983290dbdb2bc3 https://bugzilla.redhat.com/show_bug.cgi?id=2014182#c3 Given it's not upstream, it could be safer to do what Fedora did and revert a couple of patches, what do you think? The fix is from the original author so I'm inclined to trust it, I'd be surprised if it doesn't get merged. Thanks, Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmGPyQoYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UaQgH/2INSVLAYFCGTcx68Cjx4ewG cFx8SmJC2t2dhMSPrkO9/LSsgdekBAk9Dwj5DPwXfNSmfyOCZDoFvKo6DQ6qXNl5 lvXMRi6R8hZAgzjlgn/BK4ecvcwzOvpZk61tIDTHo2cmwFg2+8pdWppOsaJH+dVM uY/87Jyd+pL81Q/nK7rnJS7F3LetLD0HGCkcPtLd2lQpC6sR83Bt2u7ZkvKfoBwt 0LCWt2Lhs/X1QLkTJJRQKGyOGmV4LUa52F/+SdfqLE/E7UZcrya7h75z00jexi32 Jh9m644BelmrCbpWMoBG4HFT4To+2gTetzO2uevrN5hL7xQUVm+fdGy/90chaU8= =C4QF -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Aug 18 17:53:26 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Pierre Langlois Subject: bug#51663: closed (Re: bug#51663: [PATCH] gnu: u-boot: Fix rk3399 boot from emmc.) Message-ID: References: <87czmld4ey.fsf@gmx.com> <87a6igav2l.fsf@gmx.com> X-Gnu-PR-Message: they-closed 51663 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 51663@debbugs.gnu.org Date: Sat, 27 Nov 2021 15:07:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1638025622-26406-1" This is a multi-part message in MIME format... ------------=_1638025622-26406-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #51663: [PATCH] gnu: u-boot: Fix rk3399 boot from emmc. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 51663@debbugs.gnu.org. --=20 51663: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51663 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1638025622-26406-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 51663-done) by debbugs.gnu.org; 27 Nov 2021 15:06:28 +0000 Received: from localhost ([127.0.0.1]:34381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqzHY-0006r6-GX for submit@debbugs.gnu.org; Sat, 27 Nov 2021 10:06:28 -0500 Received: from mout.gmx.net ([212.227.17.22]:56209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqzHV-0006qp-Eb for 51663-done@debbugs.gnu.org; Sat, 27 Nov 2021 10:06:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1638025575; bh=U2/xCXIBM4wb5UjzwVvSKyFfUoDW1zvr2i1HvJ59xqA=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=U1s+Tx7r+bK10jPPtaBT8qGEzoRKxMJ2wKqex8KA7J8JsMleutS6ue7G9dOXcUA0q GwCKbEkPA2CeUduRlKWz3DdvfPj8vG5zDFUdzSp4Fkv14+ieES/aA5oahndW8DQI7I DppHq8ECuZxWg8CpthDjT4LlJa2PmmXEbjk+Fres= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MvsJ5-1maHuC10aN-00svNS; Sat, 27 Nov 2021 16:06:15 +0100 References: <87a6igav2l.fsf@gmx.com> <87ilwxjr1j.fsf@gnu.org> User-agent: mu4e 1.6.10; emacs 27.2 From: Pierre Langlois To: Mathieu Othacehe Subject: Re: bug#51663: [PATCH] gnu: u-boot: Fix rk3399 boot from emmc. Date: Sat, 27 Nov 2021 15:04:21 +0000 In-reply-to: <87ilwxjr1j.fsf@gnu.org> Message-ID: <87czmld4ey.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:PgQABumlHzPy0xX25oXlHP/1dX9LYlq/92eqj04od919SLitcTR o0DvPAladkn4xtKSP6SbLfAKKjop4DtKtuyCE7YtR7slZWlDQbtRK/XP1wlrzFuXmJGfpaQ /1dTc9xJq4o0zd/V3d1PzcYBMU60fmABiv9m3M1pMVKsD0jWx/JJCU+IWwKBe5kwyU8m1Lz d3HR8ko5kL9Ra9IY81Vuw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:idipeariYpM=:RBYWNOLTdV8MAI5uQfpAwJ BJS6iPpwKOcxLg+N3EyoY8NhOo88pblQxVfVv3GXU8KqgD9VUzfpsOIm6bJLCNq1le+Kzw/w9 CE9HEwmm0kw7iEfmT2yTp5mki7ZRHZW5qdklxzyTjpyldOU/UNlO7m53UsuQczOvlzkwrqYrK u0myRCnePGzwcBxiM1diWpWK7RyXg/JO/JY7C69yVsQjoMubBaBy/LVzf/TnZBYtslWBB6qCp orcM4l3G+LfCOWAbjN/vVSyVFzYYs8Z2ibjXwFkTdEpUTJAziJBZCJ4wxVllO6gud01kzGDXh EPoahdLieX+/wPqaiyPrPPwEJ/id37p2ybb0xM8SVRnGx9KoEu2QLsYaIEQMGLY6+BLQVtqKP asbvqLtPht0vtmtk+kNLJ8+57uggcCFd0YYaeg87BkjrGZ/aTxUeWgoQL64U1R0jSEAplRAak Md8rEY7FW/k0mLsPZxPpJI1I4T8+WPhKsRZUdWzWNTVcNF0U1joKM8zKQ7DviUOgSQYQh+VE+ qRNU62xi2+fQQ15K9nL7PV2Vn04MRjZ/6dtLG4yB0naSsm3RSgYcXkptZS0AoKc7R+libLJJt wwBOa0i0ELlCYKKy4hQcno9oAV2Xa3nsthhK0avXUOPEnuHgLJjsCFctjCMG4PvE80eCWTJx4 95+KtqRLXDD92I/7AvaevAd3fvAF7wnIMP8Uxs/Jxlg2nlOPRf8r4b7DBv2bva7+OP5PUVoQ1 f6gR/wbgQfWSxUsOstrqaRTiAqnkw6Phcqf1kKnrUc8xHOXg+CIWl5mYQspYnnxUErwaqQk5A TDE1r1uqlx/6eRF40Amzu8kHO4Bw0vnamibtRi/5/zrV2rDLOZ9oc4S3/FIHmskEqQqWsVBiQ jc4LEMMZgAH1zu4qU3UWBpd3BZqt9EY/Kw6R7kq8NPBV7FApjL4bzvKaxbLecf3fc9w5GaXn6 Y44piOakcHlyS4x6FkByJJE59ikPkRsf8uIrnS0FkbC7BbYXOZw+RaUFuZyLEngcgphVpiAjb 1lvRp5g5+xYut7hcUBKB/fY0mXtPQLM5yejCLSRhwfQ9MVel34F+LC+tgC6ekCKz0I3fqWEFP l+xVrehTNIm8jE= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51663-done Cc: Vagrant Cascadian , Pierre Langlois , 51663-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Mathieu, Mathieu Othacehe writes: > Hello Pierre, > >> + %u-boot-rk3399-enable-emmc-phy-patch)) > > You could add a comment to indicate that this can probably be removed > when updating u-boot. Done, the patch hasn't been picked up upstream yet AFAIK, however it was picked up by fedora so I'm confident it's OK and it doens't just work for me accidentally :-). > > Otherwise, looks fine! Thanks! Pushed with bf1e46e959884df4bb204807efd21bbf44c5f87e Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmGiSWUYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UooYH/09YowIUX2UuGqeGzqvMH/F+ 6lvdlrQlVfQUXaXn++G6/bJoHVj+VsmzZKG0JwYon7ck2+NdbeUAjv+8b3eppKY6 T3Q6X1/lC7/WADjXo4UVaZ1i72N+38gnH+4n2PsKJXLZ6N+IPBsO63fPpffahTKc p2479YRWbxIPmQsoz4XYK3lNzNGK59KIVMVNhoq7WIctfXa/rRwPrprl8gb3Imge 03dabTIBp/eFISHzXoL+ZrCp0LaORT+1Hogp9yx6eaeg20XwADzkkKvNu5f6NSEt ExFwo1QuIuC7wx13cAnep9aNsp9e7sBPhxkih56Vu18p0IHfnYDfMbaCE1T/aUM= =T/AQ -----END PGP SIGNATURE----- --=-=-=-- ------------=_1638025622-26406-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Nov 2021 14:40:15 +0000 Received: from localhost ([127.0.0.1]:52219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjjL8-0007S2-Vj for submit@debbugs.gnu.org; Sun, 07 Nov 2021 09:40:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:55298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjjL4-0007Ro-MU for submit@debbugs.gnu.org; Sun, 07 Nov 2021 09:40:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:32812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjjL1-0001uF-NO for guix-patches@gnu.org; Sun, 07 Nov 2021 09:40:04 -0500 Received: from mout.gmx.net ([212.227.17.21]:52455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjjKv-00089d-Ks for guix-patches@gnu.org; Sun, 07 Nov 2021 09:40:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1636295988; bh=NfnN2TEGs1LasGe2D96wxZmlyYMiMdzEW25HuXWHSRA=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=kwlVoLVKmt9x3/UOx6QYeVOXFLLO2ZQ4BzzuQkmq2kzKqps182df8yYbF5v1tfFSk S04o1XppQtKFpG2daQL9Vqws373t5FxTnxLvsP03tIibyfcb8ac+zvwBg1sDeBrpC3 rWmxtrSRDBAoJZ56YKMzDVFgePl+5k3wNtslQZHY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mt79F-1mTrHJ1EN7-00tTPB; Sun, 07 Nov 2021 15:39:48 +0100 User-agent: mu4e 1.6.9; emacs 27.2 From: Pierre Langlois To: guix-patches@gnu.org Subject: [PATCH] gnu: u-boot: Fix rk3399 boot from emmc. Date: Sun, 07 Nov 2021 14:34:09 +0000 Message-ID: <87a6igav2l.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:9HJZEQ3OmJryLQZfeV8l7/t7pPOCm4/Jj7+8/9B1e8R4D6HxiDG 1+3OmuATXwCTf5Eb/yoWjwi+OwoflerYcGA8gAJfd+e8J4FEZzLkh07z4rrWDT7FMeGdcY7 GVDvchTiCayQINy1tW9iZdnIn/iEkfBhzonUetoFS2q4XYCvFJdRXAv/h393sruIn1+Xv8l QRYCwnA1bjH0jKlW/B2CQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Og5GUBFUeBU=:/+EjLXBqLYiPWS6Kkq6kum a7xwgkhItmeGEwyDmDw0HMhNPJZw9NqcoA2LBsCuRIaaveU7AjrNWr8RZutDWtfQCmBQv9zUW cmWNF0Q2dtmrEOs4xYeGmGVDhe8pleMlhoWoXvqw9nT2AY2Ve/zpUdKaQ1gA5MyakV869rFj4 vH1PUrsLuu7EpoA0g9YRWNIx9KM0U7dCg8seMM6AbVSNmcTtZf+c2NAHL29qUsTXRc5Kp17xD PSk6UqeZH3fbrcqwONVcuJUM1zs8GO0i49cGS4qXuWKv6HM+71r6spXOenpsMq0TM+bB/AXdw atl+VUvLvPIIvDWDBr8YCcO7LHgBE5cdoA0qxEJ59W1AKUl049nlZ+PACx+bYXY7r6v9AnTgP r7CD2rTzlVh5kmoo6R/dePF0pS8zSn3F5rqUZ95chJS2eQPMEZ8YWRlQzGPP/wWedf4WWfnph suVuHYzPQoED3tPullqwVhd+9ptnG9gLv9kSPrij6LfkMhVs8YnXUf2NxG22ZlW7BWAreL9Xf /oHnHloit4/D50IG3IHtvJwLQobYMsQ1NLdc3MakN6j+txCqI+bo5O3b4jq7c4ZxK1wIfb5uW io9HcgSsV2Lzy/GHmp39af8MhzEkcVori4mKjliWGCpN1npSZ/I7D63KH+DvLbvNem3xubjfZ FLMKQ+13k/Kng+XKkpm9AZP3h5VJpdKneJsx6TbSdWx16oop3mzkkuvo/tKeohHQoRJTDGYE2 Qv65Yijj5DFRiVTEYyJTS08eAGxk9p6iyc2/MiJXGHBN9o37S19lG+YxugscvIn/A8GueYylm dFlIqNQH43HP3wY9aRncAaA9P79v7jbg0BWhc29WZBCtqc7ohQubC8UMT4fnhEbaezPQlNtKt Uwsb48T2Qqz9Ff0XuMqijja/fs6Af4g8av2QD7FJv6YIsnfHXnUIXEXo+ydF3rBYiWg5eeGu1 0yBsmjQaa+aTS2UTUpg29cKDnF9ql3H3YBrFYv4fSXUrkbsIQ2oKkOMaGaY2gRzJ256SsKrcs F4QbiEBSdvl9KPUOYHe1pras4uu6BCtvGvSinqc4BWvBaOhvDFnBbS9a/EGxhP2ZWC6elN3Zx HfCAVPho57MYso= Received-SPF: pass client-ip=212.227.17.21; envelope-from=pierre.langlois@gmx.com; helo=mout.gmx.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: submit Cc: Vagrant Cascadian X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain Hi Guix! I'm afraid the last u-boot update broke booting the rockpro64 and pinebook-pro from the eMMC card :-/. Going through the u-boot ML, I saw that it was reported [0], and this fix [1] should be applied. So here's a patch! I tested it on on both the pinebook-pro and rockpro64. OK to apply? Thanks, Pierre [0]: https://lists.denx.de/pipermail/u-boot/2021-November/466329.html [1]: https://patchwork.ozlabs.org/project/uboot/patch/20211101044347.17822-1-yifeng.zhao@rock-chips.com/ --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmGH5TMYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UJUQH/2m0UVp+kjnRCRMs4gZ77XVO 68E+/JXH3qi480QCUtZPhGD7HlTounAP3RrMntDINSAZ4E5Hu74778GkAQxvyWNY iCbtzZexa0p1ZKUOppSEesHk97WgDzQZTpchDrrKOxvPWASjPTGT8HBN4W+nmCHx BFhe2eOPiDQKMyQtWv9wiPcFwpx7bLiZNntm/DW7awRMgztS59v3As30yv/UXsZS 6GFSYeoQb5Y3IpiPv536z7mOwJo3i4CoEH4UAHSCkpCnXQjDA84yYZoErbzW9mxA G2JXc8JnEF6LjrkNSjVvhLfax9RRmfm3+pAPiW835xFpSfFrtfnxIOy96rfL/sw= =UFLW -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-u-boot-Fix-rk3399-boot-from-emmc.patch Content-Transfer-Encoding: quoted-printable =46rom 4dea90a439f749f9f54407603c01eabf9900a75e Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Fri, 5 Nov 2021 20:38:45 +0000 Subject: [PATCH] gnu: u-boot: Fix rk3399 boot from emmc. * gnu/packages/bootloaders.scm (%u-boot-rk3399-enable-emmc-phy-patch): New variable. (u-boot)[origin]: Register it. * gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. =2D-- gnu/local.mk | 1 + gnu/packages/bootloaders.scm | 8 +++++- .../u-boot-rk3399-enable-emmc-phy.patch | 26 +++++++++++++++++++ 3 files changed, 34 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.pat= ch diff --git a/gnu/local.mk b/gnu/local.mk index 05258ac054..0f98d6ce56 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -1842,6 +1842,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/u-boot-rockchip-inno-usb.patch \ %D%/packages/patches/u-boot-sifive-prevent-reloc-initrd-fdt.patch \ %D%/packages/patches/u-boot-riscv64-fix-extlinux.patch \ + %D%/packages/patches/u-boot-rk3399-enable-emmc-phy.patch \ %D%/packages/patches/ucx-tcp-iface-ioctl.patch \ %D%/packages/patches/ungoogled-chromium-extension-search-path.patch \ %D%/packages/patches/ungoogled-chromium-ffmpeg-compat.patch \ diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 706ddf0207..c93af2241f 100644 =2D-- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -504,6 +504,11 @@ (define %u-boot-allow-disabling-openssl-patch ;; https://lists.denx.de/pipermail/u-boot/2021-October/462728.html (search-patch "u-boot-allow-disabling-openssl.patch")) +(define %u-boot-rk3399-enable-emmc-phy-patch + ;; Fix emmc boot on rockpro64 and pinebook-pro. + ;; https://lists.denx.de/pipermail/u-boot/2021-November/466329.html + (search-patch "u-boot-rk3399-enable-emmc-phy.patch")) + (define u-boot (package (name "u-boot") @@ -512,7 +517,8 @@ (define u-boot (patches (list %u-boot-rockchip-inno-usb-patch %u-boot-allow-disabling-openssl-patch - %u-boot-sifive-prevent-relocating-initrd-fdt)) + %u-boot-sifive-prevent-relocating-initrd-fdt + %u-boot-rk3399-enable-emmc-phy-patch)) (method url-fetch) (uri (string-append "https://ftp.denx.de/pub/u-boot/" diff --git a/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch b/gn= u/packages/patches/u-boot-rk3399-enable-emmc-phy.patch new file mode 100644 index 0000000000..f14a9ce104 =2D-- /dev/null +++ b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch @@ -0,0 +1,26 @@ +adapting commit ac804143cf ("mmc: rockchip_sdhci: add phy and clock +config for rk3399") to fix the issue "Not found emmc phy device". + +Signed-off-by: Yifeng Zhao +--- + + arch/arm/dts/rk3399-u-boot.dtsi | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/arch/arm/dts/rk3399-u-boot.dtsi b/arch/arm/dts/rk3399-u-boot= .dtsi +index 73922c328a..716b9a433a 100644 +--- a/arch/arm/dts/rk3399-u-boot.dtsi ++++ b/arch/arm/dts/rk3399-u-boot.dtsi +@@ -88,6 +88,10 @@ + u-boot,dm-pre-reloc; + }; + ++&emmc_phy { ++ u-boot,dm-pre-reloc; ++}; ++ + &grf { + u-boot,dm-pre-reloc; + }; +-- +2.17.1 =2D- 2.33.1 --=-=-=-- ------------=_1638025622-26406-1-- From unknown Mon Aug 18 17:53:26 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#51663] [PATCH] gnu: u-boot: Fix rk3399 boot from emmc. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 27 Nov 2021 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vagrant Cascadian Cc: Pierre Langlois , 51663@debbugs.gnu.org Received: via spool by 51663-submit@debbugs.gnu.org id=B51663.163802571326593 (code B ref 51663); Sat, 27 Nov 2021 15:09:02 +0000 Received: (at 51663) by debbugs.gnu.org; 27 Nov 2021 15:08:33 +0000 Received: from localhost ([127.0.0.1]:34390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqzJY-0006uq-Sk for submit@debbugs.gnu.org; Sat, 27 Nov 2021 10:08:33 -0500 Received: from mout.gmx.net ([212.227.17.22]:48791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqzJW-0006uS-Ku for 51663@debbugs.gnu.org; Sat, 27 Nov 2021 10:08:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1638025705; bh=AbwgBfVYJ+CD3nq7CbKaLtzgdjeqsCXKX+HHNmGsFsM=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=Bcrhw9jvtRXY/FHdPHyhLgybLwqXtT6uD66QwNrjc/qRrSh0t4p8Trp2cu3jqcXV7 k0QTPLlrAQdK38eI/Vj6jb8/CV0nApqLkvirZoP4f5a/v75zfuFwwiuvzIEF41hHKm SlsFMXrzcr3Bbq6t2gwllzeQGBiOfVS0QCP1cs/4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MbRjt-1mKONl3GUT-00bwUY; Sat, 27 Nov 2021 16:08:24 +0100 References: <87a6igav2l.fsf@gmx.com> <87sfw1fcxd.fsf@yucca> <87ee7kcf79.fsf@gmx.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Pierre Langlois Date: Sat, 27 Nov 2021 15:06:18 +0000 In-reply-to: <87ee7kcf79.fsf@gmx.com> Message-ID: <8735nhd4bc.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:ZRDdHk8uG0Wu34v2BD/EG2obvfsAePIs11MUaOqijzfMAsN2wXJ ACJAi+YIBjcA29iQSyG/4E/rHuL/TN6w02sJpVp4RkLXH6VGV6OsdJRzTa3gE9FeoR52awc hmH5fpyo0/E/8Jzn1Ew10B4TJBjVPTOq0qB6ZChujKkHSkJ/EkBaDN8zbWtZ5HbrIRjnJPB McXZ3Y7Xo3+iLjEGs666w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:K9kg7raoZj8=:Vim2ObKn0V3tDf7ZIGbRfq KMpH6QIajAioVfaheZiLcdCrW+m8saSc1BMGtWZG3kXNX3BSGqxGA+DfHfGKpkmi7XRzy6aQ4 Jq/FkFttA8ZA2qFlE7xMIzYcmHctYJnGAPcJoQ1skw5INjwIc+Lix4wNiXmQGPMWWayljNeZ7 WUsh/nVMcR8TNK/YhNriB/YxQQMKRNgckGA3DojoX2W5GCF9f1fITsi91KQIrd0gcBo+nu4Sv TwEbhptmpOlLcysPQcTphE6C5nUut5u7ZJfQGwQ7XUqtE7wJ0gM/Dma3k0BAp20T0qGXwRNi2 pXa4ehNKpBBYHGgILKdVMk6skObAFwDk2UI09uVicpJVhYsRGGzsh0t44zHo12VF36SsNd443 b5OGVzaEeVOrgUcBQJ7WAet5Vo1FpSpbBivTgMXW5tL6c6XzoqtvF9fpF//eZpP/YM+ByTlEm KK0RhnLAQu5BF4udeFvV99KSfRlp+rkvg3PU4Wqpx5hpCuhi5FSBtqDpzLroPyuZijMhd3g5x aemkoU2zuiGqV3Hj0G6m8AWpnuhVQA+0ZM2OuIS+0B1nUh9sSRxUzny9nWGUnVWZARIA1pcH4 C8qhiEEY1avnVI4UZ72sv/Etu29JJmX8SUGqsYiblCMB7RWWz1PpjWPgLIgbXZq5r3k+89tD/ MdhF28bKd0YWpP8WVvrINJmhDfCK/5uQUABwC1b+XW8eU4FutUsH0ISjwuf0rQ5+k5lkLMWin qP10fboQHX+7AWfA/vkfsQ6a9GKASOOQwnSbAgqm9x1L2BeDUVavUnHUC7dsuEGvJ+yTMwQx9 kbkw/hrCIBWm3LyyuU3iGIhmGFaQDQsuFn5GTwroPleAP6XgcMtoQ0QdNMsY+ZoQXRjd/2Jau D5NODOr2RXymEDHjQPD0YVxMVI8bhekk1gQQcCOhtoDkSjabaCMlzcncrCa/LC+cLKjD4FdfO 4SqJ+uqursqaxX5fWuAr19ld+RoOJpg65UeaWsoyAVPhJ1XrI300LdFUzqggs98fxwdvDrtUO 6BAPAYuCQhFz4GESABZJiPb1k9LuKUStiblEJZDXA1DUSVoDxWhgYvO2n9IEACpBxvs6t58Qg wh5Zf7FAx3jVQg= X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Pierre Langlois writes: > [[PGP Signed Part:Undecided]] > Hi, > > Vagrant Cascadian writes: > >> [[PGP Signed Part:Undecided]] >> On 2021-11-07, Pierre Langlois wrote: >>> I'm afraid the last u-boot update broke booting the rockpro64 and >>> pinebook-pro from the eMMC card :-/. Going through the u-boot ML, I saw >>> that it was reported [0], and this fix [1] should be applied. >>> >>> So here's a patch! I tested it on on both the pinebook-pro and >>> rockpro64. >>> >>> OK to apply? >>> >>> Thanks, >>> Pierre >>> >>> [0]: https://lists.denx.de/pipermail/u-boot/2021-November/466329.html >>> [1]: https://patchwork.ozlabs.org/project/uboot/patch/20211101044347.17822-1-yifeng.zhao@rock-chips.com/ >> ... >>> diff --git a/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch >>> new file mode 100644 >>> index 0000000000..f14a9ce104 >>> --- /dev/null >>> +++ b/gnu/packages/patches/u-boot-rk3399-enable-emmc-phy.patch >>> @@ -0,0 +1,26 @@ >>> +adapting commit ac804143cf ("mmc: rockchip_sdhci: add phy and clock >>> +config for rk3399") to fix the issue "Not found emmc phy device". >> >> I'm a little confused about this comment in the patch... is ac804143cf >> the commit which fixed the issue or broke it? is there a reference to an >> upstream commit and/or issue that fixes it? > > Yeah it's not very clear to me either, I think ac804143cf is the commit > that introduced the regression indeed. Doing a bit of digging, I don't > think the fix was merged upstream yet though :-(. > > Instead, I see Fedora opted to revert the problematic patch, along with > another dependent one. Probably before the fix was posted to the list: > > https://src.fedoraproject.org/rpms/uboot-tools/c/37df227bc0961f9f0dc4dafa9e983290dbdb2bc3 > https://bugzilla.redhat.com/show_bug.cgi?id=2014182#c3 > > Given it's not upstream, it could be safer to do what Fedora did and > revert a couple of patches, what do you think? The fix is from the > original author so I'm inclined to trust it, I'd be surprised if it > doesn't get merged. Taking another quick look today, it seems Fedora now picked up this patch, yey! https://src.fedoraproject.org/rpms/uboot-tools/c/9eb973e7d2ab74341c0eb7312576b6f016ec03d4?branch=rawhide I'm more confident it's the right fix now so I've gone ahead and pushed it. Thanks! Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmGiSecYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UObMIAK1MtsB1gI+hvRUu5Zlv8irq ahPQTqhrehfakEsde+SgBEbjkRiT09n/+tyxsBoK4zmy1ulOONzDSwfc7iucdIry 6booZJuo8VZkItXZYzBA0+32uBF4rvXqyFRZFgb+fctV+XhTsTjRxCk5gSd3P3W4 slh0gmJ/CR7SZRC3EInzaCemV3rvgTqEgz6k5yKdONQsb+LWADWs1IL45e9fVMjP FOwLsxMb/EckfvHa+LK32FJfPFJ/mnzja9Sqph0A1pN7y+xDVTH0J/PJyEaVZegM 5pvBwERg5oLfVe7PI+C+EeIpA0+E3Scu7rCu/AgZYduH38BcMdQdtUSzdUu0+7o= =mfKK -----END PGP SIGNATURE----- --=-=-=--