GNU bug report logs - #51658
[PATCH] Haiku port (again)

Previous Next

Full log

Message #73 received at 51658 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 51658 <at> debbugs.gnu.org
Subject: Re: bug#51658: [PATCH] Haiku port (again)
Date: Sat, 20 Nov 2021 11:56:31 +0200

> From: Po Lu <luangruo <at> yahoo.com>
> Cc: 51658 <at> debbugs.gnu.org
> Date: Sat, 20 Nov 2021 17:34:44 +0800
> 
> >>  (defun tooltip-show-help (msg)
> >>    "Function installed as `show-help-function'.
> >>  MSG is either a help string to display, or nil to cancel the display."
> >> -  (if (display-graphic-p)
> >> +  (if (and (display-graphic-p)
> >> +           (or (not (eq window-system 'haiku)) ;; On Haiku, there isn't a reliable way to show tooltips
> >> +                                               ;; above menus.
> >> +               (not (menu-or-popup-active-p))))
> 
> > This seems to contradict what you wrote in the user manual about
> > tooltip options?
> 
> This only disables tooltips on Haiku if a menu or popup is active, as
> Haiku doesn't let you map windows or tooltips above them.

But the manual doesn't mention that limitation, does it?

Does this limitation also affect tooltips produced by Emacs as special
frames?

> Here's a patch with the other issues you mentioned fixed.  Please see if
> it's better, thanks.

If you fixed everything and feel confident you did, just install it.
If there are some places where you want my opinion, please show only
those few places.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.