GNU bug report logs - #51653
[PATCH] Fix dumping stretch glyph when drawing s->next in NS port

Previous Next

Package: emacs;

Reported by: Po Lu <luangruo <at> yahoo.com>

Date: Sun, 7 Nov 2021 08:02:01 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Alan Third <alan <at> idiocy.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Po Lu <luangruo <at> yahoo.com>, 51653 <at> debbugs.gnu.org
Subject: bug#51653: [PATCH] Fix dumping stretch glyph when drawing s->next in NS port
Date: Sun, 7 Nov 2021 23:40:22 +0000
On Sun, Nov 07, 2021 at 09:43:24PM +0100, Lars Ingebrigtsen wrote:
> Po Lu <luangruo <at> yahoo.com> writes:
> 
> > * src/nsterm.m (ns_draw_glyph_string): Always focus even when dumping
> > stretch glyphs in s->next.
> 
> Alan, do you have any comments here?

I asked Po Lu to move the focus call out of ns_dumpglyphs_stretch and
into ns_draw_glyph_string as it's the only caller (in two places) and
it meant we didn't have to handle nested ns_focus calls further down.

I forgot to check this call had been fixed in subsequent patch sets.

So yeah, it's good.
-- 
Alan Third




This bug report was last modified 3 years and 192 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.