From unknown Wed Jun 18 23:15:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#51651 <51651@debbugs.gnu.org> To: bug#51651 <51651@debbugs.gnu.org> Subject: Status: 29.0.50; [PATCH] Fix xwidget-webkit-goto-history Reply-To: bug#51651 <51651@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:15:43 +0000 retitle 51651 29.0.50; [PATCH] Fix xwidget-webkit-goto-history reassign 51651 emacs submitter 51651 Po Lu severity 51651 normal tag 51651 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 07 01:55:04 2021 Received: (at submit) by debbugs.gnu.org; 7 Nov 2021 05:55:04 +0000 Received: from localhost ([127.0.0.1]:51542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjb8x-0004IQ-Ng for submit@debbugs.gnu.org; Sun, 07 Nov 2021 01:55:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:51988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjb8v-0004Hy-9L for submit@debbugs.gnu.org; Sun, 07 Nov 2021 01:55:02 -0400 Received: from [2001:470:142:3::10] (port=34084 helo=eggs.gnu.org) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjb8u-00053c-V7 for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 01:55:00 -0400 Received: from sonic304-20.consmr.mail.ne1.yahoo.com ([66.163.191.146]:35323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjb8t-0001gV-2r for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 01:55:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636264497; bh=xd5JZj+ERQGXaikoDx9ovtYIjWEWHILr8YMlL2Y8fkc=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=tEKN+y0VU8Nq9zXmFd6BS1oTSin196cmn5lnKRftQAWnwEts/uogVngbEp8l7oETviUQrJQfqP2FSNE5jVKC/YBF7Fca8r68qu6xWX+Q9iawqhO0q00oBRzsk+b8vSNKaXyJjjjbwoG0KvV7Iw3EJ1/yN+nAA//+GW3pgfar2FvF/ohEdC4UEiKOUcUJT2YNtsy6IIFvB2bV6lzP/K1tFUUJJ8Z423TK9JaxsE1YH5osg6BZ/Co/hsQutXSNCjTk8BxEzB46mKsNpY7sn1WplYAKBm6Qzd2O4y66daxhzMBxBgM9CqtbKwmTDktnC9OHi+Hfs81wFlHKPB7joUXDwg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636264497; bh=KWkSRmEebS6C1jxDOW1GAW6YcsR9Fw032yqyhD4MPIX=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=UvQl8tg6YR5zdpVJbmG/BVADY5mMIF6pbQYRZUQHT6ESI2fouYo5mRcZqsIoZ9BPYiAol6O9u6X8j6+UaL237eB8HohtwUGgJ9uqvIpriXF52q3cLUnE3XG2ll4Aas0X+x8LnitGTn8ocbcwOwJ/YmaKwhyLQ4s24qavF/Z9mrjKqGne//s7YG2QrgXQlKd9QqPs89LYjPvi6ycsTnJt8ffKq+FxW93sSAXNJNFQLW+HR1dn+qcJGwAMDH24EwiFI8c+qihzJYX0bcxZttYF0KDr8v7Plm6xSyrkvSXETz3wlb8suiWENBNQr55lINhL+jRViS0qV4nppqPCzg1qbg== X-YMail-OSG: YapItHIVM1maR9yN9617K9QLvkYnXHvWh_i6WM_3R9a5SW9DaiptEZmuD9XdaXt 9xQf263fFv1YH900cUZuu5m4rXNVsYLSBsND.r.ANT4kJH7XZHwDy3YnAuegp3.e88kJgMJ_Ml3R BjDxM4SjXYiIcistRmTyCLTudmA8nJfUcQ7q.eOItUK2N0wFdnPWiV2ZFn9ze.Oxh4RP0OKM0Bj_ cJeL3wVoBbn.AlrjkTFmKxiObsn22wQtL7u5fvekbGJP7eCzUYOJ7XW3XKYwutcs6a0tjsrhvYa4 uH.2Y9P7qhcKwyrEkzUZTGrhV0rsBUxhDaadXR.wnAUU6qundVnweV_lAS_iFrNIPdUrXKyS5dFV YOYB6AL9zmME6I7HM.pWzXTx0yl_FiG265G85ZEMqJSMaLOOrpz2ZJfK34EJMnj10X80NQyxgonh 8oqdfm_RwRkOR2LvM7pxWN.MxWABQTBdsYi_3fnTQszUe_onXGAkzUO_ZsWQRKtrLG7pulAqOKvc 6uuEZz6nS5jnRMN2GjULMOb._nt_7JamtuEDb2oliZmWwX9lMuayo6rbq7tGgvS__Y0OnzJUStik VXk4ICxP1znflM51MiRULb6FbJH4ZfuCcnDW4Acy4aPqvcvZBf4kwLFTqER8OjPEHIYh52fUv1.0 vJwv46cvaMe8mMg6b8x1yvU7.UBXoumALnCilYAjvjqMzN9B2BHfhM9erD8QkqykjgsKbsApb.YN SBXhDKGJPAztVYzJQGzDcFrcPuMm4kNyDBZxJGL7nMe8lntYA8YDLa98LJKt0rt_esiaT9jmpYZf pecBztmKjqqFZGBlGXOOiJ0gJWtRFzmPp62gRStD0dwMKdEPSolv8VAE2fyQKC6mO2LFXJ33yqhF DsVYwTEJqQMCD9UY2k9ykiM7p.PvGqlXhARpzUz6S5hTmuggICc0Ad.AGDCKkgOYfN9X84MdHslH CT4cIP6Jp0eKF5uo5SaouMGGROJbZA0YPSag6StrR6pmmnDQbduF6Qzwccnp9xdVU1ttliSAR7xa cMzOuktEpMc8OYXaNd3vTMZmjOfpT0dteUYs3zjkO7wWY2pR.ye4W.oEMPytwif3fPuMgIgOM48q MeL9ZaB1yXOtZz28BWdiveGAOqJg9INbaM3LGmJH.FsVFxRabYXifPYo4lubia0sXGcpcQajwhCI d9Ss1fY_bM_1Umu2iqaQarvn4eBVcIrxl518wZgUrrAvPVTRXVxQnn6ZGKHvDuBbT1hxjjZhHp8z 0vG40jpe.8mSPIE..xXWeH4cUzdTNZYHkHzK401D1IdyJsicFj.bw1dHYIfzZ661OhltOosaX_NQ WtqlEEZCcRmzmO67Gmc1nZgurZ1Mi3.Lu6SHiO1WNd91zpz_pMCU3OqfOOewA.VH5hvNmKvGnqYM 9ttQYZUJwDb3DSfZ5TxJ7no.lG7XtRbNh9wGuBqXWJY4W_nCT2pI58DnIowqwLnNQNt91TXHzc8V MbneSu4VhfTkS_ef6WyS5pDWhFEUZ13wamzz8CzIm9OnTwyOmRPHst6zQYTqd0N87piwDhR.j5T0 U4UiHcTPbDuUrgzVbeqfIaDGFEiwqcjbU86gIgQqSHQs2ymoMZs4nKgS9Pt8YMvtrtKKu9pSJOrd XWA1DkwWgcHNqyefN8SPYSiaHbozcFBQNfJsh_pjkxn.gyP6z9MMNAdNBUB5W4aFgR28q1B6Rv4N i4XAFLQLWKJGG_TZgF0p91.4kAK3LjClVwh.j9BuH5YhuOzaUnbmV1C1.6pkA0JfMab2r8XwCPt6 RmUZeUyuCpj.Rrpy3ZTGGAOTqNPNb3ah3YKrAEKs4qcyMZBuuzClCkxrIrCLVtTzVDuztHvwOIJ_ xVkoqokEsfs9cHb8jXdgEMG5AAEfwfhcuciwHCbOH5oSIcWl7VpAXRYVvAHtucSTB.5MneZz9OUV 1ulYTdndhy4D9EcRaGrEsG1H2zwFkAD6dawvD12DiTjaZGDJSMW3hjjmpXbkY_7iu9yPpFGB0KkT 3l5wO3jy1pMyizBQPrI06UrVPTAQgVSj939c.YNI2mTh80JQRxiny60lJ.3dVhKK2xFAFScqoFBt lvg2fw.YHdsR1oiwTIk7RFhsBldy3lQ407NZndgKIrB3YM3c7ln73_WXFB5YqcmyDGzhEnMb7MaI u7watkfQE3B9Zq1pdtoZ5o5zIft8gEHzdkFnBlxfMQZb3TiV05wJdJdAs3nLmDvSpARJ_kWCcOA7 9o.u2iV7mEoK1YGWlPy1XW5SFbbiUGw-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Sun, 7 Nov 2021 05:54:57 +0000 Received: by kubenode512.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID ec47d914eee589d80ec93a035d273be8; Sun, 07 Nov 2021 05:54:53 +0000 (UTC) From: Po Lu To: bug-gnu-emacs@gnu.org Subject: 29.0.50; [PATCH] Fix xwidget-webkit-goto-history Date: Sun, 07 Nov 2021 13:54:49 +0800 Message-ID: <87r1bswlw6.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" References: <87r1bswlw6.fsf.ref@yahoo.com> X-Mailer: WebService/1.1.19266 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 2237 Received-SPF: pass client-ip=66.163.191.146; envelope-from=luangruo@yahoo.com; helo=sonic304-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) --=-=-= Content-Type: text/plain This makes the back/forward navigation commands work again. Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-xwidget-webkit-goto-history.patch >From ec300c45296d3e247402fe72bff185e750d6e289 Mon Sep 17 00:00:00 2001 From: Po Lu Date: Sun, 7 Nov 2021 13:52:38 +0800 Subject: [PATCH] Fix xwidget-webkit-goto-history * src/xwidget.c (xwidget-webkit-goto-history): Use WebKitBackForwardList and XFIXNUM instead of XFIXNAT. --- src/xwidget.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/src/xwidget.c b/src/xwidget.c index 78a3860490..7944ca5c4b 100644 --- a/src/xwidget.c +++ b/src/xwidget.c @@ -1516,7 +1516,11 @@ DEFUN ("xwidget-webkit-goto-uri", DEFUN ("xwidget-webkit-goto-history", Fxwidget_webkit_goto_history, Sxwidget_webkit_goto_history, 2, 2, 0, - doc: /* Make the XWIDGET webkit load REL-POS (-1, 0, 1) page in browse history. */) + doc: /* Make the XWIDGET webkit the REL-POSth element in load history. + +If REL-POS is 0, the widget will be just reload the current element in +history. If REL-POS is more or less than 0, the widget will load the +REL-POSth element around the current spot in the load history. */) (Lisp_Object xwidget, Lisp_Object rel_pos) { WEBKIT_FN_INIT (); @@ -1526,11 +1530,20 @@ DEFUN ("xwidget-webkit-goto-history", #ifdef USE_GTK WebKitWebView *wkwv = WEBKIT_WEB_VIEW (xw->widget_osr); - switch (XFIXNAT (rel_pos)) + WebKitBackForwardList *list; + WebKitBackForwardListItem *it; + + if (XFIXNUM (rel_pos) == 0) + webkit_web_view_reload (wkwv); + else { - case -1: webkit_web_view_go_back (wkwv); break; - case 0: webkit_web_view_reload (wkwv); break; - case 1: webkit_web_view_go_forward (wkwv); break; + list = webkit_web_view_get_back_forward_list (wkwv); + it = webkit_back_forward_list_get_nth_item (list, XFIXNUM (rel_pos)); + + if (!it) + error ("There is no item at this index"); + + webkit_web_view_go_to_back_forward_list_item (wkwv, it); } #elif defined NS_IMPL_COCOA nsxwidget_webkit_goto_history (xw, XFIXNAT (rel_pos)); -- 2.31.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 07 08:42:05 2021 Received: (at 51651) by debbugs.gnu.org; 7 Nov 2021 13:42:05 +0000 Received: from localhost ([127.0.0.1]:52086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjiQv-0001WA-J2 for submit@debbugs.gnu.org; Sun, 07 Nov 2021 08:42:05 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjiQs-0001Vd-Kr for 51651@debbugs.gnu.org; Sun, 07 Nov 2021 08:42:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aPSMfb7pTGtU0vah3faxpIb5BoeN8CUY6B/fIQaAPoY=; b=gAaU7sZBf/cvUvA/PWCvOF1djN 7PCj/PpJq7G13Kg+NEQKubwmvRApF79nv5PMSPjS0A+dpuD6tD1cawh8E+CnrKXM5OPDT5XGCJq+O w9kvngi8NYr3MQt88SYK0SNBxp17clvpol9WMCVDYBVIhHikyx4ivJY2Vp3kET8mPt0g=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjiQj-0000k2-Ur; Sun, 07 Nov 2021 14:41:56 +0100 From: Lars Ingebrigtsen To: 51651@debbugs.gnu.org Subject: Re: bug#51651: 29.0.50; [PATCH] Fix xwidget-webkit-goto-history References: <87r1bswlw6.fsf.ref@yahoo.com> <87r1bswlw6.fsf@yahoo.com> X-Now-Playing: Moon-Drenched's _Moon-Drenched_: "Terra Incognito" Date: Sun, 07 Nov 2021 14:41:52 +0100 In-Reply-To: <87r1bswlw6.fsf@yahoo.com> (Po Lu via's message of "Sun, 07 Nov 2021 13:54:49 +0800") Message-ID: <87fss8jd5r.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > This makes the back/forward navigation commands work again. Thanks; applied to the trunk. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51651 Cc: Po Lu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > This makes the back/forward navigation commands work again. Thanks; applied to the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 07 08:42:15 2021 Received: (at control) by debbugs.gnu.org; 7 Nov 2021 13:42:15 +0000 Received: from localhost ([127.0.0.1]:52090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjiR4-0001We-Ql for submit@debbugs.gnu.org; Sun, 07 Nov 2021 08:42:14 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjiR2-0001WM-UA for control@debbugs.gnu.org; Sun, 07 Nov 2021 08:42:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=o18s7JuxVUUnpak9Jq1rDDFyP86/KiNall5TU3NMeWE=; b=sWdGkKuXaq6K+VR60YAa2StK9p 1dY4RY1w2cu9UW2OBEvLrljLbztO/BhoCEVAQY5gqI56u8usW18M5gxdo6jgWY+bguart0cjTdBgK 7BpPAiDxkSJJxg9nk/fej5xxG8Zf6q/ZhOtwFn2N/ku1JE8OaqTDBiPZKiqF3O+27PN0=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjiQv-0000kE-AS for control@debbugs.gnu.org; Sun, 07 Nov 2021 14:42:07 +0100 Date: Sun, 07 Nov 2021 14:42:04 +0100 Message-Id: <87ee7sjd5f.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #51651 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 51651 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 51651 29.1 quit From unknown Wed Jun 18 23:15:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 06 Dec 2021 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator