GNU bug report logs - #51605
Fwd: [PATCH] Update themes to support mode-line

Previous Next

Full log

Message #25 received at 51605 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: paaguti <at> gmail.com, 51605 <at> debbugs.gnu.org
Subject: Re: bug#51605: Fwd: [PATCH] Update themes to support mode-line
Date: Sun, 05 Dec 2021 20:38:23 +0200

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Sun, 5 Dec 2021 19:05:36 +0100
> Cc: Pedro Andres Aranda Gutierrez <paaguti <at> gmail.com>
> 
> AFAICT, the point of this patch is essentially changing the line-number
> face to inherit the fringe face and line-number-current to have the
> default foreground (to make the current line more visible).
> 
> I think this makes sense and looks good.  I checked, and this seems to
> be what VSCode is doing too, so I don't think it's a controversial
> design choice.
> 
> So I'd suggest installing the below diff, and then an adapted version of
> the proposed patch from Pedro Andres Aranda Gutierrez.  Comments?

I don't think we should change defaults of the faces because someone
prefers to have them look differently.  Faces can be easily
customized, so people who don't like the defaults can have the faces
they like very easily.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.