GNU bug report logs - #516
[PATCH] Minor Enhancement for grep.el: auto-input the symbol into minibuffer command line.

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> jurta.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 516 <at> debbugs.gnu.org
Subject: bug#516: [PATCH] Minor Enhancement for grep.el: auto-input thesymbol into minibuffer command line.
Date: Sat, 05 Dec 2009 21:51:17 +0200

>> > This patch is to let you input the cursor position symbol
>> > automatically into minibuffer command line. I think it makes
>> > us easier to use "grep-find" function.
>>
>> There is a function `grep-default-command' in grep.el that does this.
>> I wonder why it's used in `grep', but not in `grep-find'.  I think
>> we should do the same in `grep-find'.
>
> Yes, and as I've suggested before, if the region is active,
> then its contents, surrounded by "s, should be the default
> search string. Example code:
> http://www.emacswiki.org/emacs/grep%2b.el

`grep-tag-default' already provides the active region.  But it uses
`shell-quote-argument' instead of surrounding by quotes.  I don't know
what is better, since it's harder to edit the command when
`shell-quote-argument' puts a backslash before every space
and some other characters.

Another drawback of `grep-tag-default' is that it provides only
one alternative.  This is unlike `read-regexp' that proposes
a list of possible default values.  So `grep-tag-default' could be
improved to do the same.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.