GNU bug report logs - #51590
follow-mode is broken with header-line and tab-line

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alan Mackenzie <acm <at> muc.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#51590: closed (follow-mode is broken with header-line and
 tab-line)
Date: Mon, 08 Nov 2021 07:14:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 8 Nov 2021 07:13:30 +0000
with message-id <YYjOGkXy7zU/f57e <at> ACM>
and subject line Re: bug#51590: follow-mode is broken with header-line and tab-line
has caused the debbugs.gnu.org bug report #51590,
regarding follow-mode is broken with header-line and tab-line
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
51590: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51590
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: Tab-line breaks windows of follow-mode
Date: Wed, 03 Nov 2021 20:24:18 +0200

In emacs -Q visit a long buffer, split the window horizontally,
and enable 'M-x follow-mode'.  A partially-visible bottom line
of the left window will help to observe that the same line
is completely visible at the top of the right window.
This is a nice feature that allows follow-mode to work correctly.

Now enable 'M-x global-tab-line-mode' and observe that
the same line is still visible at the top of the right window,
whereas the bottom line of the left window shows another
partially-visible line.  This is a bug.

The most low-level function of follow-mode is follow-calc-win-end.
When global-tab-line-mode is enabled, follow-calc-win-end
returns the same values as when global-tab-line-mode is disabled.

I don't understand what more low-level function doesn't take
into account the height of the tab-line.  Maybe the problem is
in pos-visible-in-window-p?  Or maybe different values returned
by window-inside-pixel-edges and window-end?

[Message part 3 (message/rfc822, inline)]

From: Alan Mackenzie <acm <at> muc.de>
To: Juri Linkov <juri <at> linkov.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 51590-done <at> debbugs.gnu.org
Subject: Re: bug#51590: follow-mode is broken with header-line and tab-line
Date: Mon, 8 Nov 2021 07:13:30 +0000

Hello, Juri.

On Sun, Nov 07, 2021 at 21:56:50 +0200, Juri Linkov wrote:
> >> Thanks, I tested it out, and everything works without a hitch:
> >> with tab-line-format, or with header-line-format, or with both.

> > That's great.  If it's OK with you, I will write a commit message,
> > commit the change to the emacs-28 branch, then merge it to master.

> > Thanks for spotting the problem with the header line; it's been there
> > for a long time.

> Fixing it on the emacs-28 branch would be great.  I hadn't realized
> until now that some glitches in follow-mode were related to the
> tab-line/header-line.  Thanks in advance for pushing the fix
> to the emacs-28 branch.

Done.  I'm closing the bug with this post.

-- 
Alan Mackenzie (Nuremberg, Germany).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.