GNU bug report logs - #51587
[PATCH 0/3] Add rss2email.

Previous Next

Package: guix-patches;

Reported by: Morgan.J.Smith <at> outlook.com

Date: Wed, 3 Nov 2021 16:34:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Morgan.J.Smith <at> outlook.com
To: monego <at> posteo.net, 51587 <at> debbugs.gnu.org
Subject: [bug#51587] [PATCH v2 0/3] gnu: Add rss2email.
Date: Thu, 11 Nov 2021 10:30:02 -0500
Thanks for the review!

I looked over both previously submitted sgmllib3k packages and I think my patch is the best as the description mentions SGML.

I fixed the sgmllib3k indentation issue and added a missing word to the description.

For the rss2email patch:
- I added my copyright to mail.scm
- I removed the inputs and outputs from the check phase
- Made the input not propagated. It is indeed a binary that seems to still work this way.
- Fixed that comment
- Slightly modified the description but I'm honestly not sure what the issue is. I'll admit I'm not very good at english so if you could just change it how you see fit that would make me happy


[PATCH v2 1/3] gnu: Add python-sgmllib3k.
[PATCH v2 2/3] gnu: python-feedparser: Add input
[PATCH v2 3/3] gnu: Add rss2email.





This bug report was last modified 3 years and 194 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.