GNU bug report logs - #51573
[PATCH] gnu: virtualization: Add qemu-guest-agent service.

Previous Next

Full log

Message #10 received at 51573-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Timotej Lazar <timotej.lazar <at> araneo.si>
Cc: 51573-done <at> debbugs.gnu.org
Subject: Re: bug#51573: [PATCH] gnu: virtualization: Add qemu-guest-agent
 service.
Date: Fri, 12 Nov 2021 23:41:29 +0100

[Message part 1 (text/plain, inline)]

Hi,

Timotej Lazar <timotej.lazar <at> araneo.si> skribis:

> * gnu/services/virtualization.scm (<qemu-guest-agent-configuration>): New
> record.
> (qemu-guest-agent-shepherd-service): New procedure.
> (qemu-guest-agent-service-type): New variable.
> * doc/guix.texi (Virtualization Services): Document it.

Nice.  Do you think we could have a simple test under (gnu tests
virtualization) for this?

Applied with the cosmetic changes below.

Thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/doc/guix.texi b/doc/guix.texi
index c0dfb2e5e2..7e54b5f75e 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -30060,14 +30060,14 @@ Return the name of @var{platform}---a string such as @code{"arm"}.
 @end deffn
 
 
-@subsubheading QEMU guest agent
+@subsubheading QEMU Guest Agent
 
 @cindex emulation
 
 The QEMU guest agent provides control over the emulated system to the
 host.  The @code{qemu-guest-agent} service runs the agent on Guix
 guests.  To control the agent from the host, open a socket by invoking
-@code{qemu} with the following arguments:
+QEMU with the following arguments:
 
 @example
 qemu-system-x86_64 \
@@ -30098,11 +30098,11 @@ Configuration for the @code{qemu-guest-agent} service.
 
 @table @asis
 @item @code{qemu} (default: @code{qemu-minimal})
-The qemu package to use.
+The QEMU package to use.
 
 @item @code{device} (default: @code{""})
-Path to device or socket the agent uses to communicate with the host.
-If empty, QEMU uses a default path.
+File name of the device or socket the agent uses to communicate with the
+host.  If empty, QEMU uses a default file name.
 @end table
 @end deftp
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.