GNU bug report logs - #51565
PATCH: Update Yggdrasil to new protocol (important breaking changes)

Previous Next

Full log

View this message in rfc822 format

From: raingloom <raingloom <at> riseup.net>
To: pukkamustard <pukkamustard <at> posteo.net>
Cc: 51565 <at> debbugs.gnu.org
Subject: [bug#51565] PATCH: Update Yggdrasil to new protocol (important breaking changes)
Date: Mon, 22 Nov 2021 22:13:08 +0100

[Message part 1 (text/plain, inline)]

On Mon, 15 Nov 2021 14:10:46 +0000
pukkamustard <pukkamustard <at> posteo.net> wrote:

> Thanks for this!
> 
> Some minor changes may be needed to make the linter happy:
> 
> raingloom <raingloom <at> riseup.net> writes:
> 
> [..]
> 
> > [3. text/x-patch; 0002-gnu-Add-go-github-com-rivo-uniseg.patch]...  
> 
> Linter complains that a line is too long:
> 
> gnu/packages/golang.scm:8885:0: go-github-com-rivo-uniseg <at> 0.2.0: line
> 8885 is way too long (93 characters)
> 
> >
> > [4. text/x-patch;
> > 0003-gnu-Add-go-github-com-mattn-go-runewidth.patch]...  
> 
> Linter complains about the synopsis. Maybe: "Go functions for getting
> fixed width of characters or strings"?
> 
> Does seem like a bit of a duplication of the description...
> 
> > [5. text/x-patch;
> > 0004-gnu-go-github-com-cheggaaa-pb-Update-to-3.0.8.patch]...
> >
> > [6. text/x-patch;
> > 0005-gnu-Rename-go-github-com-cheggaaa-pb-to-go-github-co.patch]...
> >
> > [7. text/x-patch;
> > 0006-gnu-Add-go-github-com-arceliar-ironwood.patch]...  
> 
> Lines in descriptions are too long and should be wrapped.
> 
> A synopsis is required. Maybe: "Ironwood is a Go network routing
> library using cryptographic keys as addresses"?

Heck, I think I meant to run the linter but it was getting late and I
just wanted to be done with the patch. Well, here is an updated patch
list.

[0008-gnu-yggdrasil-Update-to-0.4.1.patch (text/x-patch, attachment)]

[0007-gnu-yggdrasil-Update-to-0.4.0.patch (text/x-patch, attachment)]

[0006-gnu-Add-go-github-com-arceliar-ironwood.patch (text/x-patch, attachment)]

[0005-gnu-Rename-go-github-com-cheggaaa-pb-to-go-github-co.patch (text/x-patch, attachment)]

[0004-gnu-go-github-com-cheggaaa-pb-Update-to-3.0.8.patch (text/x-patch, attachment)]

[0003-gnu-Add-go-github-com-mattn-go-runewidth.patch (text/x-patch, attachment)]

[0002-gnu-Add-go-github-com-rivo-uniseg.patch (text/x-patch, attachment)]

[0001-gnu-Add-go-github-com-vividcortex-ewma.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.