Subject: Re: bug#51565: PATCH: Update Yggdrasil to new protocol (important breaking changes)

From: raingloom <[email-masked]>
Date: Wed, 1 Dec 2021 17:03:10 +0100

On Wed, 01 Dec 2021 16:27:23 +0100
Ludovic Courtès <[email-masked]> wrote:

> Hi raingloom,
> 
> Apologies for the delay.
> 
> raingloom <[email-masked]> skribis:
> 
> >>From 776202eb2d0610e51f5168d108ce80a4096b10d4 Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <[email-masked]>
> > Date: Wed, 3 Nov 2021 21:40:37 +0100
> > Subject: [PATCH 8/8] gnu: yggdrasil: Update to 0.4.1.
> >
> > * gnu/packages/networking.scm (yggdrasil): Update to 0.4.1.
> > * gnu/packages/patches/yggdrasil-extra-config.patch: Update for new
> > version.  
> 
> OK.
> 
> >>From ce6e34a490816fd9c093fec3b9124bff26620e1f Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <[email-masked]>
> > Date: Tue, 2 Nov 2021 06:50:36 +0000
> > Subject: [PATCH 6/8] gnu: Add go-github-com-arceliar-ironwood.
> >
> > * gnu/packages/golang.scm (go-github-com-arceliar-ironwood): New
> > variable.  
> 
> OK.
> 
> >>From 1b4bfd5a947902f453e47a510ab058ff459412f5 Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <[email-masked]>
> > Date: Tue, 2 Nov 2021 06:46:57 +0000
> > Subject: [PATCH 5/8] gnu: Rename go-github-com-cheggaaa-pb to
> >  go-github-com-cheggaaa-pb-v3.
> >
> > * gnu/packages/golang.scm:
> >   (go-github-com-cheggaaa-pb): Rename variable.
> >   (go-github-com-cheggaaa-pb-v3): New variable.
> > ---
> >  gnu/packages/golang.scm | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> > index 4033806c7f..d0435b5469 100644
> > --- a/gnu/packages/golang.scm
> > +++ b/gnu/packages/golang.scm
> > @@ -7945,9 +7945,9 @@ (define-public go-github-com-arceliar-phony
> >  inspired by the causal messaging system in the Pony programming
> > language.") (license license:expat))))
> >  
> > -(define-public go-github-com-cheggaaa-pb
> > +(define-public go-github-com-cheggaaa-pb-v3
> >    (package
> > -    (name "go-github-com-cheggaaa-pb")
> > +    (name "go-github-com-cheggaaa-pb-v3")  
> 
> Why rename?  If we do need to rename, let’s add a ‘deprecated-package’
> definition to allow users to notice and get a smooth upgrade.

Without a rename guix import go gets confused and imports it again
under that name. It didn't seem like anything was using it so I went
with a rename, but I guess someone's channel might be depending on it.
(although I doubt it)
What would proper deprecation look like? Just inheriting from the new
package, changing the name field, and marking it as deprecated?

> >>From 6a4220dbb3cbb56cc818bd2f2714484e5f8682e4 Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <[email-masked]>
> > Date: Tue, 2 Nov 2021 06:45:47 +0000
> > Subject: [PATCH 4/8] gnu: go-github-com-cheggaaa-pb: Update to
> > 3.0.8.
> >
> > * gnu/packages/golang.scm (go-github-com-cheggaaa-pb): Update to
> > 3.0.8.  
> 
> Could you mention input changes?
> 
> >>From a234dd530900d0914a9972ad5a22a1fe303c1bc5 Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <[email-masked]>
> > Date: Tue, 2 Nov 2021 06:37:17 +0000
> > Subject: [PATCH 3/8] gnu: Add go-github-com-mattn-go-runewidth.
> >
> > * gnu/packages/golang.scm (go-github-com-mattn-go-runewidth): New
> > variable.  
> 
> [...]
> 
> > +    (home-page "https://github.com/mattn/go-runewidth")
> > +    (synopsis "Rune width implementation for Go")
> > +    (description
> > +      "Provides functions to get fixed width of the character or
> > string.")  
> 
> Please write a full sentence:
> 
>   https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html
> 
> >>From 4732bee7bdbea38292afe9f6b1149986dbfabcb7 Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <[email-masked]>
> > Date: Tue, 2 Nov 2021 06:37:11 +0000
> > Subject: [PATCH 2/8] gnu: Add go-github-com-rivo-uniseg.
> >
> > * gnu/packages/golang.scm (go-github-com-rivo-uniseg): New
> > variable.  
> 
> [...]
> 
> > +    (synopsis "Unicode Text Segmentation for Go")
> > +    (description
> > +      "Package uniseg implements Unicode Text Segmentation
> > according to Unicode +Standard Annex #29
> > +(@url{http://unicode.org/reports/tr29/,http://unicode.org/reports/tr29/}).
> > +")  
> 
> Ditto.
> 
> >>From c11a2cf43ddd6108b57c24ef9669655b677ce276 Mon Sep 17 00:00:00
> >>2001  
> > From: raingloom <[email-masked]>
> > Date: Tue, 2 Nov 2021 06:36:37 +0000
> > Subject: [PATCH 1/8] gnu: Add go-github-com-vividcortex-ewma.
> >
> > * gnu/packages/golang.scm (go-github-com-vividcortex-ewma): New
> > variable.  
> 
> [...]
> 
> > +    (home-page "https://github.com/VividCortex/ewma")
> > +    (synopsis "EWMA")
> > +    (description
> > +      "Package ewma implements exponentially weighted moving
> > averages.")  
> 
> Ditto.
> 
> Could you send updated patches?
> 
> TIA,
> Ludo’.