From unknown Sun Jun 22 00:07:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51558: Long mode-line-compact breaks tab-line tabs Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Nov 2021 20:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 51558@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163579741128027 (code B ref -1); Mon, 01 Nov 2021 20:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Nov 2021 20:10:11 +0000 Received: from localhost ([127.0.0.1]:36216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhddD-0007Hz-Aj for submit@debbugs.gnu.org; Mon, 01 Nov 2021 16:10:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:34962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhdd8-0007Hk-Qq for submit@debbugs.gnu.org; Mon, 01 Nov 2021 16:10:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhdd5-0008DM-9c for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 16:10:06 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:40321) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhdcz-0006Zb-CG for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 16:10:03 -0400 Received: (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id D89AE100006 for ; Mon, 1 Nov 2021 20:09:51 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET Date: Mon, 01 Nov 2021 21:59:42 +0200 Message-ID: <86pmrjsl3l.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) 0. emacs -Q 1. (setq mode-line-compact 'long) 2. (global-tab-line-mode) 3. Visit more buffers in the same window 4. Click on a non-first tab on the tab-line 5. It always selects the first tab only The click event returns a string that contains all tabs, whereas with the default value of mode-line-compact the event correctly contains only one tab's string. I don't know why mode-line-compact affects the tab-line, but maybe it should have a condition to not apply to the tab-line? From unknown Sun Jun 22 00:07:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51558: Long mode-line-compact breaks tab-line tabs Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Nov 2021 13:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 51558@debbugs.gnu.org Received: via spool by 51558-submit@debbugs.gnu.org id=B51558.163585817632630 (code B ref 51558); Tue, 02 Nov 2021 13:03:01 +0000 Received: (at 51558) by debbugs.gnu.org; 2 Nov 2021 13:02:56 +0000 Received: from localhost ([127.0.0.1]:36887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhtRH-0008UE-OY for submit@debbugs.gnu.org; Tue, 02 Nov 2021 09:02:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhtRG-0008U1-HO for 51558@debbugs.gnu.org; Tue, 02 Nov 2021 09:02:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhtR5-0000qz-AV; Tue, 02 Nov 2021 09:02:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=f/rG5C+PPOdeFiEGkqRbnDvCu4DHJ7YrsgOrXji0Tvs=; b=Rn+mp8WD9iO6 VQPcpRrHCOR8mDQkHDy99CXUmkxPgeNPkU5FQ7xLAc75ZltOigLJuaCXmlA++Taa6CLkusNa0O5Zo ZUVSSfMRRbnqs4qI8uu8ZCITFFMLOeh8uOd9mE1fRcpReuuE1TxU5Y0UJ0rvt7Fhqjj+podkU3Grk 9hvRC6H7zSs1JrUHWkBIycPINKhr5jMtIPHRCLatfrHVsMOGxQ1f2cghr6yLs1zF/if8dnTpXyZ13 E5bzkRy/D7M94MdoEj06M9GXglNby7Pii3cRqkce2YM9BU6lgQUyL1ahKOnL4QDsQEApC8tKC0p9o +BJRDHCTj5+i97m/83XT0g==; Received: from [87.69.77.57] (port=1915 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhtR4-0007oA-S1; Tue, 02 Nov 2021 09:02:43 -0400 Date: Tue, 02 Nov 2021 15:02:37 +0200 Message-Id: <837ddqlngy.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86pmrjsl3l.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 01 Nov 2021 21:59:42 +0200) References: <86pmrjsl3l.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Mon, 01 Nov 2021 21:59:42 +0200 > > 0. emacs -Q > 1. (setq mode-line-compact 'long) > 2. (global-tab-line-mode) > 3. Visit more buffers in the same window > 4. Click on a non-first tab on the tab-line > 5. It always selects the first tab only > > The click event returns a string that contains all tabs, > whereas with the default value of mode-line-compact > the event correctly contains only one tab's string. > > I don't know why mode-line-compact affects the tab-line, > but maybe it should have a condition to not apply to the tab-line? I think it's indeed a bug that mode-line-compact affects anything but the mode line. Does the patch below give good results? diff --git a/src/xdisp.c b/src/xdisp.c index 436153b..c05e7ed 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -25592,7 +25592,8 @@ display_mode_line (struct window *w, enum face_id face_id, Lisp_Object format) push_kboard (FRAME_KBOARD (it.f)); record_unwind_save_match_data (); - if (NILP (Vmode_line_compact)) + if (NILP (Vmode_line_compact) + || face_id == HEADER_LINE_FACE_ID || face_id == TAB_LINE_FACE_ID) { mode_line_target = MODE_LINE_DISPLAY; display_mode_element (&it, 0, 0, 0, format, Qnil, false); From unknown Sun Jun 22 00:07:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51558: Long mode-line-compact breaks tab-line tabs Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Nov 2021 08:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 51558@debbugs.gnu.org Received: via spool by 51558-submit@debbugs.gnu.org id=B51558.163592915226238 (code B ref 51558); Wed, 03 Nov 2021 08:46:02 +0000 Received: (at 51558) by debbugs.gnu.org; 3 Nov 2021 08:45:52 +0000 Received: from localhost ([127.0.0.1]:38924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miBu3-0006p8-PI for submit@debbugs.gnu.org; Wed, 03 Nov 2021 04:45:51 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:44261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miBu2-0006op-6P for 51558@debbugs.gnu.org; Wed, 03 Nov 2021 04:45:50 -0400 Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 9B5EF24000F; Wed, 3 Nov 2021 08:45:42 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <86pmrjsl3l.fsf@mail.linkov.net> <837ddqlngy.fsf@gnu.org> Date: Wed, 03 Nov 2021 10:45:15 +0200 In-Reply-To: <837ddqlngy.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 02 Nov 2021 15:02:37 +0200") Message-ID: <868ry5bpb8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> The click event returns a string that contains all tabs, >> whereas with the default value of mode-line-compact >> the event correctly contains only one tab's string. >> >> I don't know why mode-line-compact affects the tab-line, >> but maybe it should have a condition to not apply to the tab-line? > > I think it's indeed a bug that mode-line-compact affects anything but > the mode line. Does the patch below give good results? I confirm the fix, there are no more problems with it. From unknown Sun Jun 22 00:07:43 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Juri Linkov Subject: bug#51558: closed (Re: bug#51558: Long mode-line-compact breaks tab-line tabs) Message-ID: References: <83o871iee1.fsf@gnu.org> <86pmrjsl3l.fsf@mail.linkov.net> X-Gnu-PR-Message: they-closed 51558 X-Gnu-PR-Package: emacs Reply-To: 51558@debbugs.gnu.org Date: Wed, 03 Nov 2021 13:00:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1635944403-31275-1" This is a multi-part message in MIME format... ------------=_1635944403-31275-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #51558: Long mode-line-compact breaks tab-line tabs which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 51558@debbugs.gnu.org. --=20 51558: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51558 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1635944403-31275-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 51558-done) by debbugs.gnu.org; 3 Nov 2021 12:59:29 +0000 Received: from localhost ([127.0.0.1]:39439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miFrV-000878-E7 for submit@debbugs.gnu.org; Wed, 03 Nov 2021 08:59:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miFrT-00086p-Ot for 51558-done@debbugs.gnu.org; Wed, 03 Nov 2021 08:59:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49750) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miFrN-0004Ju-N2; Wed, 03 Nov 2021 08:59:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZNkxsSY3BynJF+JJpcJt7pkF9b0zd+oK7sushanSp60=; b=QUzMJqdq9F5y 1DelnVsVhqqWhs1B0N6g3Fyrh5d35T1OumcMdvk45C0bueMXL4z6h4ajVPBzTtSoSJs8uRrXnbErx senMYJ+iTUre1TdE8s1dP43NMLvdJaVl/jEDZWZ5zOraHvw4Iw42WnT6efTJLywXq//yo4ekEQWpq psbtkiEL7L6PiPUVA27VFqB4HHSNlBYaXiNAqOk5NOgU8YUFfrOAuCUP4B7svTklnpDE4RbpklozG RBYuhr13f7xDiKrQ+Jg6C67TJVRN7+telr99lSTAJtCpt7VjRfbr/k2pxgyl9rcmrCVCkRo2WFDOV SkAcO7MD4sECRGhT+AQioA==; Received: from [87.69.77.57] (port=2413 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miFrM-0003Pt-Gl; Wed, 03 Nov 2021 08:59:21 -0400 Date: Wed, 03 Nov 2021 14:59:18 +0200 Message-Id: <83o871iee1.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <868ry5bpb8.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 03 Nov 2021 10:45:15 +0200) Subject: Re: bug#51558: Long mode-line-compact breaks tab-line tabs References: <86pmrjsl3l.fsf@mail.linkov.net> <837ddqlngy.fsf@gnu.org> <868ry5bpb8.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51558-done Cc: 51558-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 51558@debbugs.gnu.org > Date: Wed, 03 Nov 2021 10:45:15 +0200 > > >> The click event returns a string that contains all tabs, > >> whereas with the default value of mode-line-compact > >> the event correctly contains only one tab's string. > >> > >> I don't know why mode-line-compact affects the tab-line, > >> but maybe it should have a condition to not apply to the tab-line? > > > > I think it's indeed a bug that mode-line-compact affects anything but > > the mode line. Does the patch below give good results? > > I confirm the fix, there are no more problems with it. Thanks, I installed on the emacs-28 branch, and am closing the bug. ------------=_1635944403-31275-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Nov 2021 20:10:11 +0000 Received: from localhost ([127.0.0.1]:36216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhddD-0007Hz-Aj for submit@debbugs.gnu.org; Mon, 01 Nov 2021 16:10:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:34962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhdd8-0007Hk-Qq for submit@debbugs.gnu.org; Mon, 01 Nov 2021 16:10:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhdd5-0008DM-9c for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 16:10:06 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:40321) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhdcz-0006Zb-CG for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 16:10:03 -0400 Received: (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id D89AE100006 for ; Mon, 1 Nov 2021 20:09:51 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Long mode-line-compact breaks tab-line tabs Organization: LINKOV.NET Date: Mon, 01 Nov 2021 21:59:42 +0200 Message-ID: <86pmrjsl3l.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) 0. emacs -Q 1. (setq mode-line-compact 'long) 2. (global-tab-line-mode) 3. Visit more buffers in the same window 4. Click on a non-first tab on the tab-line 5. It always selects the first tab only The click event returns a string that contains all tabs, whereas with the default value of mode-line-compact the event correctly contains only one tab's string. I don't know why mode-line-compact affects the tab-line, but maybe it should have a condition to not apply to the tab-line? ------------=_1635944403-31275-1--