GNU bug report logs - #51556
29.0.50; Poor contrast of Customize SVG icons with dark backgrounds

Previous Next

Package: emacs;

Reported by: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>

Date: Mon, 1 Nov 2021 17:57:02 UTC

Severity: normal

Found in version 29.0.50

Fixed in version 29.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log


Message #32 received at 51556 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: jporterbugs <at> gmail.com, kevin.legouguec <at> gmail.com, 51556 <at> debbugs.gnu.org
Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with
 dark backgrounds
Date: Tue, 2 Nov 2021 08:26:12 -0700
[Message part 1 (text/plain, inline)]
Stefan Kangas <stefan <at> marxist.se> writes:

>> As for foreground: what does it mean to remove the foreground from an
>> image?

(I realize that I didn't answer this part in my previous reply.)  SVG is
a special case, where we just use the foreground of the current face.

In this case, I think the fix is as simple as the attached patch.  I've
tested this with several themes, and it looks very good to my eyes.

I suggest that we install this fix on emacs-28.
[0001-Use-current-face-foreground-for-SVG-icons-in-customi.patch (text/x-diff, attachment)]

This bug report was last modified 3 years and 252 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.