From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 01 13:56:23 2021 Received: (at submit) by debbugs.gnu.org; 1 Nov 2021 17:56:23 +0000 Received: from localhost ([127.0.0.1]:36045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhbXi-0003gt-Uc for submit@debbugs.gnu.org; Mon, 01 Nov 2021 13:56:23 -0400 Received: from lists.gnu.org ([209.51.188.17]:34878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhbXg-0003gk-UD for submit@debbugs.gnu.org; Mon, 01 Nov 2021 13:56:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhbXg-00043M-Jh for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 13:56:20 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:53070) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhbXd-0000ZK-DC for bug-gnu-emacs@gnu.org; Mon, 01 Nov 2021 13:56:20 -0400 Received: by mail-wm1-x32a.google.com with SMTP id b71so2420324wmd.2 for ; Mon, 01 Nov 2021 10:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:user-agent:mime-version; bh=n1XHL/JrIdCA4aWPrIj1ETsL417N0EgWpkTkzd2Jws4=; b=aFIaxPK5QjXXkDz2Bz5ehNEPdk9gb2RNly47rb7MHKOrwSYlbD1Cje20EJ3wHoXm3B OO7+ifSMrjJjlEzU59oYFKp4U4fyxmZ2tjxio1VjPYYwq+sQnuqV98FaALcyigcCHVAq z+NbBiZNMi7MMHIFgdI0CRuBvq7ZiE6cZN+UGftPQ/bHA+IMmnCY6OJiskJqic1Qu5/w cvOh0ohWscYR0FvMe2MKSMreWz5uz7IpzysArXQgGQHgTYH3F0PfvfTlMlFoUyXWmtIy 4AuFjWLxh1bht+4a6YQfZIjefDldhSwmdkW9gl00dnd7RtdWDW8PSOKD0SU2K7TKEkTx /sEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=n1XHL/JrIdCA4aWPrIj1ETsL417N0EgWpkTkzd2Jws4=; b=FRym6XFAUOfPMnkNo03/hx93p+T9R/joIKYvTFCGDURPPEYiNxHoTpxnrb3YHtvO+5 OAWnjnqsVM+XT+D4GbZWxcnbgvirznmTVZlSmtW8bXjtUhiWFKfEAJ+diJ9mC56gLzMi 3YaMwR1h8bIGs4hWJGXlGIDb448x+mCFGyQfeX0sr9nJNP7Lv4/+qoe+NEl25J9njJMl fNke93pUfMSCEsQD847blbcWlXbVl2pZOJiOHnFXjJZaqq09z68werwGxsDa6ea6uo5R aqIZZhmBJ9SjouUu7crHLS3Z+A1YC3BH6r3iDMNAFxOg5C3bAqp3xRAAlNiDd6M1fAk0 9fHg== X-Gm-Message-State: AOAM530UWzOxhBvHz/qYAlFYgfrRXlTf36o8KhWFMCiozSkneIeHAP7H aqvktAqZuNFNWHDDx8A7SOAywCK+glk= X-Google-Smtp-Source: ABdhPJwqgn0ftvbtG6kBIfAFGbAKwdbHMeb8M9BNy3LhAMWJ/WEQHtIbWwzqRdLcY8yX/zxSxuPkqw== X-Received: by 2002:a05:600c:3584:: with SMTP id p4mr466035wmq.168.1635789374721; Mon, 01 Nov 2021 10:56:14 -0700 (PDT) Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id j7sm258680wmq.32.2021.11.01.10.56.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 10:56:14 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: bug-gnu-emacs@gnu.org Subject: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Date: Mon, 01 Nov 2021 18:56:13 +0100 Message-ID: <87v91b92v6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=kevin.legouguec@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On darker themes (e.g. modus-vivendi), the Customize SVG icons (etc/images/right.svg and etc/images/down.svg) are not very visible, due to the poor contrast between their fill color (#2e3436) and dark backgrounds[1]. Empirically, AFAICT, the "nuclear" solution of removing "fill:#2e3436" from the SVG files causes the icons to render with the foreground color of the default face. That solves the contrast problem, but maybe a more subtle solution could be devised? Once the "fill:=E2=80=A6" bit is removed, it becomes possible to change the= SVG image's color, either when calling create-image[2], or by applying faces[3]. A quick dive into widget-create-child-and-convert (down to widget-image-insert) suggests that there's no way to tell widget.el to slap a face onto an image; perhaps a new keyword could be added to that effect? Then we could add a face that (1) could preserve the original color (#2e3436) for light backgrounds (2) be set to something more reasonable for dark backgrounds (3) be themed. I wouldn't mind working on that (time permitting); I'd like to collect some feedback first to make sure what I suggest is the right approach; maybe there are better solutions I haven't considered. Thanks for your time. [1] https://webaim.org/resources/contrastchecker/?fcolor=3D2E3436&bcolor=3D= 000000 [2] E.g. after saving the attached rightnofill.svg, evaluate (insert-image (create-image "rightnofill.svg" nil nil :foreground "orange")) [3] E.g. after saving the attached rightnofill.svg, evaluate (insert-image (create-image "rightnofill.svg")) (add-text-properties (point-at-bol) (point-at-eol) '(font-lock-face suc= cess)) In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, c= airo version 1.16.0) of 2021-10-30 built on amdahl30 Repository revision: c30f95078c0735447c0bf293f2e6f573bc7057a3 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: openSUSE Tumbleweed Configured using: 'configure --with-cairo --with-gconf' Configured features: ACL CAIRO DBUS FREETYPE GCONF GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=3Dlocal locale-coding-system: utf-8-unix --=-=-= Content-Type: image/svg+xml; charset=utf-8 Content-Disposition: attachment; filename=rightnofill.svg Content-Transfer-Encoding: base64 PD94bWwgdmVyc2lvbj0nMS4wJyBlbmNvZGluZz0nVVRGLTgnIHN0YW5kYWxvbmU9J25vJz8+Cjxz dmcgeG1sbnM6Y2M9J2h0dHA6Ly9jcmVhdGl2ZWNvbW1vbnMub3JnL25zIycgeG1sbnM6ZGM9J2h0 dHA6Ly9wdXJsLm9yZy9kYy9lbGVtZW50cy8xLjEvJyBzb2RpcG9kaTpkb2NuYW1lPSdwYW4tZW5k LXN5bWJvbGljLnN2ZycgaW5rc2NhcGU6ZXhwb3J0LWZpbGVuYW1lPScvaG9tZS9zYW0vc291cmNl LXN5bWJvbGljLnBuZycgaW5rc2NhcGU6ZXhwb3J0LXhkcGk9JzI3MCcgaW5rc2NhcGU6ZXhwb3J0 LXlkcGk9JzI3MCcgaGVpZ2h0PScxNicgaWQ9J3N2ZzczODQnIHhtbG5zOmlua3NjYXBlPSdodHRw Oi8vd3d3Lmlua3NjYXBlLm9yZy9uYW1lc3BhY2VzL2lua3NjYXBlJyB4bWxuczpyZGY9J2h0dHA6 Ly93d3cudzMub3JnLzE5OTkvMDIvMjItcmRmLXN5bnRheC1ucyMnIHhtbG5zOnNvZGlwb2RpPSdo dHRwOi8vc29kaXBvZGkuc291cmNlZm9yZ2UubmV0L0RURC9zb2RpcG9kaS0wLmR0ZCcgc3R5bGU9 J2VuYWJsZS1iYWNrZ3JvdW5kOm5ldycgeG1sbnM6c3ZnPSdodHRwOi8vd3d3LnczLm9yZy8yMDAw L3N2ZycgdmVyc2lvbj0nMS4xJyBpbmtzY2FwZTp2ZXJzaW9uPScxLjAgKDQwMzVhNGZiNDksIDIw MjAtMDUtMDEpJyB3aWR0aD0nMTYnIHhtbG5zPSdodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2Zyc+ CiAgPHNvZGlwb2RpOm5hbWVkdmlldyBpbmtzY2FwZTpiYm94LW5vZGVzPSd0cnVlJyBpbmtzY2Fw ZTpiYm94LXBhdGhzPSdmYWxzZScgYm9yZGVyY29sb3I9JyMwMDAwMDAnIGJvcmRlcmxheWVyPSdm YWxzZScgYm9yZGVyb3BhY2l0eT0nMC41MDE5NjA3OCcgaW5rc2NhcGU6Y3VycmVudC1sYXllcj0n bGF5ZXIxMCcgaW5rc2NhcGU6Y3g9JzMxLjE0NzY2OCcgaW5rc2NhcGU6Y3k9JzcuOTYyNTEnIGlu a3NjYXBlOmRvY3VtZW50LXJvdGF0aW9uPScwJyBncmlkdG9sZXJhbmNlPScxMCcgaW5rc2NhcGU6 Z3VpZGUtYmJveD0ndHJ1ZScgZ3VpZGV0b2xlcmFuY2U9JzEwJyBpZD0nbmFtZWR2aWV3ODgnIGlu a3NjYXBlOm1lYXN1cmUtZW5kPScwLDAnIGlua3NjYXBlOm1lYXN1cmUtc3RhcnQ9JzAsMCcgaW5r c2NhcGU6b2JqZWN0LW5vZGVzPSd0cnVlJyBpbmtzY2FwZTpvYmplY3QtcGF0aHM9J3RydWUnIG9i amVjdHRvbGVyYW5jZT0nMTAnIHBhZ2Vjb2xvcj0nI2UyZTJlMicgaW5rc2NhcGU6cGFnZW9wYWNp dHk9JzAnIGlua3NjYXBlOnBhZ2VzaGFkb3c9JzInIHNob3dib3JkZXI9J2ZhbHNlJyBzaG93Z3Jp ZD0ndHJ1ZScgc2hvd2d1aWRlcz0nZmFsc2UnIGlua3NjYXBlOnNob3dwYWdlc2hhZG93PSdmYWxz ZScgaW5rc2NhcGU6c25hcC1iYm94PSd0cnVlJyBpbmtzY2FwZTpzbmFwLWJib3gtZWRnZS1taWRw b2ludHM9J2ZhbHNlJyBpbmtzY2FwZTpzbmFwLWJib3gtbWlkcG9pbnRzPSd0cnVlJyBpbmtzY2Fw ZTpzbmFwLWNlbnRlcj0nZmFsc2UnIGlua3NjYXBlOnNuYXAtZ2xvYmFsPSd0cnVlJyBpbmtzY2Fw ZTpzbmFwLWdyaWRzPSd0cnVlJyBpbmtzY2FwZTpzbmFwLWludGVyc2VjdGlvbi1wYXRocz0nZmFs c2UnIGlua3NjYXBlOnNuYXAtbWlkcG9pbnRzPSd0cnVlJyBpbmtzY2FwZTpzbmFwLW5vZGVzPSd0 cnVlJyBpbmtzY2FwZTpzbmFwLW9iamVjdC1taWRwb2ludHM9J3RydWUnIGlua3NjYXBlOnNuYXAt b3RoZXJzPSd0cnVlJyBpbmtzY2FwZTpzbmFwLXBhZ2U9J2ZhbHNlJyBpbmtzY2FwZTpzbmFwLXNt b290aC1ub2Rlcz0ndHJ1ZScgaW5rc2NhcGU6c25hcC10by1ndWlkZXM9J3RydWUnIGlua3NjYXBl OndpbmRvdy1oZWlnaHQ9JzEyMDUnIGlua3NjYXBlOndpbmRvdy1tYXhpbWl6ZWQ9JzAnIGlua3Nj YXBlOndpbmRvdy13aWR0aD0nMTU1MycgaW5rc2NhcGU6d2luZG93LXg9JzI2JyBpbmtzY2FwZTp3 aW5kb3cteT0nMjMnIGlua3NjYXBlOnpvb209JzEnPgogICAgPGlua3NjYXBlOmdyaWQgY29sb3I9 JyMwMDAwMDAnIGRvdHRlZD0nZmFsc2UnIGVtcGNvbG9yPScjMDgwMGZmJyBlbXBvcGFjaXR5PScw LjQ2Mjc0NTEnIGVtcHNwYWNpbmc9JzQnIGVuYWJsZWQ9J3RydWUnIGlkPSdncmlkNDg2Nicgb3Bh Y2l0eT0nMC4xNjQ3MDU4OCcgb3JpZ2lueD0nLTExMi4wMDU4NScgb3JpZ2lueT0nLTk1MS45OTk5 OScgc25hcHZpc2libGVncmlkbGluZXNvbmx5PSd0cnVlJyBzcGFjaW5neD0nMScgc3BhY2luZ3k9 JzEnIHR5cGU9J3h5Z3JpZCcgdmlzaWJsZT0ndHJ1ZScvPgogICAgPGlua3NjYXBlOmdyaWQgZG90 dGVkPSd0cnVlJyBlbXBjb2xvcj0nIzNmM2ZmZicgZW1wb3BhY2l0eT0nMCcgZW1wc3BhY2luZz0n NCcgaWQ9J2dyaWQzNTQwJyBvcmlnaW54PSctMTEyLjAwNTg1JyBvcmlnaW55PSctOTUxLjk5OTk5 JyBzcGFjaW5neD0nMC41JyBzcGFjaW5neT0nMC41JyB0eXBlPSd4eWdyaWQnLz4KICA8L3NvZGlw b2RpOm5hbWVkdmlldz4KICA8bWV0YWRhdGEgaWQ9J21ldGFkYXRhOTAnPgogICAgPHJkZjpSREY+ CiAgICAgIDxjYzpXb3JrIHJkZjphYm91dD0nJz4KICAgICAgICA8ZGM6Zm9ybWF0PmltYWdlL3N2 Zyt4bWw8L2RjOmZvcm1hdD4KICAgICAgICA8ZGM6dHlwZSByZGY6cmVzb3VyY2U9J2h0dHA6Ly9w dXJsLm9yZy9kYy9kY21pdHlwZS9TdGlsbEltYWdlJy8+CiAgICAgICAgPGRjOnRpdGxlPkdub21l IFN5bWJvbGljIEljb25zPC9kYzp0aXRsZT4KICAgICAgICA8Y2M6bGljZW5zZSByZGY6cmVzb3Vy Y2U9J2h0dHA6Ly9jcmVhdGl2ZWNvbW1vbnMub3JnL2xpY2Vuc2VzL2J5LXNhLzQuMC8nLz4KICAg ICAgPC9jYzpXb3JrPgogICAgICA8Y2M6TGljZW5zZSByZGY6YWJvdXQ9J2h0dHA6Ly9jcmVhdGl2 ZWNvbW1vbnMub3JnL2xpY2Vuc2VzL2J5LXNhLzQuMC8nPgogICAgICAgIDxjYzpwZXJtaXRzIHJk ZjpyZXNvdXJjZT0naHR0cDovL2NyZWF0aXZlY29tbW9ucy5vcmcvbnMjUmVwcm9kdWN0aW9uJy8+ CiAgICAgICAgPGNjOnBlcm1pdHMgcmRmOnJlc291cmNlPSdodHRwOi8vY3JlYXRpdmVjb21tb25z Lm9yZy9ucyNEaXN0cmlidXRpb24nLz4KICAgICAgICA8Y2M6cmVxdWlyZXMgcmRmOnJlc291cmNl PSdodHRwOi8vY3JlYXRpdmVjb21tb25zLm9yZy9ucyNOb3RpY2UnLz4KICAgICAgICA8Y2M6cmVx dWlyZXMgcmRmOnJlc291cmNlPSdodHRwOi8vY3JlYXRpdmVjb21tb25zLm9yZy9ucyNBdHRyaWJ1 dGlvbicvPgogICAgICAgIDxjYzpwZXJtaXRzIHJkZjpyZXNvdXJjZT0naHR0cDovL2NyZWF0aXZl Y29tbW9ucy5vcmcvbnMjRGVyaXZhdGl2ZVdvcmtzJy8+CiAgICAgICAgPGNjOnJlcXVpcmVzIHJk ZjpyZXNvdXJjZT0naHR0cDovL2NyZWF0aXZlY29tbW9ucy5vcmcvbnMjU2hhcmVBbGlrZScvPgog ICAgICA8L2NjOkxpY2Vuc2U+CiAgICA8L3JkZjpSREY+CiAgPC9tZXRhZGF0YT4KICA8dGl0bGUg aWQ9J3RpdGxlODQ3Myc+R25vbWUgU3ltYm9saWMgSWNvbnM8L3RpdGxlPgogIDxkZWZzIGlkPSdk ZWZzNzM4NicvPgogIDxnIGlua3NjYXBlOmdyb3VwbW9kZT0nbGF5ZXInIGlkPSdsYXllcjEwJyBp bmtzY2FwZTpsYWJlbD0ndWknIHRyYW5zZm9ybT0ndHJhbnNsYXRlKC0xMTIuMDA1ODUsLTk1MS45 OTk5OSknPgogICAgPHBhdGggaW5rc2NhcGU6Y29ubmVjdG9yLWN1cnZhdHVyZT0nMCcgZD0nbSAx MTcsOTY2IDYuMDA1ODUsLTYuMDAwMDEgTCAxMTcsOTU0IFonIGlkPSdwYXRoNjQxMicgc29kaXBv ZGk6bm9kZXR5cGVzPSdjY2NjJyBzdHlsZT0nZmlsbC1vcGFjaXR5OjE7c3Ryb2tlOm5vbmUnLz4K ICA8L2c+CiAgPGcgaW5rc2NhcGU6Z3JvdXBtb2RlPSdsYXllcicgaWQ9J2xheWVyMScgaW5rc2Nh cGU6bGFiZWw9J3N0YXR1cycgdHJhbnNmb3JtPSd0cmFuc2xhdGUoLTExMi4wMDU4NSwtODg3Ljk5 OTk5KScvPgogIDxnIGlua3NjYXBlOmdyb3VwbW9kZT0nbGF5ZXInIGlkPSdsYXllcjExJyBpbmtz Y2FwZTpsYWJlbD0nbGVnYWN5JyB0cmFuc2Zvcm09J3RyYW5zbGF0ZSgtMTEyLjAwNTg1LC05NTEu OTk5OTkpJy8+CiAgPGcgaW5rc2NhcGU6Z3JvdXBtb2RlPSdsYXllcicgaWQ9J2xheWVyNycgaW5r c2NhcGU6bGFiZWw9J3BsYWNlcycgdHJhbnNmb3JtPSd0cmFuc2xhdGUoLTExMi4wMDU4NSwtODg3 Ljk5OTk5KScvPgogIDxnIGlua3NjYXBlOmdyb3VwbW9kZT0nbGF5ZXInIGlkPSdsYXllcjYnIGlu a3NjYXBlOmxhYmVsPSdtaW1ldHlwZXMnIHRyYW5zZm9ybT0ndHJhbnNsYXRlKC0xMTIuMDA1ODUs LTg4Ny45OTk5OSknLz4KICA8ZyBpbmtzY2FwZTpncm91cG1vZGU9J2xheWVyJyBpZD0nbGF5ZXI1 JyBpbmtzY2FwZTpsYWJlbD0nZW1vdGVzJyB0cmFuc2Zvcm09J3RyYW5zbGF0ZSgtMTEyLjAwNTg1 LC04ODcuOTk5OTkpJy8+CiAgPGcgaW5rc2NhcGU6Z3JvdXBtb2RlPSdsYXllcicgaWQ9J2xheWVy OScgaW5rc2NhcGU6bGFiZWw9J2VtYmxlbXMnIHRyYW5zZm9ybT0ndHJhbnNsYXRlKC0xMTIuMDA1 ODUsLTg4Ny45OTk5OSknLz4KICA8ZyBpbmtzY2FwZTpncm91cG1vZGU9J2xheWVyJyBpZD0nbGF5 ZXIyJyBpbmtzY2FwZTpsYWJlbD0nZGV2aWNlcycgdHJhbnNmb3JtPSd0cmFuc2xhdGUoLTExMi4w MDU4NSwtODg3Ljk5OTk5KScvPgogIDxnIGlua3NjYXBlOmdyb3VwbW9kZT0nbGF5ZXInIGlkPSds YXllcjgnIGlua3NjYXBlOmxhYmVsPSdjYXRlZ29yaWVzJyB0cmFuc2Zvcm09J3RyYW5zbGF0ZSgt MTEyLjAwNTg1LC04ODcuOTk5OTkpJy8+CiAgPGcgaW5rc2NhcGU6Z3JvdXBtb2RlPSdsYXllcicg aWQ9J2xheWVyMycgaW5rc2NhcGU6bGFiZWw9J2FwcHMnIHRyYW5zZm9ybT0ndHJhbnNsYXRlKC0x MTIuMDA1ODUsLTg4Ny45OTk5OSknLz4KICA8ZyBpbmtzY2FwZTpncm91cG1vZGU9J2xheWVyJyBp ZD0nbGF5ZXI0JyBpbmtzY2FwZTpsYWJlbD0nYWN0aW9ucycgdHJhbnNmb3JtPSd0cmFuc2xhdGUo LTExMi4wMDU4NSwtODg3Ljk5OTk5KScvPgo8L3N2Zz4K --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 01 15:14:55 2021 Received: (at 51556) by debbugs.gnu.org; 1 Nov 2021 19:14:55 +0000 Received: from localhost ([127.0.0.1]:36171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhclj-0005o1-Et for submit@debbugs.gnu.org; Mon, 01 Nov 2021 15:14:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhclg-0005nm-Gb for 51556@debbugs.gnu.org; Mon, 01 Nov 2021 15:14:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40122) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhclb-0007Qa-9P; Mon, 01 Nov 2021 15:14:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lgEpfpxPDlpn4J9UDQaUy/eGQr3+tQQuh18gKPlSm6o=; b=B9tweU/U6Ad6XgrXkB+a plYQksoOmPizQXaPVHduAY2LgMO9BshVDIYReB3KmMdYo0xIdgXiNkYTNpse6n2BbbliTXJRLgUjD cLGuRXOb1KMhC1DS9Q90WPx5Jocrzz5sbGsTuQG1Gy3+nFCoYTdIFCtq+KlWdxnTWyK6LuBsuGxzH bHJu6cmjJpa/a5K1GrDS92G6F/Nl6fZgXFTlXJPToYfobrOwAQy1wecCo3XQkyhq811eI73YEYjCr GiNjd4/VsCZDOWiYxct42xmUPEtZ5rzxPxgVru/Gye3IRrvBFdSir/pmBHrgI4x57OGwJb13lOVby Is1/gtgOqBPdFQ==; Received: from [87.69.77.57] (port=4431 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhcla-0000YN-Q8; Mon, 01 Nov 2021 15:14:47 -0400 Date: Mon, 01 Nov 2021 21:14:39 +0200 Message-Id: <83fssflmcg.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec In-Reply-To: <87v91b92v6.fsf@gmail.com> (message from =?utf-8?Q?K=C3=A9vin?= Le Gouguec on Mon, 01 Nov 2021 18:56:13 +0100) Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds References: <87v91b92v6.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51556 Cc: 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Kévin Le Gouguec > Date: Mon, 01 Nov 2021 18:56:13 +0100 > > On darker themes (e.g. modus-vivendi), the Customize SVG icons > (etc/images/right.svg and etc/images/down.svg) are not very visible, due > to the poor contrast between their fill color (#2e3436) and dark > backgrounds[1]. That's for the themes to resolve, isn't it? They could supply their own icons, because only they know which colors will go well with the theme's colors. So I don't think we should try solving this in general. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 01 16:10:25 2021 Received: (at 51556) by debbugs.gnu.org; 1 Nov 2021 20:10:25 +0000 Received: from localhost ([127.0.0.1]:36219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhddR-0007IW-Gx for submit@debbugs.gnu.org; Mon, 01 Nov 2021 16:10:25 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:40646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhddM-0007ID-Tl for 51556@debbugs.gnu.org; Mon, 01 Nov 2021 16:10:24 -0400 Received: by mail-wr1-f43.google.com with SMTP id r8so16934256wra.7 for <51556@debbugs.gnu.org>; Mon, 01 Nov 2021 13:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=wSqSG+KFSZ/8zRkEdK/xhTprTuaaE7roaSPyceCxrhQ=; b=Nvgj4cChuWz9plZ8XskNkScVqRLDp8t+ggiU2OwDtCAAjXyNSLhExnw/UQZP0qitHN Zac+N5IYNE6DG9ASdrBSni4JvqNUBFiqISvhX76/pInh81FGidmXlgd/xpnk6e4b1Mib HE4zjSqos6d3wFIZOa7xvBz9nATi0Z8Rhe1U8QlUlAIKu1cPG+lU/fLChtlk7exSwa8W 2d1I9FzMYABa8dU7Cy5Qk7kR0+Qecvb8ur1sn6GhO6Q23IEu/EWleFKd9axx4kR2QSlR qIjwjFP8OL04ULxjq9Wpb+GG6PjfCaygDXR7swynAzp3XhD2QLZA4ZGGnezTZHzyE5lG 6Uhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=wSqSG+KFSZ/8zRkEdK/xhTprTuaaE7roaSPyceCxrhQ=; b=A32BrvCA1wbaX46q6Y8KMM6StjaQxXZETB05AQ71p5rDFKYzEmIOkKSbaT20cnwMX+ +Itg02EK1ufymx9OmDNhRT0+8R54ipbX27eMVgFrDdaEXe7vQ974Z65TnkDqwJNdhwWQ qZP4ENDEyUHORwX1gkLUBhdex/6jkhM/ApfLXtdXIWCdja9Xkaho6z1wZSRiIbXNiSdF bVVGhRDut5qbdKMKFr6BZetAoYZjDNRJAfI96hUutkrPmSRN1NhviJ8MWvvYMGs7GK1t YfQ3jFepuuvsf/VEanSEXpmprTRvUr925g1HNALocS3Uysaj2VObiax7qAhfphboXLx1 ZmAg== X-Gm-Message-State: AOAM533hOcJhIIOQeDZlc/IIq0NsKmGObdcdxGdzU6mH0U7SyjEzLQgJ 9CBH3/KJ2VkLDo8QUe9fGMkrwy6E9QU= X-Google-Smtp-Source: ABdhPJyv2MhH6Z+N/OtGfpPI4lc7PxMHJwZRDvsKeDCnslneuU5jR/qGyWBr1Q6z/krh06pZjikTjg== X-Received: by 2002:a05:600c:1c1a:: with SMTP id j26mr1348383wms.28.1635797414581; Mon, 01 Nov 2021 13:10:14 -0700 (PDT) Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id u10sm18715404wrs.5.2021.11.01.13.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 13:10:14 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Eli Zaretskii Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> Date: Mon, 01 Nov 2021 21:10:13 +0100 In-Reply-To: <83fssflmcg.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 01 Nov 2021 21:14:39 +0200") Message-ID: <87wnlreixm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51556 Cc: 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: K=C3=A9vin Le Gouguec >> Date: Mon, 01 Nov 2021 18:56:13 +0100 >>=20 >> On darker themes (e.g. modus-vivendi), the Customize SVG icons >> (etc/images/right.svg and etc/images/down.svg) are not very visible, due >> to the poor contrast between their fill color (#2e3436) and dark >> backgrounds[1]. > > That's for the themes to resolve, isn't it? They could supply their > own icons, because only they know which colors will go well with the > theme's colors. That's sort of what I suggest? In the rest of my message, I propose allowing widgets to apply faces to their icons (:on-glyph and :off-glyph), so that themes can customize these faces. This should work for all SVG images that do not define a fill color. Or is there a way for themes to define sets of icons? "(elisp) Custom Themes" describes custom-theme-set-variables and custom-theme-set-faces, but I couldn't find anything related to icons. Or are you suggesting adding the ability for themes to include sets of icons? That seems a bit heavy-handed to me; I don't think a lot of theme authors will want to bother with SVG editing. For the purposes of this bug, merely letting themes customize the icon color (through faces) ought to be enough? I'm not sure which path forward you prefer (if any). Sorry for being slow. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 01 16:49:50 2021 Received: (at 51556) by debbugs.gnu.org; 1 Nov 2021 20:49:50 +0000 Received: from localhost ([127.0.0.1]:36247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mheFZ-0008Nd-WF for submit@debbugs.gnu.org; Mon, 01 Nov 2021 16:49:50 -0400 Received: from mail-pf1-f181.google.com ([209.85.210.181]:41618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mheFX-0008NL-HI for 51556@debbugs.gnu.org; Mon, 01 Nov 2021 16:49:48 -0400 Received: by mail-pf1-f181.google.com with SMTP id u33so5472744pfg.8 for <51556@debbugs.gnu.org>; Mon, 01 Nov 2021 13:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=HBqJWN/INVFsqgBBmJPDKxlQRUfHDc2VFlDpJbj3waY=; b=enUPujny86Blaw+wx+fQtKAyUcpwRBjAo5uqSIfdp7kFowmlq8SvSTxo/+UFHxJVf0 Prs9lyJyN10uZ8/2DHFggUvHoXtuc1HX4zYlhnjh6zmTeCuLyZn0oVnqBkYh5fi8FZdU 3537/9N3tPyq1g1uFUJAbHZ2oMJDtLVUMLBzSWKDJ3ZA6Jg6ry/PLS1vpI48OUWI4NJb ZVWP7EEvhEjmh043fOvvmNJftLAwnP6oxYQfO8KKDpw+7WTCFQ5L37K5zDc2lOI0D6Qp 29hYKCp4jXx1nO3DmEw4l985QwGQtdWoPmDHSaGhUcg/IrNW0QdfxxdYqfxiWsVuXzxT 6n/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HBqJWN/INVFsqgBBmJPDKxlQRUfHDc2VFlDpJbj3waY=; b=EsgmNW+qiEX9BNsI/WUdIYhQ0Dns7AfrbyA2f1V+26zwzuQi/PAJsuBAbENbXqO6fa mLvqon61RK5z0unEXXq1g1BNN8I9uDR/yhWslmnaGXEAKopvVmsBgOi3WdZcpfdzunJ/ SSB4pWEP79D/AwEabG3EE2pYrmFBqUhOtsZIlY1KiNQaCwmcJ1B+DQZsZ5zaWMlhfBdd 28r6nojLE6qBrMaM1GP8H8ZcXWIFkZQl86/zfLYE1tPRLdK0pa/qzneoek0VD55FFEs9 /7La1yPBtL2iKc6gLa0Wuy4WRRk95g8qn1F261hvnoLqgmfggyme785TNb4yRTLhl2fh EQZw== X-Gm-Message-State: AOAM531+MYarGcc1p1GVKPLceiGlZbwhskZWXmNznqkrwTZnHRC7BD27 hsBrGH6BQI4W7Y7Dx5pmwI7H3h+I0k0= X-Google-Smtp-Source: ABdhPJyOPJU4psFc9cpuLoMcgZhsB+iZ/YDj7gjONZErx6NUyTGpZmKfjZU9DJuQz1S6bjASSilW/A== X-Received: by 2002:a63:1d7:: with SMTP id 206mr23952210pgb.387.1635799781609; Mon, 01 Nov 2021 13:49:41 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id m184sm13136298pga.40.2021.11.01.13.49.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Nov 2021 13:49:41 -0700 (PDT) Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds To: Eli Zaretskii , =?UTF-8?Q?K=c3=a9vin_Le_Gouguec?= References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> From: Jim Porter Message-ID: <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> Date: Mon, 1 Nov 2021 13:49:40 -0700 MIME-Version: 1.0 In-Reply-To: <83fssflmcg.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51556 Cc: 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 11/1/2021 12:14 PM, Eli Zaretskii wrote: >> From: Kévin Le Gouguec >> Date: Mon, 01 Nov 2021 18:56:13 +0100 >> >> On darker themes (e.g. modus-vivendi), the Customize SVG icons >> (etc/images/right.svg and etc/images/down.svg) are not very visible, due >> to the poor contrast between their fill color (#2e3436) and dark >> backgrounds[1]. > > That's for the themes to resolve, isn't it? They could supply their > own icons, because only they know which colors will go well with the > theme's colors. The method suggested in the original report (see below) would allow for themes to do this by customizing the appropriate face, wouldn't it? That seems like a simpler way for themes to apply the appropriate colors. As someone developing a dark Emacs theme, I think this would be a welcome improvement. On 11/1/2021 10:56 AM, Kévin Le Gouguec wrote: > A quick dive into widget-create-child-and-convert (down to > widget-image-insert) suggests that there's no way to tell widget.el to > slap a face onto an image; perhaps a new keyword could be added to that > effect? > > Then we could add a face that (1) could preserve the original color > (#2e3436) for light backgrounds (2) be set to something more reasonable > for dark backgrounds (3) be themed. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 08:40:30 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 12:40:30 +0000 Received: from localhost ([127.0.0.1]:36877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mht5a-0007vK-Gc for submit@debbugs.gnu.org; Tue, 02 Nov 2021 08:40:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mht5Z-0007v8-DH for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 08:40:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36820) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mht5U-0006tU-4h; Tue, 02 Nov 2021 08:40:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=t4fnY+nabhYwwvZHqCtEZ/Udv/J9KEy6V+ZuNUsqbx0=; b=M95aLTygmTdpeR6GUQVD RuyKNbMNfbTFdktJbQuMA6lRieOebxsP6y4EzFyxDT9xZ9KVFhlTKaDG5JmzrvNfZ8/KJrCUIKonN 5RBj4lrSTl8eNIKDNizppZmoqkT93Uhz38lmR5hmudaNm+KZj1AK69OINtiUmi4VOTJFeo7rC4psr YRF+vIchBfv3jJB3UXAT51zQJJuXDN9LEXMhpqRCEsbOMNyHjaO4jdJEa6qYue2g3wB9kl08mGUHQ uucXg5iyJ7e78mNsD0OoupUrsMBwPJLGUCskuErguhOKeb75JyRejkZDAFqxssv/Fb0/dIGlJYd2X 4EEw+kiSZXnvGg==; Received: from [87.69.77.57] (port=4528 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mht5T-0005nf-LZ; Tue, 02 Nov 2021 08:40:23 -0400 Date: Tue, 02 Nov 2021 14:40:18 +0200 Message-Id: <83czniloi5.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec In-Reply-To: <87wnlreixm.fsf@gmail.com> (message from =?utf-8?Q?K=C3=A9vin?= Le Gouguec on Mon, 01 Nov 2021 21:10:13 +0100) Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <87wnlreixm.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51556 Cc: 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Kévin Le Gouguec > Cc: 51556@debbugs.gnu.org > Date: Mon, 01 Nov 2021 21:10:13 +0100 > > Or is there a way for themes to define sets of icons? In some cases, yes. For example, on the tool bar and the tab bar. > "(elisp) Custom > Themes" describes custom-theme-set-variables and custom-theme-set-faces, > but I couldn't find anything related to icons. > > Or are you suggesting adding the ability for themes to include sets of > icons? If that's what it will take, yes. > That seems a bit heavy-handed to me; I don't think a lot of > theme authors will want to bother with SVG editing. The default will be to use the existing icons, as we did before. > For the purposes of this bug, merely letting themes customize the > icon color (through faces) ought to be enough? That will only affect the background, which might not be enough. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 08:50:08 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 12:50:08 +0000 Received: from localhost ([127.0.0.1]:36882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhtEu-0008Bj-Em for submit@debbugs.gnu.org; Tue, 02 Nov 2021 08:50:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhtEr-0008B7-U3 for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 08:50:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhtEm-0002n3-Ka; Tue, 02 Nov 2021 08:50:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=O2OAyBqr7Tvf46DVSErMy3pcwr0UbSRM2QmMAXT8cHI=; b=k6sVDepi6u0P DoWMlLq8+ZOnYJnUUJqBsVb7CyQmcEeLi1zxT9gxsjcNGcIvw/ZunsdGL6UZyGuMTUtNoqQSzzRG6 ZH8kKvukm2qkZYMLUChOYNaDfV8atiMgM/O/ZsDHO7l/JCX9lKrXPqLFLfUFDBbM+BZKecRRHGaOB EPyAgGzXxZ+86w/l6NxK5hoYQFAeghQk8Wi3tyZkKv8ObFpMeFjt7NTjMeEHOgWbYbyAcvcbaQjZl 0FU3eshM94kqRGTJ1QM4uUkM54rmLYw5S9SKhRagYuTdF/+Q65CjW+i9xw5lmIMfOjkXq4E/SOVam hsSpyZZbnV5Lbr6IoFXOwg==; Received: from [87.69.77.57] (port=1139 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhtEm-00011c-5P; Tue, 02 Nov 2021 08:50:00 -0400 Date: Tue, 02 Nov 2021 14:49:56 +0200 Message-Id: <83a6imlo23.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> (message from Jim Porter on Mon, 1 Nov 2021 13:49:40 -0700) Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51556 Cc: 51556@debbugs.gnu.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 51556@debbugs.gnu.org > From: Jim Porter > Date: Mon, 1 Nov 2021 13:49:40 -0700 > > >> On darker themes (e.g. modus-vivendi), the Customize SVG icons > >> (etc/images/right.svg and etc/images/down.svg) are not very visible, due > >> to the poor contrast between their fill color (#2e3436) and dark > >> backgrounds[1]. > > > > That's for the themes to resolve, isn't it? They could supply their > > own icons, because only they know which colors will go well with the > > theme's colors. > > The method suggested in the original report (see below) would allow for > themes to do this by customizing the appropriate face, wouldn't it? That > seems like a simpler way for themes to apply the appropriate colors. AFAIK, only the background color of the face will affect the display, and that is not enough. Since a theme determines the looks, it should also control the icons where that matters. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 10:42:05 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 14:42:05 +0000 Received: from localhost ([127.0.0.1]:37762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhuzF-0004x7-72 for submit@debbugs.gnu.org; Tue, 02 Nov 2021 10:42:05 -0400 Received: from mail-pg1-f179.google.com ([209.85.215.179]:35338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhuyz-0004wI-Gh for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 10:42:04 -0400 Received: by mail-pg1-f179.google.com with SMTP id p17so731123pgj.2 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 07:41:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=0aW8ZagTp7ZJ8jZc9VHTtr9c1XeeNVULbnwflyadRBo=; b=dFjl+Yz7RqFY9bGaPre4Pg39vtIGp7K4QR9yB27PtsY/25VEyAVF6k+QxPEXKYW1iO ZwU5Q+H5imWu3HjwjoOYq9q4JuFIdH1gc9Ma63iESNbu0njDhyiHZBvCpFQ6KQT+vsrA HbUnv7/BRgPrmaeUL1xDuBr1zkJKNR2xkp3l2N7UB/acVhMFLAV+ofWWsFZncSwtwQnB wQtoUc92zHrCTkJroqmJkwogBVIQ15ToSzdYn4FuhAq66XEr4pjs9oW5pDPXLIHRLbY7 Fue0xqupgUde+unzaCC9AXCNz8XS9Sy2Gr+ux0LOjlIUQvP6TqlFICXWM7ZAXRJYhJYb wGQg== X-Gm-Message-State: AOAM531PMVCgYPQBIsz3I+EGQCrHh/eEyLcU8+szVdgWipQ+j1+jj6hw aDJhLZQau9+Ka52z8bLd5j6O9w57xNTRtY2Cdw4= X-Google-Smtp-Source: ABdhPJyL3i91jAtNF/P1yulsua2A1sh/YMCcXG4Lf3r1eg2x7KyT5CACDpL4IFdz1sVdCHACCx54htwkQH7YTRlTrQQ= X-Received: by 2002:a63:86c1:: with SMTP id x184mr18850049pgd.114.1635864103802; Tue, 02 Nov 2021 07:41:43 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 07:41:43 -0700 From: Stefan Kangas In-Reply-To: <83a6imlo23.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 02 Nov 2021 14:49:56 +0200") References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 2 Nov 2021 07:41:43 -0700 Message-ID: Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51556 Cc: Jim Porter , kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > AFAIK, only the background color of the face will affect the display, > and that is not enough. Since a theme determines the looks, it should > also control the icons where that matters. As I have recently announced on emacs-devel, I am working on developing a library supporting icon sets. I think it is better to think of icons as orthogonal to the colors: this allows choosing any combination of icons and colors. For example, I might want to use the icons from some free set X, but I want to use it with all color themes. This will also allow color theme developers to simply say "this or that icon, whatever it is, should have this color", without having to provide a large amount of icons to get it right. Thinking about how to fix this in emacs-28, we discussed adding a face and just removing the foreground color from the svg. If we were add a face here, I think the more general customization that I hope we will introduce in Emacs 29.1 (read: if we accept my new library) would render that face ineffective. So it might not be worth it, I don't know. Perhaps something like that could wait for 29. The simplest solution for emacs-28 seems to simply remove the foreground color of that glyph, which IIUC (but I didn't test) should mean it will just use the foreground color of the current face in the customize buffer. Which should look okay in most cases, I think. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 11:00:06 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 15:00:07 +0000 Received: from localhost ([127.0.0.1]:37791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhvGg-0005VP-NZ for submit@debbugs.gnu.org; Tue, 02 Nov 2021 11:00:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhvGe-0005U5-99 for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 11:00:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42370) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhvGY-0003ao-Nk; Tue, 02 Nov 2021 10:59:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MykJndRXTtkbvodLlRDR9vAg3cuttDeRHHUsjDN4AQg=; b=qBv8Q0QlgXui WY7NE+4XCPAWqkCpjgEml+iVAXhIQAzP0rKLZ8G3Q5xLQR82CNtgrMmC0UyYBQn/lXMWnz08ic4dF FmUQYZci3N2nSkX621z5UFXIk6DPeVOJ4INKIj/nl48KIwCRHgOGCZfW17SxfG9PzoMl4XCNlXmlE znCAqysW0mN4Jh4WnPVJRtbwez8bUV1mR6PhBVlN+kMda9yI9ixRKMM+w59UZ/Y3tlFQNPN62CLWL CYrd0p3iSYN9VJLEUn5usd4J2ci0UBbiYJ1UWUPDXyIpykG5CTpevhMsEbBeO0WkSBc5ui0XI1aFt zKJWg/U+dR1IQTSCseAGPQ==; Received: from [87.69.77.57] (port=1245 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhvGY-0005M1-8A; Tue, 02 Nov 2021 10:59:58 -0400 Date: Tue, 02 Nov 2021 16:59:53 +0200 Message-Id: <83tuguk3h2.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Tue, 2 Nov 2021 07:41:43 -0700) Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 2 Nov 2021 07:41:43 -0700 > Cc: Jim Porter , 51556@debbugs.gnu.org, kevin.legouguec@gmail.com > > Thinking about how to fix this in emacs-28, we discussed adding a face > and just removing the foreground color from the svg. Foreground or background? AFAIR, we already are able to display SVG with non-default background. As for foreground: what does it mean to remove the foreground from an image? Aren't the foreground colors the most important part of an image? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 11:17:10 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 15:17:11 +0000 Received: from localhost ([127.0.0.1]:37808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhvXC-0005zs-NV for submit@debbugs.gnu.org; Tue, 02 Nov 2021 11:17:10 -0400 Received: from mail-pg1-f169.google.com ([209.85.215.169]:39686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhvXA-0005zb-M0 for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 11:17:09 -0400 Received: by mail-pg1-f169.google.com with SMTP id g184so20421378pgc.6 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 08:17:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=74uYrien40NJ3l+uNt5YDcUf91ejc6k+hHFCVoiB2Pw=; b=E8iVLI6jF4m7C3rFmljaQOfeJ4x/jaYwb3J3QcaKXuchqE9mYtnT4AGBX3uEeTS/e2 +mI4yzZ/lye//09SUdmML4tyBMNqaai9GDTOgHoGZNx+vLnaoHA2FUEvTd+G0qY/MPd0 SdPs6YZ8HxHAMXHypEE7dm1quXFFzcM2wfEZYCCq1DQp62G3jm3BiVHjuJT8B6v+ZiKc V+wZfjNcjBuBEHbUYhN9h/NCX5gPS7+2U0PqTwdZVF8GcbYXDh9GLGNjDXzVBbz1m4/A 9FVSjqASoqh7//11qgrTzCa+TMPMSyLb7atOQ7SVpfQWYZTNiem4PcngRgdLiOHzil1m 76cw== X-Gm-Message-State: AOAM530wBd/MmB/XJ6XaYVLhcCkrINE7Ww90O8H5lbQHboGVTc0/i45t bYkDsEZr2bJW+IQbrc5HMB/1xlv1sZ1uGK/hMKc= X-Google-Smtp-Source: ABdhPJw/bIseOXS+9GHtCpQqg8qCLrFmUikUsMqgZl3hfYyx43WKtXpwLDxuQtHBHGlJxGIDno3dkNLkDxculTX2m7Q= X-Received: by 2002:a05:6a00:1955:b0:47c:1d32:84de with SMTP id s21-20020a056a00195500b0047c1d3284demr36885276pfk.70.1635866222959; Tue, 02 Nov 2021 08:17:02 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 08:17:02 -0700 From: Stefan Kangas In-Reply-To: <83tuguk3h2.fsf@gnu.org> References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> MIME-Version: 1.0 Date: Tue, 2 Nov 2021 08:17:02 -0700 Message-ID: Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: >> Thinking about how to fix this in emacs-28, we discussed adding a face >> and just removing the foreground color from the svg. > > Foreground or background? Foreground. > AFAIR, we already are able to display SVG with non-default background. > As for foreground: what does it mean to remove the foreground from an > image? Aren't the foreground colors the most important part of an > image? It used to be the case that icons normally had 3D appearance and so on, in which case we obviously couldn't change the colors easily. Such icons were normally distributed in some bitmap format. These days, icons are treated more like glyphs, and the intention is that they will have colors suitable for the context they are used in. Such icons are normally distributed as SVG or indeed as TTF files. See here for some examples: https://google.github.io/material-design-icons/#coloring From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 11:26:20 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 15:26:21 +0000 Received: from localhost ([127.0.0.1]:37839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhvg4-0006H2-HJ for submit@debbugs.gnu.org; Tue, 02 Nov 2021 11:26:20 -0400 Received: from mail-pg1-f178.google.com ([209.85.215.178]:35444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhvg3-0006Gq-4P for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 11:26:19 -0400 Received: by mail-pg1-f178.google.com with SMTP id p17so841542pgj.2 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 08:26:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=llBWaXMuFuZ6SVfQ57KZlqJ6QUtaIGQpt3mnvBN6F8Q=; b=ay3RobKYhSwayi6bJ9f0hgeiBTKGSf0fTxLvWLHDZSElf45YQCygU7W9xu63GttpYk hOkNZLZxVdmSBIcIL/M95TQlgYyPvbKSPgHHY8EaGZ8kqFoYWWdVqM1lo1lOA2kVQe+P vG4W67vVq9+TQM4JcVTXR23TDfbINKed8hJSEL7axzBIcJK4t/jfoMcxNQnUS22LzTPB p0iVWX0/p1RP+IcXqLdNTxVULlv50qmjRbtX0hWIf46oLz5JU4L8oUEfqSu7p/EIqP63 rQnkQ20obr/k9xJ8mM/K7ZNc34PVMaMcXk+4n4pRsn/6n5Y/bkLpYE8TQxDTde9oRyPv OtAw== X-Gm-Message-State: AOAM533j3JUn+jO5V6E0GKSTNoSiHAhcQ4bn6yyFeCEsBILzLaibcl8R /zApjFDTbI6LtJsfgfA8fnOMqMC/Y7T5IL6Vf2Q= X-Google-Smtp-Source: ABdhPJzCEkhLQyDgivN/frmqMnUsmQI6cyYONQIinfY+OquVn8WXPXWEGh1TK6CpEhy00n5F18lTOaLYtifGUeHkg+A= X-Received: by 2002:a63:370c:: with SMTP id e12mr27997458pga.359.1635866773562; Tue, 02 Nov 2021 08:26:13 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 08:26:12 -0700 From: Stefan Kangas In-Reply-To: References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> MIME-Version: 1.0 Date: Tue, 2 Nov 2021 08:26:12 -0700 Message-ID: Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000f038d105cfcfe9f8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --000000000000f038d105cfcfe9f8 Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: >> As for foreground: what does it mean to remove the foreground from an >> image? (I realize that I didn't answer this part in my previous reply.) SVG is a special case, where we just use the foreground of the current face. In this case, I think the fix is as simple as the attached patch. I've tested this with several themes, and it looks very good to my eyes. I suggest that we install this fix on emacs-28. --000000000000f038d105cfcfe9f8 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Use-current-face-foreground-for-SVG-icons-in-customi.patch" Content-Disposition: attachment; filename="0001-Use-current-face-foreground-for-SVG-icons-in-customi.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: e39d20218651906_0.1 RnJvbSBiNjY4MmJiNGYzZDc5OTJmMDU5NGI4NDg2MDU5MzdmMzU4ZjkzYTMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogVHVlLCAyIE5vdiAyMDIxIDE2OjIxOjE5ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gVXNlIGN1 cnJlbnQgZmFjZSBmb3JlZ3JvdW5kIGZvciBTVkcgaWNvbnMgaW4gY3VzdG9taXplCgoqIGV0Yy9p bWFnZXMvZG93bi5zdmc6CiogZXRjL2ltYWdlcy9sZWZ0LnN2ZzoKKiBldGMvaW1hZ2VzL3JpZ2h0 LnN2ZzoKKiBldGMvaW1hZ2VzL3VwLnN2ZzogRG9uJ3QgZGVmaW5lIGZvcmVncm91bmQ7IHRoaXMg bWVhbnMgdGhleSB3aWxsIHVzZQp0aGUgZm9yZWdyb3VuZCBvZiB0aGUgY3VycmVudGx5IGRlZmlu ZWQgZmFjZSBpbnN0ZWFkLiAgKEJ1ZyM1MTU1NikKLS0tCiBldGMvaW1hZ2VzL2Rvd24uc3ZnICB8 IDIgKy0KIGV0Yy9pbWFnZXMvbGVmdC5zdmcgIHwgMiArLQogZXRjL2ltYWdlcy9yaWdodC5zdmcg fCAyICstCiBldGMvaW1hZ2VzL3VwLnN2ZyAgICB8IDIgKy0KIDQgZmlsZXMgY2hhbmdlZCwgNCBp bnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2V0Yy9pbWFnZXMvZG93 bi5zdmcgYi9ldGMvaW1hZ2VzL2Rvd24uc3ZnCmluZGV4IGUyNzYwNDI3ZDcuLjcwN2NkMjNlYTQg MTAwNjQ0Ci0tLSBhL2V0Yy9pbWFnZXMvZG93bi5zdmcKKysrIGIvZXRjL2ltYWdlcy9kb3duLnN2 ZwpAQCAtMjUsNyArMjUsNyBAQAogICA8dGl0bGUgaWQ9J3RpdGxlODQ3Myc+R25vbWUgU3ltYm9s aWMgSWNvbnM8L3RpdGxlPgogICA8ZGVmcyBpZD0nZGVmczczODYnLz4KICAgPGcgaW5rc2NhcGU6 Z3JvdXBtb2RlPSdsYXllcicgaWQ9J2xheWVyMTAnIGlua3NjYXBlOmxhYmVsPSd1aScgdHJhbnNm b3JtPSd0cmFuc2xhdGUoLTE1Mi4wMDU4NiwtOTUyKSc+Ci0gICAgPHBhdGggaW5rc2NhcGU6Y29u bmVjdG9yLWN1cnZhdHVyZT0nMCcgZD0nbSAxNjYsOTU3IC01Ljk5NDE0LDUuOTk5OTkgTCAxNTQs OTU3IFonIGlkPSdwYXRoNjQyNCcgc29kaXBvZGk6bm9kZXR5cGVzPSdjY2NjJyBzdHlsZT0nZmls bDojMmUzNDM2O2ZpbGwtb3BhY2l0eToxO3N0cm9rZTpub25lJy8+CisgICAgPHBhdGggaW5rc2Nh cGU6Y29ubmVjdG9yLWN1cnZhdHVyZT0nMCcgZD0nbSAxNjYsOTU3IC01Ljk5NDE0LDUuOTk5OTkg TCAxNTQsOTU3IFonIGlkPSdwYXRoNjQyNCcgc29kaXBvZGk6bm9kZXR5cGVzPSdjY2NjJyBzdHls ZT0nZmlsbC1vcGFjaXR5OjE7c3Ryb2tlOm5vbmUnLz4KICAgPC9nPgogICA8ZyBpbmtzY2FwZTpn cm91cG1vZGU9J2xheWVyJyBpZD0nbGF5ZXIxJyBpbmtzY2FwZTpsYWJlbD0nc3RhdHVzJyB0cmFu c2Zvcm09J3RyYW5zbGF0ZSgtMTUyLjAwNTg2LC04ODgpJy8+CiAgIDxnIGlua3NjYXBlOmdyb3Vw bW9kZT0nbGF5ZXInIGlkPSdsYXllcjExJyBpbmtzY2FwZTpsYWJlbD0nbGVnYWN5JyB0cmFuc2Zv cm09J3RyYW5zbGF0ZSgtMTUyLjAwNTg2LC05NTIpJy8+CmRpZmYgLS1naXQgYS9ldGMvaW1hZ2Vz L2xlZnQuc3ZnIGIvZXRjL2ltYWdlcy9sZWZ0LnN2ZwppbmRleCBkNjQyOWJjNDEwLi44OTM1MTVk MmRmIDEwMDY0NAotLS0gYS9ldGMvaW1hZ2VzL2xlZnQuc3ZnCisrKyBiL2V0Yy9pbWFnZXMvbGVm dC5zdmcKQEAgLTI1LDcgKzI1LDcgQEAKICAgPHRpdGxlIGlkPSd0aXRsZTg0NzMnPkdub21lIFN5 bWJvbGljIEljb25zPC90aXRsZT4KICAgPGRlZnMgaWQ9J2RlZnM3Mzg2Jy8+CiAgIDxnIGlua3Nj YXBlOmdyb3VwbW9kZT0nbGF5ZXInIGlkPSdsYXllcjEwJyBpbmtzY2FwZTpsYWJlbD0ndWknIHRy YW5zZm9ybT0ndHJhbnNsYXRlKC05Mi4wMDU4NDgsLTk1MS45OTk5OSknPgotICAgIDxwYXRoIGlu a3NjYXBlOmNvbm5lY3Rvci1jdXJ2YXR1cmU9JzAnIGQ9J00gMTAzLDk2NiA5Ny4wMDU4NSw5NTku OTk5OTkgMTAzLDk1NCBaJyBpZD0ncGF0aDY0MDAnIHNvZGlwb2RpOm5vZGV0eXBlcz0nY2NjYycg c3R5bGU9J2ZpbGw6IzJlMzQzNjtmaWxsLW9wYWNpdHk6MTtzdHJva2U6bm9uZScvPgorICAgIDxw YXRoIGlua3NjYXBlOmNvbm5lY3Rvci1jdXJ2YXR1cmU9JzAnIGQ9J00gMTAzLDk2NiA5Ny4wMDU4 NSw5NTkuOTk5OTkgMTAzLDk1NCBaJyBpZD0ncGF0aDY0MDAnIHNvZGlwb2RpOm5vZGV0eXBlcz0n Y2NjYycgc3R5bGU9J2ZpbGwtb3BhY2l0eToxO3N0cm9rZTpub25lJy8+CiAgIDwvZz4KICAgPGcg aW5rc2NhcGU6Z3JvdXBtb2RlPSdsYXllcicgaWQ9J2xheWVyMScgaW5rc2NhcGU6bGFiZWw9J3N0 YXR1cycgdHJhbnNmb3JtPSd0cmFuc2xhdGUoLTkyLjAwNTg0OCwtODg3Ljk5OTk5KScvPgogICA8 ZyBpbmtzY2FwZTpncm91cG1vZGU9J2xheWVyJyBpZD0nbGF5ZXIxMScgaW5rc2NhcGU6bGFiZWw9 J2xlZ2FjeScgdHJhbnNmb3JtPSd0cmFuc2xhdGUoLTkyLjAwNTg0OCwtOTUxLjk5OTk5KScvPgpk aWZmIC0tZ2l0IGEvZXRjL2ltYWdlcy9yaWdodC5zdmcgYi9ldGMvaW1hZ2VzL3JpZ2h0LnN2Zwpp bmRleCBkNThjZDM2NDM1Li42YzdkNzE1OTM5IDEwMDY0NAotLS0gYS9ldGMvaW1hZ2VzL3JpZ2h0 LnN2ZworKysgYi9ldGMvaW1hZ2VzL3JpZ2h0LnN2ZwpAQCAtMjUsNyArMjUsNyBAQAogICA8dGl0 bGUgaWQ9J3RpdGxlODQ3Myc+R25vbWUgU3ltYm9saWMgSWNvbnM8L3RpdGxlPgogICA8ZGVmcyBp ZD0nZGVmczczODYnLz4KICAgPGcgaW5rc2NhcGU6Z3JvdXBtb2RlPSdsYXllcicgaWQ9J2xheWVy MTAnIGlua3NjYXBlOmxhYmVsPSd1aScgdHJhbnNmb3JtPSd0cmFuc2xhdGUoLTExMi4wMDU4NSwt OTUxLjk5OTk5KSc+Ci0gICAgPHBhdGggaW5rc2NhcGU6Y29ubmVjdG9yLWN1cnZhdHVyZT0nMCcg ZD0nbSAxMTcsOTY2IDYuMDA1ODUsLTYuMDAwMDEgTCAxMTcsOTU0IFonIGlkPSdwYXRoNjQxMicg c29kaXBvZGk6bm9kZXR5cGVzPSdjY2NjJyBzdHlsZT0nZmlsbDojMmUzNDM2O2ZpbGwtb3BhY2l0 eToxO3N0cm9rZTpub25lJy8+CisgICAgPHBhdGggaW5rc2NhcGU6Y29ubmVjdG9yLWN1cnZhdHVy ZT0nMCcgZD0nbSAxMTcsOTY2IDYuMDA1ODUsLTYuMDAwMDEgTCAxMTcsOTU0IFonIGlkPSdwYXRo NjQxMicgc29kaXBvZGk6bm9kZXR5cGVzPSdjY2NjJyBzdHlsZT0nZmlsbC1vcGFjaXR5OjE7c3Ry b2tlOm5vbmUnLz4KICAgPC9nPgogICA8ZyBpbmtzY2FwZTpncm91cG1vZGU9J2xheWVyJyBpZD0n bGF5ZXIxJyBpbmtzY2FwZTpsYWJlbD0nc3RhdHVzJyB0cmFuc2Zvcm09J3RyYW5zbGF0ZSgtMTEy LjAwNTg1LC04ODcuOTk5OTkpJy8+CiAgIDxnIGlua3NjYXBlOmdyb3VwbW9kZT0nbGF5ZXInIGlk PSdsYXllcjExJyBpbmtzY2FwZTpsYWJlbD0nbGVnYWN5JyB0cmFuc2Zvcm09J3RyYW5zbGF0ZSgt MTEyLjAwNTg1LC05NTEuOTk5OTkpJy8+CmRpZmYgLS1naXQgYS9ldGMvaW1hZ2VzL3VwLnN2ZyBi L2V0Yy9pbWFnZXMvdXAuc3ZnCmluZGV4IDllMWEyNDViZTcuLmUzNThjMjk5MTIgMTAwNjQ0Ci0t LSBhL2V0Yy9pbWFnZXMvdXAuc3ZnCisrKyBiL2V0Yy9pbWFnZXMvdXAuc3ZnCkBAIC0yNSw3ICsy NSw3IEBACiAgIDx0aXRsZSBpZD0ndGl0bGU4NDczJz5Hbm9tZSBTeW1ib2xpYyBJY29uczwvdGl0 bGU+CiAgIDxkZWZzIGlkPSdkZWZzNzM4NicvPgogICA8ZyBpbmtzY2FwZTpncm91cG1vZGU9J2xh eWVyJyBpZD0nbGF5ZXIxMCcgaW5rc2NhcGU6bGFiZWw9J3VpJyB0cmFuc2Zvcm09J3RyYW5zbGF0 ZSgtMTMyLjAwNTg1LC05NTIpJz4KLSAgICA8cGF0aCBpbmtzY2FwZTpjb25uZWN0b3ItY3VydmF0 dXJlPScwJyBkPSdNIDE0Niw5NjMgMTQwLjAwNTg1LDk1Ni45OTk5OSAxMzQsOTYzIFonIGlkPSdw YXRoNjQxOCcgc29kaXBvZGk6bm9kZXR5cGVzPSdjY2NjJyBzdHlsZT0nZmlsbDojMmUzNDM2O2Zp bGwtb3BhY2l0eToxO3N0cm9rZTpub25lJy8+CisgICAgPHBhdGggaW5rc2NhcGU6Y29ubmVjdG9y LWN1cnZhdHVyZT0nMCcgZD0nTSAxNDYsOTYzIDE0MC4wMDU4NSw5NTYuOTk5OTkgMTM0LDk2MyBa JyBpZD0ncGF0aDY0MTgnIHNvZGlwb2RpOm5vZGV0eXBlcz0nY2NjYycgc3R5bGU9J2ZpbGwtb3Bh Y2l0eToxO3N0cm9rZTpub25lJy8+CiAgIDwvZz4KICAgPGcgaW5rc2NhcGU6Z3JvdXBtb2RlPSds YXllcicgaWQ9J2xheWVyMScgaW5rc2NhcGU6bGFiZWw9J3N0YXR1cycgdHJhbnNmb3JtPSd0cmFu c2xhdGUoLTEzMi4wMDU4NSwtODg4KScvPgogICA8ZyBpbmtzY2FwZTpncm91cG1vZGU9J2xheWVy JyBpZD0nbGF5ZXIxMScgaW5rc2NhcGU6bGFiZWw9J2xlZ2FjeScgdHJhbnNmb3JtPSd0cmFuc2xh dGUoLTEzMi4wMDU4NSwtOTUyKScvPgotLSAKMi4zMC4yCgo= --000000000000f038d105cfcfe9f8-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 12:38:48 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 16:38:48 +0000 Received: from localhost ([127.0.0.1]:37915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhwoC-0004IM-0L for submit@debbugs.gnu.org; Tue, 02 Nov 2021 12:38:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhwo9-0004HC-QZ for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 12:38:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhwo4-0001Au-9D; Tue, 02 Nov 2021 12:38:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=V683o4ttdcFxwHgNqQorDNlpubElc607RQfXy3J91kM=; b=nSLVAou51NUr E2jZ3nkB83iDa85Bt8NXNhgtzigORNNZGF1+Fhvp8+6DBvoecUf0QCDKujCjTr08qF8a/21hQKbAC zxkXalRArcotcHNVliORWSlkzC9839SX/88VxX5bIYaSEQZ7SIdWiDqFulpGkOGRLhaUd37VFJoe4 Lx3tkutwet/ZN3WyEQjJ96+Dk2PNqJdTdT0zNmy6hJ1rvvmdE8ug93pUKHZO4GdnVEeHCVgJ+Pnwb MdyAfgXOf69gZapBG17wH5sN1pKtBl3Si0MeJNjIJF61ur2WZjRaPXSCt6SsCVq6EGuYiu2yxpKKG E88QF4krhKBmbPMFEhf+HA==; Received: from [87.69.77.57] (port=3280 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhwo3-0007Eu-Nv; Tue, 02 Nov 2021 12:38:40 -0400 Date: Tue, 02 Nov 2021 18:38:33 +0200 Message-Id: <83k0hqjywm.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Tue, 2 Nov 2021 08:26:12 -0700) Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 2 Nov 2021 08:26:12 -0700 > Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com > > >> As for foreground: what does it mean to remove the foreground from an > >> image? > > (I realize that I didn't answer this part in my previous reply.) SVG is > a special case, where we just use the foreground of the current face. I don't think I understand what that means. We disregard the colors specified by the SVG image? > I suggest that we install this fix on emacs-28. Sorry, at this stage I'd prefer not to install anything on the release branch that isn't a bugfix. Or else take it up with Lars, and ask him to forget about releasing Emacs 28.1 soon, because this way it will take a while ;-) From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 12:43:35 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 16:43:35 +0000 Received: from localhost ([127.0.0.1]:37919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhwsp-0004QB-J2 for submit@debbugs.gnu.org; Tue, 02 Nov 2021 12:43:35 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhwsh-0004Pn-92 for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 12:43:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xKXuDb1op6qJEj9qRdfPd8Q6XWTDj0J4oHtpZXDUi50=; b=rVMZq9FFk+eKx5PbNJwT/Tja66 UcHYhl4Q0VQRH0Or2t8IKo5d/8Oo6NgMVc8tTKA11CQaqmFslWmlQzh+gqpNHiA5K4Psa5Sk+aL6j TAi+7GKGWK9qnW3ITBgyYnrfPHRKoxwBLBAka1j9FPacLWes0dPshjS462W8YSmeUh8M=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhwsX-0008Th-AZ; Tue, 02 Nov 2021 17:43:20 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> X-Now-Playing: Ai Aso's _The Faintest Hint_: "Floating rhythms" Date: Tue, 02 Nov 2021 17:43:16 +0100 In-Reply-To: <83k0hqjywm.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 02 Nov 2021 18:38:33 +0200") Message-ID: <877ddqld97.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > Sorry, at this stage I'd prefer not to install anything on the release > branch that isn't a bugfix. I agree. The chevrons in the Customize buffers aren't optimal on a dark background, but it's not worth changing at this point in emacs-28. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, Stefan Kangas , 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > Sorry, at this stage I'd prefer not to install anything on the release > branch that isn't a bugfix. I agree. The chevrons in the Customize buffers aren't optimal on a dark background, but it's not worth changing at this point in emacs-28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 13:02:04 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 17:02:04 +0000 Received: from localhost ([127.0.0.1]:37928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhxAi-0004zg-Kx for submit@debbugs.gnu.org; Tue, 02 Nov 2021 13:02:04 -0400 Received: from mail-pg1-f173.google.com ([209.85.215.173]:34574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhxAh-0004z9-Bl for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 13:02:03 -0400 Received: by mail-pg1-f173.google.com with SMTP id j9so15900pgh.1 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 10:02:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=TNehbi/MsZauC7izyXbK7opf/x3CSs68GyKXM4JMUhM=; b=GyGB0Qhxd2w4zh38T/AINqcwzECIxqFty/m9ldW6pqj/+LoEdvKkwEz7LtkzXGx97K pmLQlLoSHykm+0TgHI1cTiDDoBe26SrmBGlnoAT3nj/tqnjh2L+nHGBU8occDmHWQKvM XP4Gryt0rxsFAhI2c/R4lOAlSVIBDstxUM8mCSOySpEB6KnPgL1XCK/b5x9xpqhu6DPG 6ej63t57/uCkfn9nM5p9YoBRnB84lrwbAvuFHswwYkli7KqWXezSpoOf8YPWy8L7f+Eg moZ5yHj5fTL0S32/8zUphcEfedc64T2sBNRVNf3zS4iPQ8iR0t9WScW1Z4VekJiseuSu Ll5w== X-Gm-Message-State: AOAM5303BqI9A/3ftv4LYfugvuCf/2pG17AJEZejj6B3M7Db7F61EI1J zA5jc/5hEfyFhrruKGhNKpyRK8z2WwJtmQUO0BQ= X-Google-Smtp-Source: ABdhPJy2RA22yiy56MOXKsCnOukVCkFGe3zwR3n7ftjjfsqjUTOU52YmB1PTu1TtEZhA/HFLMXD+Yi/I2IOr9lYjwhY= X-Received: by 2002:a63:330f:: with SMTP id z15mr28906866pgz.42.1635872517142; Tue, 02 Nov 2021 10:01:57 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 10:01:56 -0700 From: Stefan Kangas In-Reply-To: <83k0hqjywm.fsf@gnu.org> References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> MIME-Version: 1.0 Date: Tue, 2 Nov 2021 10:01:56 -0700 Message-ID: Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > I don't think I understand what that means. We disregard the colors > specified by the SVG image? No, we do respect colors specified by the SVG image. That's why we see the current behavior. However, if no foreground color is specified in the SVG file, we use the foreground color of the current face instead. That's why the fix I propose work. > Sorry, at this stage I'd prefer not to install anything on the release > branch that isn't a bugfix. Or else take it up with Lars, and ask him > to forget about releasing Emacs 28.1 soon, because this way it will > take a while ;-) I consider this a bug fix, but admittedly only a minor one. However, I also note that the visibility of those symbols is worse with a dark theme in Emacs 28 than in Emacs 27, so we might consider it a regression. That said, I of course understand that some kind of line have to be drawn, and I'm personally fine with installing this only on master. If people feel that it is important, perhaps we could consider backporting the fix to Emacs 28.2 later (read: please speak up if you think so). From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 13:13:21 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 17:13:21 +0000 Received: from localhost ([127.0.0.1]:37944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhxLd-0005Kh-5k for submit@debbugs.gnu.org; Tue, 02 Nov 2021 13:13:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhxLZ-0005KJ-HB for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 13:13:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48532) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhxLT-0002Wn-Ot; Tue, 02 Nov 2021 13:13:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=G/nEJPzQUzM52HIMtTVuCeqSlCItpvaHsrv4xy4eow8=; b=DLAEDuLcIpUR 0CTgHtnxbZ3vImR5ANyRyn0Xs8eZC7zXvIXlRUYmHe4LmCcaI8xnNYRAwBfYAjX/C8jzo/toU4Miy 9vYz1oonFfrFD702hCIwBETJ0l6QxVVUXqfZAzG6sPHYcqK/vGGweTVBCMWruuQaSFzLDGq5/40nT w3WSz8LJhILeMCPH2lETXIG/DRHCbHL3jYGJxUiDZL9ovSfxta1m8M3saaZCUHbolPHkgCXPZRUKI XBvRfPm256PGDrrTW2RtpIsp9W+UZUa+SAfvUPJLjUUR9s9W5pZZrvxhJiv/DH2IL6rbD03UEZPfR tcQ0Dh36wR0J41u2qqiiRw==; Received: from [87.69.77.57] (port=1420 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhxLS-0004si-Ms; Tue, 02 Nov 2021 13:13:11 -0400 Date: Tue, 02 Nov 2021 19:13:06 +0200 Message-Id: <83ee7yjxb1.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Tue, 2 Nov 2021 10:01:56 -0700) Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 2 Nov 2021 10:01:56 -0700 > Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com > > Eli Zaretskii writes: > > > I don't think I understand what that means. We disregard the colors > > specified by the SVG image? > > No, we do respect colors specified by the SVG image. That's why we see > the current behavior. > > However, if no foreground color is specified in the SVG file, we use the > foreground color of the current face instead. That's why the fix I > propose work. What is the difference between "colors specified by the SVG image" (which you say we respect), and "foreground color is specified in the SVG file" (which you want us to disregard)? > > Sorry, at this stage I'd prefer not to install anything on the release > > branch that isn't a bugfix. Or else take it up with Lars, and ask him > > to forget about releasing Emacs 28.1 soon, because this way it will > > take a while ;-) > > I consider this a bug fix, but admittedly only a minor one. However, I > also note that the visibility of those symbols is worse with a dark > theme in Emacs 28 than in Emacs 27, so we might consider it a > regression. Let's not exaggerate, okay? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 13:44:33 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 17:44:33 +0000 Received: from localhost ([127.0.0.1]:37974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhxpo-0008NZ-PC for submit@debbugs.gnu.org; Tue, 02 Nov 2021 13:44:32 -0400 Received: from mail-pl1-f174.google.com ([209.85.214.174]:35456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhxpm-0008NL-2O for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 13:44:30 -0400 Received: by mail-pl1-f174.google.com with SMTP id b13so6043250plg.2 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 10:44:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=PNAKh4L8C9Wz1920QdFxCud7tZX7GFcLJhJD8vB7A6I=; b=6kASLqsmnzXt/4CWTeg/ur8/dFI/jboEgXAep+saWceD23WJBXgC73yXZDtjlIvdhr VWmEzywTtv4YcdNAsnrK5xr6OB9BCWcZDp1DVqygSpMiUussNVwliwR9ws9EC2l89Rll P5CSJvHNA8tZhyg4qw/5QGU+3RZCjjE4VJl3N+1FsdBRaAuLnZU/ZoVGA4rcnSG1k6O3 ECMKeMkLfPZLC+VM8tEy6gVlnyVEhVLNAW64+8Ja5peWylVt6eYnbcXYviQjeMoeyRcZ t6KTsuOtKLE3lV+Z2TCo0o5zaKjpZV2zEjRQOJbVVqP3K45JvylMgNZe2qothQJ19R+R e8tQ== X-Gm-Message-State: AOAM533Qi2b+MGGDfkXk+w3UiT9/YgpaNizcjnCr/eZ6U+tyODSMhIz2 6CCCpsnxdezhl2JMdKfQw8KeywxzWuZG0cf9HKM= X-Google-Smtp-Source: ABdhPJyLbwRXaJVDHhUU7cHR/SGprm2jG0IcgII4bR+rFgeLHpOC3WA9HxPtBa4eFSyD2N2ZE7MZj70p2G/dU9bmhEg= X-Received: by 2002:a17:902:a410:b0:141:be1a:53d1 with SMTP id p16-20020a170902a41000b00141be1a53d1mr22824243plq.71.1635875064311; Tue, 02 Nov 2021 10:44:24 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 10:44:23 -0700 From: Stefan Kangas In-Reply-To: <83ee7yjxb1.fsf@gnu.org> References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> MIME-Version: 1.0 Date: Tue, 2 Nov 2021 10:44:23 -0700 Message-ID: Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds To: Eli Zaretskii Content-Type: multipart/mixed; boundary="0000000000001b091905cfd1d8f4" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --0000000000001b091905cfd1d8f4 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> No, we do respect colors specified by the SVG image. That's why we see >> the current behavior. >> >> However, if no foreground color is specified in the SVG file, we use the >> foreground color of the current face instead. That's why the fix I >> propose work. > > What is the difference between "colors specified by the SVG image" > (which you say we respect), and "foreground color is specified in the > SVG file" (which you want us to disregard)? You missed quoting "no" in "no foreground color is specified in the SVG file". So the difference is that in one case the SVG files specifies the foreground color, in the other case it does not. Also, note that I'm not proposing any change. I'm only describing the current behavior. >> I consider this a bug fix, but admittedly only a minor one. However, I >> also note that the visibility of those symbols is worse with a dark >> theme in Emacs 28 than in Emacs 27, so we might consider it a >> regression. > > Let's not exaggerate, okay? I fail to see any exaggeration. I've attached two screenshots of the customize buffer using the "tsdh-dark" theme, one in Emacs 27 and the other one in Emacs 28. --0000000000001b091905cfd1d8f4 Content-Type: image/png; name="emacs27.png" Content-Disposition: attachment; filename="emacs27.png" Content-Transfer-Encoding: base64 X-Attachment-Id: 2fcdaf362d05b1db_0.1 iVBORw0KGgoAAAANSUhEUgAAAm4AAAAxCAIAAADsjbJPAAAAA3NCSVQICAjb4U/gAAAAGXRFWHRT b2Z0d2FyZQBnbm9tZS1zY3JlZW5zaG907wO/PgAAFqxJREFUeJzt3XlYE9faAPCTQDAhgUQgIDsU IYAgKFUgamwroOIGFKmIUhV3sG5UvVV7235e4VHwWlmseq0r2s+lV9xQVFQUxAVEQVYpyCJKBNlC ZAvfH6NjHoTJwBDQr+/vrzBv5pz3zJzJYc7MJDQDAwOEkL6+PgIAAABAz9EHOgEAAADg0wZDKQAA AEAJDKUAAAAAJTCUAgAAAJTAUAoAAABQokq9CN81m6ycnDstfJB4PvHQHuqFK+T/j/8xt3NECJ3d vSP79vVOURqNPjko2MrJmcXRoNHp1//30J2zp/ohq+6E/n5SbRATIdQhk71pkrwofppy5kRpXnaf VxS0dZeeqXk/tHf1nmMsjsb5Pb8+Tr6KEPL/xxZzO4f7l85eObKPYsnTl6+1G/NFzp3kM9Hb+yJT AABQlk/7rFRFVdXYyhZ7bTZs+IdvsHYe4/ilh7oml0bvoqUrog7+EHfO8UsP5WbZFRqdzuJomNuP 8Pv+x8F68CQSAAB8wt6elaanpyOEnJycel1QVvK1c3t29k1SpBla2qiqqYnLS/lGJmbDHD98g7a+ IUKourJi3/pgWXt7P6fXnTPR2/LuphpaCvz/sUWNybIcOfpeQvxAJwUAAKCX3k/wrl27NjIyElEb UDtZGXtkkDp7+wLfDpkMX2jrKvIK+f7uxf/ajfmSIHot7neF5ZvbOSCE8u+nDmKpa2rraA0xqHnx HAth04PYa219ww2HzyCEsAlPHl9v+c7/4IV4LlzhuXAFQujif6IyrydiC60+dxFOn6lrbCaTtb8o Kbr93z9Ksh/hq8xa//Nnw0fev3yuqb5upJunxmAthNDWgGnkt4xM1l6Wn/P6ZSXfyITD08KXE9Tr FfK9raso61aSpL52xFeTpI0NSccO5N1LwaJqTNbEeUsFo1ybm5quxu3/sEZlt6g7liNHj/WepWts 1trS/NfjjKTjB+qrX5GM4ni6Q779aTuby8tNu3UmOqKjQ/bhewAAYKC8n/aMiIjo6OhYu3Zteno6 dpJKXVXZM1UGg8fXk1+obWCEEKoqfUYcJVO+6TAHhFB5YV55QQ5CyGyYQ5+kbT/uK9/VGw0srFTV 1NSYLBNrO//1v5jbj+j0NluXceNnzsFGnZ6i01WMBbbY1O6Lkqfk67VwcHKZ4jOIpc7j601duorF 5mDLJ81fZj/uKzUmS0NLe8byNVwdfj+3qEs2LuN812zS/8xShcFgsjm2rqLAf25ncTTIRHHqmlz/ 9T+zuby8e6nxMZEwjgIAPjadbzuKiIiIiIgIDQ3t6RmqvWiCvWgC/mfUinkNNdXishJzOwctfUMW R2PeL5HVlRV7QpfqGBghhMRlJcRRhTWqMVkGFpYdHR3Pn+Zr6xvauorM7BwyriVg0bOxkWdjI7/w myuc4ff8af7Bf4biK9aKX2LnWyuiDmpoacufjCKE6HSVr/znI4Suxu1/eDVBlcH4avYChy/cx3rP Ks56KJ8Ai8O5fPC3vLspkvpaklsJ4xWyDoUghFB7W9vDpEu5d1PI16vCYOxdH8xkqQf+tF1tEHPI Z5bFWQ+ZbLatUIQQepx89drR/Y4TJn35zbf92aKpS1ZOXbKy00IajTZh9nwajfbX44yzu3do6en7 ff+TpraOs6fXjRNHiKN4IQwm85vv/zl4iEHBg7Qz0dtkso9llh4AAHBd38ErP6BSme+tKitBCGkb GLU1NyOEtPT0GYOY2gZGHTKZuKKUOKqwcFMbezpdpbqy4o2ksbwgFyFkajucRqfLTxf3At/YhM3l IYQm+M+f4D8f0Wg0Gg0hpGdq3umd+Q/S0q9coFLXq4qy638cwhImWe+zJ49flZcihKSSRhabg62i Y2hCp6sghG79+YdU0ph27k/Xqb5MNrv/WyRvsJ6+pjYfIXTz5NGm+rqm+rrslOufe0w1HTZcYRRn OWI0Qqi9re3Cvl0fz9VuAACQ1/VQ2ouz0i5vOxKXPUNv7/2hVZUW65qYDzG30BpiWPPieXtrK3FU YY3YZ662vuEPceewJSyOhq6x2ctnf5HMuUssDU3sRaebfhlqgzq9s7H2de+qOBO9rars2dzN4Xqm 5sIZM5OOHSBfb3OTBHsha2tDCGEjqBqT9Tal19UIoY4OmaTuNT6U9kOLOj0M87bed1O19a/E2Is6 cRVCSJ2jqTAqr721VYXBGOs9i/oDNgAAoAydh9JeDKIExOXPOmQybX0jBpNZkH6XydYQOLmoqqlh 56PEUYXM7Lq4Mmpu50hxKH3T2Ii92L1m8euXlURv7ejodS2vyktT4k+4BQSNnDA5Nf7EG4mkB/V+ QFL3dj6WM1i7TvySRqOzuYPxaP+06EPSxgbshaYOH5sx1tTh48uJo7jKvwov/R4775fIzz2mZt1K elFS1IcZAgBAn3h/mhIaGkqj0bAZ3b66ibetpeV11QsdIxO+kenzooKKp3k2LuMQQlWlJQqjxNhc Ht/IFCH029olWwOmbQ2Ylhp/Er07VSWptaUZIaRn+hldRQVfWFVWgn2aewQu1hpioMJgaOkbjpo4 bdzXs3vQchIyky43S5vUmCwntykU631d9QI7jx/rPYvJZjtP8cJPSfuzRZ2zelmJ3Y4r8g1Q19A0 GCqwG/slQqj4ySOFUflCKoufZt5IpNHpk4OCu3w+GAAABtb7s1KKl0U73XaEf9uRuKxEMEqIEHpe VKCtb2TjPBbJ3VVEHCVgamtPo9EkdbX40y9l+U8QmmlsPUxFVbW9rY1Mzi+Ki7SGGDi5T3Fyn4Le PQwja2+/8b+HJwcFWzh+buH4Of7mRzeukCmTvJY30kfXE0d7en0+cVraxf+2t7b2ut4WaVPW7euO X3o4jHdzGO/W3tbW1FCv/m5et99a1ElHR0fS8QNeId9bODit+i0OW9hQU30/IV5htJObJ4/auor0 P7N0cvN8kHheqWkDAEBPvR1K+/BZ0k6qykoEo4S14pdN9XXPi/LfLXxGJkoA+0KGsvwcfElZQW6H TKY2iGk41JrkV/Fd/+PgIBbLyMpGjaWO3YmDeZh0qbG2xnmK9xAzCxqN/rqq8mnGvfuXz5FrcQ88 SDw/atJ0NpfnIHLLuJZApd6rcfuxb3t4I2m8dux312m++FDany3qJOdOcltry5gZfnxjs9aW5uLH Gdf/ONTUUE8mKq+pvi7lzImv/OeN95ubfz+14XWNsjMHAADyaAYGBgghfX347joAAACgN+DKEwAA AEAJDKUAAAAAJTCUAgAAAJTAUAoAAABQAkMpAAAAQAkMpQAAAAAl/TeUurq6Jicnnz17lt6TL6wJ CAi4evWqMvIxMTFJTk7+4osvlFE4gV27diW/09NojwiFwuTkZCMjI4rlyBs7duyRI0eSkpKSk5PH jRvXhyV/QpTXJ0ki3gu7du3aunVr70ruxbp9uDWU0WOpU0ZWVPZRn1Nefw4MDLx8+TLFQoh7+8fz idT119krg1AolEgkPB7P1tY2O5vUVyj8v/Tdd98hhPz8/EJCQnoaHVgqKiqbNm06d+7c3r17Wz/4 vYHNmzebmJgsWrRoQHL7+yDeCwB051M8Qol7+0d1LPTfUOri4pKQkDBx4kRXV9e/81D66dLV1VVX V8/MzBzwXvt3pnAvYP+N9Q6VdQF5sJ1JIu7tH9UnUj8NpUOHDtXT00tPT9fV1RUKhfv29ezXsoRC 4dKlSw0MDEpLS7dv356bm4uHnJycFi9ebGFh0dzcnJaWFh0d/fr1a5JRedOnT1+9enVYWFhiYmKX b+hyFS8vLxMTk+rq6mvXrh08eLClpQUhxGAwJk2aNG3aNDMzs9bW1oyMjD179pSXl/eoyd0xMzNb smTJiBEj6HR6Zmbmzp07nz9/jkc9PT0DAwP5fH5RUVFKSgr5YolzDggIWLJkCfY6LCwMe7Fx48Zb t24hhK5evaqmpoYtxOelPT09G9/9Ig1xzubm5ocOHdqwYYO9vb2npydC6NSpU0eOvP/1715sjdOn T1++fHnv3r2d3o8tnzhxIkH0w+Vd6q5PKtz79vb2ixYtsrS0bG5uvnfv3r59+8RiMZkaifcCktv4 t2/f/uGHHzqtO3/+/B9//LG744hgXTI5ExyhSuqxSFHPIahX4dYgzopKf6ayjzw8PBYsWKCjo1NY WHj79u0lS5bMnj2bzAeLwiMUUdiDCnl4eCxevJjH4+Xm5u7YsaO4uFi+vW5ubtifw4cPj46OXrZs 2ZMnT5Ci3q7wWFDeZ053+ulaqaurq0wmy8zMzMjIsLCw0NXVJb+uqqrqzJkz169f7+fnJ5VKN2/e jF9tFQgEEREROTk5X3/9dUhIiKWl5bZt20hG5Xl7e69atWrLli3kx9Hly5cHBwefOnXK29v7u+++ q6mpsbOzw0IjR460srIKCwubMmVKUFAQg8H49ddf8a5MhZGR0e7du1taWgIDA2fNmiWRSCIjI1VV 33+R8oYNG/78888ZM2bExcXNmTOHfMnEOcfFxYlEotmzZyOENmzYIBKJRCIR3mvd3NxEItGVK1fy 8/NF7+BHKXHOuMDAQITQwoULFy5cyOFwyGwugpKzsrJsbGw6vV9LS4vP52dnZxNHyWwugj5JvCU1 NDS2bdv29OlTPz+/efPm3b9/f+rUqWRqRIr2AkIIW5KZmdnTnInXVZgzQcnK67G4LnuOwl5HkDNx VhT7c6/3kaOj48aNG+Pj4729vY8ePTp37lzym4j4CCWul2R7u8NkMr/55ptVq1b5+/s3NzdHRESQ /CQk7u3EUeV95hDop6FUKBQWFBRIJJKMjAzsT/Lr0un0mJiYysrKmpqa06dPGxkZ4SPxzJkz6+rq oqOj6+rqiouLY2JiBALByJEjyURxPj4+K1as+OWXX65du0YypSFDhvj5+R05cuTixYsNDQ0vX748 deoU1jSE0N27dyMjI4uLi1tbW1+8eHH06FE+n29lZUW+yd1ZtGhRU1PTv/71r6qqqpqamoiICB0d HXd3dywaEBCQl5d34sSJxsbGmzdvkm/OAOaMa2xs3LNnj1gsFovF2GFApeQnT54IBAL5nyhACGHD Z3Z2NnGUTKMI+iTxlrSwsGCz2YmJiQ0NDbW1tVeuXDlw4ACZGqkjyJmYwpwJSlZej8V12XMU9jqC nImzUl5/Js5q9uzZhYWFx48fb2hoSElJSUpK6sW26kW9JNvbHRqNFhMTU15eLhaL//3vf/P5fPw0 VHmUuo+60x9DKZfLtbGxefjwIUKopKSkpqamR0OpTCbD5wSqq6sRQjweD/vTxsbmyZMn7e3t2J+P Hz9GCNna2pKJYqZPn75q1arExMQbN26QTwmbN7h9+3aXUTqd7uvre+DAgUuXLiUnJ8fGxiKEWCwW +fK7M2rUqPv37+O7XCKRlJWV4R/TQ4cOxeZGMFlZWeRLHqiccfJnV9RLzsrK4nA4RkZGdDr9woUL K1asQAhZW1uXlpbW19cTR8lUTdAnibdkRUVFW1vbsmXLXFxc2HK/KdsPCHImpjBngpKV12NxXfYc hb2OIGfirJTXn4mzEggE8pn07e0mvd6DZOTkvP39roqKirq6uqFDh/ZZ3t1Q6j7qTn9cK3V1daXT 6fhJW0ZGhkgkYjKZb968IbN6W1sbPhx2dHQghFTe/VI3h8NpaGjA3ymVStva2jgcDpkoZvjw4Tdv 3pw4cWJ8fLz85QFimpqaCKGamq5/6mvu3Llz5swJDw+/e/duY2OjpaXl/v37e/QIUJfodDqHw/H0 9MQm93EVFRVYlMvlyrdXfgJHoQHJWd6rV6/6sOTCwsI3b94IBAIulyuRSFxcXKKioqytrbEPIOIo GQR9knhLisXiTZs2BQYGhoeH02i0nJycHTt2FBYW9qjtvUOQMzGFOXdXslJ7LO7DnkOm1xHkTJCV 8vqzwqx4PB71bdWLekm2tzutra3yn/P19fWDBw/um6S7oex91J3+GEqxc9Dt27fLL3RycurpXQYf amxs1NDQwP9ksViqqqp4JyOOYqKios6fPx8bG7t58+agoCCpVEqmXuzcRUtLq8uTGHd390uXLuHz Qj26MExAJpNJJJKzZ8/u3r27y2htba18ezv900BsQHKW10bu19pJltze3p6Xl2dtbW1mZhYfHz95 8mRjY2Nra+vffvtNYZQihVsyNTU1NTWVxWKNHj0au7Lg7+9PvV6l6l3OSu2xuA97Dvle19OslNef yWSF/QePkc9QeahsSQyDwZA/a9LU1MTPQGQymfxFlkGDBlHMFi92QPaR0id4VVVVR48enZCQgF/u dnd3b25udnV1pV54Xl7esGHD8H+uhw8fjhDCTy6Jo5i6urr29vYtW7Zoa2uvXLmSZL2ZmZkymUwk EnUZZTKZ8kNylw8OY2NwdzOo3UUfPHgwYsSIThf5cAUFBfLT1/b29kRt6HnOxKRSaZcHA3HOVBCX nJ2dbWtr6+zsnJKSkpKS4u3tzeVy8fNO4igVJLekVCq9efPm6dOn9fT0qJ/9949e5Ky8HkulXmLE WSmvPxPLz8/Hb2xECMm/Jqm7I5QY9fbiG9PQ0JDL5eLzGbW1tQwGA/+foA8nfgdkHyn9GHZwcFBX V7937x6+pLm5OTMzs0+G0pMnT/J4vJCQEC6Xa25uHhwcXFhYmJ6eTiYqr6ysLDY21tPTc/z48WTq raysPHXq1Jw5czw9PTU0NPh8vpeXF35DU1pamoeHh5WVFYfD8fHxGTt27IclZGdnt7e3e3l5dTnJ 1l10//79JiYmoaGhBgYGLBbL2to6NDQU/8Km48eP29jY+Pr6stns8ePHT5gwgUxbyOdMrKioyNjY 2NHRsdOHLHHOVBCXnJ2dbWVlpaGhUVJSkpqaOn369IaGhtLSUjJRKoi35JgxY9auXSsQCJhMpqmp qbu7e3p6ukwmo16v8lDJWXk9lkq9xIizUl5/Jnbs2DErKyt/f38OhyMUCkl+Usnr7gglRr29wcHB xsbGOjo6K1eurKqqwidsHj16JJPJ5s6dy2Kx7OzsvLy8etQcpeZsbm6enJzco4c2lT7Biz0GIz+U IoTS0tKcnZ0tLS0pXiXKy8tbt27dwoULT58+3dLSkpaWFhUVhR/kxNFO4uPjhULhunXrcnJyyDzn FxMTU1FR4efnt2bNmurq6kuXLl28eBELxcbGMhiMHTt2qKqqPn78OCwsDH/yCVdeXh4eHr5gwYKl S5fSaLRp06bV1dUpjJaUlCxdujQoKGjfvn0MBqOkpOTixYupqanYWhkZGeHh4d9+++2yZcuKioqO Hj0aFBREckuSyZnYhQsXBALBzz//zOPxaDQa/tQacc5UEJeclZXFYDDu3LmDvZZKpbm5udh1IIVR Koi35L1793R0dEJDQ01NTRsaGu7cuUPyMVaF1q9fP2XKFPxP7PHBY8eOkZm1Jl6XSs7K67FU6iVG nBWVkqnso8zMzLCwsHnz5gUFBRUUFBw+fHj58uU9+mqC7o5QYhSPX6lUeuHChZ07d3K53JycnNDQ UDzn58+fR0ZGBgYG+vj4ZGVlYQ96km+O8nLuHZqBgQFCSF9fX6nVAAAA6Cs+Pj7Lly/38PD4yKc0 /j4+jYs0AADwd8Zms3/66ScbGxsmk2ltbe3n55eQkADj6Mej/76DFwAAQO9IJJIbN26sXr3azMwM +6bSw4cPD3RS4D2Y4AUAAAAogQleAAAAgBIYSgEAAABKYCgFAAAAKIGhFAAAAKAEhlIAAACAEhhK AQAAAEpgKAUAAAAogaEUAAAAoOT/AAjGYRXo/H+ZAAAAAElFTkSuQmCC --0000000000001b091905cfd1d8f4 Content-Type: image/png; name="emacs28.png" Content-Disposition: attachment; filename="emacs28.png" Content-Transfer-Encoding: base64 X-Attachment-Id: 2fcdaf362d05b1db_0.2 iVBORw0KGgoAAAANSUhEUgAAAmkAAAA3CAIAAADYCEorAAAAA3NCSVQICAjb4U/gAAAAGXRFWHRT b2Z0d2FyZQBnbm9tZS1zY3JlZW5zaG907wO/PgAAFpBJREFUeJzt3XlcE9e+APAzIZGEhH1fhSKr YlWuImjRvgq0WCnQinWjVlTc6spVb9V+evvai69Va12waK1t3VoF70OLu16hgitIBRFJEWQT2SGE hCyT98fovBTCZMIwoJ/+vn8l88uc8zszJ3MyZzIJFhgYiAAAAABAG2ewEwAAAABeMjB2AgAAAIaB sRMAAAAwDIydAAAAgGFg7AQAAAAMA2MnAAAAYBgYOwEAAADDwNgJAAAAGIar/QTHOBwNzqS4spXL W0eP7rbQ9tIVt8NHmBRLk/jva9uH+yOEPPZ9Z5V7vVtUg2GV8+Jbx4xWCYWIw3E+ke6QeWYAsurN 3dQU3NgYIYRwnNvZaVLx2PF0pujhw36vqPizT2VurgPQ3t93f6MSidy/+976Wg5CqHTdWom/v92F i65Hf2ZYcnniwubg8ZY3b72yN7U/MgUAAEb+dN6pRhiOvaxnohout8Pbi3jc7u/X8wWtY//WOClU ZWqKODraeO/rrXk/HGicFMpuljpxOCqRqH3EcPHqFV12doOQAAAAAENwuz1XI0yDMCOkYVKo9bUc 9+++Z1JCH3QM88R5PH5NrdzZSaJr7JQ7OCCE+HV1/hs/wdTqAU6vNx57Uy1v35EO8yz9+1qcz28b /ard+YuDnRQAAAAq3cdOhBCOcTCkYTh529PvO79WCwRjEpci/P9Lbh4fVL54kf25800hwRRRl5+P 6y1f4u+PELLMy2sS8BVWVl0O9sZ1T4kQMeNHPJY7OOQf2IcQIuYwFTY2hVv/hyzk8YcfPP7wA4TQ 0IM/2mRlEwtbx4yue3uqzNUFqdXCx5UOGafMih+Qq4jXrm4PGGF38RJXIml4/XWlpQVCKHBeAv0t g+G4qFRsXN8gd3ZSmluQyynqfbQksSVonHVOLre9vXHyZKOODpdfjlveySOiOJ9fOXd2S+AYrkzm cuyXnjWy3aLetI4aVffONJmLM0ehMCsscj6eNqS5mWaU1GVr+3Dzx0ozM8tbtz32pmIaRp/zAACg D3TP0LIxeSuortbweF02NtoL5Y4ORIg6Sqf8dn9fhJBQXCYU/4EQavfTcerZB00TQspWLJe+4oHz eDifL/HxFietaR8xvNvLmoPG1cbGEMOMoTQcToe3V5edLUJI8Pgx/XrbRgY8fetNtYCvsLWpWJig FgqJ5ZXxc5omhOB8vsLSsjxxodLaaoBbpFPLuLFlK5dLPdxxHk8lFDaPD3q46R8qkZBOlKQyNRUn rVGamVncyfP4dh8MnACAQaHjvJOgRhjq61eHmiZOaJo4gXwasDppSEuLoKpG4u8vd7BXiYQln2zi 19UN37BR7uiIEBJU1VBH9dao5vM7X3kFaTTCR4+6HB1agsZJ/P1s/3OViHqk7vdI3V/7buyTaVOF ZY98//sLcsUhjY3EGdW9r7cqLS21TzcRQhoOp2bGdISQy7FfbP9zVcPjVc+Y3hj62pOoaWZF9/+U gFDoduiwxe08Xnu7QduqfEli+ZJEhBCmUtlczbK6fYd+vRoub/jGzWqBoGTTx7ixsdTD3azovtrE pHl8EELI+lqO67FfGiZPqpn+7kC2qGLB/IoF87svxbDqGdMRhpkVFnns+67L3k68ZpXCyqo+IsIp /aSe6HO4sfEfa1Z12dtZ5N99ZW8qhvfz1AgAANDU69jZ74jTR7mjI0ehQAjJ7exwY2O5owOGa/i1 NdRRvYV3+PpoOBx+XR1XKhWKxQghiZ8v4nAQs8OrzMVZaWaGEKqZEUcc3BGGIYQ63Vy7vdIi/67t 5f8wqYtf+8T5RDqRMM16TR884NfUIoSMpFK1UEisInN20nA4CCHH/z1lJJXanzlbN/UttYnJwLdI W5e9ncLaGiHkdPLfXImEK5FY516vn/JGu7+vU7qeKKlt1KsIIUylGvr9wRfnijUA4C+o17HTiMEl T53fFTJ5Njo6IIQJqqpkrq6dQ4d2OTgYP63jKFXUUb01EjO0cgeHvB8OEEtUIlGnq4vJ48q+NYGg FpkSDzQcDCGMXK4ZYtztlbzW1r5V4bE31aS6+uE/1svcXOvejnT55QT9eo06O4kHHLVajRDx/WGc zycWDmltRQhhGg2vrY0cOwegRd3uUSEWqoSiZ1k1PbuEOaSxCSGkEpnqjWrjKJU4j/ckahrz+14A AKDPdI+dTAbO3vCraxCOyx0dcGNji7sFaqGwNXA0zuMJqmv0RvWSDNdxdVPi709/7MR0LTSSSokH I9b/w/hpPdX6DC688WtqHU5nVs+c0fj6ZMfTmUadnQbU2wP3+RSrwsLCuLFRg2FKc3MyOjAt0pGV tONZVtZWxCSwwtoKIcTt6NAbJQnLK9x+PFTyyaaGKVOsc66bPL82DAAAA0zHF4LYGDgRQhyl0ri+ Qe7kLHN2FpY9EpY9ah43FiEkqKrSG6WmMjOTOTsjhEZs+DhwXkLgvASHXzMRQu1+vgakp1AghDrd 3DRGRuRCQXU1cfiumj2ry8Ee53HlDg71YVNqY94xqO162WRlG8nkaj6/4Y3XGdZrXF/PUSoRQnXv TFObmDx9K4I86RzIFnXP6mk98aXZJ7HRKpFI6vlKU0gwQsi0uFhvlDSkvt6kosImO1vDwR7Pi9d5 ny4AAAyA7ued/TJwdvuuEPm7QibV1S1/C0QICR+Vyx0dW8b+DSEkqHr2NVrqKIV2P1+EYdz2dvKm FNNScR1CHT7eGi4XU+mf8kUImVQ8ltvbN7zxOjF6EV8awtRq57STj+fFt40MaBsZQL7YJvs3WhuC NiO53CY7+2lE+NOwKXbnznOUqj7XaySTW+Veb5wU2vjaxMbXJmIqFVfSoTJ9Nik6YC3qTqNxPp5W vnhRW0DA77u/IZbxWlrsiZtZqaN/5pT+7+agoE4P9/r/et3u0mV20wYAAF3+9MmdpTNOEjEBO6Sh kSuRCB890l6oN0qB+CUEUamYXCIUizFcgxsbSz09aebmfCLN/F6hkUzWba7S5mqW545dpg9LjeRy jkIhqK52PJ3pnHayt3L6zO7iZQzXqMzMmiZOZFivy8+/WN28xVEohrS0uH/3Pa+lZVBa1I3VjZue O3eblFdgSqWRVGp585bvF8nkrCx1VBtXInE8fRohVPturNKi326hAQAA+rDAwMDBzgEAAAB4mcAV IwAAAMAwMHYCAAAAhoGxEwAAADAMjJ0AAACAYWDsBAAAAAwDYycAAABgGNbHzuDg4Ozs7FOnTnEM +RWY2bNnX7p0iY183NzcsrOzJ0+ezEbhFHbu3Jn9nKFRg4SEhGRnZ7u4uDAsR9vEiRMPHTp05cqV 7Ozs1157rR9Lfomw1ydpot4LO3fu/Ne//tW3kvuwbj9uDTZ6LHNsZMVkH/U79vpzfHz8+fPnGRZC 3dtfhCMS6/+jEhISIpVKLSws/P39i4qK2K7uhbVixQqEUFxc3PLlyw2NDi4jI6NNmzadPn163759 SqWyW3Tz5s1ubm4LFy4clNz+Oqj3AgC9eRnfodS9/QV5L7A+do4fP/7s2bMRERHBwcF/5bHz5WVn Z2diYlJQUACH7EGkdy8QH7/6hsm6gD7YzjRR9/YX5IjE7tg5bNgwe3v7vLw8Ozu7kJCQ/fv3G7R6 SEjI4sWLnZycKisrv/rqqwcPHpChwMDARYsWeXp6dnV13bhxY/fu3S1avzxHHdUWFRW1evXq5OTk Cxcu0MwqKioqOjrazc2tqanp8uXLP/zwg0KhQAjxeLw333xz2rRp7u7uSqUyPz8/NTW1ulr/7/HS 4e7unpiYOHr0aA6HU1BQsGPHjtraWjIaGRkZHx9va2tbVlaWk5NDv1jqnGfPnp2YmEg8Tk5OJh5s 3Ljxt99+QwhdunRpyJAhxEJyqjkyMrLj+Q/pUefs4eHx448/btiwISAgIDIyEiGUlpZ26NAhJlsj PT39/Pnz+/bt6/Z6YnlERARFtOdynXrrk3r3fkBAwMKFC728vLq6um7durV///6GhgY6NVLvBaS1 8a9du/bxxx93W/fDDz/85JNPensfUaxLJ2eKdyhLPRbp6zkU9erdGtRZMenPTPZReHj4/PnzbWxs xGLxtWvXEhMTZ82aRefAovcdihjsQb3Cw8MXLVpkYWHx4MGD7du3l5eXa7d3ypQpxNORI0fu3r17 yZIl9+/fR/p6u973AnvHnJ7Yvd4ZHByM43hBQUF+fr6np6ednR39dblc7vTp09evXx8XFyeTyTZv 3kxeMfXx8dm6dWtxcfG77767fPlyLy+vL7/8kmZUW0xMzKpVqz7//HP6A+fSpUuXLVuWlpYWExOz YsWK5ubmESNGEKExY8Z4e3snJydPnTo1ISGBx+N98803ZN9lwsXFZe/evQqFIj4+/v3335dKpdu2 beNyn33uCQwM3LBhw8mTJ995550jR47MmTOHfsnUOR85ciQ0NHTWrFkIoQ0bNoSGhoaGhpLddMqU KaGhoRcvXnz48GHoc+TbkjpnUnx8PEJowYIFCxYsEIlEdDYXRcmFhYV+ft3/jc7KysrW1raoqIg6 SmdzUfRJ6i1pamr65Zdf/vHHH3FxcfPmzbt9+/bbb79Np0akby8ghIglBQUFhuZMva7enClKZq/H knT2HL29jiJn6qwY9uc+76NRo0Zt3LgxIyMjJibm8OHDc+fOpb+JqN+h1PXSbG9v+Hz+jBkzVq1a NXPmzK6urq1bt9I8ElL3duooe8ccndgdO0NCQkpLS6VSaX5+PvGU/rocDmfPnj1Pnjxpbm5OT093 cXEhh97p06e3tbXt3r27ra2tvLx8z549Pj4+Y8aMoRMlxcbGfvTRR5999tnly3T/i8PBwSEuLu7Q oUNnzpyRSCRPnz5NS0sjmoYQunnz5rZt28rLy5VKZV1d3eHDh21tbb29vek3uTcLFy7s7Oz84osv 6uvrm5ubt27damNjExYWRkRnz55dUlJy/Pjxjo6OrKws+s0ZxJxJHR0dqampDQ0NDQ0NRL9nUvL9 +/d9fHww7E9/xkqMl0VFRdRROo2i6JPUW9LT01MoFF64cEEikbS2tl68ePHgwYN0amSOImdqenOm KJm9HkvS2XP09jqKnKmzYq8/U2c1a9YssVh87NgxiUSSk5Nz5cqVPmyrPtRLs729wTBsz5491dXV DQ0NX3/9ta2tLXmiyR5W91FPLI6d5ubmfn5+d+/eRQhVVFQ0NzcbNHbiOE6e5jc1NSGELJ7/aYaf n9/9+/fVajXx9N69ewghf39/OlFCVFTUqlWrLly4cPXqVfopEVMB165d0xnlcDjvvffewYMHz507 l52dnZKSghASCAT0y+/N2LFjb9++Te5jqVRaVVVFHpeHDRtGTHcQCgsL6Zc8WDmTtM+fmJdcWFgo EolcXFw4HE5mZuZHH32EEPL19a2srGxvb6eO0qmaok9Sb8mamhqVSrVkyZLx48cLhUJDm8wERc7U 9OZMUTJ7PZaks+fo7XUUOVNnxV5/ps7Kx8dHO5P+/cpIn/cgHcXP/3y3pqamra1t2LBh/ZZ3L1jd Rz2xeL0zODiYw+GQp2X5+fmhoaF8Pl8ul9NZXaVSkeOfRqNBCBk9/1dqkUgkkUjIV8pkMpVKJRKJ 6EQJI0eOzMrKioiIyMjI0J7ip2ZmZoYQam5u1hmdO3funDlztmzZcvPmzY6ODi8vrwMHDhh0Z45O HA5HJBJFRkYSE/SkmpoaImpubq7d3g5d/9vVm0HJWVtjY2M/liwWi+VyuY+Pj7m5uVQqHT9+/K5d u3x9fYkjDnWUDoo+Sb0lGxoaNm3aFB8fv2XLFgzDiouLt2/fLhaLddbSvyhypqY3595KZrXHknr2 HDq9jiJniqzY6896s7KwsGC+rfpQL8329kapVGof59vb2y0tLfsn6V6wvY96YnHsJM4yv/rqK+2F gYGBhn41oKeOjg5TU1PyqUAg4HK5ZK+ijhJ27dr166+/pqSkbN68OSEhQSaT0amXODuxsrLSeZoS FhZ27tw5cqrHoIu7FHAcl0qlp06d2rt3r85oa2urdnu7fUqgNig5a1PR+2dymiWr1eqSkhJfX193 d/eMjIy33nrL1dXV19f322+/1RtlSO+WzM3Nzc3NFQgE48aNIy4WzJw5k3m9rOpbzqz2WFLPnkO/ 1xmaFXv9mU5WxEd2gnaG7GGyJQk8Hk/7NMnMzIw85cBxXPu6ibGxMcNsyWIHeB+xNWfL5XLHjRt3 9uxZ8hp1WFhYV1dXcHAw88JLSkqGDx9OfnweOXIkQog8faSOEtra2tRq9eeff25tbb1y5Uqa9RYU FOA4HhoaqjPK5/O1x2Cdd+wSg25vk6K9Re/cuTN69OhuF+pIpaWl2jPSAQEBVG0wPGdqMplMZ++n zpkJ6pKLior8/f2DgoJycnJycnJiYmLMzc3JM0vqKBM0t6RMJsvKykpPT7e3t2d+fj8w+pAzez2W Sb3UqLNirz9Te/jwIfltRISQ9mOaenuHUmPeXnJjOjs7m5ubkzMWra2tPB6P/BDQj3O5A7yP2Hr3 vvrqqyYmJrdu3SKXdHV1FRQU9MvYeeLECQsLi+XLl5ubm3t4eCxbtkwsFufl5dGJaquqqkpJSYmM jJw0aRKdep88eZKWljZnzpzIyEhTU1NbW9vo6GjyW0g3btwIDw/39vYWiUSxsbETJ07sWUJRUZFa rY6OjtY5b9Zb9MCBA25ubklJSU5OTgKBwNfXNykpifxppGPHjvn5+b333ntCoXDSpElvvPEGnbbQ z5laWVmZq6vrqFGjuh1VqXNmgrrkoqIib29vU1PTioqK3NzcqKgoiURSWVlJJ8oE9ZacMGHC2rVr fXx8+Hz+0KFDw8LC8vLycBxnXi97mOTMXo9lUi816qzY68/Ujh496u3tPXPmTJFIFBISQvNIpa23 dyg15u1dtmyZq6urjY3NypUr6+vrySmZ33//HcfxuXPnCgSCESNGREdHG9QcVnP28PDIzs6meS8l W3O2xN0p2mMnQujGjRtBQUFeXl4Mr/SUlJSsW7duwYIF6enpCoXixo0bu3btIt/V1NFuMjIyQkJC 1q1bV1xcTOd+uz179tTU1MTFxa1Zs6apqencuXNnzpwhQikpKTweb/v27Vwu9969e8nJyeQdSKTq 6uotW7bMnz9/8eLFGIZNmzatra1Nb7SiomLx4sUJCQn79+/n8XgVFRVnzpzJzc0l1srPz9+yZcsH H3ywZMmSsrKyw4cPJyQk0NySdHKmlpmZ6ePj889//tPCwgLDMPLuMeqcmaAuubCwkMfjXb9+nXgs k8kePHhAXMvRG2WCekveunXLxsYmKSlp6NChEonk+vXrNG8n1Wv9+vVTp04lnxK38R09epTORDT1 ukxyZq/HMqmXGnVWTEpmso8KCgqSk5PnzZuXkJBQWlr6008/LV261KDfBOjtHUqN4ftXJpNlZmbu 2LHD3Ny8uLg4KSmJzLm2tnbbtm3x8fGxsbGFhYXEDZf0m8NezobCAgMDWSoaAABAP4qNjV26dGl4 ePgLPmnxV/ByXHEBAIC/IKFQ+Omnn/r5+fH5fF9f37i4uLNnz8LA+SJg/fdsAQAA9I1UKr169erq 1avd3d2JHwH96aefBjspgBDM2QIAAACGgjlbAAAAwDAwdgIAAACGgbETAAAAMAyMnQAAAIBhYOwE AAAADANjJwAAAGAYGDsBAAAAw8DYCQAAABgGxk4AAADAMDB2AgAAAIaBsRMAAAAwzP8Bmn6M9EhX Y8gAAAAASUVORK5CYII= --0000000000001b091905cfd1d8f4-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 14:01:34 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 18:01:34 +0000 Received: from localhost ([127.0.0.1]:37996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhy6I-0000Tx-4c for submit@debbugs.gnu.org; Tue, 02 Nov 2021 14:01:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhy6F-0000Tb-28 for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 14:01:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhy68-0007to-Ly; Tue, 02 Nov 2021 14:01:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/p3IGbbu4crPzCcBDkRlYSD6TJtObUI4b48aBuf+skA=; b=nDmEASOZg6qW ghlL86CZ4hlnbdlP+HZ7oUdws9rs3BrJZjRevB8RGyKTp0/+JAq0wjjadSWsDf9anPGv/BfvykVTz cQpAZjZo+tYDKoQkl9tUK1bh9HFIDl4dCO4B/hityhUpAf4YQaBJXvK43xvPQDCrAKgrkRcbv0n+n VTDs+g1c6/xhOJ6waKMh5PxRfk1x5i6ByXAVQaT1sBveCPM0LiBj3vqkBOOOEbctlkzc060xWskNX GM36e4VHdTtSVq/5cWJWfLNTobTmqZsU0XXNlFqTybsIw/81BfGr+LMM7WdlhNG/p29vTXHgALoDk Ou9AZRfjai27uFLSWGG1Kw==; Received: from [87.69.77.57] (port=4565 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhy68-0004Gq-4g; Tue, 02 Nov 2021 14:01:24 -0400 Date: Tue, 02 Nov 2021 20:01:19 +0200 Message-Id: <83a6imjv2o.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Tue, 2 Nov 2021 10:44:23 -0700) Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 2 Nov 2021 10:44:23 -0700 > Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com > > > What is the difference between "colors specified by the SVG image" > > (which you say we respect), and "foreground color is specified in the > > SVG file" (which you want us to disregard)? > > You missed quoting "no" in "no foreground color is specified in the SVG > file". So the difference is that in one case the SVG files specifies > the foreground color, in the other case it does not. I didn't miss anything, no. If the solution you propose only works for SVG that specify no foreground, then it won't be able to solve all of the situations where a different theme makes an icon barely visible or unpleasant to the eye. Which is why I think a better solution would be to allow themes to specify different icons where necessary. > >> I consider this a bug fix, but admittedly only a minor one. However, I > >> also note that the visibility of those symbols is worse with a dark > >> theme in Emacs 28 than in Emacs 27, so we might consider it a > >> regression. > > > > Let's not exaggerate, okay? > > I fail to see any exaggeration. > > I've attached two screenshots of the customize buffer using the > "tsdh-dark" theme, one in Emacs 27 and the other one in Emacs 28. If we want to fix this, we can go back to down.xpm etc. on the release branch, and discuss how to solve this on master. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 14:43:16 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 18:43:16 +0000 Received: from localhost ([127.0.0.1]:38064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhyke-0003oh-Ic for submit@debbugs.gnu.org; Tue, 02 Nov 2021 14:43:16 -0400 Received: from mail-pg1-f175.google.com ([209.85.215.175]:34475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhykd-0003oQ-3s for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 14:43:15 -0400 Received: by mail-pg1-f175.google.com with SMTP id j9so230278pgh.1 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 11:43:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=nmigvNx+lR4vq9A0s2YXIxB2otyjH4cULSQoHdaTPdU=; b=HgG0PTfEBhpudmny7YtvcT1721ToIvzk2oqY2Ps1yVOQGYfF1+xzyZzpWFaSaCkTYw 8ERYKWN3Q+Iye3QsyLqnlNwPz6aL0YSwRi88u7YSJDs2a9OHZz1UCbDG5CzgWpvYZPSQ Cncb2gATEP4KW6/G2g2wqMcdR7YNT7VhDzZ7cbtnTRa0aPm/TzgYxnaUYN6E5E6VnqiX GklluPHgLS731Vx3h0KFdFWH9QJVFTDQnQ8nC/rPd5Gf1ZHFtxkuc9UKsfH/FXqPUzkw 3kLXAM2OHDa3Z2t3W9eJQ3IA+7ZPWZ+TPFDwIsWylL4IN0WqTyeOeagc6HzQOiakNDA5 C04Q== X-Gm-Message-State: AOAM530KunVfATEa+h9VMTYeBoRZ5lMBFp/hasA8TbBTSrvBl84Qwbp4 gbA3MfidEAINOH5/Jx5L4azXk9JXKC3ePWqhCNQ= X-Google-Smtp-Source: ABdhPJxGxa/EEURp0RYOibqH2dSkqvJzMDiwX9dd7a/ob+llgD3r+Kof1qNudD0HO8L7EGG+c0HgyI6eof7w2OQ3UjI= X-Received: by 2002:a63:330f:: with SMTP id z15mr29355369pgz.42.1635878589388; Tue, 02 Nov 2021 11:43:09 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 11:43:08 -0700 From: Stefan Kangas In-Reply-To: <83a6imjv2o.fsf@gnu.org> References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> MIME-Version: 1.0 Date: Tue, 2 Nov 2021 11:43:08 -0700 Message-ID: Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > If the solution you propose only works for SVG that specify no > foreground, then it won't be able to solve all of the situations where > a different theme makes an icon barely visible or unpleasant to the > eye. It is certainly the correct solution for all the sets of scalable icons that I have reviewed. Which SVG icons do you have in mind? Could you point me to them? For the icons I know of, the best solution if you need to change the color of this or that icon, is to either change the active defface to use the correct color, or to introduce a new defface. This is, not by accident, the chosen solution also for icons on the web. > Which is why I think a better solution would be to allow themes > to specify different icons where necessary. Color themes should not *need* to provide their own icons when all they want is to change the color of an icon. That puts an unnecessary and completely avoidable burden on theme developers, for starters because they would need to learn how to edit SVG files (which is not trivial). It is also less flexible, as how icons look is orthogonal to what color they have. If you propose that this should exist as an option, that is fine by me, but I don't see any need for it. I don't think we should impose an inflexible solution when I have already indicated in several messages that I'm working on a better one. The solution you propose goes in the completely opposite direction of that work, so I hope that we won't do that. Furthermore, the patch I have already posted here is sufficient for the purposes of this bug report. I suggest we install it. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 14:44:08 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 18:44:08 +0000 Received: from localhost ([127.0.0.1]:38068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhylT-0003qX-Tj for submit@debbugs.gnu.org; Tue, 02 Nov 2021 14:44:08 -0400 Received: from mail-pl1-f175.google.com ([209.85.214.175]:37821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhylR-0003pn-Kc for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 14:44:06 -0400 Received: by mail-pl1-f175.google.com with SMTP id n8so229633plf.4 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 11:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=uCMDxPXFr0i7sVTVH+NJW37toCCuF3gv/a2RmINTf3Q=; b=cHmFCy4TEk96sSxDziSnhLpC+sRwZw0jfp/OFWTt5I0eUFbEwqGONs2CA6/JJAW/pG JeuaVdrpxbhj/yACYo7imvuaz6VklBgLXEwearP/FZWdtenfYuMyYefRe3CBYeArNOMT +D2ERPdvF5UfnJVG/bZtuCUoCk8YgjeU2EjkRQC63+LyOBuXuu4rxMQNyim2pmch5t8w e0GbH8DQ79ZGZb4twFoj9vg3i0edWp0HyqizE2juhKjXGXntHfDOItzQ8Nwc6UrV8dzv o9T3TE4eiNI9ILjC9MyfNK2FKbeet/N8XnBtzJ9FEUkASL3FDhWTcEX89lpTzuGTsOYC k9lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uCMDxPXFr0i7sVTVH+NJW37toCCuF3gv/a2RmINTf3Q=; b=nWL5kXGwKDpD11ur5DPKEKTQs01e3xZGpMwA3Vs5eXl4sTHX6Xfwn9eIblYZI1QYA7 vDUWsJVmrAvzkKxrLPapWaD8IznnCTI5pc3+gWNvkj0K8yZ56zLkjh9iExx/zETgitTV FPihTR+taJth9UkUxbwOpVGAA8U+H9rX+yd6mwCPWANM5Wv1VNyq/hhCA2SLj64do1ww SsXIylsw7czK59m+qXTQ3MtLeGI62xggU8v/d+03+1JYMg0Ec5V7H9nL8oaanyBZx9wY cbegKr8qLaHm4tgrmYLKBSvakk9CcyYLjy7hUOQQzweuGYJKjRQRuoaiklW1OQoslLWO 03LQ== X-Gm-Message-State: AOAM530j4rQe1A3RtiuFx+wLBS/Pm0pqW+oo70m3llNj61uztPA0X6wm CKFeENtPEFuR/YwmOmvO8y4= X-Google-Smtp-Source: ABdhPJxK0mSIgM6/YWjCnLj3WYifgPn7sWlGKchrmBFYrMLALxOa0HzKZ5Wxr01j+2//oVW7DLmI2w== X-Received: by 2002:a17:90b:33ca:: with SMTP id lk10mr1473999pjb.18.1635878639699; Tue, 02 Nov 2021 11:43:59 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id d18sm7213989pfv.161.2021.11.02.11.43.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Nov 2021 11:43:59 -0700 (PDT) Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds To: Eli Zaretskii , Stefan Kangas References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> From: Jim Porter Message-ID: <18066bc0-86a6-5901-9a53-e2c6ea13fbc8@gmail.com> Date: Tue, 2 Nov 2021 11:43:58 -0700 MIME-Version: 1.0 In-Reply-To: <83a6imjv2o.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51556 Cc: 51556@debbugs.gnu.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 11/2/2021 11:01 AM, Eli Zaretskii wrote: > If the solution you propose only works for SVG that specify no > foreground, then it won't be able to solve all of the situations where > a different theme makes an icon barely visible or unpleasant to the > eye. Which is why I think a better solution would be to allow themes > to specify different icons where necessary. I think it might help to break this problem down into parts. There are a few cases I can think of where the question of how to color an SVG might come up: 1) Single-color SVGs Some SVGs are just a single-color shape, like the Customize arrows. There's no *particular* color that's right for these, aside from "what looks good". In some ways, these SVGs are like an ordinary textual glyph, except that we've defined our own fancy shape to use. In this case, I think it makes sense to be able to specify what color to use for the SVG independently of the shape so that themes can adjust it as-needed. This case is the one initially described in this bug. 2) Multi-color SVGs Some SVGs have many colors. There's a particular set of colors that makes sense for this SVG, as defined in the file by the author. It would be difficult to programmatically alter the colors of such an SVG and maintain a good result, so we probably shouldn't try. This is a case where it may be nice to let themes specify a completely-different SVG to use. I'd consider this lower priority, since I'm not aware of a specific SVG in this category that's causing visual issues with themes. 3) Dynamically-colored SVGs This could be considered a variant of (1). Sometimes, we might want to define a particular shape, but give it different colors in different contexts. For example, if we wanted to use SVGs to display something similar to the circles in the fringe that mark GDB breakpoints, we could have a single breakpoint.svg file that we color bright red or gray depending on the breakpoint's state. This is another case where it would be convenient to be able to set an SVG's color independently of its shape. 4) Third-party packages Some packages might want to provide SVG icons to use in one way or another, along the same lines as the Customize arrows (i.e. a single-color SVG). If you're the author of a little-known package, you can't really expect theme authors to provide customized icons for your package that fit with the theme. However, themes *do* specify at least a handful of faces. As a package author, it would be convenient to be able to say "render this icon using the foreground color of the `error' face", for example. Then your package looks good with most themes without requiring anyone to provide custom SVGs. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 14:53:22 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 18:53:22 +0000 Received: from localhost ([127.0.0.1]:38073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhyuP-000489-TY for submit@debbugs.gnu.org; Tue, 02 Nov 2021 14:53:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhyuO-00047u-52 for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 14:53:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhyuI-0008Fi-RE; Tue, 02 Nov 2021 14:53:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aFfJyfyuxJBlVNL47BN/Y6ClxvRwdX4cvtwBUyA5BfM=; b=JDlAKScx2Mx9 nqJBEcb3SQO9X2rzzivsoqwi8GuEGsmeE5otYAuQ7cKda97Fq2+ufnHY6e0bjz5gmuindDFAhhpU9 HSKcB5V+6ICcNeG0QAimFmwNWivcqATJ69ikUU/8hKdmMoX+6QtIOox/vTNAeRFrkBJ69CY1VvjnI C3OGALZECUbWCcvjtKq7vT7Qa6wJPKzAWvLEmGip5eJwcknPcS40H45fgCx8qXr4JAXFj1j9mXvK0 zAwnmUUIXJT3Crpnrd1rq2QCAjzIckpcYoZH1Inc0D6OrxtcTzSSC6LmVMejm7NliDhErOYItlcjt HeSXGZIWmU58wT9x6v7Ekw==; Received: from [87.69.77.57] (port=3789 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhyuI-0000L5-At; Tue, 02 Nov 2021 14:53:14 -0400 Date: Tue, 02 Nov 2021 20:53:11 +0200 Message-Id: <834k8ujso8.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Tue, 2 Nov 2021 11:43:08 -0700) Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 2 Nov 2021 11:43:08 -0700 > Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com > > Eli Zaretskii writes: > > > If the solution you propose only works for SVG that specify no > > foreground, then it won't be able to solve all of the situations where > > a different theme makes an icon barely visible or unpleasant to the > > eye. > > It is certainly the correct solution for all the sets of scalable icons > that I have reviewed. Which SVG icons do you have in mind? Could you > point me to them? Try splash.svg, as a trivial example (and forget that it's too large for an icon, this is just an example). > For the icons I know of, the best solution if you need to change the > color of this or that icon, is to either change the active defface to > use the correct color, or to introduce a new defface. This is, not by > accident, the chosen solution also for icons on the web. We have a disconnect here, because I don't follow. Are you talking only about SVG that use only the gray color for its lines? > > Which is why I think a better solution would be to allow themes > > to specify different icons where necessary. > > Color themes should not *need* to provide their own icons when all they > want is to change the color of an icon. I said "should allow", and you say "need". We are mis-communicating. And that's in addition to the color business, where we also have some sort of disconnect. > Furthermore, the patch I have already posted here is sufficient for the > purposes of this bug report. I suggest we install it. On master? I don't object. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 14:58:27 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 18:58:27 +0000 Received: from localhost ([127.0.0.1]:38092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhyzL-0004H4-An for submit@debbugs.gnu.org; Tue, 02 Nov 2021 14:58:27 -0400 Received: from mail-pl1-f176.google.com ([209.85.214.176]:39793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhyzJ-0004Gm-IO for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 14:58:25 -0400 Received: by mail-pl1-f176.google.com with SMTP id t21so275356plr.6 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 11:58:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=XaQUZ8wXoR5hV4iwvmcO5kdEGFo/emUhXiOpKP1Z45A=; b=tVzaQ71koKHx3cEeqK9d7c/7IS4RoWgek2aZEm1AC1M+kCVt3sOPNzNUsZldMPEJiJ AlgNxjC85M/7Xf2whxy2zBxvFaM6zrwLDeUffuVYHrIt9VRTWG9lzrI6iSTPRpwSDeA8 qMtwqyQAM+sjd0l9Aa+G+aN39dJPv9qYVAH68EAwMA1E3D9Bj9nP50emRyyw1cwCigbz fglXxAVMlLm5v8ZL/b2V0zJOf8IQXJkbohRvdp5uFqFUbA3cfFUn7NXjIvo0shrW+mRE ojSHvYCtdHONYjacCOJV94mpcHerof6EWIpBN29SJg/L7DWHiJvPqr+1j1cRft8FjSSS dDvA== X-Gm-Message-State: AOAM53387Ese3J8sn2G49kKlyRhUfdXLE1Vb8Ojt4JeNakJnSRgJFove X6lCJkljVgdm03jVoB6UpbmlH4ok9Iv3VfQByhc= X-Google-Smtp-Source: ABdhPJzr7Xj73gtFLMbc3olVOrsF4z5tgOah6JwHO+dn65FHVOhbdA/6vNcDvUvYg9iqIYy398SVLbZWhdOpYkSiz5g= X-Received: by 2002:a17:90a:be10:: with SMTP id a16mr8797124pjs.133.1635879498301; Tue, 02 Nov 2021 11:58:18 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 11:58:17 -0700 From: Stefan Kangas In-Reply-To: <18066bc0-86a6-5901-9a53-e2c6ea13fbc8@gmail.com> References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> <18066bc0-86a6-5901-9a53-e2c6ea13fbc8@gmail.com> MIME-Version: 1.0 Date: Tue, 2 Nov 2021 11:58:17 -0700 Message-ID: Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds To: Jim Porter , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51556 Cc: 51556@debbugs.gnu.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Jim Porter writes: > I think it might help to break this problem down into parts. There are a > few cases I can think of where the question of how to color an SVG might > come up: Thanks, this summary is useful. I agree with all your points, but I have some comments. > 3) Dynamically-colored SVGs > > This could be considered a variant of (1). Sometimes, we might want to > define a particular shape, but give it different colors in different > contexts. For example, if we wanted to use SVGs to display something > similar to the circles in the fringe that mark GDB breakpoints, we could > have a single breakpoint.svg file that we color bright red or gray > depending on the breakpoint's state. I don't think this is fundamentally different from (1). The shape is independent from the color in both cases. > If you're the author of a little-known package, you can't really > expect theme authors to provide customized icons for your package that > fit with the theme. However, themes *do* specify at least a handful of > faces. As a package author, it would be convenient to be able to say > "render this icon using the foreground color of the `error' face", for > example. Then your package looks good with most themes without > requiring anyone to provide custom SVGs. Exactly the point. This goes for built-in packages as well. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 15:15:38 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 19:15:38 +0000 Received: from localhost ([127.0.0.1]:38114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhzFy-0006sK-FY for submit@debbugs.gnu.org; Tue, 02 Nov 2021 15:15:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhzFw-0006s6-6r for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 15:15:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52344) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhzFq-0006wM-P9; Tue, 02 Nov 2021 15:15:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JzbOwkh9IztuuhFCCEIVph1z3IUKhLeWQNqmVsZiXAA=; b=pyJMKeysfhNw 1uRKwjYEgV/+cgSAargqZtrOsJyTqOSuj9CVqTB7g6ngqR+L/8PLemOGzTNRnN14U81gXe5hk0ynz 5Nt0vy/WJDTm/6ZCMiYMHtpWWDZTGkTYjS/eapF0wRxfoHtWyytPFCKXm1OSax6MdBoSieGAwlzFv 2KzPZpn+hlymjEgaiUHLVjRQ7x0cAK+J53Iy+y6RUK5ec1HoSqZ8MF4u7oJ4zY7QS5fLEZJa0smF6 SuBnIHpIU2feOMQ5cKmvkukyJNmkdYETWcWc89KhZd7kL5SFF5LlIBQyz5FZME/2L1mIIf+CLPtZK QoQ1hsFu+Xj1eQ/TrKIrdQ==; Received: from [87.69.77.57] (port=1168 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhzFn-0000Z6-ND; Tue, 02 Nov 2021 15:15:30 -0400 Date: Tue, 02 Nov 2021 21:15:23 +0200 Message-Id: <8335oejrn8.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Tue, 2 Nov 2021 11:58:17 -0700) Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> <18066bc0-86a6-5901-9a53-e2c6ea13fbc8@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 2 Nov 2021 11:58:17 -0700 > Cc: 51556@debbugs.gnu.org, kevin.legouguec@gmail.com > > > If you're the author of a little-known package, you can't really > > expect theme authors to provide customized icons for your package that > > fit with the theme. However, themes *do* specify at least a handful of > > faces. As a package author, it would be convenient to be able to say > > "render this icon using the foreground color of the `error' face", for > > example. Then your package looks good with most themes without > > requiring anyone to provide custom SVGs. > > Exactly the point. This goes for built-in packages as well. How come built-in packages qualify as "little-known"? For really little-known packages, my suggestion would be to use icons whose visibility should be good with any theme. Or they could not use icons at all. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 15:26:27 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 19:26:27 +0000 Received: from localhost ([127.0.0.1]:38126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhzQR-00078i-01 for submit@debbugs.gnu.org; Tue, 02 Nov 2021 15:26:27 -0400 Received: from mail-pg1-f173.google.com ([209.85.215.173]:38665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhzQO-00078H-Qx for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 15:26:25 -0400 Received: by mail-pg1-f173.google.com with SMTP id e65so305764pgc.5 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 12:26:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=SbhEPnA+LWLLrffkJViUviuGThxiiRkqYQcvsbdaD2U=; b=4ZdjhNcja++alvTljzsdqohHAt6UhixHsJsNG/lzohWS6KEcy5CDQe8OPBVHCD5SXY 3NY7mnnxSc6Gx3bAFG6aJ4OKANoLgPqvbZQL4rMouOcYCu3k7rWpb5pv24aKmPKx9Zzu WOTT+9rN1BCYBlZnigxU7dHuf9nB3zVQMYqKz6G6MzZoicus60ZZ7SWsJT99R4Xux6ON 4liBh7qaTz1CzG7zz6o21AAin7PNiy+VGg8jotMJPIL42LD03eHuD3CLFQP1Jj/yPqzv GF2g05AK0ZPbs/XfgAE0lxPcOlNA8RI4pp3+16+Sj97N/IiuNlsoqKMj2IuuiLYubz9N xPGw== X-Gm-Message-State: AOAM533OS0kaQ6Kh5No9Zdazce/Rg6tffwwBLvt2ZMBeoRqexmUL6iIc c5N2ICnMcJ9i/XA5SG9k1Vxpetm/WsYl+aI/IEo= X-Google-Smtp-Source: ABdhPJwYbsS/76Mn8765lg4g257ev/+YGOKCzix1ND1HqVXG3fWModSXnIMPaS7AeVM+CFuc0hszUmZFn4bPwgVpCKU= X-Received: by 2002:a05:6a00:244d:b0:44d:c279:5155 with SMTP id d13-20020a056a00244d00b0044dc2795155mr38494884pfj.0.1635881179233; Tue, 02 Nov 2021 12:26:19 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 12:26:18 -0700 From: Stefan Kangas In-Reply-To: <834k8ujso8.fsf@gnu.org> References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> <834k8ujso8.fsf@gnu.org> MIME-Version: 1.0 Date: Tue, 2 Nov 2021 12:26:18 -0700 Message-ID: Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: >> It is certainly the correct solution for all the sets of scalable icons >> that I have reviewed. Which SVG icons do you have in mind? Could you >> point me to them? > > Try splash.svg, as a trivial example (and forget that it's too large > for an icon, this is just an example). That's correct, this approach won't work for multi-color SVG's. But see Jim Porter's reply. >> For the icons I know of, the best solution if you need to change the >> color of this or that icon, is to either change the active defface to >> use the correct color, or to introduce a new defface. This is, not by >> accident, the chosen solution also for icons on the web. > > We have a disconnect here, because I don't follow. Are you talking > only about SVG that use only the gray color for its lines? I'm talking about what Jim Porter calls "Single-color SVGs". This case is applicable to all sets of free and scalable icons that I have reviewed. This includes the most popular and extensive icon sets, such as fontawesome, octicons and material icons. In all these cases, the SVG files may or may not come with a foreground color, but that is an implementation accident: they are mainly intended for use in a web browser, where the web browser will override the foreground color with the foreground color specified by CSS. In Emacs, we don't let faces override a foreground color specified in an SVG file (that won't work in general, as is clear from the "splash.svg" example), so if we want this functionality, we must take care to remove the foreground color in the SVG file. > I said "should allow", and you say "need". Aha. Thanks for clarifying. Then your position does not seem to be all that different from mine. Perhaps it is only a difference in priorities, or perhaps there will exist no difference in practice. >> Furthermore, the patch I have already posted here is sufficient for the >> purposes of this bug report. I suggest we install it. > > On master? I don't object. Thank you, installed as commit 11702a6dd7. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 15:26:24 2021 Received: (at control) by debbugs.gnu.org; 2 Nov 2021 19:26:24 +0000 Received: from localhost ([127.0.0.1]:38123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhzQN-00078S-Rg for submit@debbugs.gnu.org; Tue, 02 Nov 2021 15:26:23 -0400 Received: from mail-pf1-f176.google.com ([209.85.210.176]:46732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhzQL-00078E-Oz for control@debbugs.gnu.org; Tue, 02 Nov 2021 15:26:22 -0400 Received: by mail-pf1-f176.google.com with SMTP id x66so20431080pfx.13 for ; Tue, 02 Nov 2021 12:26:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=uSHoie6938Pe1OLwz9MqXSYitMAZMw6UbbTzXDz+Cdg=; b=3U3utHhWi6PNvMfPSYTR3wxekRVKUKXLmdEa1Ze2Zg7pGLHZuLcTGYf9NwDD4IsqT+ gEWAvJNpB0IjXhIX1YSDZlFC7/0/YKxHVjU39OHEs2m+sICrvuSK2tgIkiUibpTJFxa4 2yVEeZkXF3igdlAi3da+1QsWnb0l1IiddwTs6DQ1956so7Ooym2b+C2KjdO+a6dpcsDA lMooB+nlVbAUuFGlV52soZiCrDgNdG0JtNNcRpDXi3m8QYCqbWZ5f51+3GJfNdkNNiWz 5Z+V9Pgh3i/5+vva7uKqxFliq1XeJWweh82bTgx38JqFkk6GZ4c00AI2bUappR7+lDhZ EbTw== X-Gm-Message-State: AOAM533hAprAdXgzA3nWsyWsWh0QJtfkLZlQFv7EqdLjaqQreSrzS9w6 JCZoD6eVpPwEEg+GBMboLpn8dHTeQw/UX6CPgbBKDCC/ X-Google-Smtp-Source: ABdhPJz3vIajCJ2l91pfqPK52TFHuZ23K7t8hnd5nfK5VSpJJBZ+EFCTChem/ABHbmAMhADQDEBrSqgTJtLHZXiMIeI= X-Received: by 2002:a05:6a00:1955:b0:47c:1d32:84de with SMTP id s21-20020a056a00195500b0047c1d3284demr38399573pfk.70.1635881175833; Tue, 02 Nov 2021 12:26:15 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 12:26:15 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Tue, 2 Nov 2021 12:26:15 -0700 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 51556 29.1 thanks Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.210.176 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.210.176 listed in wl.mailspike.net] 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 51556 29.1 thanks Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.210.176 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.210.176 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager close 51556 29.1 thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 15:44:53 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 19:44:53 +0000 Received: from localhost ([127.0.0.1]:38158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhziH-0001Iu-Cy for submit@debbugs.gnu.org; Tue, 02 Nov 2021 15:44:53 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:44788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhziF-0001Id-Qy for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 15:44:52 -0400 Received: by mail-pl1-f169.google.com with SMTP id t11so420394plq.11 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 12:44:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=6A0w7mvRSTCwDAx90eHXs0zMW+pDXVCFCT0/8IxgvtI=; b=3X+CWcVCYySg8jDce5nlxpQJKEVfXfo/A2YliG9f8KWfJZDjvbOZEQaIKegn3Yd90E /Z0JZpqTAKRsM8np9VEVV+FajgwoGmTt7khvOjiUBlAjCF080wUU802coC4xx8Hv7xch fRmdRhsi7YGEBEjd+oK2CTI11r7F9fzlwCgbmmJcIlCt6LZosYzFOadZ+iPfu3fP5+i0 yH6aPNRCG6kJRbXPe+JS3Cc38SG2tXYSQyUgJW3V/KrDCRmKdz05kK9FFYVLuxEf0afk 6a6YqGVFP3DfR+HVH4Os3ep5Fo7n9zOW7GtdaS0SmxxnPkFreqZwfLGsN4YtM4kKij78 yWUg== X-Gm-Message-State: AOAM5300mPGZulW7J3hL0FOEA9TlfRv5e/jhqov9LwoNP9FTWoqZNj3A o1sDJcr+n9YQ/8RdAk1UwcbbkecrDqDVAy7xFKQ= X-Google-Smtp-Source: ABdhPJw62GRxn3fgh4jYIH6ReAjWw4cmlN93366LaxhUXSEWJi0XPeiMs4ZWMMxAgZRcKCsz5sMgOPdgs6t0saySy3g= X-Received: by 2002:a17:902:8c93:b0:141:5442:e608 with SMTP id t19-20020a1709028c9300b001415442e608mr33676753plo.32.1635882286012; Tue, 02 Nov 2021 12:44:46 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 12:44:45 -0700 From: Stefan Kangas In-Reply-To: <8335oejrn8.fsf@gnu.org> References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> <18066bc0-86a6-5901-9a53-e2c6ea13fbc8@gmail.com> <8335oejrn8.fsf@gnu.org> MIME-Version: 1.0 Date: Tue, 2 Nov 2021 12:44:45 -0700 Message-ID: Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: >> > If you're the author of a little-known package, you can't really >> > expect theme authors to provide customized icons for your package that >> > fit with the theme. However, themes *do* specify at least a handful of >> > faces. As a package author, it would be convenient to be able to say >> > "render this icon using the foreground color of the `error' face", for >> > example. Then your package looks good with most themes without >> > requiring anyone to provide custom SVGs. >> >> Exactly the point. This goes for built-in packages as well. > > How come built-in packages qualify as "little-known"? They don't. I'm saying that the above points apply whether or not a package is "little-known", "well-known" or even "built-in". From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 16:20:05 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 20:20:06 +0000 Received: from localhost ([127.0.0.1]:38202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mi0GL-0002DW-Le for submit@debbugs.gnu.org; Tue, 02 Nov 2021 16:20:05 -0400 Received: from outbound.soverin.net ([116.202.126.228]:32923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mi0GJ-0002Cs-Ki for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 16:20:04 -0400 Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 77984CE; Tue, 2 Nov 2021 20:19:57 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1635884396; bh=BMlkfjN015ObNTuYqaQ3bEh/GSEZKy6iOnfws6wNihc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KWQlvUS6+bKtnv8GAqIvcV4C3d2USKzbvvhE4MEsOuRiq6yohzjBcE7pjR8CWcBle nReAzeTncliOpWaPkk+VoFgkdsIT6xZMACIgPvXpoDst0GdeX/6LwU6bRsQrWWDhVD 94/0VDBY3y731Nk2dMYF5qVr67AbgKt9cgPLNAUd21uf1f/6EZ9dYCer3Y3HNWedRs CL3RD3+x4UUMwC2TxsrgmB8HBz3tk6+zVY6/8rJJqXOnkNN4q2zDoE6Win+N0fzH2y hKrErNLUsvIpoP+KgYb9tDV3eaZexy1xVieDrvWTPQqVdquUVZHjzWdtox90KaLgSC 7T6DHQbj9sVHw== Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95-RC2) (envelope-from ) id 1mi0G8-0009Zc-1E; Tue, 02 Nov 2021 20:19:52 +0000 Date: Tue, 2 Nov 2021 20:19:52 +0000 From: Alan Third To: Jim Porter Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Message-ID: Mail-Followup-To: Alan Third , Jim Porter , Eli Zaretskii , Stefan Kangas , 51556@debbugs.gnu.org, kevin.legouguec@gmail.com References: <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> <18066bc0-86a6-5901-9a53-e2c6ea13fbc8@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18066bc0-86a6-5901-9a53-e2c6ea13fbc8@gmail.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51556 Cc: 51556@debbugs.gnu.org, Eli Zaretskii , Stefan Kangas , kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, Nov 02, 2021 at 11:43:58AM -0700, Jim Porter wrote: > > 1) Single-color SVGs > > Some SVGs are just a single-color shape, like the Customize arrows. There's > no *particular* color that's right for these, aside from "what looks good". > In some ways, these SVGs are like an ordinary textual glyph, except that > we've defined our own fancy shape to use. In this case, I think it makes > sense to be able to specify what color to use for the SVG independently of > the shape so that themes can adjust it as-needed. > > This case is the one initially described in this bug. This is the case we looked at when we originally replaced the customize widgets with SVGs. At the time we very intentionally removed the colour and size information from the SVG files (checkbox.svg, etc) so that they would match the colours and font size of the surrounding text. I guess, unfortunately, these arrows were missed. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 02 18:56:36 2021 Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 22:56:36 +0000 Received: from localhost ([127.0.0.1]:38289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mi2ho-0006CB-Dy for submit@debbugs.gnu.org; Tue, 02 Nov 2021 18:56:36 -0400 Received: from mail-wm1-f45.google.com ([209.85.128.45]:40554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mi2hn-0006By-9D for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 18:56:35 -0400 Received: by mail-wm1-f45.google.com with SMTP id j128-20020a1c2386000000b003301a98dd62so3148396wmj.5 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 15:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=HB9n5zYGA0dXXpCpyup3WGbzuiW79DYD8IIEbsjoIT4=; b=Ur1iOwZy4Z7505dUBbNrTAcsfMk/suG9X+t5Ib4cZYaC9sINyVSu7Hp6UBDIFFKhg9 hkYG0xGpqP+jVqC2U6N2HPhrecGqakzyVjRmUp7DY9ACYv6YBvxAarU2rw7AEN3y9TyJ qCLhsCvVaxwkjY+npMWVa1r0MCCHH8z0Q2xemQhtFH+X5BVh4ri3gIijef6tGUq/Vcux onvD6Kc9tWYFVhiof0PY0sxKQa+vXt5FDqZR6u8ws1d5ma1dazUnTFau+gxR4OM4rGiu PLJHTJ9h8Tnd1oONSFJMIWDAWRsuCrnq0tPCjDmevnzCiqrpbPRS/G8vHRxtDJgwE9k+ 2SzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=HB9n5zYGA0dXXpCpyup3WGbzuiW79DYD8IIEbsjoIT4=; b=Zgr23ACdo/KFtn3KQBfN8BPlu8dq8tjYUgqew5k1lpOWCpwQsxWG72HVsOcB3TNPFs EMgv4kgpYviGb2MfsZW+0EjQve4/tXIySlf1AkIItKdR4wMtpSOZWGzohDyOvBJBjtkp qlRP5soxO1mLZeb/6WTimP80xob2Y9SXvpU3jObPsgrd/X+xdaBk3YKW4XVw/tk0Mb4u izYzNTzBVwV6IXwAOQXCpjttQAVWwMfSlPrh1p+tADxEDD10fZcJjJ3qhOb7HU9olNSl ZOVmYVlNIG4aevwyMcKfx6YPp+4z4WWzfxwsx8PY0xkrC4o/L4sTzVXY1CiIXEIeHVu4 k+CA== X-Gm-Message-State: AOAM531lktyVoTb2g++Cw74fRUJLC/gAgYo4TjKVEQYa53jWpIKcvX51 df9HwWSDQBnC/hBY+I/h0q9r1/C3L1A= X-Google-Smtp-Source: ABdhPJzJ5H+/o7d7g7SRPgbD+XyHXO56D1/BQymdL9Ic6OUNHR4lE/wWhTn4XPtuCcx/VF5R3VMjSQ== X-Received: by 2002:a05:600c:1d1e:: with SMTP id l30mr7559388wms.65.1635893788967; Tue, 02 Nov 2021 15:56:28 -0700 (PDT) Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id i13sm308360wmq.41.2021.11.02.15.56.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 15:56:28 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Alan Third Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds References: <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> <18066bc0-86a6-5901-9a53-e2c6ea13fbc8@gmail.com> Date: Tue, 02 Nov 2021 23:56:27 +0100 In-Reply-To: (Alan Third's message of "Tue, 2 Nov 2021 20:19:52 +0000") Message-ID: <878ry69nfo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 51556 Cc: Jim Porter , Eli Zaretskii , Stefan Kangas , 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alan Third writes: > This is the case we looked at when we originally replaced the > customize widgets with SVGs. At the time we very intentionally removed > the colour and size information from the SVG files (checkbox.svg, etc) > so that they would match the colours and font size of the surrounding > text. > > I guess, unfortunately, these arrows were missed. Ah, that makes sense; sorry I didn't think of looking at the history of the other icons, I would probably have made a simpler report focusing on the solution that Stefan pushed today, instead of babbling about adding features to the widget code. FWIW, I think your comment reinforces the idea that Stefan's fix belongs on the release branch, but I understand that we all want 28.1 out the door already, so =F0=9F=A4=B7 Thank you all for your help. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 04 04:11:17 2021 Received: (at 51556) by debbugs.gnu.org; 4 Nov 2021 08:11:17 +0000 Received: from localhost ([127.0.0.1]:41934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miXq9-0006R1-0b for submit@debbugs.gnu.org; Thu, 04 Nov 2021 04:11:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miXq7-0006Qo-9w for 51556@debbugs.gnu.org; Thu, 04 Nov 2021 04:11:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miXq0-0005QJ-NQ; Thu, 04 Nov 2021 04:11:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VtWkvxaFhIJruHkM9OLuIU8DKD9IPznnsm+UNK0Jn94=; b=Jtj6XnHFheXK N/fOpbyJatw335kAugbPiu29iEIL+vMmEwphzYzYTjGEayy0T7YyyAtLdNVg5wJ67FVLxF4HQTbXq s2tHg/kWHyajM8FiticWQQBpnbTn9Xxf4tHf3BWCEEqG7kelWKmXpgeKHYsu4Ke7Ng2tPvsaJS6zA 4JqBrluxXQOsxZAmstLMiBVaRJLz2Hlh1SlCm3v1GVmvHMCmAYPhd5d58LOEH7r8hpX1XNfjTQFxb xxlowpUpMectJ7SfSUSV1ZigFn5sW4PcHhA5B6FVYA2e8TJesUnAfy+VH5u6DU5I2tg19Re3W1osH DQh6cXagWGn4wQ+10GFOog==; Received: from [87.69.77.57] (port=1852 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miXq0-0000N1-9X; Thu, 04 Nov 2021 04:11:08 -0400 Date: Thu, 04 Nov 2021 10:11:08 +0200 Message-Id: <83lf24fihv.fsf@gnu.org> From: Eli Zaretskii To: Alan Third In-Reply-To: (message from Alan Third on Tue, 2 Nov 2021 20:19:52 +0000) Subject: Re: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds References: <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> <18066bc0-86a6-5901-9a53-e2c6ea13fbc8@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51556 Cc: jporterbugs@gmail.com, kevin.legouguec@gmail.com, stefan@marxist.se, 51556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 2 Nov 2021 20:19:52 +0000 > From: Alan Third > Cc: Eli Zaretskii , Stefan Kangas , > 51556@debbugs.gnu.org, kevin.legouguec@gmail.com > > On Tue, Nov 02, 2021 at 11:43:58AM -0700, Jim Porter wrote: > > > > 1) Single-color SVGs > > > > Some SVGs are just a single-color shape, like the Customize arrows. There's > > no *particular* color that's right for these, aside from "what looks good". > > In some ways, these SVGs are like an ordinary textual glyph, except that > > we've defined our own fancy shape to use. In this case, I think it makes > > sense to be able to specify what color to use for the SVG independently of > > the shape so that themes can adjust it as-needed. > > > > This case is the one initially described in this bug. > > This is the case we looked at when we originally replaced the > customize widgets with SVGs. At the time we very intentionally removed > the colour and size information from the SVG files (checkbox.svg, etc) > so that they would match the colours and font size of the surrounding > text. > > I guess, unfortunately, these arrows were missed. Thanks. Since these SVG images were missed back then, I've changed my mind about the safety of the change, and cherry-picked the fix to the emacs-28 branch. From unknown Sun Aug 10 09:15:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 02 Dec 2021 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator