Subject: bug#51498: onionshare build is broken

From: raid5atemyhomework <[email-masked]>
Date: Fri, 05 Nov 2021 01:21:17 +0000

>
> Can you test it again? I was able to build it just now with commit
> c0c974ad96767a1e207fe2823cd5479605485415. I was also able to build it
> with your provided commit above.

Having diverging results suggests a nondeterministic build, which is bad, right?  I'm running on a Guix System machine running directly on the metal.

* bad: `guix time-machine --commit=ebc274063716a3a9471f51abb526d693c06b9f63 -- build onionshare`

```
        """
>       tab = self.new_share_tab()

tests/test_gui_share.py:435:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
tests/gui_base_test.py:88: in new_share_tab
    self.verify_new_tab(tab)
tests/gui_base_test.py:80: in verify_new_tab
    self.assertTrue(tab.new_tab.isVisible())
E   AssertionError: False is not true
--------------------------- Captured stdout teardown ---------------------------
[Nov 05 2021 01:00:36 AM] MainWindow.closeEvent
[Nov 05 2021 01:00:36 AM] MainWindow.closeEvent, opening warning dialog
[Nov 05 2021 01:00:37 AM] MainWindow.cleanup
[Nov 05 2021 01:00:37 AM] TabWidget.cleanup
[Nov 05 2021 01:00:37 AM] Tab.cleanup: tab_id=8
[Nov 05 2021 01:00:37 AM] Web.stop: stopping server
[Nov 05 2021 01:00:37 AM] Web.cleanup
[Nov 05 2021 01:00:37 AM] Alert.__init__
[Nov 05 2021 01:00:37 AM] OnionCleanupThread.__init__
[Nov 05 2021 01:00:37 AM] OnionCleanupThread.run
[Nov 05 2021 01:00:37 AM] Onion.cleanup
--------------------------- Captured stderr teardown ---------------------------
This plugin does not support propagateSizeHints()
This plugin does not support propagateSizeHints()
---------------------------- Captured log teardown -----------------------------
INFO     werkzeug:_internal.py:113 127.0.0.1 - - [05/Nov/2021 01:00:37] "GET /hpzwg6jwsaxb4bde4qmlh5emeu/shutdown HTTP/1.1" 200 -
============== 6 failed, 8 passed, 5 skipped in 83.87s (0:01:23) ===============
QThread: Destroyed while thread is still running
Fatal Python error: Aborted

Thread 0x00007fffd77fe700 (most recent call first):
  File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python3.8/zipfile.py", line 1139 in write
  File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python3.8/shutil.py", line 205 in copyfileobj
  File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python3.8/zipfile.py", line 1776 in write
  File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/lib/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 565 in add_file
  File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/lib/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 511 in build_zipfile_list
  File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/lib/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 418 in set_file_info_custom
  File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/lib/python3.8/site-packages/onionshare_cli/web/send_base_mode.py", line 130 in set_file_info
  File "/gnu/store/vz73w4kdk44swsws46kvzvypk2dg6nv3-onionshare-2.3.2/lib/python3.8/site-packages/onionshare/tab/mode/share_mode/threads.py", line 46 in run

Current thread 0x00007ffff785c300 (most recent call first):
<no Python frame>
./tests/run.sh: line 6:    76 Aborted                 pytest -v tests/test_gui_share.py
command "./tests/run.sh" failed with status 134
builder for `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.drv' failed with exit code 1
build of /gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.drv failed
View build log at '/var/log/guix/drvs/nw/m0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.drv.bz2'.
guix build: error: build of `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.drv' failed
```

* bad: `guix time-machine --commit=c0c974ad96767a1e207fe2823cd5479605485415 -- build onionshare`

```
        """
>       tab = self.new_share_tab()

tests/test_gui_share.py:435:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
tests/gui_base_test.py:88: in new_share_tab
    self.verify_new_tab(tab)
tests/gui_base_test.py:80: in verify_new_tab
    self.assertTrue(tab.new_tab.isVisible())
E   AssertionError: False is not true
--------------------------- Captured stdout teardown ---------------------------
[Nov 05 2021 01:08:53 AM] MainWindow.closeEvent
[Nov 05 2021 01:08:53 AM] MainWindow.closeEvent, opening warning dialog
[Nov 05 2021 01:08:53 AM] MainWindow.cleanup
[Nov 05 2021 01:08:53 AM] TabWidget.cleanup
[Nov 05 2021 01:08:53 AM] Tab.cleanup: tab_id=8
[Nov 05 2021 01:08:53 AM] Web.stop: stopping server
[Nov 05 2021 01:08:54 AM] Web.cleanup
[Nov 05 2021 01:08:54 AM] Alert.__init__
[Nov 05 2021 01:08:54 AM] OnionCleanupThread.__init__
[Nov 05 2021 01:08:54 AM] OnionCleanupThread.run
[Nov 05 2021 01:08:54 AM] Onion.cleanup
--------------------------- Captured stderr teardown ---------------------------
This plugin does not support propagateSizeHints()
This plugin does not support propagateSizeHints()
---------------------------- Captured log teardown -----------------------------
INFO     werkzeug:_internal.py:113 127.0.0.1 - - [05/Nov/2021 01:08:53] "GET /jwkuq4zjiyi6o4dw6lz2uqetlu/shutdown HTTP/1.1" 200 -
============== 6 failed, 8 passed, 5 skipped in 83.97s (0:01:23) ===============
QThread: Destroyed while thread is still running
Fatal Python error: Aborted

Thread 0x00007fffdf7fe700 (most recent call first):
  File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python3.8/zipfile.py", line 1139 in write
  File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python3.8/shutil.py", line 205 in copyfileobj
  File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python3.8/zipfile.py", line 1776 in write
  File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/lib/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 565 in add_file
  File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/lib/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 511 in build_zipfile_list
  File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/lib/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 418 in set_file_info_custom
  File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/lib/python3.8/site-packages/onionshare_cli/web/send_base_mode.py", line 130 in set_file_info
  File "/gnu/store/vz73w4kdk44swsws46kvzvypk2dg6nv3-onionshare-2.3.2/lib/python3.8/site-packages/onionshare/tab/mode/share_mode/threads.py", line 46 in run

Current thread 0x00007ffff785c300 (most recent call first):
<no Python frame>
./tests/run.sh: line 6:    76 Aborted                 pytest -v tests/test_gui_share.py
command "./tests/run.sh" failed with status 134
builder for `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.drv' failed with exit code 1
build of /gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.drv failed
View build log at '/var/log/guix/drvs/nw/m0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.drv.bz2'.
guix build: error: build of `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.drv' failed
```

* good: `guix time-machine --commit=c6adc0947396daa6d85ab08837f9cbc86f4d8722 -- build onionshare`
  * result: `/gnu/store/gsi65h1zj2wg8wm7c3jy2p1ac8yyynfs-onionshare-2.3.2`