From unknown Mon Aug 18 06:57:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51498: onionshare build is broken Resent-From: raid5atemyhomework Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 30 Oct 2021 02:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51498 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 51498@debbugs.gnu.org X-Debbugs-Original-To: "bug-guix@gnu.org" Reply-To: raid5atemyhomework Received: via spool by submit@debbugs.gnu.org id=B.163556244825620 (code B ref -1); Sat, 30 Oct 2021 02:55:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Oct 2021 02:54:08 +0000 Received: from localhost ([127.0.0.1]:56389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgeVL-0006ek-FE for submit@debbugs.gnu.org; Fri, 29 Oct 2021 22:54:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:56074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgeVH-0006eY-48 for submit@debbugs.gnu.org; Fri, 29 Oct 2021 22:53:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgeVG-0004GH-AJ for bug-guix@gnu.org; Fri, 29 Oct 2021 22:53:54 -0400 Received: from mail-4318.protonmail.ch ([185.70.43.18]:33633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgeVE-0003PH-De for bug-guix@gnu.org; Fri, 29 Oct 2021 22:53:54 -0400 Date: Sat, 30 Oct 2021 02:53:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1635562421; bh=jhPXaSP4jCuHLbyBYOUqgQi6LCZjBhA886j4sRAOjjM=; h=Date:To:From:Reply-To:Subject:From; b=knhx8V2SvGsDI2povbvS1XKNRsfzMkdjK8qpVehhmQ4wg7u+5pXTJ+M4aVYoXuLyO fvWewHltRbt/s4/ec0pPiMU9GsDr0qCuUjvZmmUJvh+0qoC4kkyYQwB8tz3UGYwxSx sdXzN0w/MS5Y8fGsEK/bci/x34/KApVVAlYR/Q9U= From: raid5atemyhomework Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.43.18; envelope-from=raid5atemyhomework@protonmail.com; helo=mail-4318.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) onionshare is broken on master 89d8417; `guix time-machine --commit=3D89d84= 17b371f3918f0508bbc561675ec100a6add -- build onionshare` results in: ``` _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _= _ _ tests/gui_base_test.py:88: in new_share_tab self.verify_new_tab(tab) tests/gui_base_test.py:80: in verify_new_tab self.assertTrue(tab.new_tab.isVisible()) E AssertionError: False is not true --------------------------- Captured stdout teardown ----------------------= ----- [Oct 28 2021 04:36:21 AM] MainWindow.closeEvent [Oct 28 2021 04:36:21 AM] MainWindow.closeEvent, opening warning dialog [Oct 28 2021 04:36:21 AM] MainWindow.cleanup [Oct 28 2021 04:36:21 AM] TabWidget.cleanup [Oct 28 2021 04:36:21 AM] Tab.cleanup: tab_id=3D8 [Oct 28 2021 04:36:21 AM] Web.stop: stopping server [Oct 28 2021 04:36:22 AM] Web.cleanup [Oct 28 2021 04:36:22 AM] Alert.__init__ [Oct 28 2021 04:36:22 AM] OnionCleanupThread.__init__ [Oct 28 2021 04:36:22 AM] OnionCleanupThread.run [Oct 28 2021 04:36:22 AM] Onion.cleanup --------------------------- Captured stderr teardown ----------------------= ----- This plugin does not support propagateSizeHints() This plugin does not support propagateSizeHints() ---------------------------- Captured log teardown ------------------------= ----- INFO werkzeug:_internal.py:113 127.0.0.1 - - [28/Oct/2021 04:36:21] "GE= T /3x7qnpxrxhm3w7pzdxxfntvsvq/shutdown HTTP/1.1" 200 - =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 6 failed, 8 passed, 5 skipped in= 83.88s (0:01:23) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D QThread: Destroyed while thread is still running Fatal Python error: Aborted Thread 0x00007fffd77fe700 (most recent call first): File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python= 3.8/zipfile.py", line 1139 in write File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python= 3.8/shutil.py", line 205 in copyfileobj File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python= 3.8/zipfile.py", line 1776 in write File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 565 in ad= d_file File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 511 in bu= ild_zipfile_list File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 418 in se= t_file_info_custom File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/send_base_mode.py", line 130 i= n set_file_info File "/gnu/store/vz73w4kdk44swsws46kvzvypk2dg6nv3-onionshare-2.3.2/lib/py= thon3.8/site-packages/onionshare/tab/mode/share_mode/threads.py", line 46 i= n run Current thread 0x00007ffff785c300 (most recent call first): ./tests/run.sh: line 6: 76 Aborted pytest -v tests/test_= gui_share.py command "./tests/run.sh" failed with status 134 builder for `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.d= rv' failed with exit code 1 build of /gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.drv f= ailed View build log at '/var/log/guix/drvs/nw/m0wl6ilxgaqwl331fmp3ggxgh706a5-oni= onshare-2.3.2.drv.bz2'. guix build: error: build of `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-on= ionshare-2.3.2.drv' failed ``` Doing a `git bisect` got me to this: * bad: `guix time-machine --commit=3Debc274063716a3a9471f51abb526d693c06b9f= 63 -- build onionshare` * good: `guix time-machine --commit=3Dc6adc0947396daa6d85ab08837f9cbc86f4d8= 722 -- build onionshare` * result: `/gnu/store/gsi65h1zj2wg8wm7c3jy2p1ac8yyynfs-onionshare-2.3.2` However the bad commit seems to be just an update on `tor` version; I am no= t certain why it would cause this build failure. Thanks, raid5atemyhomework From unknown Mon Aug 18 06:57:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51498: onionshare build is broken References: In-Reply-To: Resent-From: raid5atemyhomework Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 30 Oct 2021 03:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51498 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: "51498@debbugs.gnu.org" <51498@debbugs.gnu.org> Cc: Tobias Geerinckx-Rice Reply-To: raid5atemyhomework Received: via spool by 51498-submit@debbugs.gnu.org id=B51498.163556312826861 (code B ref 51498); Sat, 30 Oct 2021 03:06:01 +0000 Received: (at 51498) by debbugs.gnu.org; 30 Oct 2021 03:05:28 +0000 Received: from localhost ([127.0.0.1]:56420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgegS-0006zB-Dz for submit@debbugs.gnu.org; Fri, 29 Oct 2021 23:05:28 -0400 Received: from mail-4324.protonmail.ch ([185.70.43.24]:62705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgegP-0006yu-DW for 51498@debbugs.gnu.org; Fri, 29 Oct 2021 23:05:27 -0400 Date: Sat, 30 Oct 2021 03:05:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1635563118; bh=mA0VHjViae3oKHAWIyVgnOvhD0iBCjVla5jmRbBalu8=; h=Date:To:From:Cc:Reply-To:Subject:From; b=RqZh/2cg8mmOBfRfyzA+5ZQP+0GmDfzy4iiCgK57VR2CIO0W/CU4uF+Z8e2ycE/PU OU+qQOIQ4P/6Z/rdbtWq3+yhdnpm/Y7C8ycglny7WVBdvx6S3RZB4ZJv67kY6As+ps xpwP0MeU8q4Mt0258AWYqHACA3xBeKbBMthPD8s0= From: raid5atemyhomework Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) CC Tobias From unknown Mon Aug 18 06:57:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51498: onionshare build is broken Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 01 Nov 2021 10:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51498 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: raid5atemyhomework Cc: 51498@debbugs.gnu.org Received: via spool by 51498-submit@debbugs.gnu.org id=B51498.16357631096473 (code B ref 51498); Mon, 01 Nov 2021 10:39:01 +0000 Received: (at 51498) by debbugs.gnu.org; 1 Nov 2021 10:38:29 +0000 Received: from localhost ([127.0.0.1]:33788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhUhp-0001gD-OT for submit@debbugs.gnu.org; Mon, 01 Nov 2021 06:38:29 -0400 Received: from flashner.co.il ([178.62.234.194]:48994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhUhm-0001fz-KU for 51498@debbugs.gnu.org; Mon, 01 Nov 2021 06:38:19 -0400 Received: from localhost (unknown [141.226.169.107]) by flashner.co.il (Postfix) with ESMTPSA id 302F540277; Mon, 1 Nov 2021 10:38:12 +0000 (UTC) Date: Mon, 1 Nov 2021 12:37:39 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , raid5atemyhomework , 51498@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zrnFENXyWLDe7VRC" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --zrnFENXyWLDe7VRC Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 30, 2021 at 02:53:28AM +0000, raid5atemyhomework via Bug report= s for GNU Guix wrote: > onionshare is broken on master 89d8417; `guix time-machine --commit=3D89d= 8417b371f3918f0508bbc561675ec100a6add -- build onionshare` results in: >=20 >=20 > ``` > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _= _ _ _ > tests/gui_base_test.py:88: in new_share_tab > self.verify_new_tab(tab) > tests/gui_base_test.py:80: in verify_new_tab > self.assertTrue(tab.new_tab.isVisible()) > E AssertionError: False is not true > --------------------------- Captured stdout teardown --------------------= ------- > [Oct 28 2021 04:36:21 AM] MainWindow.closeEvent > [Oct 28 2021 04:36:21 AM] MainWindow.closeEvent, opening warning dialog > [Oct 28 2021 04:36:21 AM] MainWindow.cleanup > [Oct 28 2021 04:36:21 AM] TabWidget.cleanup > [Oct 28 2021 04:36:21 AM] Tab.cleanup: tab_id=3D8 > [Oct 28 2021 04:36:21 AM] Web.stop: stopping server > [Oct 28 2021 04:36:22 AM] Web.cleanup > [Oct 28 2021 04:36:22 AM] Alert.__init__ > [Oct 28 2021 04:36:22 AM] OnionCleanupThread.__init__ > [Oct 28 2021 04:36:22 AM] OnionCleanupThread.run > [Oct 28 2021 04:36:22 AM] Onion.cleanup > --------------------------- Captured stderr teardown --------------------= ------- > This plugin does not support propagateSizeHints() > This plugin does not support propagateSizeHints() > ---------------------------- Captured log teardown ----------------------= ------- > INFO werkzeug:_internal.py:113 127.0.0.1 - - [28/Oct/2021 04:36:21] "= GET /3x7qnpxrxhm3w7pzdxxfntvsvq/shutdown HTTP/1.1" 200 - > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 6 failed, 8 passed, 5 skipped = in 83.88s (0:01:23) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > QThread: Destroyed while thread is still running > Fatal Python error: Aborted >=20 > Thread 0x00007fffd77fe700 (most recent call first): > File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/pyth= on3.8/zipfile.py", line 1139 in write > File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/pyth= on3.8/shutil.py", line 205 in copyfileobj > File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/pyth= on3.8/zipfile.py", line 1776 in write > File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/= lib/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 565 in = add_file > File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/= lib/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 511 in = build_zipfile_list > File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/= lib/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 418 in = set_file_info_custom > File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/= lib/python3.8/site-packages/onionshare_cli/web/send_base_mode.py", line 130= in set_file_info > File "/gnu/store/vz73w4kdk44swsws46kvzvypk2dg6nv3-onionshare-2.3.2/lib/= python3.8/site-packages/onionshare/tab/mode/share_mode/threads.py", line 46= in run >=20 > Current thread 0x00007ffff785c300 (most recent call first): > > ./tests/run.sh: line 6: 76 Aborted pytest -v tests/tes= t_gui_share.py > command "./tests/run.sh" failed with status 134 > builder for `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2= =2Edrv' failed with exit code 1 > build of /gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.drv= failed > View build log at '/var/log/guix/drvs/nw/m0wl6ilxgaqwl331fmp3ggxgh706a5-o= nionshare-2.3.2.drv.bz2'. > guix build: error: build of `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-= onionshare-2.3.2.drv' failed > ``` >=20 > Doing a `git bisect` got me to this: >=20 > * bad: `guix time-machine --commit=3Debc274063716a3a9471f51abb526d693c06b= 9f63 -- build onionshare` > * good: `guix time-machine --commit=3Dc6adc0947396daa6d85ab08837f9cbc86f4= d8722 -- build onionshare` > * result: `/gnu/store/gsi65h1zj2wg8wm7c3jy2p1ac8yyynfs-onionshare-2.3.2` >=20 > However the bad commit seems to be just an update on `tor` version; I am = not certain why it would cause this build failure. >=20 > Thanks, > raid5atemyhomework Can you test it again? I was able to build it just now with commit c0c974ad96767a1e207fe2823cd5479605485415. I was also able to build it with your provided commit above. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --zrnFENXyWLDe7VRC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmF/w3EACgkQQarn3Mo9 g1HwUw//a0yJYjSZo/VCcMkaHCWsOCW3uClxAdsA7230qvmNYbC4mbFG/7iARddO EDnjvrLQ8zLZvGRXzUHcYiGdbxyRiiQdgulRjNVmVPPoZWMtiwt5W2BYY9ab+KHU 6nxkPWySZ09PrS85CBIe1TdqEbuD+d3Y/Ht7MmUvBI8S/xE+JHYz0f5yzj0Kqpxn wmH3GjS8u5ebNxYOVTvyHKeBA7vhkf934vn3CX2GU6vum6ObopLjUmLQ3U25Er89 zIxHJxCJp7aDriuCaRMWY46DZ+Bbvh7zjxNg9C16ZkY57WBGHxQpoXQzNrZgAffB yavlej43ZF4lixIfauzKn2iLHdnZ4upitgjO5nxJ0GhpppleyZf1BXfYIZi2ZETH rhWQEamyufX1uztUIT1by4U+0s0SfsqlTD8i9nCe/ZSURwYcd27IwP/UjKVpejP+ BLMeTghZCDL0uPLOpNVtm3eLXjfnBvC43E4Kqx1ScEfQeCB26iwSV3tSTCEYtmQ7 +I3UpnvDJ4Pf1ydexJDsZMmsELfuTqyzlGevkFksGqqCBEPP/x6x4CWWhrFdj33c A8CwhU+f7rBi0GNWjym5Dk7DLODddp2L5GZ999A9BCv8tKuYQCGMD3oloc7J7dMJ n6yejGrSc83Gx83EF869IG5+nvUv33lm/C9q6qISnJ8gZSkF77E= =6H7v -----END PGP SIGNATURE----- --zrnFENXyWLDe7VRC-- From unknown Mon Aug 18 06:57:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51498: onionshare build is broken Resent-From: raid5atemyhomework Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 05 Nov 2021 01:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51498 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Efraim Flashner Cc: "51498@debbugs.gnu.org" <51498@debbugs.gnu.org> Reply-To: raid5atemyhomework Received: via spool by 51498-submit@debbugs.gnu.org id=B51498.163607530912536 (code B ref 51498); Fri, 05 Nov 2021 01:22:02 +0000 Received: (at 51498) by debbugs.gnu.org; 5 Nov 2021 01:21:49 +0000 Received: from localhost ([127.0.0.1]:43980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1minvI-0003Fp-Hu for submit@debbugs.gnu.org; Thu, 04 Nov 2021 21:21:48 -0400 Received: from mail-4325.protonmail.ch ([185.70.43.25]:36757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1minvG-0003Fb-IM for 51498@debbugs.gnu.org; Thu, 04 Nov 2021 21:21:39 -0400 Date: Fri, 05 Nov 2021 01:21:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1636075284; bh=Zm2uBsHa8DHIFv3ClSNOYnGadpxsDnsbm9iwfHX9q4E=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=mA4HcMwOKOLyj42XtvpnEcCe9fYm85Pn6S0Ci1DezMxnS6A3SsT3hNyPROa/Mbc2+ R4jW7HBOjXlNJT4qzxtTuktuc4XW+zYrsE4cT9SUe41VAPqz188/n7q9vdtlhq9huk nb4AncMdcPSjqyy7aQ+S8hmdxnE+uMfATwjuzocw= From: raid5atemyhomework Message-ID: <92qiop_y9j0qwdLooBRmFS2c4LIcTWyH12TZ7li1isQfez4ntpPdkLmBdH5p0dtF0T4xgUB6D0FIdbGDOXVWz5HHdFlxHgxXMZ2TxUPxU7I=@protonmail.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Can you test it again? I was able to build it just now with commit > c0c974ad96767a1e207fe2823cd5479605485415. I was also able to build it > with your provided commit above. Having diverging results suggests a nondeterministic build, which is bad, r= ight? I'm running on a Guix System machine running directly on the metal. * bad: `guix time-machine --commit=3Debc274063716a3a9471f51abb526d693c06b9f= 63 -- build onionshare` ``` """ > tab =3D self.new_share_tab() tests/test_gui_share.py:435: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _= _ _ tests/gui_base_test.py:88: in new_share_tab self.verify_new_tab(tab) tests/gui_base_test.py:80: in verify_new_tab self.assertTrue(tab.new_tab.isVisible()) E AssertionError: False is not true --------------------------- Captured stdout teardown ----------------------= ----- [Nov 05 2021 01:00:36 AM] MainWindow.closeEvent [Nov 05 2021 01:00:36 AM] MainWindow.closeEvent, opening warning dialog [Nov 05 2021 01:00:37 AM] MainWindow.cleanup [Nov 05 2021 01:00:37 AM] TabWidget.cleanup [Nov 05 2021 01:00:37 AM] Tab.cleanup: tab_id=3D8 [Nov 05 2021 01:00:37 AM] Web.stop: stopping server [Nov 05 2021 01:00:37 AM] Web.cleanup [Nov 05 2021 01:00:37 AM] Alert.__init__ [Nov 05 2021 01:00:37 AM] OnionCleanupThread.__init__ [Nov 05 2021 01:00:37 AM] OnionCleanupThread.run [Nov 05 2021 01:00:37 AM] Onion.cleanup --------------------------- Captured stderr teardown ----------------------= ----- This plugin does not support propagateSizeHints() This plugin does not support propagateSizeHints() ---------------------------- Captured log teardown ------------------------= ----- INFO werkzeug:_internal.py:113 127.0.0.1 - - [05/Nov/2021 01:00:37] "GE= T /hpzwg6jwsaxb4bde4qmlh5emeu/shutdown HTTP/1.1" 200 - =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 6 failed, 8 passed, 5 skipped in= 83.87s (0:01:23) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D QThread: Destroyed while thread is still running Fatal Python error: Aborted Thread 0x00007fffd77fe700 (most recent call first): File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python= 3.8/zipfile.py", line 1139 in write File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python= 3.8/shutil.py", line 205 in copyfileobj File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python= 3.8/zipfile.py", line 1776 in write File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 565 in ad= d_file File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 511 in bu= ild_zipfile_list File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 418 in se= t_file_info_custom File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/send_base_mode.py", line 130 i= n set_file_info File "/gnu/store/vz73w4kdk44swsws46kvzvypk2dg6nv3-onionshare-2.3.2/lib/py= thon3.8/site-packages/onionshare/tab/mode/share_mode/threads.py", line 46 i= n run Current thread 0x00007ffff785c300 (most recent call first): ./tests/run.sh: line 6: 76 Aborted pytest -v tests/test_= gui_share.py command "./tests/run.sh" failed with status 134 builder for `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.d= rv' failed with exit code 1 build of /gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.drv f= ailed View build log at '/var/log/guix/drvs/nw/m0wl6ilxgaqwl331fmp3ggxgh706a5-oni= onshare-2.3.2.drv.bz2'. guix build: error: build of `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-on= ionshare-2.3.2.drv' failed ``` * bad: `guix time-machine --commit=3Dc0c974ad96767a1e207fe2823cd54796054854= 15 -- build onionshare` ``` """ > tab =3D self.new_share_tab() tests/test_gui_share.py:435: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _= _ _ tests/gui_base_test.py:88: in new_share_tab self.verify_new_tab(tab) tests/gui_base_test.py:80: in verify_new_tab self.assertTrue(tab.new_tab.isVisible()) E AssertionError: False is not true --------------------------- Captured stdout teardown ----------------------= ----- [Nov 05 2021 01:08:53 AM] MainWindow.closeEvent [Nov 05 2021 01:08:53 AM] MainWindow.closeEvent, opening warning dialog [Nov 05 2021 01:08:53 AM] MainWindow.cleanup [Nov 05 2021 01:08:53 AM] TabWidget.cleanup [Nov 05 2021 01:08:53 AM] Tab.cleanup: tab_id=3D8 [Nov 05 2021 01:08:53 AM] Web.stop: stopping server [Nov 05 2021 01:08:54 AM] Web.cleanup [Nov 05 2021 01:08:54 AM] Alert.__init__ [Nov 05 2021 01:08:54 AM] OnionCleanupThread.__init__ [Nov 05 2021 01:08:54 AM] OnionCleanupThread.run [Nov 05 2021 01:08:54 AM] Onion.cleanup --------------------------- Captured stderr teardown ----------------------= ----- This plugin does not support propagateSizeHints() This plugin does not support propagateSizeHints() ---------------------------- Captured log teardown ------------------------= ----- INFO werkzeug:_internal.py:113 127.0.0.1 - - [05/Nov/2021 01:08:53] "GE= T /jwkuq4zjiyi6o4dw6lz2uqetlu/shutdown HTTP/1.1" 200 - =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 6 failed, 8 passed, 5 skipped in= 83.97s (0:01:23) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D QThread: Destroyed while thread is still running Fatal Python error: Aborted Thread 0x00007fffdf7fe700 (most recent call first): File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python= 3.8/zipfile.py", line 1139 in write File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python= 3.8/shutil.py", line 205 in copyfileobj File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python= 3.8/zipfile.py", line 1776 in write File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 565 in ad= d_file File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 511 in bu= ild_zipfile_list File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 418 in se= t_file_info_custom File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/send_base_mode.py", line 130 i= n set_file_info File "/gnu/store/vz73w4kdk44swsws46kvzvypk2dg6nv3-onionshare-2.3.2/lib/py= thon3.8/site-packages/onionshare/tab/mode/share_mode/threads.py", line 46 i= n run Current thread 0x00007ffff785c300 (most recent call first): ./tests/run.sh: line 6: 76 Aborted pytest -v tests/test_= gui_share.py command "./tests/run.sh" failed with status 134 builder for `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.d= rv' failed with exit code 1 build of /gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.drv f= ailed View build log at '/var/log/guix/drvs/nw/m0wl6ilxgaqwl331fmp3ggxgh706a5-oni= onshare-2.3.2.drv.bz2'. guix build: error: build of `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-on= ionshare-2.3.2.drv' failed ``` * good: `guix time-machine --commit=3Dc6adc0947396daa6d85ab08837f9cbc86f4d8= 722 -- build onionshare` * result: `/gnu/store/gsi65h1zj2wg8wm7c3jy2p1ac8yyynfs-onionshare-2.3.2` From unknown Mon Aug 18 06:57:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#51498: onionshare build is broken Resent-From: raid5atemyhomework Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 05 Nov 2021 01:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51498 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Efraim Flashner Cc: "51498@debbugs.gnu.org" <51498@debbugs.gnu.org> Reply-To: raid5atemyhomework Received: via spool by 51498-submit@debbugs.gnu.org id=B51498.163607589413594 (code B ref 51498); Fri, 05 Nov 2021 01:32:01 +0000 Received: (at 51498) by debbugs.gnu.org; 5 Nov 2021 01:31:34 +0000 Received: from localhost ([127.0.0.1]:44005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mio4s-0003XB-65 for submit@debbugs.gnu.org; Thu, 04 Nov 2021 21:31:34 -0400 Received: from mail-4324.protonmail.ch ([185.70.43.24]:29207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mio4q-0003Ww-HA for 51498@debbugs.gnu.org; Thu, 04 Nov 2021 21:31:33 -0400 Date: Fri, 05 Nov 2021 01:31:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1636075885; bh=YVl5o64wLoE9yYvnWFbPzfu5Heym2h6S/TGzR6LcDNw=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=PQzTyndLk4UYBSVY8smjzIJJ1jmkU/UN4f7vQ0amoUVwIHXX/LbQ77s8Tz+38bcBv w9r0Y3R60NzGQOYl67DW07r1GVntvD/6eeKG44tv/uGIMq3F6yshjepU2ilfwfI1dh KmZI2j1+srtMMWJw/iCVe/D2iWsFcQ48ca6aAWWY= From: raid5atemyhomework Message-ID: <71NrR9CIatwqC45LYY-6AWdyugCrijO3vc409GY_eDSCIg9wnzFAE3CerYB3r0zkY16fwraexVge-RKIQPquf0cDHrFRfnXHMGrEdfKAqh0=@protonmail.com> In-Reply-To: <92qiop_y9j0qwdLooBRmFS2c4LIcTWyH12TZ7li1isQfez4ntpPdkLmBdH5p0dtF0T4xgUB6D0FIdbGDOXVWz5HHdFlxHgxXMZ2TxUPxU7I=@protonmail.com> References: <92qiop_y9j0qwdLooBRmFS2c4LIcTWyH12TZ7li1isQfez4ntpPdkLmBdH5p0dtF0T4xgUB6D0FIdbGDOXVWz5HHdFlxHgxXMZ2TxUPxU7I=@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Can you test it again? I was able to build it just now with commit > > c0c974ad96767a1e207fe2823cd5479605485415. I was also able to build it > > with your provided commit above. > > Having diverging results suggests a nondeterministic build, which is bad,= right? I'm running on a Guix System machine running directly on the metal. On a Guix on top of a foreign distro, I got: * good: `guix time-machine --commit=3Debc274063716a3a9471f51abb526d693c06b9= f63 -- build onionshare` * result: `/gnu/store/ynkjlqh9sjr72blfvvxrj86cgjpa270l-onionshare-2.3.2` Looks like nondeterminism? On the machine where the build is failing, this is the stanza where the tes= ts start going wrong: ``` tests/test_gui_share.py::TestShare::test_401_public_skips_ratelimit PASSED = [ 5%] tests/test_gui_share.py::TestShare::test_401_triggers_ratelimit PASSED [ = 10%] tests/test_gui_share.py::TestShare::test_405_page_returned_for_invalid_meth= ods PASSED [ 15%] tests/test_gui_share.py::TestShare::test_autostart_and_autostop_timer_misma= tch SKIPPED [ 21%] tests/test_gui_share.py::TestShare::test_autostart_timer SKIPPED [ = 26%] tests/test_gui_share.py::TestShare::test_autostart_timer_cancel PASSED [ = 31%] tests/test_gui_share.py::TestShare::test_autostart_timer_too_short SKIPPED = [ 36%] tests/test_gui_share.py::TestShare::test_autostop_timer SKIPPED [ = 42%] tests/test_gui_share.py::TestShare::test_autostop_timer_too_short SKIPPED [= 47%] tests/test_gui_share.py::TestShare::test_clear_all_history_button PASSED [ = 52%] tests/test_gui_share.py::TestShare::test_download PASSED [ = 57%] tests/test_gui_share.py::TestShare::test_individual_files PASSED [ = 63%] tests/test_gui_share.py::TestShare::test_individual_files_without_autostop_= sharing PASSED [ 68%] tests/test_gui_share.py::TestShare::test_large_download FAILED [ = 73%] tests/test_gui_share.py::TestShare::test_persistent_password FAILED [ = 78%] tests/test_gui_share.py::TestShare::test_public_mode FAILED [ = 84%] tests/test_gui_share.py::TestShare::test_remove_all_file_selection_button F= AILED [ 89%] tests/test_gui_share.py::TestShare::test_unreadable_file FAILED [ = 94%] tests/test_gui_share.py::TestShare::test_without_autostop_sharing FAILED [1= 00%] ``` Build log github gist: https://gist.github.com/raid5atemyhomework/113e4860b= 359ab70637eedc032648d3b Thanks raid5atemyhomework From unknown Mon Aug 18 06:57:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: raid5atemyhomework Subject: bug#51498: closed (Re: bug#51498: onionshare build is broken) Message-ID: References: <87k08j9e46.fsf@gmail.com> X-Gnu-PR-Message: they-closed 51498 X-Gnu-PR-Package: guix Reply-To: 51498@debbugs.gnu.org Date: Tue, 12 Jul 2022 03:59:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1657598342-20436-1" This is a multi-part message in MIME format... ------------=_1657598342-20436-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #51498: onionshare build is broken which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 51498@debbugs.gnu.org. --=20 51498: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D51498 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1657598342-20436-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 51498-done) by debbugs.gnu.org; 12 Jul 2022 03:58:12 +0000 Received: from localhost ([127.0.0.1]:41398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oB72J-0005IJ-Cz for submit@debbugs.gnu.org; Mon, 11 Jul 2022 23:58:12 -0400 Received: from mail-qt1-f178.google.com ([209.85.160.178]:39739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oB72H-0005I2-G3 for 51498-done@debbugs.gnu.org; Mon, 11 Jul 2022 23:58:10 -0400 Received: by mail-qt1-f178.google.com with SMTP id r17so5982640qtx.6 for <51498-done@debbugs.gnu.org>; Mon, 11 Jul 2022 20:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9VVbu+YkHOXROPIwP4s2u0ULVjtt1SLtgI8MDjJMxyU=; b=q4kLxtfUC1ChfXALiwvATf8hQzskf2FgDx+xV8f3hD/W/piZmsrvhAEeTMCIWTOlIH TdYdbGnZPEA8k25xn8ObDWt3zHSNkVZ1iu5q4SymKzLQzv7JYKgri+BQox7BRAUOe7Is T462Ab68v+CwymMtflIRD8B37i7Tay7iLUg/TFtahL4qlZQ+QxeWT3S3a3xpO/ckVJLL w18VZIlehLHyDMm0o2xBIag8xaHxG62VhSuRx2ljrUYIb+rEqgiPx/Jord042aNvqhiz /FMU8ZiCsXMXI1t4vqk55SeDVg/Zc03hYdCCedrCdmafPNRuPvulIvk/sP2na2dxsjW8 vWfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9VVbu+YkHOXROPIwP4s2u0ULVjtt1SLtgI8MDjJMxyU=; b=Nr3ny31hALrOwbnnAzydD76B2jBS1tda7EFabL7CaH+AInFaco0u2QXH3lJUwqeuht r1vvTnLvhyUmUp2vyFQUSe7pbb2J89jGBGK0Py6nWYYv6W1dXiD0PNyOO7RFvXvgcTts SZs9xMAvHMg+WI0tub+COOdLH+mnd5lOAJDUp6Vry94D9QyYKXGa8lXV8IkHQfs1zZVz Z88hNcsAMkTG08zdKM5LtITkz0d3+rqHlQa/v333dLGSNsVKLURrAxz1umeIZJe4Lv/c voShEiyzuKxzFFY02hRIrRH/ikGuITmg5XuhV/rWBXinrH+I2Po2uPTFC3vWllDweE21 9g0w== X-Gm-Message-State: AJIora9z6N698JY7EKeMckCj1KvpbMWkYEeUylWZ1wKbqiyLXFYHCnl7 nmLXjFfzsyUymKkpEwUIrF+ppzpvtsG/0ZR2 X-Google-Smtp-Source: AGRyM1s20QUc0/iIQMi9k6KTn7Bqh9IV5KGNZKZppAEFr86qJujsEaDW4CCn+PYkqJZHMrP51GZ8iw== X-Received: by 2002:ac8:5c47:0:b0:31e:a9b9:822a with SMTP id j7-20020ac85c47000000b0031ea9b9822amr13393521qtj.250.1657598283428; Mon, 11 Jul 2022 20:58:03 -0700 (PDT) Received: from hurd (dsl-155-226.b2b2c.ca. [66.158.155.226]) by smtp.gmail.com with ESMTPSA id br15-20020a05620a460f00b006af290182c8sm8067728qkb.86.2022.07.11.20.58.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 20:58:02 -0700 (PDT) From: Maxim Cournoyer To: raid5atemyhomework Subject: Re: bug#51498: onionshare build is broken References: <92qiop_y9j0qwdLooBRmFS2c4LIcTWyH12TZ7li1isQfez4ntpPdkLmBdH5p0dtF0T4xgUB6D0FIdbGDOXVWz5HHdFlxHgxXMZ2TxUPxU7I=@protonmail.com> <71NrR9CIatwqC45LYY-6AWdyugCrijO3vc409GY_eDSCIg9wnzFAE3CerYB3r0zkY16fwraexVge-RKIQPquf0cDHrFRfnXHMGrEdfKAqh0=@protonmail.com> Date: Mon, 11 Jul 2022 23:58:01 -0400 In-Reply-To: <71NrR9CIatwqC45LYY-6AWdyugCrijO3vc409GY_eDSCIg9wnzFAE3CerYB3r0zkY16fwraexVge-RKIQPquf0cDHrFRfnXHMGrEdfKAqh0=@protonmail.com> (raid5atemyhomework@protonmail.com's message of "Fri, 05 Nov 2021 01:31:24 +0000") Message-ID: <87k08j9e46.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 51498-done Cc: Efraim Flashner , "51498@debbugs.gnu.org" <51498-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, raid5atemyhomework writes: >> > Can you test it again? I was able to build it just now with commit >> > c0c974ad96767a1e207fe2823cd5479605485415. I was also able to build it >> > with your provided commit above. >> >> Having diverging results suggests a nondeterministic build, which is >> bad, right? I'm running on a Guix System machine running directly on >> the metal. > > On a Guix on top of a foreign distro, I got: > > * good: `guix time-machine --commit=ebc274063716a3a9471f51abb526d693c06b9f63 -- build onionshare` > * result: `/gnu/store/ynkjlqh9sjr72blfvvxrj86cgjpa270l-onionshare-2.3.2` > > Looks like nondeterminism? > > On the machine where the build is failing, this is the stanza where the tests start going wrong: > > ``` > tests/test_gui_share.py::TestShare::test_401_public_skips_ratelimit PASSED [ 5%] > tests/test_gui_share.py::TestShare::test_401_triggers_ratelimit PASSED [ 10%] > tests/test_gui_share.py::TestShare::test_405_page_returned_for_invalid_methods PASSED [ 15%] > tests/test_gui_share.py::TestShare::test_autostart_and_autostop_timer_mismatch SKIPPED [ 21%] > tests/test_gui_share.py::TestShare::test_autostart_timer SKIPPED [ 26%] > tests/test_gui_share.py::TestShare::test_autostart_timer_cancel PASSED [ 31%] > tests/test_gui_share.py::TestShare::test_autostart_timer_too_short SKIPPED [ 36%] > tests/test_gui_share.py::TestShare::test_autostop_timer SKIPPED [ 42%] > tests/test_gui_share.py::TestShare::test_autostop_timer_too_short SKIPPED [ 47%] > tests/test_gui_share.py::TestShare::test_clear_all_history_button PASSED [ 52%] > tests/test_gui_share.py::TestShare::test_download PASSED [ 57%] > tests/test_gui_share.py::TestShare::test_individual_files PASSED [ 63%] > tests/test_gui_share.py::TestShare::test_individual_files_without_autostop_sharing PASSED [ 68%] > tests/test_gui_share.py::TestShare::test_large_download FAILED [ 73%] > tests/test_gui_share.py::TestShare::test_persistent_password FAILED [ 78%] > tests/test_gui_share.py::TestShare::test_public_mode FAILED [ 84%] > tests/test_gui_share.py::TestShare::test_remove_all_file_selection_button FAILED [ 89%] > tests/test_gui_share.py::TestShare::test_unreadable_file FAILED [ 94%] > tests/test_gui_share.py::TestShare::test_without_autostop_sharing FAILED [100%] > ``` I was able to reproduce the nondeterministic failure; on my system it gave: --8<---------------cut here---------------start------------->8--- =================================== FAILURES =================================== ________________________ TestShare.test_large_download _________________________ self = def test_large_download(self): """ Test a large download """ tab = self.new_share_tab() self.run_all_common_setup_tests() self.run_all_share_mode_setup_tests(tab) tab.get_mode().server_status.file_selection.file_list.add_file( self.tmpfile_large ) > self.run_all_share_mode_started_tests(tab, startup_time=15000) tests/test_gui_share.py:432: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ tests/test_gui_share.py:183: in run_all_share_mode_started_tests self.server_is_started(tab, startup_time) tests/gui_base_test.py:249: in server_is_started self.assertEqual(tab.get_mode().server_status.status, 2) E AssertionError: 1 != 2 ----------------------------- Captured stdout call ----------------------------- [Jul 11 2022 10:05:58 PM] Tab.share_mode_clicked [Jul 11 2022 10:05:58 PM] Web.__init__: is_gui=True, mode=share [Jul 11 2022 10:05:58 PM] Common.get_resource_path: filename=static [Jul 11 2022 10:05:58 PM] Common.get_resource_path: filename=static, path=/gnu/store/dg59r5qmksn2llkbqxbzj4zw3xvcfppp-onionshare-cli-2.4/lib/python3.9/site-packages/onionshare_cli/resources/static [Jul 11 2022 10:05:58 PM] Common.get_resource_path: filename=templates [Jul 11 2022 10:05:58 PM] Common.get_resource_path: filename=templates, path=/gnu/store/dg59r5qmksn2llkbqxbzj4zw3xvcfppp-onionshare-cli-2.4/lib/python3.9/site-packages/onionshare_cli/resources/templates [Jul 11 2022 10:05:58 PM] Web.generate_static_url_path: new static_url_path is /static_uosd2rkf6txcyiop4jrurdpxtu [Jul 11 2022 10:05:58 PM] ShareModeWeb.init [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = [] [Jul 11 2022 10:05:58 PM] ServerStatus.update [Jul 11 2022 10:05:58 PM] ServerStatus.update [Jul 11 2022 10:05:58 PM] ShareMode.update_primary_action [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ServerStatus.update [Jul 11 2022 10:05:58 PM] ShareMode.update_primary_action [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/640bf8a6.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ServerStatus.update [Jul 11 2022 10:05:58 PM] ShareMode.update_primary_action [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/640bf8a6.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/c31c4eeb.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ServerStatus.update [Jul 11 2022 10:05:58 PM] ShareMode.update_primary_action [Jul 11 2022 10:05:58 PM] ToggleHistory.toggle_clicked [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/640bf8a6.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/c31c4eeb.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/640bf8a6.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/c31c4eeb.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/c31c4eeb.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ServerStatus.update [Jul 11 2022 10:05:58 PM] ShareMode.update_primary_action [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/c31c4eeb.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/c31c4eeb.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/c31c4eeb.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ServerStatus.update [Jul 11 2022 10:05:58 PM] ShareMode.update_primary_action [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/640bf8a6.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ServerStatus.update [Jul 11 2022 10:05:58 PM] ShareMode.update_primary_action [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ServerStatus.update [Jul 11 2022 10:05:58 PM] ShareMode.update_primary_action [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/640bf8a6.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ServerStatus.update [Jul 11 2022 10:05:58 PM] ShareMode.update_primary_action [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/640bf8a6.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/c31c4eeb.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ServerStatus.update [Jul 11 2022 10:05:58 PM] ShareMode.update_primary_action [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/640bf8a6.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/c31c4eeb.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/large_file', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'] [Jul 11 2022 10:05:58 PM] ServerStatus.update [Jul 11 2022 10:05:58 PM] ShareMode.update_primary_action [Jul 11 2022 10:05:58 PM] ServerStatus.update [Jul 11 2022 10:05:58 PM] Mode.start_server [Jul 11 2022 10:05:58 PM] Mode.start_server: Starting an onion thread [Jul 11 2022 10:05:58 PM] OnionThread.__init__ [Jul 11 2022 10:05:58 PM] ModeSettings.set: updating undress-coyness-anime: share.filenames = ['/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/640bf8a6.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/c31c4eeb.txt', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/large_file', '/tmp/guix-build-onionshare-2.4.drv-0/tmpx624akaf/test.txt'][Jul 11 2022 10:05:58 PM] OnionThread.run [Jul 11 2022 10:05:58 PM] Web.generate_static_url_path: new static_url_path is /static_76kyy3l57efdgiew6xhqlusxca [Jul 11 2022 10:05:58 PM] OnionShare.start_onion_service [Jul 11 2022 10:05:59 PM] WebThread.__init__ [Jul 11 2022 10:05:59 PM] WebThread.run[Jul 11 2022 10:05:59 PM] Mode.start_server_step2 [Jul 11 2022 10:05:59 PM] Web.start: port=17618 [Jul 11 2022 10:05:59 PM] CompressThread.__init__ [Jul 11 2022 10:05:59 PM] CompressThread.run [Jul 11 2022 10:05:59 PM] ShareModeWeb.init [Jul 11 2022 10:05:59 PM] ShareModeWeb.set_file_info_custom [Jul 11 2022 10:05:59 PM] ShareModeWeb.build_zipfile_list ----------------------------- Captured stderr call ----------------------------- This plugin does not support setParent! ------------------------------ Captured log call ------------------------------- INFO werkzeug:_internal.py:225 * Running on http://127.0.0.1:17618/ (Press CTRL+C to quit) __________________________ TestShare.test_public_mode __________________________ self = def test_public_mode(self): """ Public mode shouldn't have a password """ > tab = self.new_share_tab() tests/test_gui_share.py:367: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ tests/gui_base_test.py:88: in new_share_tab self.verify_new_tab(tab) tests/gui_base_test.py:80: in verify_new_tab self.assertTrue(tab.new_tab.isVisible()) E AssertionError: False is not true ----------------------------- Captured stdout call ----------------------------- [Jul 11 2022 10:06:14 PM] Mode.start_server_step3 [Jul 11 2022 10:06:14 PM] ServerStatus.update [Jul 11 2022 10:06:14 PM] Settings.load _______________ TestShare.test_remove_all_file_selection_button ________________ self = def test_remove_all_file_selection_button(self): """ Test remove all file items at once """ > tab = self.new_share_tab() tests/test_gui_share.py:356: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ tests/gui_base_test.py:88: in new_share_tab self.verify_new_tab(tab) tests/gui_base_test.py:80: in verify_new_tab self.assertTrue(tab.new_tab.isVisible()) E AssertionError: False is not true ________________________ TestShare.test_unreadable_file ________________________ self = def test_unreadable_file(self): """ Sharing an unreadable file should throw a warning """ > tab = self.new_share_tab() tests/test_gui_share.py:489: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ tests/gui_base_test.py:88: in new_share_tab self.verify_new_tab(tab) tests/gui_base_test.py:80: in verify_new_tab self.assertTrue(tab.new_tab.isVisible()) E AssertionError: False is not true ___________________ TestShare.test_without_autostop_sharing ____________________ self = def test_without_autostop_sharing(self): """ Disable autostop sharing after first download """ > tab = self.new_share_tab() tests/test_gui_share.py:379: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ tests/gui_base_test.py:88: in new_share_tab self.verify_new_tab(tab) tests/gui_base_test.py:80: in verify_new_tab self.assertTrue(tab.new_tab.isVisible()) E AssertionError: False is not true --------------------------- Captured stdout teardown --------------------------- [Jul 11 2022 10:06:18 PM] MainWindow.closeEvent [Jul 11 2022 10:06:18 PM] MainWindow.closeEvent, opening warning dialog [Jul 11 2022 10:06:18 PM] MainWindow.cleanup [Jul 11 2022 10:06:18 PM] TabWidget.cleanup [Jul 11 2022 10:06:18 PM] Tab.cleanup: tab_id=8 [Jul 11 2022 10:06:18 PM] Web.stop: stopping server [Jul 11 2022 10:06:19 PM] Web.cleanup [Jul 11 2022 10:06:19 PM] Alert.__init__ [Jul 11 2022 10:06:19 PM] OnionCleanupThread.__init__ [Jul 11 2022 10:06:19 PM] OnionCleanupThread.run [Jul 11 2022 10:06:19 PM] Onion.cleanup --------------------------- Captured stderr teardown --------------------------- This plugin does not support propagateSizeHints() This plugin does not support propagateSizeHints() ---------------------------- Captured log teardown ----------------------------- INFO werkzeug:_internal.py:225 127.0.0.1 - - [11/Jul/2022 22:06:18] "GET /xwpum3u67ltpl525lvd3tgghce/shutdown HTTP/1.1" 200 - =============================== warnings summary =============================== tests/conftest.py:75 /tmp/guix-build-onionshare-2.4.drv-0/source/desktop/tests/conftest.py:75: PytestDeprecationWarning: @pytest.yield_fixture is deprecated. Use @pytest.fixture instead; they are the same. def temp_dir_1024_delete(temp_dir): tests/conftest.py:99 /tmp/guix-build-onionshare-2.4.drv-0/source/desktop/tests/conftest.py:99: PytestDeprecationWarning: @pytest.yield_fixture is deprecated. Use @pytest.fixture instead; they are the same. def temp_file_1024_delete(temp_dir): tests/conftest.py:113 /tmp/guix-build-onionshare-2.4.drv-0/source/desktop/tests/conftest.py:113: PytestDeprecationWarning: @pytest.yield_fixture is deprecated. Use @pytest.fixture instead; they are the same. @pytest.yield_fixture(scope="session") tests/conftest.py:126 /tmp/guix-build-onionshare-2.4.drv-0/source/desktop/tests/conftest.py:126: PytestDeprecationWarning: @pytest.yield_fixture is deprecated. Use @pytest.fixture instead; they are the same. @pytest.yield_fixture(scope="session") tests/test_gui_share.py::TestShare::test_405_page_returned_for_invalid_methods tests/test_gui_share.py::TestShare::test_clear_all_history_button tests/test_gui_share.py::TestShare::test_client_auth tests/test_gui_share.py::TestShare::test_individual_files_without_autostop_sharing tests/test_gui_share.py::TestShare::test_without_autostop_sharing /gnu/store/dg59r5qmksn2llkbqxbzj4zw3xvcfppp-onionshare-cli-2.4/lib/python3.9/site-packages/onionshare_cli/web/web.py:317: UserWarning: The 'environ['werkzeug.server.shutdown']' function is deprecated and will be removed in Werkzeug 2.1. func() tests/test_gui_share.py::TestShare::test_download tests/test_gui_share.py::TestShare::test_individual_files /gnu/store/dg59r5qmksn2llkbqxbzj4zw3xvcfppp-onionshare-cli-2.4/lib/python3.9/site-packages/onionshare_cli/web/share_mode.py:387: UserWarning: The 'environ['werkzeug.server.shutdown']' function is deprecated and will be removed in Werkzeug 2.1. shutdown_func() -- Docs: https://docs.pytest.org/en/stable/warnings.html =========================== short test summary info ============================ FAILED tests/test_gui_share.py::TestShare::test_large_download - AssertionErr... FAILED tests/test_gui_share.py::TestShare::test_public_mode - AssertionError:... FAILED tests/test_gui_share.py::TestShare::test_remove_all_file_selection_button FAILED tests/test_gui_share.py::TestShare::test_unreadable_file - AssertionEr... FAILED tests/test_gui_share.py::TestShare::test_without_autostop_sharing - As... ======== 5 failed, 7 passed, 5 skipped, 11 warnings in 73.66s (0:01:13) ======== error: in phase 'check': uncaught exception: %exception #<&invoke-error program: "./tests/run.sh" arguments: () exit-status: 1 term-signal: #f stop-signal: #f> phase `check' failed after 97.3 seconds command "./tests/run.sh" failed with status 1 --8<---------------cut here---------------end--------------->8--- So the first thing I tried was updating onionshare to 2.5; unfortunately the tests got even more problematic to run, so I asked guidance upstream and disabled the test suite for now, after trying to make things work for a good while (see commit aedd7dc8e085788fbaf066754eb3387edb719335). At least it won't fail nondeterministically! Thanks for the report. Closing. Maxim ------------=_1657598342-20436-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Oct 2021 02:54:08 +0000 Received: from localhost ([127.0.0.1]:56389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgeVL-0006ek-FE for submit@debbugs.gnu.org; Fri, 29 Oct 2021 22:54:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:56074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgeVH-0006eY-48 for submit@debbugs.gnu.org; Fri, 29 Oct 2021 22:53:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgeVG-0004GH-AJ for bug-guix@gnu.org; Fri, 29 Oct 2021 22:53:54 -0400 Received: from mail-4318.protonmail.ch ([185.70.43.18]:33633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgeVE-0003PH-De for bug-guix@gnu.org; Fri, 29 Oct 2021 22:53:54 -0400 Date: Sat, 30 Oct 2021 02:53:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1635562421; bh=jhPXaSP4jCuHLbyBYOUqgQi6LCZjBhA886j4sRAOjjM=; h=Date:To:From:Reply-To:Subject:From; b=knhx8V2SvGsDI2povbvS1XKNRsfzMkdjK8qpVehhmQ4wg7u+5pXTJ+M4aVYoXuLyO fvWewHltRbt/s4/ec0pPiMU9GsDr0qCuUjvZmmUJvh+0qoC4kkyYQwB8tz3UGYwxSx sdXzN0w/MS5Y8fGsEK/bci/x34/KApVVAlYR/Q9U= To: "bug-guix@gnu.org" From: raid5atemyhomework Subject: onionshare build is broken Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.43.18; envelope-from=raid5atemyhomework@protonmail.com; helo=mail-4318.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raid5atemyhomework Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) onionshare is broken on master 89d8417; `guix time-machine --commit=3D89d84= 17b371f3918f0508bbc561675ec100a6add -- build onionshare` results in: ``` _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _= _ _ tests/gui_base_test.py:88: in new_share_tab self.verify_new_tab(tab) tests/gui_base_test.py:80: in verify_new_tab self.assertTrue(tab.new_tab.isVisible()) E AssertionError: False is not true --------------------------- Captured stdout teardown ----------------------= ----- [Oct 28 2021 04:36:21 AM] MainWindow.closeEvent [Oct 28 2021 04:36:21 AM] MainWindow.closeEvent, opening warning dialog [Oct 28 2021 04:36:21 AM] MainWindow.cleanup [Oct 28 2021 04:36:21 AM] TabWidget.cleanup [Oct 28 2021 04:36:21 AM] Tab.cleanup: tab_id=3D8 [Oct 28 2021 04:36:21 AM] Web.stop: stopping server [Oct 28 2021 04:36:22 AM] Web.cleanup [Oct 28 2021 04:36:22 AM] Alert.__init__ [Oct 28 2021 04:36:22 AM] OnionCleanupThread.__init__ [Oct 28 2021 04:36:22 AM] OnionCleanupThread.run [Oct 28 2021 04:36:22 AM] Onion.cleanup --------------------------- Captured stderr teardown ----------------------= ----- This plugin does not support propagateSizeHints() This plugin does not support propagateSizeHints() ---------------------------- Captured log teardown ------------------------= ----- INFO werkzeug:_internal.py:113 127.0.0.1 - - [28/Oct/2021 04:36:21] "GE= T /3x7qnpxrxhm3w7pzdxxfntvsvq/shutdown HTTP/1.1" 200 - =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 6 failed, 8 passed, 5 skipped in= 83.88s (0:01:23) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D QThread: Destroyed while thread is still running Fatal Python error: Aborted Thread 0x00007fffd77fe700 (most recent call first): File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python= 3.8/zipfile.py", line 1139 in write File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python= 3.8/shutil.py", line 205 in copyfileobj File "/gnu/store/9w9jvy3bgjg4qaqmrij01nbppiccqr7c-python-3.8.2/lib/python= 3.8/zipfile.py", line 1776 in write File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 565 in ad= d_file File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 511 in bu= ild_zipfile_list File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/share_mode.py", line 418 in se= t_file_info_custom File "/gnu/store/qycixjbyhvh2mchlrsbadvrh0p81lgpz-onionshare-cli-2.3.2/li= b/python3.8/site-packages/onionshare_cli/web/send_base_mode.py", line 130 i= n set_file_info File "/gnu/store/vz73w4kdk44swsws46kvzvypk2dg6nv3-onionshare-2.3.2/lib/py= thon3.8/site-packages/onionshare/tab/mode/share_mode/threads.py", line 46 i= n run Current thread 0x00007ffff785c300 (most recent call first): ./tests/run.sh: line 6: 76 Aborted pytest -v tests/test_= gui_share.py command "./tests/run.sh" failed with status 134 builder for `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.d= rv' failed with exit code 1 build of /gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-onionshare-2.3.2.drv f= ailed View build log at '/var/log/guix/drvs/nw/m0wl6ilxgaqwl331fmp3ggxgh706a5-oni= onshare-2.3.2.drv.bz2'. guix build: error: build of `/gnu/store/nwm0wl6ilxgaqwl331fmp3ggxgh706a5-on= ionshare-2.3.2.drv' failed ``` Doing a `git bisect` got me to this: * bad: `guix time-machine --commit=3Debc274063716a3a9471f51abb526d693c06b9f= 63 -- build onionshare` * good: `guix time-machine --commit=3Dc6adc0947396daa6d85ab08837f9cbc86f4d8= 722 -- build onionshare` * result: `/gnu/store/gsi65h1zj2wg8wm7c3jy2p1ac8yyynfs-onionshare-2.3.2` However the bad commit seems to be just an update on `tor` version; I am no= t certain why it would cause this build failure. Thanks, raid5atemyhomework ------------=_1657598342-20436-1--