GNU bug report logs - #5148
Lossage in comint history

Previous Next

Full log

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Lossage in comint history
Date: Mon, 07 Dec 2009 19:27:34 +0200

Using M-x shell in Emacs causes lossage in .bash_history.

I set HISTFILESIZE and HISTSIZE to large values in .bashrc
to not truncate the history file but comint.el disregards
my settings and truncates the history file used by bash.

The following patch make `comint-input-ring-size' customizable.
The type should be `integer' because this value is used by `make-ring'
to create the history ring.  The default value increased to 500
to be the same as the default value of HISTFILESIZE and HISTSIZE.

Index: lisp/comint.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/comint.el,v
retrieving revision 1.402
diff -c -r1.402 comint.el
*** lisp/comint.el	1 Dec 2009 20:32:00 -0000	1.402
--- lisp/comint.el	7 Dec 2009 17:27:08 -0000
***************
*** 309,317 ****
    :type 'integer
    :group 'comint)
  
! ;; FIXME: this should be defcustom
! (defvar comint-input-ring-size 150
!   "Size of input history ring.")
  
  (defvar comint-input-ring-separator "\n"
    "Separator between commands in the history file.")
--- 309,319 ----
    :type 'integer
    :group 'comint)
  
! (defcustom comint-input-ring-size 500
!   "Size of input history ring."
!   :type 'integer
!   :group 'comint
!   :version "23.2")
  
  (defvar comint-input-ring-separator "\n"
    "Separator between commands in the history file.")

-- 
Juri Linkov
http://www.jurta.org/emacs/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.