Subject: bug#5148 closed by Chong Yidong <[email-masked]> (Re: Lossage in comint history)

From: [email-masked] (Emacs bug Tracking System)
Date: Fri, 01 Jan 2010 18:46:02 +0000

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#5148: Lossage in comint history

It has been closed by Chong Yidong <[email-masked]>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Chong Yidong <[email-masked]> by
replying to this email.

-- 
5148: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5148
Emacs Bug Tracking System
Contact [email-masked] with problems

Subject: Re: Lossage in comint history
From: Chong Yidong <[email-masked]>
To: Juri Linkov <[email-masked]>
Cc: [email-masked]
Date: Fri, 01 Jan 2010 13:45:32 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

> Using M-x shell in Emacs causes lossage in .bash_history.
>
> I set HISTFILESIZE and HISTSIZE to large values in .bashrc
> to not truncate the history file but comint.el disregards
> my settings and truncates the history file used by bash.
>
> The following patch make `comint-input-ring-size' customizable.  The
> type should be `integer' because this value is used by `make-ring' to
> create the history ring.  The default value increased to 500 to be the
> same as the default value of HISTFILESIZE and HISTSIZE.

Looks reasonable enough to me.  Checked in, thanks.

Subject: Lossage in comint history
From: Juri Linkov <[email-masked]>
To: [email-masked]
Date: Mon, 07 Dec 2009 19:27:34 +0200

Using M-x shell in Emacs causes lossage in .bash_history.

I set HISTFILESIZE and HISTSIZE to large values in .bashrc
to not truncate the history file but comint.el disregards
my settings and truncates the history file used by bash.

The following patch make `comint-input-ring-size' customizable.
The type should be `integer' because this value is used by `make-ring'
to create the history ring.  The default value increased to 500
to be the same as the default value of HISTFILESIZE and HISTSIZE.

Index: lisp/comint.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/comint.el,v
retrieving revision 1.402
diff -c -r1.402 comint.el
*** lisp/comint.el	1 Dec 2009 20:32:00 -0000	1.402
--- lisp/comint.el	7 Dec 2009 17:27:08 -0000
***************
*** 309,317 ****
    :type 'integer
    :group 'comint)
  
! ;; FIXME: this should be defcustom
! (defvar comint-input-ring-size 150
!   "Size of input history ring.")
  
  (defvar comint-input-ring-separator "\n"
    "Separator between commands in the history file.")
--- 309,319 ----
    :type 'integer
    :group 'comint)
  
! (defcustom comint-input-ring-size 500
!   "Size of input history ring."
!   :type 'integer
!   :group 'comint
!   :version "23.2")
  
  (defvar comint-input-ring-separator "\n"
    "Separator between commands in the history file.")

-- 
Juri Linkov
http://www.jurta.org/emacs/