GNU bug report logs - #51479
[PATCH 0/1] gnu: ta-lib: Explicitly link math library

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51479 in the body.
You can then email your comments to 51479 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/1] gnu: ta-lib: Explicitly link math library
Date: Fri, 29 Oct 2021 11:04:17 +0000

The math library has to be linked with ta-lib. Otherwise, errors may
occur. For example: https://github.com/rivella50/talib-ruby/issues/6

The fix here was copied from the patch used by Arch Linux and Gentoo.
https://gitweb.gentoo.org/repo/gentoo.git/tree/sci-libs/ta-lib/files/ta-lib-0.4.0-asneeded.patch


Foo Chuan Wei (1):
  gnu: ta-lib: Explicitly link math library

 gnu/packages/finance.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)


base-commit: ad39268cdf075f4c4eeb87ed78ce46ca6f817675
-- 
2.25.1

Message #8 received at 51479 <at> debbugs.gnu.org (full text, mbox):

From: Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
To: 51479 <at> debbugs.gnu.org
Subject: [PATCH 1/1] gnu: ta-lib: Explicitly link math library
Date: Fri, 29 Oct 2021 11:06:43 +0000

* gnu/packages/finance.scm (ta-lib): Explicitly link math library.
---
 gnu/packages/finance.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index f0093ba635..f662b5b774 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -1768,7 +1768,17 @@ editing on the Web.")
         (base32 "0lf69nna0aahwpgd9m9yjzbv2fbfn081djfznssa84f0n7y1xx4z"))))
     (build-system gnu-build-system)
     (arguments
-     `(;; Parallel build fails with:
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'edit-makefile-to-link-math-library
+           (lambda _
+             (substitute* "src/Makefile.am"
+               (("ta_common/libta_common.la")
+                "ta_common/libta_common.la -lm"))
+             (substitute* "src/Makefile.in"
+               (("\\$\\(libta_lib_la_LDFLAGS\\) \\$\\(LDFLAGS\\) -o \\$@")
+                "$(libta_lib_la_LDFLAGS) $(LDFLAGS) -lm -o $@")))))
+       ;; Parallel build fails with:
        ;; mv -f .deps/gen_code-gen_code.Tpo .deps/gen_code-gen_code.Po
        ;; mv: cannot stat '.deps/gen_code-gen_code.Tpo': No such file or directory
        ;; Makefile:254: recipe for target 'gen_code-gen_code.o' failed
-- 
2.25.1

Message #13 received at 51479-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
Cc: 51479-done <at> debbugs.gnu.org
Subject: Re: [bug#51479] [PATCH 1/1] gnu: ta-lib: Explicitly link math library
Date: Sat, 30 Oct 2021 12:46:34 +0000

[Message part 1 (text/plain, inline)]

Patch pushed as d4449565ed90aabaa6b755dfe1786a1dce370707 with a slightly
modified commit message.
Thanks.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.