GNU bug report logs - #51475
read-char-choice should hide the cursor

Previous Next

Full log

View this message in rfc822 format

From: Gregory Heytings <gregory <at> heytings.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: ndame <laszlomail <at> protonmail.com>, 51475 <at> debbugs.gnu.org
Subject: bug#51475: read-char-choice should hide the cursor
Date: Fri, 29 Oct 2021 18:54:14 +0000

>> Or we could make it depend on a dynamic variable.  See attached patch.
>
> I'd rather have an optional variable if this is something that should be 
> controlled.
>

You mean, an optional argument?  If so, unless you also add an additional 
optional argument to read-char-from-minibuffer, you'll need a dynamic 
variable anyway.

>
> But I'm not sure we want to.  The original example was:
>
> (read-char-choice " a - good\n b - bad\n c - ugly" '(?a ?b ?c))
>
> But that's an ugly prompt in itself.  If it's amended to
>
> (read-char-choice " a - good\n b - bad\n c - ugly: " '(?a ?b ?c))
>
> then it's fine showing the cursor.  (And that's a prompt should look.)
>

I'm not sure either.  I'm also not sure the OP would agree that your 
amended version is fine.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.