From unknown Tue Jun 17 01:27:17 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#51469 <51469@debbugs.gnu.org> To: bug#51469 <51469@debbugs.gnu.org> Subject: Status: 27.2; Mismatch: `set-face-attribute' and `face-all-attributes' Reply-To: bug#51469 <51469@debbugs.gnu.org> Date: Tue, 17 Jun 2025 08:27:17 +0000 retitle 51469 27.2; Mismatch: `set-face-attribute' and `face-all-attributes' reassign 51469 emacs submitter 51469 Drew Adams severity 51469 normal tag 51469 wontfix thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 28 19:04:11 2021 Received: (at submit) by debbugs.gnu.org; 28 Oct 2021 23:04:11 +0000 Received: from localhost ([127.0.0.1]:53478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgERP-0005Gw-Fn for submit@debbugs.gnu.org; Thu, 28 Oct 2021 19:04:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:42858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgERK-0005Gl-Os for submit@debbugs.gnu.org; Thu, 28 Oct 2021 19:04:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgERK-0004pd-Is for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 19:04:06 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:2680) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgERE-0004ZF-UE for bug-gnu-emacs@gnu.org; Thu, 28 Oct 2021 19:04:06 -0400 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19SMEP0E030820 for ; Thu, 28 Oct 2021 23:03:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=vyyctZ4cQ7EQ5qy6bnBzYE4u/vV3ygKNrq8VRrYGv4I=; b=pn1VsaMB8fDYB/FeV3JOvekvD6qdWaq/0kfeb83ktzc+brsFeUrn2uuSXaeYrdLL2j0t 6Zcy5EgxFdZ0UYvYEzepZcImpIoSvL0MV3kCUR2nzbfIqa09d3JmPuO91R6zPhHuxqIS Fy/bdiv0bDYfCdQuV7VdVOgMs2gxP3sFYn4K0q9oov5/2coS4jPL6kvUJYUuP5Pf2jPG SXBgy0G6cWcKaFOn6CiiLCbLZV7o6qFWnarHIz1yKoI1CMM09zbQj2he1V9JdiCnbMIC RmoS/mczozg7FXpUMMmtS7AQUU0an7+cQaAzapwEBD3kgrHBDQ2z4TKSKCBhk8I7b7Ca Dw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3byhy9n81n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 28 Oct 2021 23:03:55 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19SMu4iS137818 for ; Thu, 28 Oct 2021 23:03:37 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by userp3030.oracle.com with ESMTP id 3bx4h4wrh2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 28 Oct 2021 23:03:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aU+qABq/OYoeBebadDASuOOgoLdIpQJj8IG5a/62VpKcBOcQrWnfe+uQLblLlCBj7Mrd9yN1rhQYeN5iBtU++wezrcPjnfSzo45GXp/DneiJk4ELIeJZ8roFEppFieGYZO82oQ29s/9zHgGMRbm3QC7YTE2R32kGvcBjoArMwDQDts2FqsuF98Ok8+ULcz0kiKKSa/mRlBVLwzS7t1N+Zak2mSh/K+1moXTk7fgw8crW9Orx9dR8QrVsCwr6hphc9IcSln0Pehn2yRqD/5DUazV7UYwnYbjE3rIRVFatlI8mdXIWfm6ySW8TnF5gKhfi2r+GAT9tB+ptKzHE49MLYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vyyctZ4cQ7EQ5qy6bnBzYE4u/vV3ygKNrq8VRrYGv4I=; b=iqmhd2bFyTL7j19xi2E5XyTYfh9Q/7hx27KTqKzpQeNiuI3RmJaPHOhcCrLye1/01QwNtw2REHB6DZaGDaYd/U2fgAoi8XUWc+f862cppkyeXGui8dLXFNM16rabuZATKxBA3RXuGwBKBn2J6afdk6U/haoNf/vpxuHolrYovN8W1gL7bj9cHIy7aWk2+haOR0zXCl0Bps9mReomoN/4uaogzu6CE7FHcQJXR0ElwtBNIMZJx94M2gNI2jfPmr3ZxLfQDtkqyKAiDZTeaF7N3aIetq+LvAIJjQ8tnEnc/1FQGCv8rU/WF2XGzie1ClvJiK3CdnEFkbBtO2kw63O5KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vyyctZ4cQ7EQ5qy6bnBzYE4u/vV3ygKNrq8VRrYGv4I=; b=b0FjHvhsQStkQA0VlOSHlPE49R/qFl6ndTtcwSTB9g1AnnRuAO0HPO5EK/PR0p3DS1GmoTaNc2ynxQ5Wricm3Fi4ggHYKU+unxrRvFTdQe9U1u1beAKtLCUbKbS70mra3ghcQh1A/2YPF9+9NEY13O5Isn3KkKUyF9uaa6DMpn8= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BYAPR10MB3111.namprd10.prod.outlook.com (2603:10b6:a03:159::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 28 Oct 2021 23:03:35 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::c0bc:7c3a:292f:8a82]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::c0bc:7c3a:292f:8a82%8]) with mapi id 15.20.4628.020; Thu, 28 Oct 2021 23:03:35 +0000 From: Drew Adams To: "bug-gnu-emacs@gnu.org" Subject: 27.2; Mismatch: `set-face-attribute' and `face-all-attributes' Thread-Topic: 27.2; Mismatch: `set-face-attribute' and `face-all-attributes' Thread-Index: AdfMT9s6eNjzRjfmSr6dxm5NMTOY6w== Date: Thu, 28 Oct 2021 23:03:35 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=oracle.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7513259c-d7a4-47aa-3275-08d99a672bb3 x-ms-traffictypediagnostic: BYAPR10MB3111: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: shQGZuMISZ3H/713NG2g6HIyggY1N47maE96dPG1SZnt7MXU+8NnR8lgJEXpUpf3L3nbqTHL30bjtOIo1NYG6XuLURB83MliBzbRw0bzAueV46EKaRTRXEyNGMTMuxHhMOXjftl/gIlQOP94LL0t1LKL0BEVtNpS3iw7GrmGQ1ZJecZCv8qeFF4ervSl+/zEJq5m6r3UUZEAONLxtsWSJr3kt6iC8uOeNtwXfEgkgPaLs5cpY79TMsfntmRire4DDYw5PVimqiCEeo17LvyEEt6SkUcWrrQAwtxwkJcGcFO4aSeWcX813pNz/T+W9JOUOtcChbCmUiobT0AN+8DAhDy7V90zaJajwbw8l3av++dfrNjPgDgJ9aMBN5Qtdw/Er8szqN1e2XHdqNiOCNLsEL7jtXEm3TfgOHpqyOIl4a4A7Irs3UgyPnHhhqPQyfEIlug7+frzG4wRsQNn2nY7XuO05p8NLEwo5XDF2lvsPRTNUq3rT52XPQiLzGjVuURpk6RPDbDFI3wM5DYESprLa7I2CgYbyBqdhu9JrPb8EMB1nsi0c7pBGLS5OhDWlWoBk9XGlnpHlxok2ipiu8la3LxIgCr2mXQfEwLwDgCAVsquQBGHueP2kf6095mdXSt/ZvKsojaHGhxB75n83j4SMkiSyQK0aKe4rfCJs0imPlRaZ74aR6mBYtEvILuPz8vSYCjmmuNPOFlNEas8CPtoKWlaMu9WwBCYblViSCSXhzE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38070700005)(8676002)(7696005)(9686003)(6506007)(52536014)(55016002)(45080400002)(508600001)(38100700002)(6916009)(316002)(2906002)(26005)(5660300002)(186003)(66476007)(122000001)(66446008)(8936002)(86362001)(44832011)(66556008)(66946007)(71200400001)(64756008)(76116006)(33656002)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nFe4pZQR12dI89Wvz4f3aCtYpsgHrCiVfzJ4jYSfbDL15NH5V48Pg1O9Q9UF?= =?us-ascii?Q?/aNLJX2AjNFA09tq88l1Jf70Avvkx43dznD9/MbOy/Mf34iRhkSzu/V+l2YZ?= =?us-ascii?Q?ynGeIWwbqNydXH3O1MslNxk2idrLQPFMMqEa/k8gNVJRSPj6R3bF9VGfR5zg?= =?us-ascii?Q?wACHwx8qROjOancwGuusaslBeLxIjl93MazTiI85ZD+GRf2GlHUQqFbJ93Y4?= =?us-ascii?Q?Km05E82SizVm0GVRlw4+NXNnHY4+wmuYuxpr1jM4AOCurLsVvkFy8fUkdMLQ?= =?us-ascii?Q?0OYmEY+Ppv6Y3lJLrB7fmTbWV12FfB9mHZxgBVHp33BKCGPOSgefC4g5Pwmb?= =?us-ascii?Q?Mf8DHuIfrXtCr+kQ8YNIlhzX2/hEEGoWrfE8rmVQrleT5Xcaj1gxBbXIOYYe?= =?us-ascii?Q?uCEQhYySa+cFgXMU96xUotm9F0GRSgsLwBBD7c2lL/v/2i4q+fpruTNuBalZ?= =?us-ascii?Q?vg1u9xD84zgQSkb5mRAQfmS6f/zqAAprhbWnNJZ4aFGmR74Ve1JT9afERTab?= =?us-ascii?Q?a6fKUYwjgFzhfUZKscXpEtq213JIsSGlbXRElmlIZZ5dlu19WHv6RmREQiA8?= =?us-ascii?Q?YOE21zFUkO8AJGkPVAAmx0Jla3HBFjJKSKdoN2o/1WrOfPj9bUz1HDMsOYQt?= =?us-ascii?Q?mIItDQwiUIeDI9cXM/iSk9obyc5Kdh5FLoqLnDI1cgglXxmVyIJvEqqoi7pV?= =?us-ascii?Q?i1V3MV6IT9aCaEXJioQBuHl93nvnQ3YRFRTfb3xcBupNWljg7eR4em7Pcb2F?= =?us-ascii?Q?e3G9+KzTYE/+t6rLKdTEPVs2z5NN53Nf7n433PlbPvzjul1EEuFedVTUDWWq?= =?us-ascii?Q?ZKt7E6guYjb60LZ+LgZ/OfcuwxzyAAOQzzjGtJ/mm57OlOnZXIsWyff0sd1S?= =?us-ascii?Q?kzSp84VTjGP3Z0wdNxYVE98vm7vpbkLyQC4NGxubpnO5bRN9m97JzGkNoxvN?= =?us-ascii?Q?utD7FWzId8aj/yEsukG9awbEDrO+gL0DzS/WxPa8z2Ymgbnr9hyWnyCRlE6e?= =?us-ascii?Q?JVg6bqtewrvz3iFqpTh9i6bZbDTcZEV7x4OrPawbdbm8gF0jJAcG2E1AIgtV?= =?us-ascii?Q?wKtl6yjVuVY+9irJ/eYCeSf8/2+KwlPtiKyuxxf9EJGjTpk82O2/EpQmz2pW?= =?us-ascii?Q?7ZF59C9DQC/xK0SgL84hLCWN7V7v8NPOranQfvoraTwXLZ+ILcJDad6ItilZ?= =?us-ascii?Q?o5OyMa9a2RLexRjJ2C9etmBZMwRmToq78faMML0EWskzIHXYkp1DlsSy51oi?= =?us-ascii?Q?kOk+MZvnphhSCvSgHX8qwblxhmc9nTiCzpMK7RfyUwYXbGUJSYEXqHwBcMUb?= =?us-ascii?Q?F+FD6UNtTFZeUfQgHftcHGNFfiFKTmwTMmmyL/MRdvwYuHB8x6ukKvnnICwO?= =?us-ascii?Q?OkGnGAvwtcqFiNI198C/4D2tPpODcQ7N/HDmKTcbggKV0tleEusmS51xm60k?= =?us-ascii?Q?lHt1qN2lsK8jnNcQk3BLWsLu2y0pqo1iKxLOVi//8+eFGhCZ2bf6kCu/52uJ?= =?us-ascii?Q?PH79oxi9WRasexRCfpHQ4dGVUEhaBjbcn+OpveR1jG66plLtB4ZAx+aC8PWy?= =?us-ascii?Q?F6b/jP0NprO1AwYcncXdj+9v7s5H5xXoNaWighGF7ckC8KTXqKgrN+HVwYsK?= =?us-ascii?Q?CQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7513259c-d7a4-47aa-3275-08d99a672bb3 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 23:03:35.3824 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dyS6OnHBncxd+id6EkaE8I7M/SjfHHmZIscN7acX0MYyAJWS8THmvwRBgheau0KyPuCw0oO98wFU/rBNK2Spag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3111 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10151 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2110280121 X-Proofpoint-ORIG-GUID: h9LZOuVfXaXTqpC93Gu1dqkGfb8dvipe X-Proofpoint-GUID: h9LZOuVfXaXTqpC93Gu1dqkGfb8dvipe Received-SPF: pass client-ip=205.220.177.32; envelope-from=drew.adams@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Why is the &rest argument ARGUMENTS of `set-face-attribute' a plist of attributes, but `face-all-attributes' returns an alist of attributes? Just doing something like the following isn't possible directly: (apply #'set-face-attribute 'some-face nil (face-all-attributes 'other-face)) To accomplish that hand-off, you need to convert the alist returned by `face-all-attributes' to a plist, and pass that to `set-face-attribute'. And the conversion function needs to check that the attributes are acceptable for `set-face-attribute' (else an error is raised). Why should we need to do that each time, instead of just being able to pass the result of one to the other? E.g., something like `foo', applied to (face-all-attributes FACE1 FRAME1), should give a PLIST1 as expected by `set-frame-attribute', using (apply #'set-face-attribute FACE2 FRAME2 PLIST1): (defun foo (alist) "Return a plist of valid face attributes from ALIST. ALIST is a list of conses with car a face attribute and with cdr its value. The returned PLIST is acceptable as an argument to `set-face-attribute'." (let ((plist ())) (dolist (pair alist) (when (member (car pair)=20 '(:family :foundry :width :height :weight :slant :foreground :background :underline :color :overline :strike-through :box :inverse-video :stipple :font :inherit)) (push (car pair) plist) (push (cdr pair) plist))) (setq plist (nreverse plist)))) What other uses of these two functions would suggest that they should, as they do, use different ways to express the list of face attributes? Is there a good reason for this status quo? If not, can we change it to get a better fit and not require conversion? In GNU Emacs 27.2 (build 1, x86_64-w64-mingw32) of 2021-03-26 built on CIRROCUMULUS Repository revision: deef5efafb70f4b171265b896505b92b6eef24e6 Repository branch: HEAD Windowing system distributor 'Microsoft Corp.', version 10.0.19042 System Description: Microsoft Windows 10 Pro (v10.0.2009.19042.1288) From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 29 09:12:54 2021 Received: (at 51469) by debbugs.gnu.org; 29 Oct 2021 13:12:54 +0000 Received: from localhost ([127.0.0.1]:54146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgRgk-0006kq-AF for submit@debbugs.gnu.org; Fri, 29 Oct 2021 09:12:54 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgRgh-0006kV-PP for 51469@debbugs.gnu.org; Fri, 29 Oct 2021 09:12:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Mis2z6E8jyWhHrpPHn1+eWyebCV75SnF3DwxkyQZ7pA=; b=jGbb2SCYfMOww9qSgsGWi6ErwC UFFlEWq3WS6AfpsutT7pGdyaCTmCT758OksKz7SVk2YMlbhDFcXRc1Y4Ed7Qxm+7sBtC95BLQ6yFe wMtD0VcwdIipDQ+pMmhlPxQP1VM0uJ6HBYbqpFstuwXUmvZQXcgHM5R6WsBANjN+3Jwk=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mgRgW-0008S4-RS; Fri, 29 Oct 2021 15:12:44 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#51469: 27.2; Mismatch: `set-face-attribute' and `face-all-attributes' References: X-Now-Playing: Joni Mitchell's _Shine_: "Shine" Date: Fri, 29 Oct 2021 15:12:40 +0200 In-Reply-To: (Drew Adams's message of "Thu, 28 Oct 2021 23:03:35 +0000") Message-ID: <87h7d0ynxz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Drew Adams writes: > Why is the &rest argument ARGUMENTS of `set-face-attribute' a plist of > attributes, but `face-all-attributes' returns an alist of attributes? It's not essentially a plist, but a list of :keyword value pairs, but that's splitting hairs. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51469 Cc: 51469@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Drew Adams writes: > Why is the &rest argument ARGUMENTS of `set-face-attribute' a plist of > attributes, but `face-all-attributes' returns an alist of attributes? It's not essentially a plist, but a list of :keyword value pairs, but that's splitting hairs. face-all-attributes could return such a plist, but we usually prefer to return alists from functions instead of plists. > Is there a good reason for this status quo? If not, can we change it to > get a better fit and not require conversion? We can't change the output of face-all-attributes (because that would break code), so I don't think there's anything to do here, and I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 29 09:12:57 2021 Received: (at control) by debbugs.gnu.org; 29 Oct 2021 13:12:57 +0000 Received: from localhost ([127.0.0.1]:54149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgRgn-0006l5-Gk for submit@debbugs.gnu.org; Fri, 29 Oct 2021 09:12:57 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgRgk-0006kb-SC for control@debbugs.gnu.org; Fri, 29 Oct 2021 09:12:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GweDObRql/voGzXimd2EBcXotuyHqVnhxKQe7GQeqOw=; b=CkukhRS5nVPy8etHcrxmOM/WDF j+BQRvkmYDxWhy+IpGsSvPF8DOEHd4753RPJMqHKLJu+1ZX5UfOPCsXoa0iCbCcypfzvHXWnthVpf eqxrKpB4NZeLkdNObwt/fBWvIHODpp/eKuAhks208YPp/PtPK75Ec+aPz8egYXLlxBac=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mgRgd-0008SB-EH for control@debbugs.gnu.org; Fri, 29 Oct 2021 15:12:49 +0200 Date: Fri, 29 Oct 2021 15:12:47 +0200 Message-Id: <87fsskynxs.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #51469 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 51469 wontfix close 51469 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 51469 wontfix close 51469 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 29 14:01:34 2021 Received: (at 51469) by debbugs.gnu.org; 29 Oct 2021 18:01:34 +0000 Received: from localhost ([127.0.0.1]:55845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgWC6-0005y8-84 for submit@debbugs.gnu.org; Fri, 29 Oct 2021 14:01:34 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:4010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgWC2-0005xx-Jc for 51469@debbugs.gnu.org; Fri, 29 Oct 2021 14:01:32 -0400 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19THHN3C004532; Fri, 29 Oct 2021 18:01:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=i7RyNxXJJfyukQBKmKxM8W1z3OjanGbAfQ68Mb82mKU=; b=Vl1c5IrPzdYXRtIxwV9THBwc3WoxNaLAytqlca1rJJy6Vn3RkEu96HeW91xqb8/lz9sE RF3rYZe3QtqtIgf0o8VFV3fqaYXno+dbV/JgJAT6uJouHbCeiun8+MYQ7mmoD3gmKy+i iecgAY4tZ3zPQidrfvfKBkRsuOJV1g90wVXvH6Ae85HtF4Dt+I0Rb1IIZtsaJ6v2mFOa 6VhtyH+5TSr3Uhykd+xN4EytOgrlrTYuQ2WsNEBDJHLaD1qRjKk5RnvtsN8is3IwOP/4 yffHXCJ426f/JMipnEAENL7IEbkuXWPJkQiZZNW/Xw6d8+bTUhE1p4/qqc6HGEdpj06w /g== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3byja2hevk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Oct 2021 18:01:29 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19THpfGK051329; Fri, 29 Oct 2021 18:01:28 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2100.outbound.protection.outlook.com [104.47.70.100]) by aserp3020.oracle.com with ESMTP id 3bx4gg93jb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Oct 2021 18:01:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GO+GH3QxgcWWTfG2zngDIrmWsFokfAh+MPrjxZRilYd9N/Wn5u9NfXf7LA4s3NgjbgOSdz6SFn4PPZ8/qAQGMDM+ECPE4E0hn6/3/NNUNxXJ4usix19jomdou/Ym582x6q+pW8fwqBofDUXhauJRUsaES8W4rEINRb8XV8Qk6O4w6yTaJTDCuQ5NROFp4i2gr0Shh8Zs/keB1z4AfDkbOBTpjo9V8E0xy/DXI0oqprakThxxZ9Zp0jCZ5SccI2EI0mSiOsZt/TNFq7MGdjXbLLRHPnShI9nNENo5ANicLhbTkYEcUH582cx3vI/5ZvMR+6lsjHwQjs3uPh4H0CkUTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i7RyNxXJJfyukQBKmKxM8W1z3OjanGbAfQ68Mb82mKU=; b=YaRYRmDokdlZtgkK/TRwk9+RkDcZp0RhDeTMZS8YTyyzwSWJSjyrk8bw47J04Sv6gtIzMmAlJ0Tv8CjdT5WdBXf/ExpxMucz+F7D6y4v3TYxqyQKVz4J9aQ2b6ffG1oD2KwhLU+bi+2yCUVOHdvS2QR2ap3ZZxrdHPr7Nu/6xvN2n4mcG5yDNfwR7hf2NB7P9CTiy8Ohk0JoNqrqvuD4Qq49d3afOsW3lVjmPvL3yUiJJT68IsOiC8dmA2/xTzeAewlv5ijJmErcoGsD5wW/NpZNWXvMSjqDy0gtsXQVIQnB6tJN9Gd/6IIQ/wdLSKzSFLa9dGdmq9Cf+3CZKevIyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i7RyNxXJJfyukQBKmKxM8W1z3OjanGbAfQ68Mb82mKU=; b=LsgCwqQQmawPzseUm/cb0HwkEd05KT19XeLUrexSNHet+e5TN+LNhOUTgSyqA6V5qRjpPLS6U3F9VslTOSU0+3Yx9J6ZtI/xjTji2IdxPAkjh866Jtbz71qB9lF0Z06SQvDpfzXVgTEJ9rKTUiXp2os7GGupK6e/LNTbaINqEkM= Received: from CO6PR10MB5473.namprd10.prod.outlook.com (2603:10b6:5:355::21) by MWHPR1001MB2287.namprd10.prod.outlook.com (2603:10b6:301:31::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Fri, 29 Oct 2021 18:01:26 +0000 Received: from CO6PR10MB5473.namprd10.prod.outlook.com ([fe80::d0fa:fa4b:7c65:ddd6]) by CO6PR10MB5473.namprd10.prod.outlook.com ([fe80::d0fa:fa4b:7c65:ddd6%6]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021 18:01:26 +0000 From: Drew Adams To: Lars Ingebrigtsen Subject: RE: [External] : Re: bug#51469: 27.2; Mismatch: `set-face-attribute' and `face-all-attributes' Thread-Topic: [External] : Re: bug#51469: 27.2; Mismatch: `set-face-attribute' and `face-all-attributes' Thread-Index: AdfMT9s6eNjzRjfmSr6dxm5NMTOY6wAdtKkxAAimImA= Date: Fri, 29 Oct 2021 18:01:26 +0000 Message-ID: References: <87h7d0ynxz.fsf@gnus.org> In-Reply-To: <87h7d0ynxz.fsf@gnus.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gnus.org; dkim=none (message not signed) header.d=none;gnus.org; dmarc=none action=none header.from=oracle.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 504f0484-e225-4661-7464-08d99b062057 x-ms-traffictypediagnostic: MWHPR1001MB2287: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tfaV3mLMXMgsoS4M9HO0Yc+b+uQUWXQ7V2VYKC22OFZhgIeawreHHMZ/z6YA3ZYR6T5MASnANnOtaauDweek9aaQ81mWEIFLrSZcYZMmDV3Qz3J0YNKKcwHr91PrI8y6mZHlc9wJlKc6nh1Pt/gn5jSPGXiXVg290K6KtMMNtJXEhf/odiQgGUs2iZJGNnnKfOpBf24J0/zZqXE4UUgrbSYKc6UGT4yHvdpVTQLakIl6C2f/q/BLdQE2Y7f1TJfGOFiR5tdl76Mgb+2tX3jMou+wtO106iXlsttHt3yWURb/GHoUiU8DJ/O4lp6RsDYaNIoEiVKGcbSDzhkXMnEaR33q+i7QphiveDXkVvLVJBt/3pn8PJsQK9Zj/DD8fLcBR8e2x1q5HhZ46GXFLyGF9Ndxhl/3u3PyYITdUl7a44P+DkSjpUQHWh1OQPtt2xwhac1SYer04v+bCG/kD7K6S0jLyITIONeZqb/NAaqh+7kZVkuUEY0qGnkfRZa0JGxegBjs26Ei72blFDXn6fWiUqdGP71tLfDZCGFEejibj0UyP7LKUUtKxL8R5LD98tjtEA1/xCTuFAMBDPSs6/lrCsEj+YlNafReb0Z0kdS5mdOZwfem6VbD02QCsLXoXCCE9Kh/fYt0AhfwUaZRh3m1r7F7NDDL13bQuQdCKxYQD3IB2BVRNrmRBqXOhY2RXFwqIEtbhEC9m9Vwh8DRkHKC9SJhdDvcDv4qROVJ1m9h9+M= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR10MB5473.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(33656002)(66476007)(6506007)(7696005)(52536014)(44832011)(66556008)(38100700002)(8936002)(83380400001)(8676002)(4326008)(186003)(86362001)(5660300002)(122000001)(508600001)(71200400001)(2906002)(38070700005)(316002)(6916009)(55016002)(9686003)(64756008)(66946007)(66446008)(26005)(76116006)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/RKbB1CBq45HBNYZP+qEZT9J5L1YCjDuQc8kl44uTUHzZbFfsj5HBshLe/rR?= =?us-ascii?Q?F9cMdtlOARmKqIR+NHNHtwYbaZ2Ez1ACjOyUlnA95RoARRwtm41c0ZsdVYmN?= =?us-ascii?Q?y9VtWrCIAUYBDBBBwA6UpZlm5Ljv/8WoWa62r/d/8xT1k5OZz1GJkLbybthR?= =?us-ascii?Q?+j1iZwjWC7a74cAMscY7KIBYmlmPzZCqOO6KEpq3xOXLQo6FDlIgb0iwFEIj?= =?us-ascii?Q?hFUthHfoOYw9XGV0lDjVtX34NOYvnjyQu1nOIIEEoCirjMtRGXlF5AtT5zyb?= =?us-ascii?Q?DAk5XyCcdRxwrtoqf+knPujBwOzlj2APNJD4AN/zmE2NpZqqRCE7mvqjV6MM?= =?us-ascii?Q?nKjlTP74YCknhh1SAJL6CNCZpQK1eZCCFVeFDxpvFm8dAAWNaMg1eHe+cR/y?= =?us-ascii?Q?2m4Wh4IdLTwTG6UHcRShdIlgWO+D9V5W9AIO3zzjv8OTZ55vSOU5fjHrAUao?= =?us-ascii?Q?WJKw4NmZ8W+UQP3oOvnIz1okOO7qsXGsiwjGTL1sjgq9Mv1PHqItv1OHfjay?= =?us-ascii?Q?SKEeV2W+tj67qUUcw/VKZgsK5LJclq/65jdOiVOY5u06qUjTQfG+Fgb0scvb?= =?us-ascii?Q?ZOLGdw6Fvc6MbV6P0gEPKC+KYmjlUg42CHLS7m9K/Vo4hCUQzJqLnXDaJCcR?= =?us-ascii?Q?lPaTjvqZ0SgIcDb34oEMnXcVUbCjiMMdspsG5Jl+Y7OPhuYv347A3DwqKskO?= =?us-ascii?Q?U1+KXbB+fz73STFKiK6YNfJRAWwBDBdGI+L3xc9ZBJIy7CGH8+9+4IWap8qw?= =?us-ascii?Q?Yu3yTdIDr8DFPPtagDEpzp8D6hDSF+6we9JruTmVbRRuAShlKrSTZzzNBemH?= =?us-ascii?Q?jSxbA/Gxm0w/X6Jupc2x9uz0SdWA9NQBjFbrLg+t1e9PZsFmI+kDVSJtbvYY?= =?us-ascii?Q?24f2rcgjCPwM5CRRT8NuVYCzYtYO1hs1lllAtSjmLjbV8DsoxKtBU5V1UW88?= =?us-ascii?Q?Z6MfdX75XU0PtO6EAJDBNo636hQXzRuNZSLd6YYZvOK07EqR89G1UeVmWG8d?= =?us-ascii?Q?wT/W2b1NuRxJN8ukMj6Nbo5z0MhEHSvq04r9blmge4FO0fyVA9tqDspHTLbj?= =?us-ascii?Q?UDnagFeElRxK97U6TrdiFq2wa1T1K4xAi12JCoixMBtW3opvPvoYhOyidaMp?= =?us-ascii?Q?3dkDITsU4YKzXDI/fh56WZ3TWr2EMgWjZajhavVO2TrPyvKXxLENBdrUxzc5?= =?us-ascii?Q?NmWxGu8YsOWe1FernDxPtxBevFiAp1tD90Q2kVtglE84PHtyvGWkdKWykCfG?= =?us-ascii?Q?CZ+wsgkY3kmgsJJT00Ib3WbiyrIFVQFVxTwDUQMWl5a4fh/KMifgL5VwytEa?= =?us-ascii?Q?c1Futfjg3wmOJz0HeePSvYwx6gyshLvVraqmwgco5Lgv/hslITk9MlSXbmVH?= =?us-ascii?Q?9vwJpYuXFA0cTQnVyI4MpZRu/LSbVIg2UCxR5PKkPYT3BX2ka3UY5TzGCqeS?= =?us-ascii?Q?VD4Zjo7QQt0l5DPlr2kIW9bhnNQ47yCnYii4YBvf4vElFUYMDRAH53/RoBuO?= =?us-ascii?Q?Xasdt7B1qyJ/dCUHhCdOoBaqxV/TUS2Ay3/09sEbWYBl3znQ3VUcQfNEGnil?= =?us-ascii?Q?2Ap1oh1KMQqzyMDzxeNgrYG7UzxNW/RXHhGFZV+B/7jltvOzns0VwTs5r4X6?= =?us-ascii?Q?/Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5473.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 504f0484-e225-4661-7464-08d99b062057 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2021 18:01:26.3092 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cMhuTEqeXqxyVguvIkwYsHHnAyopUD4M6ruiQIF/l9qCy4dxI5EoMEbYM3ag0mJJVFWV96p99mh+oLh7fp/9hw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2287 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10152 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2110290098 X-Proofpoint-GUID: 69LKnB-6eI6Tqdw2xpdH6lSXXze0rR0r X-Proofpoint-ORIG-GUID: 69LKnB-6eI6Tqdw2xpdH6lSXXze0rR0r X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 51469 Cc: "51469@debbugs.gnu.org" <51469@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > face-all-attributes could return such a plist, but we usually prefer to > return alists from functions instead of plists. >=20 > > Is there a good reason for this status quo? If not, can we change it > > to get a better fit and not require conversion? >=20 > We can't change the output of face-all-attributes (because that would > break code), so I don't think there's anything to do here, and I'm > closing this bug report. Do as you like (you already did), but FTR, I disagree. ___ We could certainly allow another optional arg that specifies that the result be a plist. All that's lacking is the will (so far). If you want a patch for that, and if you'll actually use it, let me know. The definition below is what the patch would do. But I have a comment and a question first. A comment is that if you prefer to move the test for PLIST that's inside the loop outside of it, let me know. A question is why `face-all-attributes' excludes `:font' from the list of attributes it returns. More generally, shouldn't attribute `:font' be included in the value of defconst `face-attribute-name-alist'? If it should, then the code would be simpler, as would use by users (no special value needed for arg PLIST, to include `:font' for use by `set-face-attribute'). However, that's a "constant", and existing (3rd-party) code might now depend on `:font' not being included. So a 2nd part of the question is why we use `defconst'. If Emacs later adds an attribute (as it did with `:extend') then the "constant" is effectively broken. `defconst' is supposed to mean that neither program nor programmer is expected to change the value. ___ (defun face-all-attributes (face &optional frame plist) "Return an alist or plist of the attributes of FACE. By default, return an alist, with elements of the form \(ATTR-NAME . ATTR-VALUE). By default, ATTR-VALUE is the value provided by default for ATTR-NAME of FACE before it is defined with `defface', which means it is typically the symbol `unspecified'. But non-nil FRAME means ATTR-VALUE is the value of ATTR-NAME for FACE as it is defined for FRAME. Non-nil PLIST means return a plist, not an alist: \( ATTR-NAME-1 ATTR-VALUE-1 ATTR-NAME-2 ATTR-VALUE-2...). If PLIST is `font-also' then include attribute `:font'. In that case, the result includes all attributes valid as arguments to function `set-face-attribute'." (let ((names (if (eq plist 'font-also) (cons (cons :font "font") face-attribute-name-alist) face-attribute-name-alist)) (result ()) att val) (while names (setq att (caar names) val (face-attribute face att (or frame t)) names (cdr names)) (if (not plist) (push (cons att val) result) (push att result) (push val result))) (when plist (setq result (nreverse result))) result)) Eli recently made some kind of improvement to the doc of this function for bug #51465, to clarify what "default" attribute values mean for this when FRAME is nil. Dunno just what change he made, but the doc I show here can be changed to say whatever he said or whatever you like. Let me know the text you prefer, before I send any patch. From unknown Tue Jun 17 01:27:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 27 Nov 2021 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator