From unknown Thu Jun 19 14:04:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#51446 <51446@debbugs.gnu.org> To: bug#51446 <51446@debbugs.gnu.org> Subject: Status: [PATCH] image-dired: Unreverse accidentally reversed menus Reply-To: bug#51446 <51446@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:04:56 +0000 retitle 51446 [PATCH] image-dired: Unreverse accidentally reversed menus reassign 51446 emacs submitter 51446 Stefan Kangas severity 51446 normal tag 51446 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 27 15:36:22 2021 Received: (at submit) by debbugs.gnu.org; 27 Oct 2021 19:36:22 +0000 Received: from localhost ([127.0.0.1]:50624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfoij-0001yV-R9 for submit@debbugs.gnu.org; Wed, 27 Oct 2021 15:36:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:50146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfoiZ-0001yB-Ki for submit@debbugs.gnu.org; Wed, 27 Oct 2021 15:36:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfoiY-0007ds-15 for bug-gnu-emacs@gnu.org; Wed, 27 Oct 2021 15:36:11 -0400 Received: from mail-pl1-f180.google.com ([209.85.214.180]:43772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfoiV-0007P2-8L for bug-gnu-emacs@gnu.org; Wed, 27 Oct 2021 15:36:09 -0400 Received: by mail-pl1-f180.google.com with SMTP id y1so2734552plk.10 for ; Wed, 27 Oct 2021 12:36:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=igQM2NOMWAIkNoGl0ArquaFJejF6dChO1c+fAdVEPJg=; b=HJjlkbCVUZzfMYgb+U2g1euc+wcofHmzTr8IR1kBSqDfbzaZQsG6uq6VqA/6WrQZu7 sgzp8vROp4JSDtITinolt7NJqHHM4rNnzvfzpJ0URUv334gK2T1XnTTFhuuO1vT8SRV1 AB+zgiyfxtjTg8l7RHqZxvwRJw2SOmi/156rqxd7k1e54B2slX0zGUn9Gz5cEizwguyu HVX7GVjk/HAQwuw2pkz0FFHaVQ4DsdoZGtR+vjYKm/bH4BXCygAU6Dp5N59IyNF6jPEQ jk099tM6JPknoB80YJ0jYQlpY14EV6Fy7O5m8RZIRkjsxQXAD9rsM8Di7gt75FkFoPFZ UNXg== X-Gm-Message-State: AOAM531+Yrrjuqa+xxzz49ZqZP78VXLA8ohY26HilUHhqoN2ap8Cvq41 8GCP+uWepc2Rhh26pW7+O4LUXmCPm6w4wOSvDFdE8V0P X-Google-Smtp-Source: ABdhPJxG6G4OLspvevJUk8ydWMg4WB3NE4a3MRSq/oXJSJLXBvsF8gVkfDlIY37wyudsNQR1lGODhbY1WVAad2Jcct4= X-Received: by 2002:a17:902:e8c9:b0:141:6eaa:2137 with SMTP id v9-20020a170902e8c900b001416eaa2137mr4012388plg.22.1635363365764; Wed, 27 Oct 2021 12:36:05 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 27 Oct 2021 12:36:05 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Wed, 27 Oct 2021 12:36:05 -0700 Message-ID: Subject: [PATCH] image-dired: Unreverse accidentally reversed menus To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="0000000000007ed7d905cf5ab4fd" Received-SPF: pass client-ip=209.85.214.180; envelope-from=stefankangas@gmail.com; helo=mail-pl1-f180.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --0000000000007ed7d905cf5ab4fd Content-Type: text/plain; charset="UTF-8" image-dired: Unreverse accidentally reversed menus * lisp/image-dired.el (image-dired-thumbnail-mode-map) (image-dired-display-image-mode-map, image-dired-minor-mode-map): In commits b905454680c7 and bed0373855ea, the menus were converted to use 'easy-menu-define', but they were reversed in the process. Unreverse the menus. Eli and Lars, is the attached bug fix acceptable for 28.1? This merely reverses the menus and does nothing else. The change as such is a mechanical one, and after adjusting one two-line entry really just comes down to a `reverse-region', so I think it should be safe. --0000000000007ed7d905cf5ab4fd Content-Type: text/x-diff; charset="US-ASCII"; name="0001-image-dired-Unreverse-accidentally-reversed-menus.patch" Content-Disposition: attachment; filename="0001-image-dired-Unreverse-accidentally-reversed-menus.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 83acd19702d3c006_0.1 RnJvbSAyMTBjMTAyNTk4MWVjNTJhOWMwNTA4NzkyNGYyMzJkYjZkYzZmZjg4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogV2VkLCAyNyBPY3QgMjAyMSAyMToyODowMiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGltYWdl LWRpcmVkOiBVbnJldmVyc2UgYWNjaWRlbnRhbGx5IHJldmVyc2VkIG1lbnVzCgoqIGxpc3AvaW1h Z2UtZGlyZWQuZWwgKGltYWdlLWRpcmVkLXRodW1ibmFpbC1tb2RlLW1hcCkKKGltYWdlLWRpcmVk LWRpc3BsYXktaW1hZ2UtbW9kZS1tYXAsIGltYWdlLWRpcmVkLW1pbm9yLW1vZGUtbWFwKToKSW4g Y29tbWl0cyBiOTA1NDU0NjgwYzcgYW5kIGJlZDAzNzM4NTVlYSwgdGhlIG1lbnVzIHdlcmUgY29u dmVydGVkIHRvCnVzZSAnZWFzeS1tZW51LWRlZmluZScsIGJ1dCB0aGV5IHdlcmUgcmV2ZXJzZWQg aW4gdGhlIHByb2Nlc3MuClVucmV2ZXJzZSB0aGUgbWVudXMuCi0tLQogbGlzcC9pbWFnZS1kaXJl ZC5lbCB8IDc2ICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQog MSBmaWxlIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDM4IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2xpc3AvaW1hZ2UtZGlyZWQuZWwgYi9saXNwL2ltYWdlLWRpcmVkLmVsCmluZGV4IDk5 ODVlNWE1NGIuLjMyOTA4NWM4MjMgMTAwNjQ0Ci0tLSBhL2xpc3AvaW1hZ2UtZGlyZWQuZWwKKysr IGIvbGlzcC9pbWFnZS1kaXJlZC5lbApAQCAtMTU0NywzMyArMTU0NywzMyBAQCBpbWFnZS1kaXJl ZC10aHVtYm5haWwtbW9kZS1tYXAKICAgICAoZWFzeS1tZW51LWRlZmluZSBuaWwgbWFwCiAgICAg ICAiTWVudSBmb3IgYGltYWdlLWRpcmVkLXRodW1ibmFpbC1tb2RlJy4iCiAgICAgICAnKCJJbWFn ZS1EaXJlZCIKLSAgICAgICAgWyJRdWl0IiBxdWl0LXdpbmRvd10KLSAgICAgICAgWyJEZWxldGUg dGh1bWJuYWlsIGZyb20gYnVmZmVyIiBpbWFnZS1kaXJlZC1kZWxldGUtY2hhcl0KLSAgICAgICAg WyJEZWxldGUgbWFya2VkIGltYWdlcyIgaW1hZ2UtZGlyZWQtZGVsZXRlLW1hcmtlZF0KLSAgICAg ICAgWyJSZW1vdmUgdGFnIGZyb20gY3VycmVudCBvciBtYXJrZWQgdGh1bWJuYWlscyIKLSAgICAg ICAgIGltYWdlLWRpcmVkLXRhZy10aHVtYm5haWwtcmVtb3ZlXQotICAgICAgICBbIlRhZyBjdXJy ZW50IG9yIG1hcmtlZCB0aHVtYm5haWxzIiBpbWFnZS1kaXJlZC10YWctdGh1bWJuYWlsXQotICAg ICAgICBbIkNvbW1lbnQgdGh1bWJuYWlsIiBpbWFnZS1kaXJlZC1jb21tZW50LXRodW1ibmFpbF0K LSAgICAgICAgWyJSZWZyZXNoIHRodW1iIiBpbWFnZS1kaXJlZC1yZWZyZXNoLXRodW1iXQotICAg ICAgICBbIkR5bmFtaWMgbGluZSB1cCIgaW1hZ2UtZGlyZWQtbGluZS11cC1keW5hbWljXQotICAg ICAgICBbIkxpbmUgdXAgdGh1bWJuYWlscyIgaW1hZ2UtZGlyZWQtbGluZS11cF0KLQotICAgICAg ICBbIlJvdGF0ZSB0aHVtYm5haWwgbGVmdCIgaW1hZ2UtZGlyZWQtcm90YXRlLXRodW1ibmFpbC1s ZWZ0XQotICAgICAgICBbIlJvdGF0ZSB0aHVtYm5haWwgcmlnaHQiIGltYWdlLWRpcmVkLXJvdGF0 ZS10aHVtYm5haWwtcmlnaHRdCi0gICAgICAgIFsiUm90YXRlIG9yaWdpbmFsIGxlZnQiIGltYWdl LWRpcmVkLXJvdGF0ZS1vcmlnaW5hbC1sZWZ0XQotICAgICAgICBbIlJvdGF0ZSBvcmlnaW5hbCBy aWdodCIgaW1hZ2UtZGlyZWQtcm90YXRlLW9yaWdpbmFsLXJpZ2h0XQorICAgICAgICBbIkRpc3Bs YXkgaW1hZ2UiIGltYWdlLWRpcmVkLWRpc3BsYXktdGh1bWJuYWlsLW9yaWdpbmFsLWltYWdlXQor ICAgICAgICBbIkRpc3BsYXkgaW4gZXh0ZXJuYWwgdmlld2VyIiBpbWFnZS1kaXJlZC10aHVtYm5h aWwtZGlzcGxheS1leHRlcm5hbF0KIAotICAgICAgICBbIlRvZ2dsZSBtb3ZlbWVudCB0cmFja2lu ZyBvbi9vZmYiIGltYWdlLWRpcmVkLXRvZ2dsZS1tb3ZlbWVudC10cmFja2luZ10KKyAgICAgICAg WyJNYXJrIG9yaWdpbmFsIiBpbWFnZS1kaXJlZC1tYXJrLXRodW1iLW9yaWdpbmFsLWZpbGVdCisg ICAgICAgIFsiVW5tYXJrIG9yaWdpbmFsIiBpbWFnZS1kaXJlZC11bm1hcmstdGh1bWItb3JpZ2lu YWwtZmlsZV0KKyAgICAgICAgWyJGbGFnIG9yaWdpbmFsIGZvciBkZWxldGlvbiIgaW1hZ2UtZGly ZWQtZmxhZy10aHVtYi1vcmlnaW5hbC1maWxlXQogCi0gICAgICAgIFsiSnVtcCB0byBkaXJlZCBi dWZmZXIiIGltYWdlLWRpcmVkLWp1bXAtb3JpZ2luYWwtZGlyZWQtYnVmZmVyXQogICAgICAgICBb IlRyYWNrIG9yaWdpbmFsIiBpbWFnZS1kaXJlZC10cmFjay1vcmlnaW5hbC1maWxlXQorICAgICAg ICBbIkp1bXAgdG8gZGlyZWQgYnVmZmVyIiBpbWFnZS1kaXJlZC1qdW1wLW9yaWdpbmFsLWRpcmVk LWJ1ZmZlcl0KIAotICAgICAgICBbIkZsYWcgb3JpZ2luYWwgZm9yIGRlbGV0aW9uIiBpbWFnZS1k aXJlZC1mbGFnLXRodW1iLW9yaWdpbmFsLWZpbGVdCi0gICAgICAgIFsiVW5tYXJrIG9yaWdpbmFs IiBpbWFnZS1kaXJlZC11bm1hcmstdGh1bWItb3JpZ2luYWwtZmlsZV0KLSAgICAgICAgWyJNYXJr IG9yaWdpbmFsIiBpbWFnZS1kaXJlZC1tYXJrLXRodW1iLW9yaWdpbmFsLWZpbGVdCisgICAgICAg IFsiVG9nZ2xlIG1vdmVtZW50IHRyYWNraW5nIG9uL29mZiIgaW1hZ2UtZGlyZWQtdG9nZ2xlLW1v dmVtZW50LXRyYWNraW5nXQogCi0gICAgICAgIFsiRGlzcGxheSBpbiBleHRlcm5hbCB2aWV3ZXIi IGltYWdlLWRpcmVkLXRodW1ibmFpbC1kaXNwbGF5LWV4dGVybmFsXQotICAgICAgICBbIkRpc3Bs YXkgaW1hZ2UiIGltYWdlLWRpcmVkLWRpc3BsYXktdGh1bWJuYWlsLW9yaWdpbmFsLWltYWdlXSkp CisgICAgICAgIFsiUm90YXRlIG9yaWdpbmFsIHJpZ2h0IiBpbWFnZS1kaXJlZC1yb3RhdGUtb3Jp Z2luYWwtcmlnaHRdCisgICAgICAgIFsiUm90YXRlIG9yaWdpbmFsIGxlZnQiIGltYWdlLWRpcmVk LXJvdGF0ZS1vcmlnaW5hbC1sZWZ0XQorICAgICAgICBbIlJvdGF0ZSB0aHVtYm5haWwgcmlnaHQi IGltYWdlLWRpcmVkLXJvdGF0ZS10aHVtYm5haWwtcmlnaHRdCisgICAgICAgIFsiUm90YXRlIHRo dW1ibmFpbCBsZWZ0IiBpbWFnZS1kaXJlZC1yb3RhdGUtdGh1bWJuYWlsLWxlZnRdCisKKyAgICAg ICAgWyJMaW5lIHVwIHRodW1ibmFpbHMiIGltYWdlLWRpcmVkLWxpbmUtdXBdCisgICAgICAgIFsi RHluYW1pYyBsaW5lIHVwIiBpbWFnZS1kaXJlZC1saW5lLXVwLWR5bmFtaWNdCisgICAgICAgIFsi UmVmcmVzaCB0aHVtYiIgaW1hZ2UtZGlyZWQtcmVmcmVzaC10aHVtYl0KKyAgICAgICAgWyJDb21t ZW50IHRodW1ibmFpbCIgaW1hZ2UtZGlyZWQtY29tbWVudC10aHVtYm5haWxdCisgICAgICAgIFsi VGFnIGN1cnJlbnQgb3IgbWFya2VkIHRodW1ibmFpbHMiIGltYWdlLWRpcmVkLXRhZy10aHVtYm5h aWxdCisgICAgICAgIFsiUmVtb3ZlIHRhZyBmcm9tIGN1cnJlbnQgb3IgbWFya2VkIHRodW1ibmFp bHMiCisgICAgICAgICBpbWFnZS1kaXJlZC10YWctdGh1bWJuYWlsLXJlbW92ZV0KKyAgICAgICAg WyJEZWxldGUgbWFya2VkIGltYWdlcyIgaW1hZ2UtZGlyZWQtZGVsZXRlLW1hcmtlZF0KKyAgICAg ICAgWyJEZWxldGUgdGh1bWJuYWlsIGZyb20gYnVmZmVyIiBpbWFnZS1kaXJlZC1kZWxldGUtY2hh cl0KKyAgICAgICAgWyJRdWl0IiBxdWl0LXdpbmRvd10pKQogICAgIG1hcCkKICAgIktleW1hcCBm b3IgYGltYWdlLWRpcmVkLXRodW1ibmFpbC1tb2RlJy4iKQogCkBAIC0xNjA2LDkgKzE2MDYsOSBA QCBpbWFnZS1kaXJlZC1kaXNwbGF5LWltYWdlLW1vZGUtbWFwCiAgICAgKGVhc3ktbWVudS1kZWZp bmUgbmlsIG1hcAogICAgICAgIk1lbnUgZm9yIGBpbWFnZS1kaXJlZC1kaXNwbGF5LWltYWdlLW1v ZGUtbWFwJy4iCiAgICAgICAnKCJJbWFnZS1EaXJlZCIKLSAgICAgICAgWyJRdWl0IiBxdWl0LXdp bmRvd10KKyAgICAgICAgWyJEaXNwbGF5IG9yaWdpbmFsLCBmdWxsIHNpemUiIGltYWdlLWRpcmVk LWRpc3BsYXktY3VycmVudC1pbWFnZS1mdWxsXQogICAgICAgICBbIkRpc3BsYXkgb3JpZ2luYWws IHNpemVkIHRvIGZpdCIgaW1hZ2UtZGlyZWQtZGlzcGxheS1jdXJyZW50LWltYWdlLXNpemVkXQot ICAgICAgICBbIkRpc3BsYXkgb3JpZ2luYWwsIGZ1bGwgc2l6ZSIgaW1hZ2UtZGlyZWQtZGlzcGxh eS1jdXJyZW50LWltYWdlLWZ1bGxdKSkKKyAgICAgICAgWyJRdWl0IiBxdWl0LXdpbmRvd10pKQog ICAgIG1hcCkKICAgIktleW1hcCBmb3IgYGltYWdlLWRpcmVkLWRpc3BsYXktaW1hZ2UtbW9kZScu IikKIApAQCAtMTY3NSwyNSArMTY3NSwyNSBAQCBpbWFnZS1kaXJlZC1taW5vci1tb2RlLW1hcAog ICAgIChlYXN5LW1lbnUtZGVmaW5lIG5pbCBtYXAKICAgICAgICJNZW51IGZvciBgaW1hZ2UtZGly ZWQtbWlub3ItbW9kZScuIgogICAgICAgJygiSW1hZ2UtZGlyZWQiCi0gICAgICAgIFsiQ29weSB3 aXRoIEVYSUYgZmlsZSBuYW1lIiBpbWFnZS1kaXJlZC1jb3B5LXdpdGgtZXhpZi1maWxlLW5hbWVd Ci0gICAgICAgIFsiQ29tbWVudCBmaWxlcyIgaW1hZ2UtZGlyZWQtZGlyZWQtY29tbWVudC1maWxl c10KLSAgICAgICAgWyJNYXJrIHRhZ2dlZCBmaWxlcyIgaW1hZ2UtZGlyZWQtbWFyay10YWdnZWQt ZmlsZXNdCi0gICAgICAgIFsiSnVtcCB0byB0aHVtYm5haWwgYnVmZmVyIiBpbWFnZS1kaXJlZC1q dW1wLXRodW1ibmFpbC1idWZmZXJdCisgICAgICAgIFsiRGlzcGxheSB0aHVtYiBmb3IgbmV4dCBm aWxlIiBpbWFnZS1kaXJlZC1uZXh0LWxpbmUtYW5kLWRpc3BsYXldCisgICAgICAgIFsiRGlzcGxh eSB0aHVtYiBmb3IgcHJldmlvdXMgZmlsZSIgaW1hZ2UtZGlyZWQtcHJldmlvdXMtbGluZS1hbmQt ZGlzcGxheV0KKyAgICAgICAgWyJNYXJrIGFuZCBkaXNwbGF5IG5leHQiIGltYWdlLWRpcmVkLW1h cmstYW5kLWRpc3BsYXktbmV4dF0KIAotICAgICAgICBbIlRvZ2dsZSBtb3ZlbWVudCB0cmFja2lu ZyIgaW1hZ2UtZGlyZWQtdG9nZ2xlLW1vdmVtZW50LXRyYWNraW5nXQotICAgICAgICBbIlRvZ2ds ZSBhcHBlbmQgYnJvd3NpbmciIGltYWdlLWRpcmVkLXRvZ2dsZS1hcHBlbmQtYnJvd3NpbmddCi0g ICAgICAgIFsiVG9nZ2xlIGRpc3BsYXkgcHJvcGVydGllcyIgaW1hZ2UtZGlyZWQtdG9nZ2xlLWRp cmVkLWRpc3BsYXktcHJvcGVydGllc10KKyAgICAgICAgWyJDcmVhdGUgdGh1bWJuYWlscyBmb3Ig bWFya2VkIGZpbGVzIiBpbWFnZS1kaXJlZC1jcmVhdGUtdGh1bWJzXQogCi0gICAgICAgIFsiRGlz cGxheSBpbiBleHRlcm5hbCB2aWV3ZXIiIGltYWdlLWRpcmVkLWRpcmVkLWRpc3BsYXktZXh0ZXJu YWxdCi0gICAgICAgIFsiRGlzcGxheSBpbWFnZSIgaW1hZ2UtZGlyZWQtZGlyZWQtZGlzcGxheS1p bWFnZV0KLSAgICAgICAgWyJEaXNwbGF5IHRoaXMgdGh1bWJuYWlsIiBpbWFnZS1kaXJlZC1kaXNw bGF5LXRodW1iXQogICAgICAgICBbIkRpc3BsYXkgdGh1bWJuYWlscyBhcHBlbmQiIGltYWdlLWRp cmVkLWRpc3BsYXktdGh1bWJzLWFwcGVuZF0KKyAgICAgICAgWyJEaXNwbGF5IHRoaXMgdGh1bWJu YWlsIiBpbWFnZS1kaXJlZC1kaXNwbGF5LXRodW1iXQorICAgICAgICBbIkRpc3BsYXkgaW1hZ2Ui IGltYWdlLWRpcmVkLWRpcmVkLWRpc3BsYXktaW1hZ2VdCisgICAgICAgIFsiRGlzcGxheSBpbiBl eHRlcm5hbCB2aWV3ZXIiIGltYWdlLWRpcmVkLWRpcmVkLWRpc3BsYXktZXh0ZXJuYWxdCiAKLSAg ICAgICAgWyJDcmVhdGUgdGh1bWJuYWlscyBmb3IgbWFya2VkIGZpbGVzIiBpbWFnZS1kaXJlZC1j cmVhdGUtdGh1bWJzXQorICAgICAgICBbIlRvZ2dsZSBkaXNwbGF5IHByb3BlcnRpZXMiIGltYWdl LWRpcmVkLXRvZ2dsZS1kaXJlZC1kaXNwbGF5LXByb3BlcnRpZXNdCisgICAgICAgIFsiVG9nZ2xl IGFwcGVuZCBicm93c2luZyIgaW1hZ2UtZGlyZWQtdG9nZ2xlLWFwcGVuZC1icm93c2luZ10KKyAg ICAgICAgWyJUb2dnbGUgbW92ZW1lbnQgdHJhY2tpbmciIGltYWdlLWRpcmVkLXRvZ2dsZS1tb3Zl bWVudC10cmFja2luZ10KIAotICAgICAgICBbIk1hcmsgYW5kIGRpc3BsYXkgbmV4dCIgaW1hZ2Ut ZGlyZWQtbWFyay1hbmQtZGlzcGxheS1uZXh0XQotICAgICAgICBbIkRpc3BsYXkgdGh1bWIgZm9y IHByZXZpb3VzIGZpbGUiIGltYWdlLWRpcmVkLXByZXZpb3VzLWxpbmUtYW5kLWRpc3BsYXldCi0g ICAgICAgIFsiRGlzcGxheSB0aHVtYiBmb3IgbmV4dCBmaWxlIiBpbWFnZS1kaXJlZC1uZXh0LWxp bmUtYW5kLWRpc3BsYXldKSkKKyAgICAgICAgWyJKdW1wIHRvIHRodW1ibmFpbCBidWZmZXIiIGlt YWdlLWRpcmVkLWp1bXAtdGh1bWJuYWlsLWJ1ZmZlcl0KKyAgICAgICAgWyJNYXJrIHRhZ2dlZCBm aWxlcyIgaW1hZ2UtZGlyZWQtbWFyay10YWdnZWQtZmlsZXNdCisgICAgICAgIFsiQ29tbWVudCBm aWxlcyIgaW1hZ2UtZGlyZWQtZGlyZWQtY29tbWVudC1maWxlc10KKyAgICAgICAgWyJDb3B5IHdp dGggRVhJRiBmaWxlIG5hbWUiIGltYWdlLWRpcmVkLWNvcHktd2l0aC1leGlmLWZpbGUtbmFtZV0p KQogICAgIG1hcCkKICAgIktleW1hcCBmb3IgYGltYWdlLWRpcmVkLW1pbm9yLW1vZGUnLiIpCiAK LS0gCjIuMzAuMgoK --0000000000007ed7d905cf5ab4fd-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 28 02:58:01 2021 Received: (at 51446) by debbugs.gnu.org; 28 Oct 2021 06:58:01 +0000 Received: from localhost ([127.0.0.1]:51168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfzMO-0001WJ-RD for submit@debbugs.gnu.org; Thu, 28 Oct 2021 02:58:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfzMN-0001W4-9K for 51446@debbugs.gnu.org; Thu, 28 Oct 2021 02:58:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39092) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfzMH-00081w-Qa; Thu, 28 Oct 2021 02:57:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=10Rpc2pROfkGc5CK3w0FddNhTRv3uGe6bz3lGmaQtNI=; b=KT+Y1kDzGk5h 9aWkCpi4ZBy3wuJLPJwmHo6mI5/HWQQQpZCqO8K9Yj2w/MYVnWy0Ns2zClR46kN8N9HrZcHd/0xaG BpXObpMijLgjPN5zj98gv+uGtKsl1dMx83rM19+BAGWCNsP6Ye0tNK1soF/0xqaYekSW/NwvsGDLj sgDeuvkQJYQfjzpAPpKSzCOQ6le1I6tFQzG6jet/UafsZlj3b/qhfazsXcCRr92skhh7pqtKO0SSu 1biLLJ4MZPNdpqvmZlq6NRE5r9V6jycUO0e+CYW2jGL9zErwWOhzvk5piqRSsuhXvbzNj5yc0qv7X vvvwV+TD3QQtwNeqIU+iWQ==; Received: from [87.69.77.57] (port=1579 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfzMH-0000LH-Ag; Thu, 28 Oct 2021 02:57:53 -0400 Date: Thu, 28 Oct 2021 09:57:54 +0300 Message-Id: <83v91htz4d.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Wed, 27 Oct 2021 12:36:05 -0700) Subject: Re: bug#51446: [PATCH] image-dired: Unreverse accidentally reversed menus References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51446 Cc: 51446@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Wed, 27 Oct 2021 12:36:05 -0700 > > image-dired: Unreverse accidentally reversed menus > > * lisp/image-dired.el (image-dired-thumbnail-mode-map) > (image-dired-display-image-mode-map, image-dired-minor-mode-map): > In commits b905454680c7 and bed0373855ea, the menus were converted to > use 'easy-menu-define', but they were reversed in the process. > Unreverse the menus. > > Eli and Lars, is the attached bug fix acceptable for 28.1? This merely > reverses the menus and does nothing else. The change as such is a > mechanical one, and after adjusting one two-line entry really just comes > down to a `reverse-region', so I think it should be safe. I don't understand: I seem to see the same order of the menu items in Emacs 27 and on the current release branch, so what am I missing? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 28 03:27:26 2021 Received: (at 51446) by debbugs.gnu.org; 28 Oct 2021 07:27:26 +0000 Received: from localhost ([127.0.0.1]:51227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfzor-0002O3-Ra for submit@debbugs.gnu.org; Thu, 28 Oct 2021 03:27:26 -0400 Received: from mail-pg1-f172.google.com ([209.85.215.172]:44959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfzoq-0002No-5h for 51446@debbugs.gnu.org; Thu, 28 Oct 2021 03:27:25 -0400 Received: by mail-pg1-f172.google.com with SMTP id c4so5517310pgv.11 for <51446@debbugs.gnu.org>; Thu, 28 Oct 2021 00:27:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=u37s2vMMxWIBp02OOs/5mu6PZaJBofFGMRD8e+Ot8Xg=; b=gGUZA81EXIeScrG6w34wQ4ZZ8VAuskTe6Tb/x4Xm985Y9tVaArsu7HQ3hBXpRP4Dxy SxP8muEWHJQ7N7uSMIY9+8J6dmxy8aG40QlGml+cK+ADsh8NPNvRlxefWd9Ur29Zvt+V 9wKmz804licB4yzyhEjWRM2yRoMCGIf6aik/a4kGoE4UFDV4iZMs7ELOmxtDpBsH36ZK RNCktNSj7QJ/CpdIUAZWGNwJJdHsRXIp7nOq1CSO+o9/lK1aVSjOdxycTmLa6htZyG22 AH6uvUB5bEuS2ufAbWFG4ts5OqrMUEgLk6mnY9+dvitcXy8Sm2VQ1WuE1UqYOK1baXMk BVUQ== X-Gm-Message-State: AOAM5327tXc7MCWS964Llhrhl+7K4dlCXgSBYhdm85vkf+iPcAeMLVP0 XbDzQSM4nFI7KD7Gt1VhfkxwG8T/1QiU/pAyUfyHRksZ X-Google-Smtp-Source: ABdhPJyN05YC7v5T3/jE3G5u2eWsiGctA4aQ5sMuyTW8wYtxHYbSrb8EkWZ8VSzEbYvOdTvZocbMT9EDmGyNfqDmlb8= X-Received: by 2002:a63:b958:: with SMTP id v24mr1991654pgo.114.1635406038401; Thu, 28 Oct 2021 00:27:18 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 28 Oct 2021 00:27:18 -0700 From: Stefan Kangas In-Reply-To: <83v91htz4d.fsf@gnu.org> References: <83v91htz4d.fsf@gnu.org> MIME-Version: 1.0 Date: Thu, 28 Oct 2021 00:27:18 -0700 Message-ID: Subject: Re: bug#51446: [PATCH] image-dired: Unreverse accidentally reversed menus To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51446 Cc: 51446@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > I don't understand: I seem to see the same order of the menu items in > Emacs 27 and on the current release branch, so what am I missing? The regression was introduced in Emacs 26.1, in these commits: $ git tag --contain=bed0373855ea | head -3 emacs-26.0.90 emacs-26.0.91 emacs-26.1 $ git tag --contain=b905454680c7 | head -3 emacs-26.0.90 emacs-26.0.91 emacs-26.1 It's the easy-to-make mistake of converting to easy-menu-define without realizing that the order is not reversed there. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 28 05:32:48 2021 Received: (at 51446) by debbugs.gnu.org; 28 Oct 2021 09:32:48 +0000 Received: from localhost ([127.0.0.1]:51353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mg1mC-0006HU-5O for submit@debbugs.gnu.org; Thu, 28 Oct 2021 05:32:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mg1m7-0006HB-8o for 51446@debbugs.gnu.org; Thu, 28 Oct 2021 05:32:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mg1m1-00079X-Tf; Thu, 28 Oct 2021 05:32:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mr1x3LPA1cTw4MLvOPFJOfbP7GAj+rZadvl26qDemRk=; b=IiFaexbpJuDj AshpxzurmKWh7eekIdfHA11nFZM2bUSASV4myeq91Xjgm+w30regExVXlQmw+cAejjZZfCy2MBVxK D4faj5jjCBnoGv6hX4He2EKbRFpTsYsm5ZShUnvm4IEwhh/aPWaZPtJ1KRPmcA7H9X/Kp7i4oWS6+ cM/HwAog2D+FZehm8JsIep4hlYFFL31cAyWpVBzocmP5aji3umIDCWdrV4FjZRjN2KkYKV7akfE6X MUmprXfNKfUEEgLyVYLShJ6ym2j4BWwXJFE4QOnH77AbRUbbicbMDrnNvlwb6/nhCLZn/iiaW6loL 7P1Kia5++rsFd0NKAzo0Vg==; Received: from [87.69.77.57] (port=3267 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mg1m0-0000Kp-Dv; Thu, 28 Oct 2021 05:32:36 -0400 Date: Thu, 28 Oct 2021 12:32:37 +0300 Message-Id: <83h7d1tryi.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Thu, 28 Oct 2021 00:27:18 -0700) Subject: Re: bug#51446: [PATCH] image-dired: Unreverse accidentally reversed menus References: <83v91htz4d.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 51446 Cc: 51446@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Thu, 28 Oct 2021 00:27:18 -0700 > Cc: 51446@debbugs.gnu.org > > Eli Zaretskii writes: > > > I don't understand: I seem to see the same order of the menu items in > > Emacs 27 and on the current release branch, so what am I missing? > > The regression was introduced in Emacs 26.1, in these commits: > > $ git tag --contain=bed0373855ea | head -3 > emacs-26.0.90 > emacs-26.0.91 > emacs-26.1 > $ git tag --contain=b905454680c7 | head -3 > emacs-26.0.90 > emacs-26.0.91 > emacs-26.1 > > It's the easy-to-make mistake of converting to easy-menu-define without > realizing that the order is not reversed there. Thanks. I cannot invoke image-dired-minor-mode in Emacs 25, so I cannot see the problem. I don't really understand why the order of the items in the menu matters in this case. but it doesn't matter; please go ahead and install the change. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 28 07:04:57 2021 Received: (at 51446) by debbugs.gnu.org; 28 Oct 2021 11:04:57 +0000 Received: from localhost ([127.0.0.1]:51459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mg3DN-0000jF-F0 for submit@debbugs.gnu.org; Thu, 28 Oct 2021 07:04:57 -0400 Received: from mail-pj1-f46.google.com ([209.85.216.46]:38680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mg3DM-0000iv-9A for 51446@debbugs.gnu.org; Thu, 28 Oct 2021 07:04:56 -0400 Received: by mail-pj1-f46.google.com with SMTP id s10-20020a17090a6e4a00b001a5f4da9892so504294pjm.3 for <51446@debbugs.gnu.org>; Thu, 28 Oct 2021 04:04:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=hHVPrSky1JGnQ6g2Qj5IODDbTZ0jaMDGlIEuA5PJd0U=; b=ae3M+8aPI1y12mWwsL1B5wC0+KtdkbU68V6WdJgZRw4Pol8tMjZDLQFiSM8Fm4yo6V AAs22Q3mZw0trVoHf/jza04YaHFykaofRfPeS1xTE40e+FkLqgKoHkZ6qoY5nrfTu7JA h5aT3fOP4AsVBm6sS7owO5ET93/hjOFn9dhE0Uy6XvbyFxHCCuPFn2PTb0JxAnLV6P4u 7ol3xqzL4+ZDXZH18z3tvdObV1SDfVKOc0sNkpigHeurFSe0j2Da8w7md6PcL82Jcd8c dd4lqlVxArsxNDuYgHQdgMM5cHd/qHqLGGNryeSlOfnV0FxgQFFxMnGeDs7/A1T8mEHA YPTA== X-Gm-Message-State: AOAM5324kC8GSnqGfX3PsjFrRZWSAn9XXSCpNns9ysC8xWAAB4enx9SG yRa+6MSZ0m/mZAHG8lBsu8cEIbjFwShl+W9xlh8= X-Google-Smtp-Source: ABdhPJyEWdK2A3bgMGo4YZVLbpGSYTPhn397HFgYFaWKiIJubgvQWsu7afCaAwBuZos3noACTAgjkR6aYXj4sh+R+ks= X-Received: by 2002:a17:90b:3b86:: with SMTP id pc6mr11840365pjb.143.1635419090653; Thu, 28 Oct 2021 04:04:50 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 28 Oct 2021 07:04:50 -0400 From: Stefan Kangas In-Reply-To: <83h7d1tryi.fsf@gnu.org> References: <83v91htz4d.fsf@gnu.org> <83h7d1tryi.fsf@gnu.org> MIME-Version: 1.0 Date: Thu, 28 Oct 2021 07:04:50 -0400 Message-ID: Subject: Re: bug#51446: [PATCH] image-dired: Unreverse accidentally reversed menus To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 51446 Cc: 51446@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) close 51446 28.1 thanks Eli Zaretskii writes: > Thanks. I cannot invoke image-dired-minor-mode in Emacs 25, so I > cannot see the problem. I don't really understand why the order of > the items in the menu matters in this case. but it doesn't matter; I believe it should be enough to just say `M-x image-dired'. As for why the fix matters, it's mostly just confusing to have "Quit" at the top. > please go ahead and install the change. Thanks, pushed to emacs-28 (commit f52fa1c150). From unknown Thu Jun 19 14:04:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 25 Nov 2021 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator