GNU bug report logs - #51434
[PATCH] Fix typos

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51434 in the body.
You can then email your comments to 51434 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jan Synáček <jan.synacek <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix typos
Date: Wed, 27 Oct 2021 14:12:34 +0200

[Message part 1 (text/plain, inline)]

Tags: patch


In GNU Emacs 28.0.60 (build 13, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4)
 of 2021-10-27 built on jsynacek-home
Repository revision: b81471279696e591ab91eb4eb10e9544f9f903ac
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: Arch Linux

Configured using:
 'configure --with-native-compilation'

[0001-Fix-typos.patch (text/patch, attachment)]

Message #8 received at 51434 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Jan Synáček <jan.synacek <at> gmail.com>
Cc: 51434 <at> debbugs.gnu.org
Subject: Re: bug#51434: [PATCH] Fix typos
Date: Wed, 27 Oct 2021 17:24:50 +0200

>>>>> On Wed, 27 Oct 2021 14:12:34 +0200, Jan Synáček <jan.synacek <at> gmail.com> said:
    Jan>  When I work over a network, I forget which machine I am using.  Also,
    Jan> -I tend to I lose track of where I am, and which line point is on.
    Jan> +I tend to lose track of where I am, and which line point is on.

Yes.

    Jan>  So I reset my mode line to look like this:
 
    Jan> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
    Jan> index bc21f027b6..19e02bdc79 100644
    Jan> --- a/lisp/minibuffer.el
    Jan> +++ b/lisp/minibuffer.el
    Jan> @@ -3579,7 +3579,7 @@ completion-pcm--hilit-commonality
    Jan>                  ;; "hole" in the middle of the string is indicated by
    Jan>                  ;; "-".  Note that there are no "holes" near the edges
    Jan>                  ;; of the string.  The completion score is a number
    Jan> -                ;; bound by ]0..1]: the higher the better and only a
    Jan> +                ;; bound by [0..1]: the higher the better and only a
    Jan>                  ;; perfect match (pattern equals string) will have
    Jan>                  ;; score 1.  The formula takes the form of a quotient.
    Jan>                  ;; For the numerator, we use the number of +, i.e. the

No. Itʼs talking about the range 0..1 but without including 0

Robert
-- 

Message #11 received at 51434 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 51434 <at> debbugs.gnu.org, Jan Synáček <jan.synacek <at> gmail.com>
Subject: Re: bug#51434: [PATCH] Fix typos
Date: Wed, 27 Oct 2021 17:34:30 +0200

Robert Pluim <rpluim <at> gmail.com> writes:

>     Jan> -                ;; bound by ]0..1]: the higher the better and only a
>     Jan> +                ;; bound by [0..1]: the higher the better and only a

[...]

> No. Itʼs talking about the range 0..1 but without including 0

I don't think I've seen that syntax before -- <0..1] is pretty common,
though.

In any case, I think it's better to spell this out explicitly.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #16 received at 51434 <at> debbugs.gnu.org (full text, mbox):

From: "H. Dieter Wilhelm" <dieter <at> duenenhof-wilhelm.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 51434 <at> debbugs.gnu.org, Jan Synáček <jan.synacek <at> gmail.com>,
 Robert Pluim <rpluim <at> gmail.com>
Subject: Re: bug#51434: [PATCH] Fix typos
Date: Thu, 28 Oct 2021 08:15:49 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Robert Pluim <rpluim <at> gmail.com> writes:
>
>>     Jan> -                ;; bound by ]0..1]: the higher the better and only a
>>     Jan> +                ;; bound by [0..1]: the higher the better and only a
>
> [...]
>
>> No. Itʼs talking about the range 0..1 but without including 0
>
> I don't think I've seen that syntax before -- <0..1] is pretty common,
> though.

May I pipe in with another convention?  

Emacs' Calc is using this notation (0 .. 1] for one sided open
ranges.. ;-)

> In any case, I think it's better to spell this out explicitly.

Off course

Message #19 received at 51434 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Jan Synáček <jan.synacek <at> gmail.com>
Cc: 51434 <at> debbugs.gnu.org
Subject: Re: bug#51434: [PATCH] Fix typos
Date: Thu, 28 Oct 2021 23:34:04 +0200

Jan Synáček <jan.synacek <at> gmail.com> writes:

> Tags: patch

Thanks; applied with a slight change:

"H. Dieter Wilhelm" <dieter <at> duenenhof-wilhelm.de> writes:

> Emacs' Calc is using this notation (0 .. 1] for one sided open
> ranges.. ;-)

Yeah, that seems like the most common syntax.

>> In any case, I think it's better to spell this out explicitly.
>
> Off course

So I've now done this in emacs-28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.