GNU bug report logs - #51432
[PATCH 0/4] gnu: Add flask-combo-jsonapi

Previous Next

Full log

Message #34 received at 51432-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: david larsson <david.larsson <at> selfhosted.xyz>
Cc: 51432-done <at> debbugs.gnu.org
Subject: Re: [bug#51432] [PATCH 1/4] gnu: Add sqlalchemy-1.3
Date: Wed, 03 Nov 2021 14:27:41 +0100

[Message part 1 (text/plain, inline)]

David,

Thanks!  I've pushed this series as 
52a7fba8fc78763967c15781ea9b9176d3b4cc26 et al.

> Subject: [PATCH 1/4] gnu: Add sqlalchemy-1.3.

Use the full package name here.  This applies to all patches in 
this series AFAICT.

> +    ;; (propagated-inputs
> +    ;;  `(("python-greenlet" ,python-greenlet)))

Why is this commented out?  Please add a comment in such cases (if 
you've verified that all dependents still work without it, or that 
it was added after 1.3.20).

Great news!  This whole package can instead be written as:

(define-public python-sqlalchemy-1.3
 (package
   (inherit python-sqlalchemy)
   (version "1.3.20")
   (source
    (origin
     (method url-fetch)
     (uri (pypi-uri "SQLAlchemy" version))
     (sha256
      (base32 "18b9am7bsqc4nj3d2h5r93i002apczxfvpfpcqbd6f0385zmrwnj"))))
   (propagated-inputs '())))

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.