GNU bug report logs - #51432
[PATCH 0/4] gnu: Add flask-combo-jsonapi

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#51432: closed ([PATCH 0/4] gnu: Add flask-combo-jsonapi)
Date: Wed, 03 Nov 2021 17:47:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 03 Nov 2021 14:27:41 +0100
with message-id <878ry56sk0.fsf <at> nckx>
and subject line Re: [bug#51432] [PATCH 1/4] gnu: Add sqlalchemy-1.3
has caused the debbugs.gnu.org bug report #51432,
regarding [PATCH 0/4] gnu: Add flask-combo-jsonapi
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
51432: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51432
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: david larsson <david.larsson <at> selfhosted.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/4] gnu: Add flask-combo-jsonapi
Date: Wed, 27 Oct 2021 12:52:32 +0200

Hi!
This patch series is to add python-flask-combo-jsonapi and necessary 
dependencies.

Best regards,
David

[Message part 3 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: david larsson <david.larsson <at> selfhosted.xyz>
Cc: 51432-done <at> debbugs.gnu.org
Subject: Re: [bug#51432] [PATCH 1/4] gnu: Add sqlalchemy-1.3
Date: Wed, 03 Nov 2021 14:27:41 +0100

[Message part 4 (text/plain, inline)]

David,

Thanks!  I've pushed this series as 
52a7fba8fc78763967c15781ea9b9176d3b4cc26 et al.

> Subject: [PATCH 1/4] gnu: Add sqlalchemy-1.3.

Use the full package name here.  This applies to all patches in 
this series AFAICT.

> +    ;; (propagated-inputs
> +    ;;  `(("python-greenlet" ,python-greenlet)))

Why is this commented out?  Please add a comment in such cases (if 
you've verified that all dependents still work without it, or that 
it was added after 1.3.20).

Great news!  This whole package can instead be written as:

(define-public python-sqlalchemy-1.3
 (package
   (inherit python-sqlalchemy)
   (version "1.3.20")
   (source
    (origin
     (method url-fetch)
     (uri (pypi-uri "SQLAlchemy" version))
     (sha256
      (base32 "18b9am7bsqc4nj3d2h5r93i002apczxfvpfpcqbd6f0385zmrwnj"))))
   (propagated-inputs '())))

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.